Shift+F3 debug menu (#18065)

* F3 debug menu

* Some tweaks

* So that escalated

* Update code/controllers/subsystem.dm

* Update code/controllers/subsystem/debugview.dm

* Charlie tweaks

code/modules/admin/admin_verbs.dm

@@ -167,6 +167,7 @@ GLOBAL_LIST_INIT(admin_verbs_debug, list(
 	/client/proc/uid_log,
 	/client/proc/visualise_active_turfs,
 	/client/proc/reestablish_db_connection,
+	/client/proc/ss_breakdown,
 	#ifdef REFERENCE_TRACKING
 	/datum/proc/find_refs,
 	/datum/proc/qdel_then_find_references,
@@ -282,6 +283,7 @@ GLOBAL_LIST_INIT(admin_verbs_maintainer, list(
 			verbs += /client/proc/cmd_display_del_log_simple
 			verbs += /client/proc/toggledebuglogs
 			verbs += /client/proc/debug_variables /*allows us to -see- the variables of any instance in the game. +VAREDIT needed to modify*/
+			verbs += /client/proc/ss_breakdown
 			spawn(1) // This setting exposes the profiler for people with R_VIEWRUNTIMES. They must still have it set in cfg/admin.txt
 				control_freak = 0
 

code/modules/client/client_defines.dm

@@ -65,6 +65,9 @@
 	//datum that controls the displaying and hiding of tooltips
 	var/datum/tooltip/tooltips
 
+	// Overlay for showing debug info
+	var/obj/screen/debugtextholder/debug_text_overlay
+
 	/// Persistent storage for the flavour text of examined atoms.
 	var/list/description_holders = list()
 

code/modules/client/client_procs.dm

@@ -415,6 +415,7 @@
 
 /client/Destroy()
 	announce_leave() // Do not put this below
+	SSdebugview.stop_processing(src)
 	if(holder)
 		holder.owner = null
 		GLOB.admins -= src

code/modules/keybindings/bindings_admin.dm

@@ -1,5 +1,14 @@
 /datum/admins/key_down(_key, client/user)
 	switch(_key)
+		if("F3")
+			if(user.keys_held["Shift"])
+				if(!check_rights(R_DEBUG|R_VIEWRUNTIMES))
+					return
+				if(user in SSdebugview.processing)
+					SSdebugview.stop_processing(user)
+				else
+					SSdebugview.start_processing(user)
+				return
 		if("F5")
 			user.get_admin_say()
 			return

code/modules/keybindings/bindings_client.dm

@@ -58,11 +58,13 @@
 				adminhelp()
 			return
 		if("F2") // Screenshot. Hold shift to choose a name and location to save in
+			// AA 2022-06-23 - What the heck is the above comment here
 			ooc()
 			return
-		if("F3")
-			mob.say_wrapper()
-			return
+		if("F3") // Who the hell uses F3 to say
+			if(!keys_held["Shift"]) // Shift+F3 shows admin debug menu
+				mob.say_wrapper()
+				return
 		if("F4")
 			mob.me_wrapper()
 			return