review changes

This commit is contained in:
joep van der velden
2020-08-08 07:39:25 +02:00
parent 0cccd0ebf0
commit d89572afee
2 changed files with 7 additions and 8 deletions
+5 -6
View File
@@ -193,15 +193,14 @@
/obj/item/reagent_containers/food/snacks/grown/proc/log_action(mob/user, atom/target, what_done)
var/reagent_str = reagents.log_list()
var/genes_str
var/genes_str = "No genes"
if(seed && length(seed.genes))
var/list/plant_gene_names = list()
for(var/datum/plant_gene/trait/T in seed.genes)
if(T.dangerous)
plant_gene_names += T.name
for(var/thing in seed.genes)
var/datum/plant_gene/G = thing
if(G.dangerous)
plant_gene_names += G.name
genes_str = english_list(plant_gene_names)
else
genes_str = "No genes"
add_attack_logs(user, target, "[what_done] ([reagent_str] | [genes_str])")
+2 -2
View File
@@ -1,5 +1,7 @@
/datum/plant_gene
var/name
/// Used to determine if the trait should be logged when the holder is used
var/dangerous = FALSE
/datum/plant_gene/proc/get_name() // Used for manipulator display and gene disk name.
return name
@@ -139,8 +141,6 @@
var/rate = 0.05
var/examine_line = ""
var/list/origin_tech = null
/// Used to determine if the trait should be logged when the holder is used
var/dangerous = FALSE
var/trait_id // must be set and equal for any two traits of the same type
/datum/plant_gene/trait/Copy()