Fix compile, Add job restriction column, make job skirts betterish

Job skirts now only cost 3 points, any further job skirts selected will
not count towards points. Yes, you still spawn with multiple skirts if you
are in a position that has them, no, I can't fix it.

code/modules/client/preference/loadout/gear_tweaks.dm

@@ -111,34 +111,3 @@ var/datum/gear_tweak/color/gear_tweak_free_color_choice = new()
 		else
 			path = 	contents[metadata[i]]
 		new path(I)
-
-/*
-* Ragent adjustment
-*/
-
-/datum/gear_tweak/reagents
-	var/list/valid_reagents
-
-/datum/gear_tweak/reagents/New(var/list/reagents)
-	valid_reagents = reagents.Copy()
-	..()
-
-/datum/gear_tweak/reagents/get_contents(var/metadata)
-	return "Reagents: [metadata]"
-
-/datum/gear_tweak/reagents/get_default()
-	return "Random"
-
-/datum/gear_tweak/reagents/get_metadata(var/user, var/list/metadata)
-	. = input(user, "Choose an entry.", "Character Preference", metadata) as null|anything in (valid_reagents + list("Random", "None"))
-	if(!.)
-		return metadata
-
-/datum/gear_tweak/reagents/tweak_item(var/obj/item/I, var/list/metadata)
-	if(metadata == "None")
-		return
-	if(metadata == "Random")
-		. = valid_reagents[pick(valid_reagents)]
-	else
-		. = valid_reagents[metadata]
-	I.reagents.add_reagent(., I.reagents.get_free_space())

code/modules/client/preference/loadout/loadout.dm

@@ -53,6 +53,7 @@ var/list/gear_datums = list()
 	var/sort_category = "General"
 	var/list/gear_tweaks = list() //List of datums which will alter the item after it has been spawned.
 	var/subtype_path = /datum/gear //for skipping organizational subtypes (optional)
+	var/subtype_cost_overlap = TRUE //if subtypes can take points at the same time
 
 /datum/gear/New()
 	..()

code/modules/client/preference/loadout/loadout_uniform.dm

@@ -7,14 +7,6 @@
 /datum/gear/uniform/skirt
 	display_name = "skirt"
 
-/datum/gear/uniform/skirt/New()
-	..()
-	var/list/jumpskirts = list()
-	for(var/jump in subtypesof(/obj/item/clothing/under1))
-		if(findtext(path2text(jump), "skirt"))
-	gear_tweaks += new/datum/gear_tweak/path(sortAssoc(skirt_list))
-
-
 /datum/gear/uniform/skirt
 	display_name = "plaid skirt, blue"
 	path = /obj/item/clothing/under/dress/plaid_blue
@@ -31,72 +23,77 @@
 	display_name = "skirt, black"
 	path = /obj/item/clothing/under/blackskirt
 
-/datum/gear/uniform/skirt/ce
+/datum/gear/uniform/skirt/job
+	cost = 3
+	subtype_path = /datum/gear/uniform/skirt/job
+	subtype_cost_overlap = FALSE
+
+/datum/gear/uniform/skirt/job/ce
 	display_name = "skirt, ce"
 	path = /obj/item/clothing/under/rank/chief_engineer/skirt
 	allowed_roles = list("Chief Engineer")
 
-/datum/gear/uniform/skirt/atmos
+/datum/gear/uniform/skirt/job/atmos
 	display_name = "skirt, atmos"
 	path = /obj/item/clothing/under/rank/atmospheric_technician/skirt
 	allowed_roles = list("Chief Engineer","Atmospheric Technician")
 
-/datum/gear/uniform/skirt/eng
+/datum/gear/uniform/skirt/job/eng
 	display_name = "skirt, engineer"
 	path = /obj/item/clothing/under/rank/engineer/skirt
 	allowed_roles = list("Chief Engineer","Station Engineer")
 
-/datum/gear/uniform/skirt/roboticist
+/datum/gear/uniform/skirt/job/roboticist
 	display_name = "skirt, roboticist"
 	path = /obj/item/clothing/under/rank/roboticist/skirt
 	allowed_roles = list("Research Director","Roboticist")
 
-/datum/gear/uniform/skirt/cmo
+/datum/gear/uniform/skirt/job/cmo
 	display_name = "skirt, cmo"
 	path = /obj/item/clothing/under/rank/chief_medical_officer
 	allowed_roles = list("Chief Medical Officer")
 
-/datum/gear/uniform/skirt/chem
+/datum/gear/uniform/skirt/job/chem
 	display_name = "skirt, chemist"
 	path = /obj/item/clothing/under/rank/chemist/skirt
 	allowed_roles = list("Chief Medical Officer","Chemist")
 
-/datum/gear/uniform/skirt/viro
+/datum/gear/uniform/skirt/job/viro
 	display_name = "skirt, virologist"
 	path = /obj/item/clothing/under/rank/virologist/skirt
 	allowed_roles = list("Chief Medical Officer","Medical Doctor")
 
-/datum/gear/uniform/skirt/med
+/datum/gear/uniform/skirt/job/med
 	display_name = "skirt, medical"
 	path = /obj/item/clothing/under/rank/medical/skirt
 	allowed_roles = list("Chief Medical Officer","Medical Doctor","Chemist","Psychiatrist","Paramedic")
 
-/datum/gear/uniform/skirt/sci
+/datum/gear/uniform/skirt/job/sci
 	display_name = "skirt, scientist"
 	path = /obj/item/clothing/under/rank/scientist/skirt
 	allowed_roles = list("Research Director","Scientist")
 
-/datum/gear/uniform/skirt/cargo
+/datum/gear/uniform/skirt/job/cargo
 	display_name = "skirt, cargo"
 	path = /obj/item/clothing/under/rank/cargotech/skirt
 	allowed_roles = list("Quartermaster","Cargo Technician")
 
-/datum/gear/uniform/skirt/qm
+/datum/gear/uniform/skirt/job/qm
 	display_name = "skirt, QM"
 	path = /obj/item/clothing/under/rank/cargo/skirt
 	allowed_roles = list("Quartermaster")
 
-/datum/gear/uniform/skirt/warden
+/datum/gear/uniform/skirt/job/warden
 	display_name = "skirt, warden"
 	path = /obj/item/clothing/under/rank/warden/skirt
 	allowed_roles = list("Head of Security", "Warden")
 
-/datum/gear/uniform/skirt/security
+/datum/gear/uniform/skirt/job/security
 	display_name = "skirt, security"
 	path = /obj/item/clothing/under/rank/security/skirt
 	allowed_roles = list("Head of Security", "Warden", "Detective", "Security Officer")
 
-/datum/gear/uniform/skirt/head_of_security
+/datum/gear/uniform/skirt/job/head_of_security
 	display_name = "skirt, hos"
 	path = /obj/item/clothing/under/rank/head_of_security/skirt
 	allowed_roles = list("Head of Security")