From de09a6011ec2e71f26e2210c950be84f67009a84 Mon Sep 17 00:00:00 2001
From: Shawn Hind <hind.shawn@gmail.com>
Date: Sat, 21 Mar 2020 19:03:54 -0400
Subject: [PATCH] Update cloning scan messages (#13094)

* Update cloning scan messages

Clarifies cloning scan messages to make them more clear for new players.

* Change null subject, not human, no dna message back to original.

* add xenomorph condition

* Update no ghost cloning message
---
 code/game/machinery/computer/cloning.dm | 28 +++++++++++++------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/code/game/machinery/computer/cloning.dm b/code/game/machinery/computer/cloning.dm
index 6a8aafb364d..14a8e2b6ddc 100644
--- a/code/game/machinery/computer/cloning.dm
+++ b/code/game/machinery/computer/cloning.dm
@@ -358,35 +358,37 @@
 		return
 	if(scan_brain && !can_brainscan())
 		return
-	if((isnull(subject)) || (!(ishuman(subject))) || (!subject.dna) || (NO_SCAN in subject.dna.species.species_traits))
-		scantemp = "<span class=\"bad\">Error: Unable to locate valid genetic data.</span>"
-		SSnanoui.update_uis(src)
-		return
+	if(isnull(subject) || (!(ishuman(subject))) || (!subject.dna))
+		if(isalien(subject)) 
+			scantemp = "<span class=\"bad\">Error: Xenomorphs are not scannable.</span>"
+			SSnanoui.update_uis(src)
+			return
+		// can add more conditions for specific non-human messages here
+		else 
+			scantemp = "<span class=\"bad\">Error: Subject species is not scannable.</span>"
+			SSnanoui.update_uis(src)
+			return
 	if(subject.get_int_organ(/obj/item/organ/internal/brain))
 		var/obj/item/organ/internal/brain/Brn = subject.get_int_organ(/obj/item/organ/internal/brain)
 		if(istype(Brn))
 			if(NO_SCAN in Brn.dna.species.species_traits)
-				scantemp = "<span class=\"bad\">Error: Subject's brain is incompatible.</span>"
+				scantemp = "<span class=\"bad\">Error: [subject.dna.species.name_plural] are not scannable.</span>"
 				SSnanoui.update_uis(src)
 				return
 	if(!subject.get_int_organ(/obj/item/organ/internal/brain))
-		scantemp = "<span class=\"bad\">Error: No signs of intelligence detected.</span>"
+		scantemp = "<span class=\"bad\">Error: No brain detected in subject.</span>"
 		SSnanoui.update_uis(src)
 		return
 	if(subject.suiciding)
-		scantemp = "<span class=\"bad\">Error: Subject's brain is not responding to scanning stimuli.</span>"
+		scantemp = "<span class=\"bad\">Error: Subject has committed suicide and is not scannable.</span>"
 		SSnanoui.update_uis(src)
 		return
 	if((!subject.ckey) || (!subject.client))
-		scantemp = "<span class=\"bad\">Error: Mental interface failure.</span>"
+		scantemp = "<span class=\"bad\">Error: Subject's brain is not responding. Further attempts after a short delay may succeed.</span>"
 		SSnanoui.update_uis(src)
 		return
 	if((NOCLONE in subject.mutations) && src.scanner.scan_level < 2)
-		scantemp = "<span class=\"bad\">Error: Mental interface failure.</span>"
-		SSnanoui.update_uis(src)
-		return
-	if(scan_brain && !subject.get_int_organ(/obj/item/organ/internal/brain))
-		scantemp = "<span class=\"bad\">Error: No brain found.</span>"
+		scantemp = "<span class=\"bad\">Error: Subject has incompatible genetic mutations.</span>"
 		SSnanoui.update_uis(src)
 		return
 	if(!isnull(find_record(subject.ckey)))