Adds CI to prevent manual calls of update_icon_state, update_overlay, etc. (#27010)

* CI something something

* last fix
This commit is contained in:
Contrabang
2024-10-22 12:46:00 +00:00
committed by GitHub
parent 6325c6dd8b
commit e3c0198737
28 changed files with 61 additions and 41 deletions
+1 -1
View File
@@ -27,7 +27,7 @@
icon_state = "scard_loser"
playsound(user, 'sound/items/scratching.ogg', 25, TRUE)
scratched = TRUE
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/scratch/attack_obj(obj/O, mob/living/user, params)
if(winner && istype(O, /obj/machinery/economy/atm))
@@ -39,7 +39,7 @@
if(should_start_with_canisters && !length(canisters))
canisters += new /obj/item/chemical_canister
update_canister_stats()
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/chemical_flamethrower/Destroy()
QDEL_LIST_CONTENTS(canisters)
@@ -174,11 +174,11 @@
/obj/item/melee/breach_cleaver/proc/wield(obj/item/source, mob/living/carbon/human/user)
to_chat(user, "<span class='notice'>You heave [src] up in both hands.</span>")
user.apply_status_effect(STATUS_EFFECT_BREACH_AND_CLEAVE)
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/melee/breach_cleaver/proc/unwield(obj/item/source, mob/living/carbon/human/user)
user.remove_status_effect(STATUS_EFFECT_BREACH_AND_CLEAVE)
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/melee/breach_cleaver/attack_obj(obj/O, mob/living/user, params)
if(!HAS_TRAIT(src, TRAIT_WIELDED)) // Only works good when wielded
@@ -431,7 +431,7 @@
slowdown = 1
if(antidrop_on_zip)
flags ^= NODROP
update_icon_state(UPDATE_ICON_STATE)
update_icon(UPDATE_ICON_STATE)
return
slowdown = 0
@@ -440,7 +440,7 @@
container.hide_from_all() // Hide everything inside the bag too
if(antidrop_on_zip)
flags |= NODROP
update_icon_state(UPDATE_ICON_STATE)
update_icon(UPDATE_ICON_STATE)
/obj/item/storage/backpack/duffel/update_icon_state()
. = ..()
@@ -285,8 +285,7 @@
if(electronics)
target.electronics = source.electronics
source.electronics.forceMove(target)
target.update_icon(UPDATE_OVERLAYS)
target.update_name()
target.update_appearance(UPDATE_NAME|UPDATE_OVERLAYS)
qdel(source)
/obj/structure/door_assembly/deconstruct(disassembled = TRUE)
@@ -243,6 +243,6 @@
blockage.max_integrity += 25
foam_level++
blockage.icon_state = "foamed_[foam_level]"
blockage.update_icon_state()
blockage.update_icon(UPDATE_ICON_STATE)
#undef MAX_FOAM_LEVEL
@@ -37,7 +37,7 @@
return
flipped = !flipped
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/structure/transit_tube_construction/screwdriver_act(mob/living/user, obj/item/I)
. = TRUE