Adds CI to prevent manual calls of update_icon_state, update_overlay, etc. (#27010)

* CI something something

* last fix
This commit is contained in:
Contrabang
2024-10-22 08:46:00 -04:00
committed by GitHub
parent 6325c6dd8b
commit e3c0198737
28 changed files with 61 additions and 41 deletions
+1 -1
View File
@@ -223,7 +223,7 @@
module.on_suit_deactivation()
STOP_PROCESSING(SSobj, src)
update_speed()
update_icon_state()
update_icon(UPDATE_ICON_STATE)
wearer.regenerate_icons()
/// Quickly deploys all the suit parts and if successful, seals them and turns on the suit. Intended mostly for outfits.
+1 -1
View File
@@ -250,7 +250,7 @@
if(part.use_tool(src, user, 0, volume = 30))
to_chat(user, "<span class='notice'>Assembly unscrewed.</span>")
construction_step = SCREWED_ASSEMBLY_STEP
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/mod/construction/shell/update_icon_state()
. = ..()
+3 -3
View File
@@ -362,7 +362,7 @@
return
var/core_path = pick(accepted_anomalies)
core = new core_path(src)
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/mod/module/anomaly_locked/Destroy()
QDEL_NULL(core)
@@ -407,7 +407,7 @@
core = item
to_chat(user, "<span class='notice'>You install [item].</span>")
playsound(src, 'sound/machines/click.ogg', 30, TRUE)
update_icon_state()
update_icon(UPDATE_ICON_STATE)
core.forceMove(src)
else
return ..()
@@ -424,7 +424,7 @@
if(Adjacent(user) && !issilicon(user))
user.put_in_hands(core)
core = null
update_icon_state()
update_icon(UPDATE_ICON_STATE)
/obj/item/mod/module/anomaly_locked/update_icon_state()
icon_state = initial(icon_state) + (core ? "-core" : "")