cyberpresidentvanellope/Paradise
1
0
Fork 0
mirror of https://github.com/ParadiseSS13/Paradise.git synced 2026-02-07 23:28:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

ID Card Console tweaks (#20462)

Browse Source 
* Fix ID consoles denying management access to head IDs witih custom titles

* Update proc name

* Make ID consoles highlight current rank regardless of custom title

* Fix ID consoles improperly checking Demoted/Terminated status

* Fix un-terminations not requiring a full ID console

* Fix missing `selected` properties; readability

* Fix console not disabling the Demote option on already demoted cards

* Deduplicate full and departmental ID console UI code

* Move the tab-agnostic authentication UI above tabs

* Angry feedback message consistency

* I forget this shorthand operator exists
This commit is contained in:
Nathan Winters
2023-03-25 15:45:43 +01:00
committed by GitHub
parent 86275bf5f7
commit e7acbdd6d0
4 changed files with 188 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
code/controllers/subsystem/jobs.dm
View File

@@ -632,7 +632,7 @@ SUBSYSTEM_DEF(jobs)
if(tgtcard)
var/mob/M = tgtcard.getPlayer()
for(var/datum/job/job in occupations)
if(tgtcard.assignment && tgtcard.assignment == job.title)
if(tgtcard.rank && tgtcard.rank == job.title)
jobs_to_formats[job.title] = "green" // the job they already have is pre-selected
else if(tgtcard.assignment == "Demoted" || tgtcard.assignment == "Terminated")
jobs_to_formats[job.title] = "grey"