From a010f2e7e29b4661fe478522f2272c2a467380f7 Mon Sep 17 00:00:00 2001 From: joep van der velden Date: Fri, 12 Apr 2019 23:46:35 +0200 Subject: [PATCH 01/11] whoops --- code/controllers/subsystem/tickets/tickets.dm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/code/controllers/subsystem/tickets/tickets.dm b/code/controllers/subsystem/tickets/tickets.dm index 99130025786..73279033849 100644 --- a/code/controllers/subsystem/tickets/tickets.dm +++ b/code/controllers/subsystem/tickets/tickets.dm @@ -367,26 +367,26 @@ UI STUFF if(href_list["resolve"]) var/indexNum = text2num(href_list["resolve"]) if(resolveTicket(indexNum)) - message_staff("[usr.client] / ([usr]) resolved [ticket_name] number [indexNum]") + message_staff("[span_text][usr.client] / ([usr]) resolved [ticket_name] number [indexNum]") to_chat_safe(returnClient(indexNum), "[span_text]Your [ticket_name] has now been resolved.") showUI(usr) if(href_list["detailresolve"]) var/indexNum = text2num(href_list["detailresolve"]) if(resolveTicket(indexNum)) - message_staff("[usr.client] / ([usr]) resolved [ticket_name] number [indexNum]") + message_staff("[span_text][usr.client] / ([usr]) resolved [ticket_name] number [indexNum]") to_chat_safe(returnClient(indexNum), "[span_text]Your [ticket_name] has now been resolved.") showDetailUI(usr, indexNum) if(href_list["detailclose"]) var/indexNum = text2num(href_list["detailclose"]) if(!check_rights(close_rights)) - to_chat(usr, "Not enough rights to close this ticket.") + to_chat(usr, "Not enough rights to close this ticket.") return if(alert("Are you sure? This will send a negative message.",,"Yes","No") != "Yes") return if(closeTicket(indexNum)) - message_staff("[usr.client] / ([usr]) closed [ticket_name] number [indexNum]") + message_staff("[span_text][usr.client] / ([usr]) closed [ticket_name] number [indexNum]") to_chat_safe(returnClient(indexNum), close_messages) showDetailUI(usr, indexNum) @@ -394,7 +394,7 @@ UI STUFF if(href_list["detailreopen"]) var/indexNum = text2num(href_list["detailreopen"]) if(openTicket(indexNum)) - message_staff("[usr.client] / ([usr]) re-opened [ticket_name] number [indexNum]") + message_staff("[span_text][usr.client] / ([usr]) re-opened [ticket_name] number [indexNum]") showDetailUI(usr, indexNum) if(href_list["assignstaff"]) @@ -404,5 +404,5 @@ UI STUFF /datum/controller/subsystem/tickets/proc/takeTicket(var/index) if(assignStaffToTicket(usr.client, index)) - message_staff("[usr.client] / ([usr]) has taken [ticket_name] number [index]") - to_chat_safe(returnClient(index), "[span_text]Your [ticket_name] is being handled by [usr.client].") + message_staff("[span_text][usr.client] / ([usr]) has taken [ticket_name] number [index]") + to_chat_safe(returnClient(index), "[span_text]Your [ticket_name] is being handled by [usr.client].") From 9598dcac5ee9f935ec30a210d9ead20c656e6479 Mon Sep 17 00:00:00 2001 From: joep van der velden Date: Sat, 13 Apr 2019 00:57:59 +0200 Subject: [PATCH 02/11] fixed PM's --- code/modules/client/client procs.dm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/code/modules/client/client procs.dm b/code/modules/client/client procs.dm index ac9a88aaa08..a0e2629dd20 100644 --- a/code/modules/client/client procs.dm +++ b/code/modules/client/client procs.dm @@ -78,6 +78,9 @@ C = M.client if(!C) // Might be a stealthmin ID, so pass it in straight C = href_list["priv_msg"] + else if(C.UID() != href_list["priv_msg"]) + to_chat(src, "Error: Private-Message: Client not found.") + return cmd_admin_pm(C, null, href_list["type"]) return From 36f5c8ea14730db8e7415d9710422982e6d3e261 Mon Sep 17 00:00:00 2001 From: joep van der velden Date: Sat, 13 Apr 2019 10:42:08 +0200 Subject: [PATCH 03/11] let cmd_admin_pm handle the null client --- code/modules/client/client procs.dm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/code/modules/client/client procs.dm b/code/modules/client/client procs.dm index a0e2629dd20..a6216c87b1a 100644 --- a/code/modules/client/client procs.dm +++ b/code/modules/client/client procs.dm @@ -79,8 +79,7 @@ if(!C) // Might be a stealthmin ID, so pass it in straight C = href_list["priv_msg"] else if(C.UID() != href_list["priv_msg"]) - to_chat(src, "Error: Private-Message: Client not found.") - return + C = null // 404 client not found. Let cmd_admin_pm handle the error cmd_admin_pm(C, null, href_list["type"]) return From 6ca7ebe3df690836088cb74bafb88e7dab96b1fe Mon Sep 17 00:00:00 2001 From: ParadiseSS13-Bot Date: Sun, 14 Apr 2019 00:23:02 -0400 Subject: [PATCH 04/11] Automatic changelog generation for PR #11296 [ci skip] --- html/changelogs/AutoChangeLog-pr-11296.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 html/changelogs/AutoChangeLog-pr-11296.yml diff --git a/html/changelogs/AutoChangeLog-pr-11296.yml b/html/changelogs/AutoChangeLog-pr-11296.yml new file mode 100644 index 00000000000..42a9ce1a063 --- /dev/null +++ b/html/changelogs/AutoChangeLog-pr-11296.yml @@ -0,0 +1,4 @@ +author: "farie82" +delete-after: True +changes: + - bugfix: "PM's now shouldn't go to the wrong client anymore when the target left." From 5054a30038103c4cabc24dee1b6a19e15e55aeed Mon Sep 17 00:00:00 2001 From: ParadiseSS13-Bot Date: Sun, 14 Apr 2019 00:23:34 -0400 Subject: [PATCH 05/11] Automatic changelog generation for PR #11294 [ci skip] --- html/changelogs/AutoChangeLog-pr-11294.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 html/changelogs/AutoChangeLog-pr-11294.yml diff --git a/html/changelogs/AutoChangeLog-pr-11294.yml b/html/changelogs/AutoChangeLog-pr-11294.yml new file mode 100644 index 00000000000..0088263303b --- /dev/null +++ b/html/changelogs/AutoChangeLog-pr-11294.yml @@ -0,0 +1,4 @@ +author: "farie82" +delete-after: True +changes: + - bugfix: "Ticket messages now have their corresponding span classes. Making them easier to notice" From 2304cf0f6f6f0808b23d378f441cc72e59e35cd0 Mon Sep 17 00:00:00 2001 From: AffectedArc07 Date: Sat, 23 Mar 2019 11:06:19 +0000 Subject: [PATCH 06/11] SSMapping --- code/controllers/master_controller.dm | 22 ---------------- code/controllers/subsystem/mapping.dm | 37 +++++++++++++++++++++++++++ paradise.dme | 1 + 3 files changed, 38 insertions(+), 22 deletions(-) create mode 100644 code/controllers/subsystem/mapping.dm diff --git a/code/controllers/master_controller.dm b/code/controllers/master_controller.dm index 1fd81402544..7a078a67970 100644 --- a/code/controllers/master_controller.dm +++ b/code/controllers/master_controller.dm @@ -36,29 +36,7 @@ var/global/pipe_processing_killed = 0 return QDEL_HINT_HARDDEL_NOW /datum/controller/game_controller/proc/setup() - preloadTemplates() - if(!config.disable_away_missions) - createRandomZlevel() - // Create 6 extra space levels to put space ruins on - if(!config.disable_space_ruins) - var/timer = start_watch() - log_startup_progress("Creating random space levels...") - seedRuins(level_name_to_num(EMPTY_AREA), rand(0, 3), /area/space, space_ruins_templates) - log_startup_progress("Loaded random space levels in [stop_watch(timer)]s.") - - // load in extra levels of space ruins - - var/num_extra_space = rand(config.extra_space_ruin_levels_min, config.extra_space_ruin_levels_max) - for(var/i = 1, i <= num_extra_space, i++) - var/zlev = space_manager.add_new_zlevel("[EMPTY_AREA] #[i]", linkage = CROSSLINKED) - seedRuins(zlev, rand(0, 3), /area/space, space_ruins_templates) - - space_manager.do_transition_setup() - setupfactions() setup_economy() - for(var/i=0, i