From ebf4e0ad256119a651ff2ef392af23d420dd3bfe Mon Sep 17 00:00:00 2001 From: uporotiy Date: Sat, 20 Aug 2011 19:38:33 +0000 Subject: [PATCH] Fix for an ages-old exploit. git-svn-id: http://tgstation13.googlecode.com/svn/trunk@2031 316c924e-a436-60f5-8080-3fe189b3f50e --- code/modules/admin/verbs/massmodvar.dm | 3 +++ code/modules/admin/verbs/modifyvariables.dm | 3 +++ 2 files changed, 6 insertions(+) diff --git a/code/modules/admin/verbs/massmodvar.dm b/code/modules/admin/verbs/massmodvar.dm index 0e54d1d2cb2..804b783592b 100644 --- a/code/modules/admin/verbs/massmodvar.dm +++ b/code/modules/admin/verbs/massmodvar.dm @@ -28,6 +28,9 @@ if (locked.Find(variable) && !(src.holder.rank in list("Game Master", "Game Admin"))) return + if (variable == "holder" && !holder.rank == "Game Master") //Hotfix, a bit ugly but that exploit has been there for ages and now somebody just had to go and tell everyone of it bluh bluh - U + return + if(isnull(var_value)) usr << "Unable to determine variable type." diff --git a/code/modules/admin/verbs/modifyvariables.dm b/code/modules/admin/verbs/modifyvariables.dm index d9b972fb6e4..1cea74adbc1 100644 --- a/code/modules/admin/verbs/modifyvariables.dm +++ b/code/modules/admin/verbs/modifyvariables.dm @@ -251,6 +251,9 @@ if (locked.Find(variable) && !(src.holder.rank in list("Game Master", "Game Admin"))) return + if (variable == "holder" && !holder.rank == "Game Master") //Hotfix, a bit ugly but that exploit has been there for ages and now somebody just had to go and tell everyone of it bluh bluh - U + return + if(isnull(var_value)) usr << "Unable to determine variable type."