diff --git a/.tgs.yml b/.tgs.yml index 6970078ff70..43d320cca90 100644 --- a/.tgs.yml +++ b/.tgs.yml @@ -3,7 +3,7 @@ version: 1 # The BYOND version to use # Must be interpreted as a string, keep quoted -byond: "515.1620" +byond: '515.1633' # Folders to create in "/Configuration/GameStaticFiles/" static_files: # Config directory should be static diff --git a/_maps/map_files/RandomRuins/SpaceRuins/ussp.dmm b/_maps/map_files/RandomRuins/SpaceRuins/ussp.dmm index f6febf65964..ff85ca336a4 100644 --- a/_maps/map_files/RandomRuins/SpaceRuins/ussp.dmm +++ b/_maps/map_files/RandomRuins/SpaceRuins/ussp.dmm @@ -3133,10 +3133,6 @@ icon_state = "stage_stairs" }, /area/ruin/space/derelict/crew_quarters) -"hF" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall/mineral/titanium/nodecon, -/area/ruin/space/derelict/crew_quarters) "hH" = ( /obj/machinery/door/airlock/public/glass{ name = "Eastern Annex" @@ -7553,6 +7549,13 @@ }, /turf/simulated/wall/mineral/titanium/nodecon/nodiagonal, /area/ruin/space/derelict/arrival) +"Ef" = ( +/obj/effect/decal/cleanable/dirt, +/obj/machinery/barsign{ + pixel_y = 32 + }, +/turf/simulated/floor/plasteel/dark, +/area/ruin/space/derelict/crew_quarters) "Nv" = ( /obj/effect/spawner/airlock{ req_access_txt = 0 @@ -13520,8 +13523,8 @@ gn gG gG gG -hF -hT +aV +Ef in iK je diff --git a/_maps/map_files/generic/centcomm.dmm b/_maps/map_files/generic/centcomm.dmm index eff94377911..a5a7a216fc8 100644 --- a/_maps/map_files/generic/centcomm.dmm +++ b/_maps/map_files/generic/centcomm.dmm @@ -1121,6 +1121,12 @@ icon_state = "cafeteria" }, /area/ghost_bar) +"et" = ( +/obj/machinery/barsign/ghost_bar{ + pixel_y = 32 + }, +/turf/simulated/floor/wood, +/area/ghost_bar) "ev" = ( /turf/simulated/floor/beach/sand, /area/holodeck/source_beach) @@ -2689,6 +2695,15 @@ /obj/structure/chair/stool, /turf/simulated/floor/mineral/plastitanium/red, /area/shuttle/syndicate) +"jA" = ( +/obj/machinery/barsign{ + pixel_y = 32 + }, +/turf/simulated/floor/plasteel{ + dir = 1; + icon_state = "green" + }, +/area/centcom/evac) "jB" = ( /obj/structure/table/wood, /obj/machinery/door_control/no_emag{ @@ -5375,10 +5390,6 @@ /obj/effect/landmark/spawner/syndie, /turf/simulated/floor/wood, /area/syndicate_mothership) -"sd" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall/indestructible/riveted, -/area/ghost_bar) "se" = ( /obj/structure/chair/comfy/shuttle{ dir = 4 @@ -7985,7 +7996,7 @@ /turf/simulated/wall/indestructible/syndicate, /area/admin) "Cv" = ( -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = -32 }, /obj/machinery/icemachine, @@ -9238,7 +9249,7 @@ /area/centcom/specops) "GT" = ( /obj/structure/chair, -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = 32 }, /obj/effect/landmark/spawner/tdomeobserve, @@ -12930,7 +12941,7 @@ pixel_y = 5 }, /obj/structure/table/wood, -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = -32 }, /turf/simulated/floor/plasteel{ @@ -13931,11 +13942,6 @@ }, /turf/simulated/wall/indestructible/fakeglass, /area/centcom/specops) -"Xi" = ( -/obj/effect/spawner/window, -/obj/structure/sign/barsign, -/turf/simulated/floor/plating, -/area/centcom/evac) "Xj" = ( /turf/simulated/floor/transparent/glass, /area/centcom/specops) @@ -46023,8 +46029,8 @@ Ng Ng So Vs -Xi -Xx +Qe +jA YO ZZ gI @@ -73030,8 +73036,8 @@ vd Ml vd xy -sd -Jy +Me +et Jy Jy Jy diff --git a/_maps/map_files/stations/boxstation.dmm b/_maps/map_files/stations/boxstation.dmm index 66adb73fc8a..4e73c461e3a 100644 --- a/_maps/map_files/stations/boxstation.dmm +++ b/_maps/map_files/stations/boxstation.dmm @@ -23086,7 +23086,7 @@ /area/station/maintenance/port) "bsg" = ( /obj/structure/table, -/obj/item/clothing/head/soft/grey{ +/obj/item/clothing/head/soft{ pixel_x = -2; pixel_y = 3 }, @@ -24963,10 +24963,6 @@ "bzd" = ( /turf/simulated/floor/plasteel/goonplaque/memorial, /area/station/hallway/secondary/exit) -"bze" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall, -/area/station/service/bar) "bzf" = ( /turf/simulated/floor/plasteel{ dir = 1; @@ -71298,9 +71294,9 @@ "mIA" = ( /obj/structure/table, /obj/item/stamp/granted, -/obj/item/clothing/head/soft, +/obj/item/clothing/head/soft/cargo, /obj/item/hand_labeler, -/obj/item/clothing/head/soft, +/obj/item/clothing/head/soft/cargo, /turf/simulated/floor/plasteel{ dir = 4; icon_state = "brown" @@ -76275,6 +76271,12 @@ }, /turf/simulated/floor/plating, /area/station/maintenance/apmaint) +"pcF" = ( +/obj/machinery/barsign{ + pixel_y = 32 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/primary/starboard/west) "pcH" = ( /obj/effect/decal/cleanable/dirt, /obj/structure/disposalpipe/segment, @@ -130569,8 +130571,8 @@ bmq bmq bmq bzo -bze -bAk +aUS +pcF bHy bDb bEy diff --git a/_maps/map_files/stations/cerestation.dmm b/_maps/map_files/stations/cerestation.dmm index c6f4d7379f8..3a6041bfbf5 100644 --- a/_maps/map_files/stations/cerestation.dmm +++ b/_maps/map_files/stations/cerestation.dmm @@ -3620,7 +3620,6 @@ icon_state = "4-8" }, /turf/simulated/floor/plasteel{ - dir = 2; icon_state = "green" }, /area/station/public/quantum/service) @@ -23133,7 +23132,7 @@ "cvm" = ( /obj/structure/table, /obj/item/clothing/gloves/fingerless, -/obj/item/clothing/head/soft, +/obj/item/clothing/head/soft/cargo, /turf/simulated/floor/plasteel{ icon_state = "darkbrown" }, @@ -26138,10 +26137,6 @@ "cMz" = ( /turf/simulated/wall/r_wall, /area/station/maintenance/fore) -"cMA" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall, -/area/station/maintenance/gambling_den) "cME" = ( /obj/structure/cable/orange{ d1 = 2; @@ -48367,10 +48362,6 @@ }, /turf/simulated/floor/plating, /area/station/hallway/spacebridge/serveng) -"iwJ" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall, -/area/station/service/bar) "iwU" = ( /obj/structure/sign/directions/evac{ dir = 4; @@ -54698,7 +54689,6 @@ icon_state = "0-8" }, /turf/simulated/floor/plasteel{ - dir = 2; icon_state = "green" }, /area/station/public/quantum/service) @@ -62093,6 +62083,9 @@ /obj/structure/chair/sofa/corp{ dir = 1 }, +/obj/machinery/barsign{ + pixel_y = -32 + }, /turf/simulated/floor/carpet, /area/station/hallway/primary/port/east) "mJX" = ( @@ -62400,6 +62393,9 @@ "mPu" = ( /obj/structure/table/wood/poker, /obj/effect/spawner/lootdrop/maintenance, +/obj/machinery/barsign{ + pixel_y = 32 + }, /turf/simulated/floor/wood{ icon_state = "wood-broken" }, @@ -70189,16 +70185,6 @@ icon_state = "white" }, /area/station/science/misc_lab) -"pqq" = ( -/obj/machinery/door/airlock/multi_tile/glass{ - dir = 4 - }, -/obj/effect/mapping_helpers/airlock/autoname, -/obj/machinery/door/firedoor, -/turf/simulated/floor/plasteel{ - icon_state = "dark" - }, -/area/station/public/quantum/security) "pqr" = ( /obj/machinery/atmospherics/pipe/manifold/hidden/scrubbers{ dir = 4 @@ -116888,7 +116874,7 @@ xla sZf aWA iEe -pqq +bNX ibX jzf hPy @@ -118729,7 +118715,7 @@ pkc iqL rZl mJT -iwJ +aZZ iox bjr rRc @@ -122101,7 +122087,7 @@ bhO hUU sbn sbn -cMA +uJT mPu mER oWa diff --git a/_maps/map_files/stations/deltastation.dmm b/_maps/map_files/stations/deltastation.dmm index 6d0af2fbf78..1f1054c9016 100644 --- a/_maps/map_files/stations/deltastation.dmm +++ b/_maps/map_files/stations/deltastation.dmm @@ -2819,7 +2819,7 @@ /area/station/maintenance/fore) "aqv" = ( /obj/structure/table/wood, -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = 32 }, /obj/item/wrench, @@ -4880,7 +4880,7 @@ /turf/simulated/floor/engine, /area/station/engineering/controlroom) "avL" = ( -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = 32 }, /turf/simulated/floor/plasteel{ @@ -9070,7 +9070,7 @@ /area/station/service/bar) "aGA" = ( /obj/structure/table/wood, -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = 32 }, /obj/machinery/chem_dispenser/soda{ @@ -10213,6 +10213,12 @@ /obj/effect/landmark/spawner/nukedisc_respawn, /turf/simulated/floor/plating, /area/station/maintenance/auxsolarport) +"aJK" = ( +/obj/machinery/light, +/obj/effect/turf_decal/stripes/line, +/obj/machinery/alarm/directional/south, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "aJM" = ( /obj/structure/cable{ d1 = 1; @@ -13792,10 +13798,6 @@ icon_state = "bar" }, /area/station/service/bar) -"aTq" = ( -/obj/effect/spawner/airlock, -/turf/simulated/wall, -/area/station/hallway/secondary/exit) "aTr" = ( /obj/machinery/atmospherics/unary/vent_pump/on{ dir = 1 @@ -54207,7 +54209,7 @@ /obj/machinery/light{ dir = 1 }, -/obj/structure/sign/barsign{ +/obj/machinery/barsign{ pixel_y = 32 }, /turf/simulated/floor/plating, @@ -61709,13 +61711,21 @@ /turf/simulated/floor/plasteel, /area/station/hallway/primary/aft/south) "dHO" = ( +/obj/effect/spawner/window/reinforced/grilled, +/obj/structure/cable{ + d1 = 2; + d2 = 8; + icon_state = "2-8" + }, /obj/structure/cable{ d1 = 1; - d2 = 2; - icon_state = "1-2" + d2 = 8; + icon_state = "1-8" + }, +/obj/structure/cable{ + d2 = 8; + icon_state = "0-8" }, -/obj/structure/cable, -/obj/effect/spawner/window/reinforced/grilled, /turf/simulated/floor/plating, /area/station/hallway/secondary/exit) "dHQ" = ( @@ -62691,17 +62701,6 @@ }, /turf/simulated/floor/carpet/blue, /area/station/command/office/blueshield) -"dNS" = ( -/obj/docking_port/stationary{ - dir = 4; - dwidth = 16; - height = 21; - id = "emergency_home"; - name = "emergency evac bay"; - width = 41 - }, -/turf/space, -/area/space) "dNZ" = ( /obj/effect/decal/cleanable/dirt, /turf/simulated/floor/plasteel{ @@ -63949,16 +63948,6 @@ /obj/item/crowbar/red, /turf/simulated/floor/plasteel/dark, /area/station/maintenance/apmaint) -"dSB" = ( -/obj/machinery/atmospherics/unary/portables_connector{ - dir = 8 - }, -/obj/machinery/atmospherics/portable/canister/air, -/obj/effect/turf_decal/stripes/line{ - dir = 10 - }, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "dSD" = ( /obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{ dir = 4 @@ -64691,12 +64680,6 @@ icon_state = "neutralfull" }, /area/station/hallway/primary/central) -"dUY" = ( -/obj/machinery/light, -/obj/effect/turf_decal/stripes/line, -/obj/machinery/alarm/directional/south, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "dUZ" = ( /obj/machinery/light, /obj/machinery/status_display{ @@ -66432,6 +66415,16 @@ /obj/effect/decal/cleanable/dirt, /turf/simulated/wall, /area/station/legal/lawoffice) +"evE" = ( +/obj/structure/cable{ + d1 = 1; + d2 = 2; + icon_state = "1-2" + }, +/obj/structure/cable, +/obj/effect/spawner/window/reinforced/grilled, +/turf/simulated/floor/plating, +/area/station/hallway/secondary/exit) "evX" = ( /obj/structure/cable, /obj/effect/spawner/window/reinforced/grilled, @@ -66566,6 +66559,22 @@ icon_state = "yellowcorner" }, /area/station/hallway/primary/port/east) +"ezr" = ( +/obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{ + dir = 6 + }, +/obj/structure/cable{ + d1 = 4; + d2 = 8; + icon_state = "4-8" + }, +/obj/structure/cable{ + d1 = 2; + d2 = 4; + icon_state = "2-4" + }, +/turf/simulated/floor/plasteel/white, +/area/station/medical/virology) "ezR" = ( /obj/effect/decal/cleanable/dirt, /turf/simulated/floor/plasteel{ @@ -69236,6 +69245,10 @@ icon_state = "redyellowfull" }, /area/station/maintenance/fsmaint) +"gcP" = ( +/obj/effect/spawner/airlock, +/turf/simulated/wall, +/area/station/hallway/secondary/exit) "gdJ" = ( /obj/effect/spawner/window/reinforced/grilled, /turf/simulated/floor/plating, @@ -71023,6 +71036,16 @@ }, /turf/simulated/floor/plating, /area/station/command/office/rd) +"hli" = ( +/obj/machinery/atmospherics/unary/portables_connector{ + dir = 8 + }, +/obj/machinery/atmospherics/portable/canister/air, +/obj/effect/turf_decal/stripes/line{ + dir = 10 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "hly" = ( /obj/structure/table/wood, /turf/simulated/floor/plasteel/dark, @@ -75560,15 +75583,6 @@ icon_state = "whiteblue" }, /area/station/medical/storage) -"kdg" = ( -/obj/structure/sign/vacuum{ - pixel_x = -32 - }, -/obj/effect/turf_decal/stripes/line{ - dir = 8 - }, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "kdm" = ( /obj/machinery/power/apc/critical/directional/north, /obj/machinery/firealarm{ @@ -75669,6 +75683,15 @@ }, /turf/simulated/floor/plasteel/dark, /area/station/medical/morgue) +"kfC" = ( +/obj/structure/sign/vacuum{ + pixel_x = -32 + }, +/obj/effect/turf_decal/stripes/line{ + dir = 8 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "kfT" = ( /obj/structure/cable{ d2 = 4; @@ -76089,6 +76112,17 @@ /obj/effect/spawner/random_spawners/blood_maybe, /turf/simulated/floor/plating, /area/station/maintenance/fsmaint) +"ksE" = ( +/obj/docking_port/stationary{ + dir = 4; + dwidth = 16; + height = 21; + id = "emergency_home"; + name = "emergency evac bay"; + width = 41 + }, +/turf/space, +/area/space) "ksV" = ( /obj/machinery/door/airlock/maintenance, /obj/effect/mapping_helpers/airlock/access/all/engineering/maintenance, @@ -82354,22 +82388,6 @@ icon_state = "red" }, /area/station/security/permabrig) -"ogR" = ( -/obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{ - dir = 6 - }, -/obj/structure/cable{ - d1 = 4; - d2 = 8; - icon_state = "4-8" - }, -/obj/structure/cable{ - d1 = 2; - d2 = 4; - icon_state = "2-4" - }, -/turf/simulated/floor/plasteel/white, -/area/station/medical/virology) "ogX" = ( /obj/machinery/camera{ c_tag = "Experimentation Lab Office"; @@ -91307,6 +91325,21 @@ }, /turf/simulated/floor/plasteel, /area/station/science/research) +"tjT" = ( +/obj/item/radio/intercom{ + name = "west bump"; + pixel_x = -28 + }, +/obj/machinery/newscaster{ + dir = 1; + name = "south bump"; + pixel_y = -28 + }, +/obj/effect/turf_decal/stripes/line{ + dir = 10 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "tkb" = ( /obj/machinery/atmospherics/pipe/simple/hidden/supply{ dir = 6 @@ -91839,24 +91872,6 @@ icon_state = "yellowcorner" }, /area/station/hallway/primary/port/west) -"tEp" = ( -/obj/effect/spawner/window/reinforced/grilled, -/obj/structure/cable{ - d1 = 2; - d2 = 8; - icon_state = "2-8" - }, -/obj/structure/cable{ - d1 = 1; - d2 = 8; - icon_state = "1-8" - }, -/obj/structure/cable{ - d2 = 8; - icon_state = "0-8" - }, -/turf/simulated/floor/plating, -/area/station/hallway/secondary/exit) "tEw" = ( /obj/structure/showcase{ density = 0; @@ -92354,21 +92369,6 @@ /obj/effect/spawner/window/reinforced/grilled, /turf/simulated/floor/plating, /area/station/security/prison/cell_block) -"tSp" = ( -/obj/item/radio/intercom{ - name = "west bump"; - pixel_x = -28 - }, -/obj/machinery/newscaster{ - dir = 1; - name = "south bump"; - pixel_y = -28 - }, -/obj/effect/turf_decal/stripes/line{ - dir = 10 - }, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "tSt" = ( /obj/structure/table, /obj/item/reagent_containers/drinks/drinkingglass{ @@ -136687,7 +136687,7 @@ dIx dIx dIx dIx -aTq +gcP abj aaa aaa @@ -137198,7 +137198,7 @@ dPM dkq dSs dSP -dSB +hli dIH dIH dIH @@ -137456,8 +137456,8 @@ dNa dXJ dKo dUj -kdg -tSp +kfC +tjT dIH abj aaa @@ -138742,7 +138742,7 @@ joI dNc dNQ dOw -dUY +aJK dIH abj aaa @@ -140526,10 +140526,10 @@ pIY kuJ kpd kpd -tEp -dHO -dHO dHO +evE +evE +evE tJT dKQ jpk @@ -141304,7 +141304,7 @@ aaa aaa aaa aaa -dNS +ksE aaa aaa aaa @@ -149011,7 +149011,7 @@ dGw dGw hGZ qgr -ogR +ezr wWW qfH sRk diff --git a/_maps/map_files/stations/metastation.dmm b/_maps/map_files/stations/metastation.dmm index 188474412c2..ca66c423b30 100644 --- a/_maps/map_files/stations/metastation.dmm +++ b/_maps/map_files/stations/metastation.dmm @@ -6218,10 +6218,6 @@ }, /turf/simulated/floor/plasteel, /area/station/engineering/control) -"aHe" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall, -/area/station/service/bar) "aHg" = ( /obj/effect/turf_decal/stripes/line{ dir = 1 @@ -10928,7 +10924,7 @@ /area/station/public/locker) "aVT" = ( /obj/structure/table, -/obj/item/clothing/head/soft/grey{ +/obj/item/clothing/head/soft{ pixel_x = -2; pixel_y = 3 }, @@ -45393,6 +45389,14 @@ icon_state = "neutralcorner" }, /area/station/hallway/primary/central/west) +"dKD" = ( +/obj/machinery/barsign{ + pixel_y = -32 + }, +/turf/simulated/floor/plasteel{ + icon_state = "redcorner" + }, +/area/station/hallway/primary/starboard) "dKK" = ( /obj/effect/spawner/window/reinforced/grilled, /turf/simulated/floor/plating, @@ -127034,8 +127038,8 @@ bjp bez vtx boY -bqA -aHe +dKD +bsp ded bEv bEv diff --git a/_maps/map_files/templates/biodome_beach.dmm b/_maps/map_files/templates/biodome_beach.dmm index 8fcff913987..c6af4cff658 100644 --- a/_maps/map_files/templates/biodome_beach.dmm +++ b/_maps/map_files/templates/biodome_beach.dmm @@ -454,6 +454,12 @@ }, /turf/simulated/floor/pod, /area/ruin/powered/beach) +"qe" = ( +/obj/machinery/barsign{ + pixel_y = 32 + }, +/turf/simulated/floor/beach/sand, +/area/ruin/powered/beach) "qT" = ( /obj/machinery/shower{ dir = 8 @@ -491,10 +497,6 @@ }, /turf/simulated/floor/beach/sand, /area/ruin/powered/beach) -"Ds" = ( -/obj/structure/sign/barsign, -/turf/simulated/wall/mineral/sandstone, -/area/ruin/powered/beach) "Ec" = ( /obj/machinery/door/airlock/sandstone{ name = "Beach Access" @@ -1087,8 +1089,8 @@ aC aC aC JF -Ds -bE +aj +qe bE bE bE diff --git a/code/__DEFINES/clothing_defines.dm b/code/__DEFINES/clothing_defines.dm index ed5a97ea16c..d0380ede710 100644 --- a/code/__DEFINES/clothing_defines.dm +++ b/code/__DEFINES/clothing_defines.dm @@ -37,6 +37,10 @@ #define SLOT_HUD_COLLAR 23 #define SLOT_HUD_AMOUNT 23 +// Boolean defines for hands +#define HAND_BOOL_RIGHT 0 +#define HAND_BOOL_LEFT 1 + // accessory slots #define ACCESSORY_SLOT_DECOR 1 #define ACCESSORY_SLOT_UTILITY 2 diff --git a/code/__DEFINES/mob_defines.dm b/code/__DEFINES/mob_defines.dm index ebc22191907..5d57157cfb4 100644 --- a/code/__DEFINES/mob_defines.dm +++ b/code/__DEFINES/mob_defines.dm @@ -357,3 +357,9 @@ #define TS_TIER_3 3 #define TS_TIER_4 4 #define TS_TIER_5 5 + +/* Defines used for `incorporeal_move` */ +#define NO_INCORPOREAL_MOVE 0 +#define INCORPOREAL_MOVE_NORMAL 1 +#define INCORPOREAL_MOVE_NINJA 2 +#define INCORPOREAL_MOVE_HOLY_BLOCK 3 diff --git a/code/__HELPERS/tool_helpers.dm b/code/__HELPERS/tool_helpers.dm index 03e14b56141..c88ee7c6046 100644 --- a/code/__HELPERS/tool_helpers.dm +++ b/code/__HELPERS/tool_helpers.dm @@ -26,11 +26,6 @@ return TRUE return FALSE -/proc/iscrowbar(O) - if(istype(O, /obj/item/crowbar)) - return TRUE - return FALSE - /proc/iscoil(O) if(istype(O, /obj/item/stack/cable_coil)) return TRUE diff --git a/code/__HELPERS/type2type.dm b/code/__HELPERS/type2type.dm index 0648b0ac77d..f883f0cec77 100644 --- a/code/__HELPERS/type2type.dm +++ b/code/__HELPERS/type2type.dm @@ -70,8 +70,14 @@ return num_list //Splits the text of a file at seperator and returns them in a list. -/proc/file2list(filename, seperator="\n") - return splittext(return_file_text(filename),seperator) +/proc/file2list(filename, separator = "\n", no_empty = TRUE) + var/list/result = list() + for(var/line in splittext(return_file_text(filename), separator)) + var/text = trim(line) + if(no_empty && !text) + continue + result += text + return result /proc/dir2text(direction) switch(direction) diff --git a/code/__HELPERS/unsorted.dm b/code/__HELPERS/unsorted.dm index 0fa4f14daaf..79d3208719c 100644 --- a/code/__HELPERS/unsorted.dm +++ b/code/__HELPERS/unsorted.dm @@ -1172,7 +1172,7 @@ GLOBAL_LIST_INIT(wall_items, typecacheof(list(/obj/machinery/power/apc, /obj/mac /obj/machinery/computer/security/telescreen, /obj/machinery/airlock_controller, /obj/item/storage/secure/safe, /obj/machinery/door_timer, /obj/machinery/flasher, /obj/machinery/keycard_auth, /obj/structure/mirror, /obj/structure/closet/fireaxecabinet, /obj/machinery/computer/security/telescreen/entertainment, - /obj/structure/sign))) + /obj/structure/sign, /obj/machinery/barsign))) /proc/gotwallitem(loc, dir) for(var/obj/O in loc) diff --git a/code/_onclick/hud/screen_objects.dm b/code/_onclick/hud/screen_objects.dm index d10e0006fb3..b4897cd5df7 100644 --- a/code/_onclick/hud/screen_objects.dm +++ b/code/_onclick/hud/screen_objects.dm @@ -486,9 +486,9 @@ var/mob/M = usr switch(name) if("right hand", "r_hand") - M.activate_hand("r") + M.activate_hand(HAND_BOOL_RIGHT) if("left hand", "l_hand") - M.activate_hand("l") + M.activate_hand(HAND_BOOL_LEFT) return TRUE /atom/movable/screen/swap_hand diff --git a/code/controllers/subsystem/SStimer.dm b/code/controllers/subsystem/SStimer.dm index 7e80a9c06e7..9c9bbeed24a 100644 --- a/code/controllers/subsystem/SStimer.dm +++ b/code/controllers/subsystem/SStimer.dm @@ -341,7 +341,7 @@ SUBSYSTEM_DEF(timer) return // Sort it first - var/list/sorted = sortTim(GLOB.timers_by_type, GLOBAL_PROC_REF(cmp_numeric_dsc), TRUE) + var/list/sorted = sortTim(GLOB.timers_by_proc, GLOBAL_PROC_REF(cmp_numeric_dsc), TRUE) // DOOMP EET var/timer_json_file = file("[GLOB.log_directory]/timers.json") @@ -571,14 +571,14 @@ SUBSYSTEM_DEF(timer) CRASH("this timer is attached to no object, the attempted proc to call was [callBack.delegate]") . = "[callBack.object.type]" -GLOBAL_LIST_EMPTY(timers_by_type) +GLOBAL_LIST_EMPTY(timers_by_proc) // Allows us to track what types generate the most timers. Just invokes the global addtimer /datum/proc/addtimer(datum/callback/callback, wait = 0, flags = 0) - var/tt = "[type]" - if(tt in GLOB.timers_by_type) - GLOB.timers_by_type[tt]++ + var/timer_function = "[type][callback.delegate]" + if(timer_function in GLOB.timers_by_proc) + GLOB.timers_by_proc[timer_function]++ else - GLOB.timers_by_type[tt] = 1 + GLOB.timers_by_proc[timer_function] = 1 return global.addtimer(callback, wait, flags) /** @@ -594,7 +594,7 @@ GLOBAL_LIST_EMPTY(timers_by_type) if(!check_rights(R_DEBUG | R_VIEWRUNTIMES)) return - var/list/sorted = sortTim(GLOB.timers_by_type, GLOBAL_PROC_REF(cmp_numeric_dsc), TRUE) + var/list/sorted = sortTim(GLOB.timers_by_proc, GLOBAL_PROC_REF(cmp_numeric_dsc), TRUE) var/list/text = list("

Timer Log

", "