* null check is important in other languages too
* null check is important in other languages too
* 1/0
* simplify this
* readd user info
* remove this to test
* new name
* Tidy the code, better commenting when things go wrong
* text!
* stale labeller
* get the labels right
* avoid complications
* Update .github/workflows/merge_upstream_master.yml
* Update .github/workflows/merge_upstream_master.yml
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* makes the merge upstream thingy comment, and approve its generated workflows
* wow
* remove this, paradise bot reigns supreme
---------
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Lets us install tgui merge drivers on windows
* test this
* gamer mode
* debug
* do it like this
* test
* test this
* stop it being weirdly relative
* more relative fixes
* try cat
* indentation
* update CI stuff to cache
* correct this
* yarn
* yarn consistency
* do we even need to do this? (no we don't)
* properly cache yarn deps in ci
* Why do we even have that step
---------
Co-authored-by: github-actions <github-actions@github.com>
* CI
* undef
* hooooly crap
* yeah
* false by default
* fixes
* alright, there we go
* oops lmao
* lol, lmao even
* proper programming
* fix
* losin my mind
* oops
* yeah coloring
* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
* Redoes CI + removes RUSTG from the repo
* We need these
* Split these out
* Why does every CI PR end like this
* Agh
* Fun
* Even more shit
* Try this
* Lets bump this
* adds illegal files CI to dme (this will fail)
* im only slightly mentally challenged
* and now magically, the CI works
* better comment? maybe?
* includer -> included (sorry for commit spam)
* lewc review
* warriorstar review
* give em a total number too, for ease of use
* i think this is better wording
* lewcc review
* warriorstar review
* port: tgstation maplint
* Actually add the thing and try using setup-python GH action
* .python-version is gitignored so
* add json5 to requirements
* Run the cheaper, more likely to succeed checks first.
* use version of pyyaml that doesn't have setuptools compat issues
* Add check for grilles on top of spawners.
* Port check_grep.sh from an increasingly complicated shell script to Python.
* Exclude dmdoc-formatted multi-line comments from whitespace check
* Add comment exception for both WS rules
* Fixed mixed tab/space regex.
* hate hate hate hate
* Add doctests to preserve my sanity
* Remove checks involving newlines.
* Add back newline-involved tests. Cry.
* Several large-scale changes.
- Remove all the map-related changes for now, in order to get the
code formatting changes in sooner and prevent more issues from leaking
in while the PR issues are burned down.
- Flip the method for processing files. Instead of trying to sort errors
by type, running over each file for each error, I'm simply breaking
from the original output format and returning a lint-like set of
errors. In this design, each file is opened, the checks are run, and
the file handle is reused for each check.
- Standardize failures so that the filename, line number, and message
can all be retrieved and formatted nicely for stdout.
- Compile regexes. The consensus seeeeeeeems to be that there's a
negligible difference in performance when compiling regexes but
there's a possibility that running them a lot of times may be faster,
and I could actually time it, but ugggggggh.
* Fix render_nanomaps action
Use up-to-date VM and updated SpacemanDMM with modified source
* Revert changes to SpacemanDMM/nanomap-renderer
Note that during map generation this will cause errors in the form of:
```
error: #error Your version of BYOND is too out-of-date to compile this project. Go to https://secure.byond.com/download and update.
error: #error You need version 514.1554 or higher
```
* change da world
* compile, thanks
* Update cere.dmm
* Update cere.dmm
* ready for test
* use the proper name please
its CERE not ceres.
* stops shuttle from forcibly docking with podbay
* things are now different
Landmark update for job spawns.
More hardsuits in EVA, engi, and atmos.
Disaster counters properly added.
Vault is now more spooky.
Gamma armoury moved to below gulag shuttle.
Sleeping rooms replaced with arcade and swimming pool.
Captains ERP nest deleted.
Tcomms now looks like it was designed by a functional human being.
Mining doesn't need a weird glass box.
Shuffled docking ports at arrivals.
Windows are now reinforced windows.
Mr changs has arrived.
* disposals functions now
* now with 50% more air
* gamma armoury doesn't attempt to become one with gulag shuttle
* disposals net is airless, vault is enclosed in some rock
* standard number of escape pods
* slight fixes
* more bugfixes
* lighting fixes
* divided hallways, added psych office, more cams
* fire alarms, shutters, and fixes
* temporary DME edit to set cere as default map
* fixed shuttle runtime
* this compiles and runs locally, please CI
* fixes hidden double pipe
* more double pipes
* more vents and scrubbers, morgue body delivery
* tweaks to secbot pathing
* various QoL changes
* Medbay expansion, med+arrival maints expansion.
* the definitive air alarm update, and more!
* Departmental emergency EVA suits, signage, tweaks.
* 2 Cryodorms added (oops). Asteroid sound updates.
* Borg cryo, shutters correctly rotated.
* Supply shuttle edit. I like joining the map queue.
* minor fixes, grav gen isolation.
* minor fixes
* Disposal fixes, lighting adjustment
* SabreML feedback changes
* More minor fixes
* More fixes
* NSS Farragus
* (most) floors turn into asteroid sand, not spess
* reverted random file edit, fixed mr teeny
* minor fixes
* big bombs can breach asteroid areas
* Asteroid plating exists, did you know? I do now!
* camera network pass
* walls become sand too on destruction
* lighting pass
* implements feedback, dramatically reduces ores
* yeets ores entirely, sci break room added
* roundstart pads, more solars, bigger departures
* runtimes
* mining resistant rock
* variable names are important
* AoE KA doesnt affect rocks
* actually fix AoE stuff
* now with 1000% more bats
* no sandy cables, a brig exit chute, more head ssu
* mech drills are not pickaxes
* proc rename, perma window, faster sapce bridges
* Brig rework
* robotics changes
* More sci edits
* Rotayshun changes
* dme edit
* Delete cerestation.dm
begone, thot
* temp edit so it loads cere as default
* merge conflicts begone
* decal purge
* map repipe
* removes under-wall pipe adapters
* shuffled maint areas
* dirt purge
* longest bridge rework
* fixes
* PPI feedback
* kitchen does, in fact, need air
* permabrig tweaks
* restores cc changes
* merge part 2
* tag purge
* secret clown HQ got me shook
* SQUASHENING
* solar shuffle
* directional consoles
* remove TM edits due to rotation
* merge conflict part 2
* pod pilot deletion
* cold rock, window tint fixes, etc.
* further red rocks
* further tweaks
* more standardising
* robotics redo
* carpet time
* CI update for cere
* Apply suggestions from code review
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* more squash, corridor cam removal, etc.
* light switches
* minor fixes
* temp cere default
* FOODCART!
* fixes
* no airless no more
* space_hall
* compat pass 1
* make it work
* more changes
* slimmening
* air alarm tweak
* TM commit
* ci tests
* final CI changes?
* squash. squeeze, optimise
* wall vent
* disposals fix, more squeezing
* bugfixes
* false walls
* bedroom culling
* edits and fixes
* tweaks
* changes
* det window
* further tweaks
* Revert "TM commit"
This reverts commit 9e8814937f.
* More TM only changes reverted
* fixes smoothing with falsewalls
* denth changes
* the airlockenning
* cicicici
* CICICICI
* further tweaks
* further tweaks
* reverts weird sand behaviour code from ages ago
* oops
* universal adapter my beloathed
* nanomap moment
* webmap
* cere nanomap
* feedback updates
* updates
* airlock tweaks
* vents and tweaks
* solars moment
* triple APC fix
* south of where?
* airlock helpers
* disposal flap purge
* outpost monitor with actual real networks?
* tweakeroni
* fixes
* fixes
* tweaks
* fixes
* medbay improvements
* power and flaps
* changes
* aa changes
* fixes
* more fixeronies
* fixes!
* reversed
* chemicals
* chem tweaks
* fixes
* shuttle fixes
* holopad pass
* editseditsedits
* lightslightslights
* door
* /obj/machinery/computer/security/telescreen/entertainment
* sonic underground
* actual sonic reference
* Apply suggestions from code review
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
* Tsrc
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
* Implement map tests for catching common errors.
- Adds test runner:
- to make it easier to track things across test types
- for example to ensure a fully specified log can be emitted
- Adds map tile test type:
- when writing a test, coders implement CheckTile, which is
handed a single turf
- when the test runner runs these tests, it iterates over
all turfs in the specified z-level, and runs each test's
CheckTile on each turf in turn.
- Adds two sample map tile tests:
- check to see if a pipe exists on the same tile as a scrubber
or vent
- check to see if a tile contains two cables, each with a center
node
* Review #1:
- Replace nested loops over map tiles with `block`
- Remove check for valid turf in individual tests, I think it's safe to
assume `block` will always return legit turfs
- Added proper duration tracking for old tests
- Gave log file an appropriate extension
- Actually use `Fail` for tests
* whoops
* add more tests suggested by @Vi3trice
* Add some more tests courtesy @Bm0n and @Vi3trice
* windows are okay in space as long as it's nearspace
* Add failure threshold to prevent excessive logging.
Once this threshold is reached, a test will stop being processed for
every tile.
Note that this applies to `log_world` and `text2file` equally when
logging large amounts of failures.
* Document each test.
* Remove unnecessary reboot
* Let all map tests run to completion in CI matrix.
* I know what alphabetical means
