Commit Graph
248 Commits
Author SHA1 Message Date
82062b5d05 [s] Fix an exploit involving air alarms. (#32171)
* Fix an exploit involving air alarms.

* Apply sug

Co-authored-by: PollardTheDragon <144391971+PollardTheDragon@users.noreply.github.com>
Signed-off-by: Alan <alfalfascout@users.noreply.github.com>

---------

Signed-off-by: Alan <alfalfascout@users.noreply.github.com>
Co-authored-by: PollardTheDragon <144391971+PollardTheDragon@users.noreply.github.com>
2026-06-26 22:28:34 +00:00
PollardTheDragonandGitHub 8f654dfcc7 Adds Kidan Ship Ruin (#32081)
* Kidan Warriors

* Linters

* Kidan mob AI adjustments and stat adjustments. Kidan Princess Megafauna

* Bug spray vulnerability

* Ragnarok props and kidan spear update

* The ship

* Fixes and adjustments

* Map update

* Linters
2026-06-24 21:49:27 +00:00
ToasticalandGitHub 87877363a3 Add fire alarm functionality to air alarms (#31970)
* Add fire alarm functionality to air alarms

* prettier
2026-05-17 11:56:53 +00:00
CRUNCHandGitHub 8a370088c1 Updates Pre-Loaded & Upgraded Machines (#31952)
* upgraded machines and pre-loading

* agghhhh!

* stovetop of failure

* Update cerestation.dmm

---------

Signed-off-by: CRUNCH <143041327+CRUNCH-Borg@users.noreply.github.com>
2026-05-17 11:35:29 +00:00
Hayden RedactedandGitHub 869f091967 Adds a Variety of Keyboard Shortcuts to Thermomachine Operation (#31930)
* initial commit

* allows synthetics to also use the shortcuts
2026-04-28 23:59:14 +00:00
Hayden RedactedandGitHub 58467b3ed1 initial commit (#31905) 2026-04-28 23:46:32 +00:00
68fb77a19a Wallening 2: Return of the attack of the girders [MDB IGNORE][IDB IGNORE] (#30609)
* WE HAVE LIFTOFF

* Reinforced wall + fixes

* (Reinforced) windows

* Adds nameless plasmaglass sprites

* Plasma windows

* Unnamed cult walls

* Add window edges back

* Wooden walls

* Plasma walls + THANK YOU CHAP

* Oops

* Wooden names

* Cult walls

* Plasma walls

* Uranium walls

* Golden walls

* Silver walls

* False wall basics

* All false walls

* Remove old walls

* Fixes

* First girders

* Build steps

* New floors and decalized floor tiles.

* satisfy linter

* Add command decals, remove old "blue tile" decal

* update script number

* have ATMs put their decals on last

* add engineering decals

* update spritesheets

* lots of tile coloring fixes

* more engi tile fixes

* more tile fixes

* linters

* fixes conflict?

* conflict fixes

* fix layering issue

* cult, necropolis, plastitanium, rocks, backrooms walls

* survival pod walls, prepare for titanium, plastitanium fwall fix

removes diagonal smoothing and the nodiagonal subtype from titanium walls as survival pod walls are a subtype of titanium

* linters

* linters again

* linters number 1 million and counting

* titanium walls

* brass walls, floors, windows

* titanium window, plastitanium window

* brass window smooths with wood and brass walls

* linters number 1 million and one

* all walls smooth with airlocks

in preparation for airlock sprites in a separate PR

* now all walls smooth with airlocks

* windows smooth with airlocks

* separate wallbumps, partially add apc

* tinted window

* survival pod windows

* oops i reverted apc.dm

* mapping fixes

* more mapping sprites

* more mapping stuff, fix my ungodly smooth rocks

* linters

* apc fix

* air alarm, apc, fire alarm offset preparations

* fire alarm implementation + rock fixes + firelock smoothing

* airlocks + supposed map fixes

* engi/atmos airlocks + overlays

* the rest of the doors lol

* linters + freezer fix

* fixes

* shuttle airlock + misc fixes

* firelocks

* fix

* oops

* i need to stop pushing fixes early

* shuttle airlock quickfix

* external airlocks + hatches + fixes

* centcom doors

* highsec airlocks

* vault airlock, double airlocks

* yaya deconflictsies

* lotsa fixes

* light fixes + blastdoor fixes

* firelock gap fix

* light construction fix + rcd fix

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Alexios <skillpointHD@Gmail.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
2026-04-22 14:49:30 +00:00
BiancaWilksonandGitHub a470d925c0 Turn server room into AI node room (#31666) 2026-03-13 19:34:44 +00:00
Christer2222andGitHub b5eabdf1a9 You can now stick forks into outlets (#31435)
* now shocks

* machines + added get_internal_wires

* removed duplicate variable on syndicatebomb

* adds wire tearing, check if the door has a plating

* return a few item_interaction_complete

* linting + unpowered message

* removed some checks  + floodlights + ChemMaster

* cut_random_uncut() -> cut_random_uncut_wire()

* simplified random wire selection

* return ..() + removed /

* early return if not machine

* get_internal_wires() comment

* attackchain

* attackchain + comment removal

* duplicate variable removal

* removed extra lines

* removed some / + removed unnecessary checks

* removed uncut wirecount function + extra check to cooking machinery

* attack chain signal

* space

* removed some \thes
2026-02-17 19:12:09 +00:00
203105788c [IDB Ignore] Heretic: The Mansus Re-Opened (#30738)
* fixes

* fuck my stupid chungus life

* Minion limit, heal fix, dead sac fix

* cooldown, no sacrificing star gazer or ascended alive heretics

* blade debuff

* oopsy

* Update tgui.bundle.js

* map diff bot what ya doing

* fuck that chat spam

* lets heretic armour hold a haunted longsword

* why not it makes sense

* do_after

* god I hate this bullshit

* other lewc stuff

* push

* heretic id card fix

* she tg on my ui till I css

* yes

* spent

* fix / ipc buff (real)™️

* moderate again

* revert

* no reserve

* bringing up to master

* update map files to master

* didnt replace centcomm

* beginning some rebalancing

* aggressive spread tweaks

* lots of tweaks and fixes

* trying to un-key the maps

* maybe this time

* this time????

* oops

* sql fix

* basicmob conversion

* paintings! and a critical influence fix

* rust + tweaks

* monster tweak

* small change

* removing this

* more tweaks. no more dusting

* added some examine_more

* flower seeds

* various tweaks. more to come

* no more conduit spacing

* fixed some dumb stuff

* silly stuff

* its always prettier

* bugfixes and linters

* linters, wow

* oops

* bah

* linter

* fuck you

* temp check

* hidden influence drain

* influence visible message

* tweak fix

* void cloak bugfix

* small fixes

* fixes

* do_after_once broken

* fixes and tweaks

* heretic blade potential fix + sacrifice changes

* batch of fixes

* tiny tweak

* rebuilt TGUI

* no greentext + rerolls

* logging + bugfix

* unused var

* small fix

* various fixes

* comment

* projectile change

* tgui rebuild

* tgui bundle redo

* rune issue solved

* influence visible now

* fix ui reloading

* new moon ascension + fixes + icons

* tweaks, species sprites

* tgui rebuild

* small tweak + linter

* harvester icon tweak

* spans

* fixes and tweaks

* caretaker nerf + tweaks

* potential fix for knowledge

* roller fix

* mad mask

* Update tgui.bundle.js

* void phase tweak

* Update tgui.bundle.js

* misc tweaks

* fix heretic not retargeting correctly with cryo

* simplify logic

* this is better

* lots of fixes and tweaks

* Update tgui.bundle.js

* linter

* linter

* fireshark and greyscale insanity

* fish

* Update tgui.bundle.js

* linter

* linter

* tgui

* no window shopping

* fish fix

* tgui rebundle

* moon smile runtime fix

* various fixes

* sacrifice fixes

* insanity is easier now, madness mask changes.

* bugfixing + teleport change

* linters + tweaks

* Update code/modules/antagonists/heretic/status_effects/mark_effects.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Kyani <65205627+EmeraldCandy@users.noreply.github.com>

* Update code/modules/antagonists/heretic/status_effects/mark_effects.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Kyani <65205627+EmeraldCandy@users.noreply.github.com>

---------

Signed-off-by: Kyani <65205627+EmeraldCandy@users.noreply.github.com>
Co-authored-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Paul <pmerkamp@gmail.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2026-01-27 20:36:52 +00:00
kyunkyunkyunandGitHub b0463d3c83 Convert most spans to defines (#31080)
* spanish?

* aaaagain

* keep maptext

* Update robot_items.dm

* Update span_defines.dm

* compiles

* Update silicon_mob.dm

* compile
2025-12-13 23:55:48 +00:00
ContrabangandGitHub ef7e48db9c Makes a ton of dirs into defines (#31244)
* Makes a ton of dirs into defines

* lol oops

* "fix"

* ignore everything
2025-12-12 20:32:33 +00:00
Hayden RedactedGitHubDGamerLJimKil3paradisess13[bot] <165046124+paradisess13[bot]@users.noreply.github.com>warriorstar-orion
5728e0c46f Adds Water Vapor and the Electrolyzer (#30875)
* this will work first try (adds water vapor and the electrolyzer)

* naming fix

* removes a warn

* makes water vapor able to be seen and adds it to the tiny_test atmos map

* Build Rust library

* adds the electrolyzer to all maps, and linter fix

* linter fix part 2

* electrolyzer tweak and more work on the test_atmos map

* tgui rebuilding

* re
rebuilding tgui

* makes the electrolyzer consume power and some small test atmos touch ups

* im axing the test_tiny because i don't want to map it

* clarifies how much power the electrolyzer uses

* Build Rust library

* suggestionss

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: JimKil3 <47290811+JimKil3@users.noreply.github.com>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* updating the SM manual

* electrolyzer tweaks

* dg suggestions pt. 2

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* removed unused code

---------

Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
Co-authored-by: paradisess13[bot] <165046124+paradisess13[bot]@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: JimKil3 <47290811+JimKil3@users.noreply.github.com>
2025-12-10 00:04:11 +00:00
AlanandGitHub 2ed573ded6 Hint digital valve direction when closed/off. (#31127) 2025-12-05 07:54:51 +00:00
AlanandGitHub 547d33a68b Resprite manual valves. (#31140) 2025-12-05 07:43:10 +00:00
Hayden RedactedandGitHub 79a891fd6d Remaps the Toxins Area on Deltastation and Adds an Empty Portable Air Pump Variant (#31000)
* finishes the remap and adds a portable air pump that starts empty

* inheritance moment

* linter fixes

* addresses komrad's comment and moves the pipe adapters to be hidden
2025-12-03 16:04:13 +00:00
Hayden RedactedandGitHub b0f2dbaf23 Adds the Temperature Gate (#30812)
* introducing, the temperature gate!

* why is are the icons not workinggg, perhaps CI to the rescue

* rebuilding tgui

* tgui fix!

* icon fixes and tgui

* if i had a nickel for everytime i got told to rebuild tgui

* as funny as "the temperature thing" is, it should have a proper description

* T0C rounded to 273

* small typo

* some small sprite work
2025-11-28 16:36:47 +00:00
ToasticalandGitHub 51c47d8342 Fix compiler errors for 1670 (#30874)
* stage 1

* hud alist

* mobs and parry

* stage ?

* we dont even need an alist here
2025-11-11 10:38:24 +00:00
Hayden RedactedGitHubparadisess13[bot] <165046124+paradisess13[bot]@users.noreply.github.com>
99d57fd35d Adds Hydrogen - The Framework for more Atmos Gases (#30742)
* IMPORTANT MILESTONE, AIR IS BREATHABLE

* the vibrations of the SM in my headphones are pleasing (no stupid hotspots)

* sanity check, it all works

* SM is fine

* this will work first try

* linter

* "thank you, warriorstar" everyone says in unison

* Build Rust library

* finishing touches (hopefully)

* Build Rust library

* update gas_mixture.dm to include hydrogen burning

* Build Rust library

* hydrogen should be the right color on gas analyzers

* i JUST rebuilt it

* adds agent B and Hydrogen floors

* update the h2 canister

* caniser bad speling

* in aa we trust

* Build Rust library

* Build Rust library

---------

Co-authored-by: paradisess13[bot] <165046124+paradisess13[bot]@users.noreply.github.com>
2025-11-03 21:05:26 +00:00
MigratingcocofruitandGitHub ad98a804cb Adds the alien cache ruin and a PTL terminal (#30367)
* Make the cache room

* adds alien cache machine

* adds the cache properly

* adds multitile component

* adds terminal building and reward selection procs

* adds laser receptacle file

* Refactors ptl targetting code

* more work on the ptl terminal

* change file name to laser_terminal

* changes area to powered makes laser terminal work properly

* makes a new pickweight function because the old one is bad

* Update alien_cache.dm

* Update canister.dm

* Update alien_cache.dm

* adds a template of the ruin

* adds some spawners to the reward pool

* adjusts agent b amount

* adjustments to loot table and changes to spawner comments

* new placeholder sprite for the cache

* randomizes reward spawn location and makes a PTL terminal sprite

* updates alien cache sprite and examine proc

* Adds overlays to the cache to indicate the current progress

* fixes mob capsule spawner and laser terminal

* Adds animations to PTL terminal

* new box part of the sprite for the PTL terminal. Adds glow

* fixes untargetting the PTL terminal and adds a little light overlay to the receiving dish

* changes PTL terminal id generation slightly

* adds simon says. incomplete

* Update paradise.dme

* simon says works now

* adds more rhythms

* Adds success and failure sounds

* Makes the ptl terminal board printable

* Update secure_alien_airlock.dm

* undo changes to preferences.dm

* undefs things

* removes identical to parent vars

* Update alien_cache_random_spawners.dm

* replaces animation end loop flag so open dream CI doesn't give errors

* changes centre platform colour and adds a fan to the entrance

* more pads more sounds

* better sprites

* remove old sprite

* adds the cache to example config

* makes it not always spawn

* Update simon_says_32x32.dmi

* adds some flavor to the ruin

* Update alien_cache_site.dmm

* adds a signal to the ruin
2025-10-01 12:54:10 +00:00
AlanandGitHub 99d0494e2e Add mention of alt-click lock/unlock shortcut to APC and Air Alarm descriptions. (#30420) 2025-09-26 08:27:27 +00:00
Charlie NolanandGitHub b2f3eac474 Add safeguards to share_many_airs and gas_mixture (#30077)
* Add safeguards to `share_many_airs`

* More safeguards!

* Crash out of HE pipe heat transfer if transfer value is not sane.
2025-09-16 17:49:19 +00:00
AlanandGitHub 7ee0ebc16a Standardize air alarm buildstages to defines for clarity (#30421) 2025-09-15 16:47:35 +00:00
MigratingcocofruitandGitHub 4801aa4579 Increases temp threshold and reduces animation time for HE pipes (#30314) 2025-08-28 20:58:56 +00:00
CRUNCHandGitHub c22e1ceb6f Update airalarm.dm (#29954) 2025-08-13 20:39:19 +00:00
Charlie NolanandGitHub 73421a7963 Prevent qdeleted pipelines and machinery from sharing air. (#29858)
* Prevent qdeleted pipelines and machinery from sharing air.

* Handle broken pipelines.

* Better cleanup.

* qdeleted checks
2025-08-06 05:16:00 +00:00
BurzahandGitHub 3d5b042c31 initial commit (#29881) 2025-08-01 07:10:16 +00:00
67671bf190 Allows people to toggle the cryocell auto-eject timer on and off (#29716)
* Adds toggle to cryocell auto-eject timer

* Removed unnecessary return

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PollardTheDragon <144391971+PollardTheDragon@users.noreply.github.com>

* Adds examine message

* Adds alert when entering cryocell with auto-eject disabled. Clicking it lets you resist out after 1 minute, even if unconscious.

---------

Signed-off-by: PollardTheDragon <144391971+PollardTheDragon@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-07-30 01:01:27 +00:00
ContrabangandGitHub 1504ed98be massive burndown (#29894) 2025-07-27 20:52:39 +00:00
Charlie NolanandGitHub 6d42a247bf Siphon vents should siphon. (#29718) 2025-07-05 05:36:03 +00:00
ContrabangandGitHub 211633f2b5 Adds AI ventcrawling code, does not implement it (#29661)
* bam

* push

* im trolling myself

* code

* ok lets go

* fix

* improvements
2025-07-04 19:05:23 +00:00
AmyandGitHub 85f8017ab6 More SoftReservedKeyword fixes (#29712)
* Update shieldgen.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update station_alert.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update plasmafire_generator.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update turf.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update atmospherics.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update silicon_mob.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update ai_mob.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update robot_mob.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

* Update on_move.dm

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>

---------

Signed-off-by: Amy <3855802+amylizzle@users.noreply.github.com>
2025-07-04 18:51:32 +00:00
OsetrokarasekandGitHub 8b3de4dd3e Add Wheelcart Sound To More Objs (#29427)
* bo

* ba

---------

Signed-off-by: Osetrokarasek <78341303+ostrkrs@users.noreply.github.com>
2025-06-18 20:31:24 +00:00
warriorstar-orionandGitHub 7fb024cc89 add emissives to refill stations (#29176) 2025-05-04 03:43:02 +00:00
MigratingcocofruitandGitHub 63fb835a3e Replace atmos tank vents with scrubbers (#29047)
* Replace tank vents with scrubbers

* Update emeraldstation.dmm

* take care of stray autolink ids

* fix some maps

* Update boxstation.dmm

* Update boxstation.dmm

* change injectors vents and scrubber to be off by default when added to a controller.

* makes refresh work properly if one of the devices is deleted
2025-04-26 18:43:51 +00:00
MigratingcocofruitandGitHub 172887da50 Fixed filters and mixers operating with no power (#29050) 2025-04-26 18:19:43 +00:00
6ecd1e4091 Tanks Matter: Refill Stations and Internals Nerfs (#28821)
* Nerfs tank volumes

* Adjusted gas volumes, commented expected tank durations

* Refill station no id

* No more unwrenching refill stations

* Unary Refill Stations

* Refill stations are working, and sprited

* Analyzers and plasma tank limit

* added machines

* Made refill stations truly standalone, gave them canister-sized internal volumes. Removed excess file

* Fixed runtimes, emerald conflict

* implanted the machines

* placement revisions

* oops

* Fixes CI issues on Delta and Emerald

* Removed unintended change

* Grammar

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: PollardTheDragon <144391971+PollardTheDragon@users.noreply.github.com>

* Power stuff

* Some map fixes

* More fixes

* Removes extraneous the, better checks for allowed tanks in plasma refill station

* Update for multi-sector lavaland

* Fixes air mix tanks distribution pressure

* Fixes runtimes

* Map merge fixes

* More fixes

* Even more map merge fixes

---------

Signed-off-by: PollardTheDragon <144391971+PollardTheDragon@users.noreply.github.com>
Co-authored-by: EmeraldCandy <silverriolu@yahoo.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2025-04-26 17:35:33 +00:00
MigratingcocofruitandGitHub 00573a16fd Tank control console improvements(and migrates multitool to new attack chain) (#28252)
* Allows multiple inlets and outlets

* Starts adding range to multimeter and fixes some stuff

* Migrates multitool to new attack chain and increases the scanning range

* adds vent scrubbers

* Fixes scrubber control

* moves uplink multitool to new attack chain as well

* oops

* reverts putting injectors and vents into their own component due to numbered input stuttering

* Allows vent pressure reference to be changed

* Fix bugs when adding or removing devices

* tgui rebuild

* Makes the UI look nicer

* Update tgui.bundle.js

* add range to sensor multitool interaction as well

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* review changes

* reeee

* Update tgui.bundle.js
2025-04-06 09:40:47 +00:00
warriorstar-orionandGitHub 323d2c0b10 fix atmos machines not updating appearance on shuttle rotate (#28898) 2025-04-05 12:03:13 +00:00
warriorstar-orionandGitHub 9c3dd81dce add investigate log for destroyed canisters (#28880) 2025-04-04 15:54:23 +00:00
warriorstar-orionandGitHub ff0c749f31 refactor: add commonly used investigate category defines (#28826) 2025-03-30 23:10:48 +00:00
Charlie NolanandGitHub 194e851b8f SSair performance improvements (#28271) 2025-02-12 22:39:09 +00:00
Charlie NolanandGitHub 36139a664c Better atmos init (#28274) 2025-02-08 18:29:00 +00:00
ContrabangandGitHub e3f73e178d Changes a lot of lighting colors, ranges, and powers (#28226)
* 8u hiubntgvby9 gb

* colors

* undo airlock

* bluer light

* spaghetti review
2025-02-04 19:30:09 +00:00
MigratingcocofruitandGitHub 8e1df0dced Adds unaccounted for volumes to the gas analyzer's scan and allows for a summarized view of scanned airs (#27668)
* pipes now return all airs in their pipenet when analyzed and the gas scan can either return individual reports of all airs or the sum of all airs.

* Replaces scanners.dm with the one from the upstream since it didn't do so when I merged

* Makes the scanner scan all connected volumes again. need to re-add detailed mode

* Readds the detailed report feature to the analyzer

* changes a comment

* corrects the message when turning detailed reporting on/off

* Fixes a runtime the could happen when gas scanning things that don't have a gas mix associated with them as a ghost.
2025-01-26 13:39:54 +00:00
warriorstar-orionandGitHub f479ace54f Attack chain migration: /obj/machinery (#27784)
* one at a time let's go

* air alarm

* so many

* meh

* hell

* hell

* hmm

* Attack chain migration: /obj/machinery

* what the fuck?

* hell

* review fixes

* whoops

* fix build

* nuke fixes, more tests

* gland dispsenser and start of autolathe test

* var renames

* small fixes

* i tire of life

* more tests

* more tests

* more tests

* shrink map

* customize autolathe design disk load delay

* cell charger

* fire alarm frame installation test

* funny and burz reviews

* nuke fixes
2025-01-26 00:23:42 +00:00
Charlie NolanandGitHub 28b41d925d SSair correctness improvments (#28057) 2025-01-22 04:09:14 +00:00
Charlie NolanandGitHub fdbd2b2050 Assorted atmos performance improvements. (#27966) 2025-01-20 15:18:32 +00:00
93ed0f096d Refactors AI / camera eyes and slows holopad holograms to walk speed (#25078)
* Refactor/deduplicate camera eye code

Camera Eyes previously had duplicated logic across several files. This
change uncooks the spaghetti. Additionally, half-baked support for TG's
multicam feature has been removed, as it was not functional or in use.

* lets ff now

* Camera Eye refactor fixes and finishing touches

This change completes a refactor of AI eyes, which were previously used
by xenobio consoles, syndicate and abductor camera consoles, shuttle
docking computers, holograms, and, of course, the AI. Duplicated logic
has been extracted to an abstract base mob, /mob/camera/eye, from which
new types for each of the above now derive.

Functionality is largely the same, with only a few minor cosmetic
differences (i.e. camera eyes are now appropriately named given their
type and user), as well as a quality-of-life enhancement for holograms,
slowing their movement speed to base run speed to prevent users from
accidentally zooming out of calls.

* Camera eye refactor: Fix AI acceleration toggle

The acceleration toggle was broken in the camera eye refactor, as
previously the boolean was stored on the AI rather than its eye. This
change fixes that.

* Camera eye refactor: Fix syndicate cam visibility

With the camera eye refactor, the syndicate advanced camera consoles
lost the ability to view maintenance tunnels and other areas without
active cameras, seeing static in their place instead (as all other
cameras do). This change reinstates the original behavior.

* Camera eye refactor: Convert spaces to tabs

* Camera eye refactor: Fix CRLF

* Apply suggestions from code review

General minor code quality improvements suggested by GDNgit

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* Apply suggestions from code review

Rename parameter names to avoid src accesses, remove an ambiguous and
unused mob_define and holopad range variable from a previous WIP, change
the for loop in /mob/camera/eye/relaymove to a for-to loop, and change
the chat message warning, sent when an AI Eye is created on an AI that
already has one, to a stack trace

* Adds toggle to AI commands for fast holograms

* Refactor ripped Hologram Eye relaymove

Previously, the relaymove proc for hologram eyes was redundant and
nearly impossible to read. It has been separated out into a few
different named procs, and has had its use of `spawn` removed.

* Remove unnecessary src access

* Fix bug involving shuttle placement outlines

The camera eye refactor that this commit is a part of introduced a bug
that prevented shuttle placement outlines from showing up on first use
of the shuttle console. This change fixes that bug.

* Unrevert some changes from #26306 lost in merge

* Remove erroneous free xray vision on advanced cams

* Autodoc camera acceleration vars

* Remove redundant null var initialization per code review

Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>

* Changed variables to camel_case, autodocs, cleanup

Changed a number of camera eye-related variables to camel_case style,
added appropriate autodoc comments, as per code review. Also removed an
unused cameranet function, modified the call signature of a cameranet
function to be more semantic, and changed a qdel-on-initialize in camera
eyes to return INITIALIZE_HINT_QDEL instead.

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Remove stray qdel(src) per code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>

---------

Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-01-17 18:22:43 +00:00
Charlie NolanandGitHub 39fa268f54 Bigger air pumps (#27894)
* Icons for bigger portable pumps.

* Bigger portable pumps.

* Correc bluespace attachments.

* Expanded Engineering ERT Storage
2025-01-15 14:40:24 +00:00