* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
`mutations` contains typepaths. `for(var/datum/spacevine_mutation/SM in mutations)` won't actually iterate through anything, because DM is stupid. Adding `as anything` makes it work as expected.
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Extract requests console message sending code.
* Add secondary goals
* Converted supply shuttle to a signal-based system.
* Lint.
* Review suggestions.
* Secondary goals can now check the supply shuttle for their requirements.
* Remove redundant completion variable, undef what we define.
* Made the request console refuse to issue a secondary goal until you finish the current one.
* Made the shuttle blacklist error more specific, added locked/manifest-attached crates to blacklist.
* Added round end secondary goal report.
* Lint
* Add tags to reagents for secondary goals to use.
* Extracted the reagent logic from the bar goal, used reagent tags.
* Added the Variety of Drinks Bar goal.
* Added variety drinks goal for the Bar.
* CC no longer complains about sending stuff in containers, but the shuttle will refuse lockboxes without goal items.
* Allow unlocked lockboxes on the shuttle.
* Added kitchen goals.
* Lint
* More lint
* Add goals for scichem and medchem, pending reagent labelling.
* Added Kudzu goal for botany.
* I forgot to rename them, oops.
* Lint
* Made mechs sellable, configurable goal rewards.
* Balancing changes.
* Added random Ripley goal.
* Add Clear Task Backlog station goal.
* Lint
* Oops.
* did i even do this right
* Lint
* Excluded drinks available from upgraded booze dispenser.
* Such bugs. Much fix. Wow.
* Goal notice formatting.
* Apply suggestions from code review
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
* Made storage nesting better, improved consistency between storage types.
* Out, er, space.
* Added a proc for sending a requests console message.
* Added error messages to Virology Goals.
Backported a few small things from Secondary Goals to make this easier.
* Extracted out the three-way reward code into a proc.
* Update code/__DEFINES/dcs/signals.dm
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Removed redundant SIGNAL_HANDLER labels.
* Yes, that should be a proc.
* Enforce important parent calls.
* Thank you, DreamChecker
* Undid accidental merge of #24699
* Removed a testing proc that wasn't intended for this PR.
* Removed parts of #24750 that also crept in.
* Made the variety of [x] goals more explicit that they want 50u of each.
* Reduced Kudzu trait requirement to 1.
* Request consoles now output the list of valid departments if you're at an unsupported one.
* Added personal crates.
* Added a supply pack of personal crates.
* Added special cargo handling for personal crates.
* Added automatic personal crate when requesting a goal.
* Required personal crates for most secondary goals.
* Add goal labels to the hand labeler, require them for mech goals.
* Made secondary goals one-per-person, not one-per-department.
* Added support for multi-line system messages to the request consoles.
* Made the RC message for goals nicer.
* Send goal crates even if no normal crates are ready, name and access-lock them properly.
* Don't double-label.
* Let's not use registered_account, names are fine.
* Add a ton of blackbox data to cargo and secondary goals.
* Fix a few bugs.
* More bugfixing, couple more stats.
* Even more stats.
* Text fix.
* Made cargo fines more consistent with other cargo feedback.
* Fixed a bug that prevented non-top-level items from being checked for CARGO_REQUIRE_PRIORITY.
* Blocked large crates from being sent back unopened.
* Enum values should probably be different from each other.
* Correct a bitflag mishap.
* Removed redundant supply shuttle docking and buy/sell attempts.
* Tweak message about personal crates to inlclude that they need to lock it.
* Add /Crates to the Personal Lockers description.
* Less pretty alignment, less complaining linters.
* Corrected a bad name in stats tracking.
* Reduced SciChem variety goal to 5 types.
* Toned down Task Backlog a bit.
* Fixed a bug that made unsellable items nested in containers be stolen by CC (qdeleted).
* Don't require bluespace 8, that's silly.
* Made secondary goals modifiable in the Modify Station Goals UI.
* Whoops, that was supposed to be 600u.
* i ded pls nerf
---------
Co-authored-by: synthtee <127706731+SynthTwo@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* CI
* undef
* hooooly crap
* yeah
* false by default
* fixes
* alright, there we go
* oops lmao
* lol, lmao even
* proper programming
* fix
* losin my mind
* oops
* yeah coloring
* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
