* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* Many botany QoL changes.
* Give observers a plant analyzer.
* Hooks should be executable.
* Completely new botany mutation mechanics.
* Minor fixes, changed vendor contents.
* Add charcoal to NutriMax extended inventory.
* Lint.
* Reset somatoray beam effects in a few more places.
* Mapped in seed sorting trays and mutrient.
* Slimmed down the seed sorting tray.
* Update unsorted seeds with analyzer, ghost-analyzer, and HUD support.
* Make english_list null-safe (and slightly faster).
* Fixed a mutation focus bug, added plant anayzer attackby to unsorted seeds.
* Made self-sufficient trays display their nutrient as Earthsblood.
* Improved descriptions and on-use texts.
* Added 5 dropers and 3 seed sorting trays to NutriMax.
* Mark stuff as notices, special case for duplicate doping.
* New way to get kudzu, QoL changes.
* Yield somatoray adds a message to the yield stat.
* Unsorted seeds produce a message when you try to put them in a tray or
machine.
* Potassium iodide and pentetic acid will now neutralize the tray's
mutagen.
* Using a plant bag on a seed extractor will now process plants into
seeds if there are no seeds in it.
* Bonk.
* Don't try to extract no seeds.
* Butterfingers.
* Bonk more.
* Add seed sorting trays to perma.
* Upgraded Seed Extractor GUI.
* Do not drop that which you do not extract.
* Don't bug out when removing the last seed.
* You want a tgui rebuild? Have a tgui rebuild.
* Drop trait-adding threshold by 10.
Before:
Needs modified mutation level >50.
With the x2 from 9+ seeds, this happens at base mutation level 25.
With maximum mutation level of 35 (L4Z+mutagen+somatoray), chance was
20%.
Required either L4Z (yield set to 1), or a somatoray (external help) for
any chance.
After:
Needs modified mutation level >40.
With the x2 from 9+ seeds, this happens at base mutation level 20.
With maximum mutation level of 35 (L4Z+mutagen+somatoray), chance is
30%.
Can get 10% chance with mutation level 25 (Mut+mutagen).
* Renamed mutagen level -> mutagen tank
* Left-align seed extractor, more efficient icon sending.
* New sprite thanks to McRamon.
* tgui rebuild
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
* Refactors Mutations
* traits
* more work
* styling fix
* yet even more work
* oh hush
* almost there
* it continues yet further
* and that's genetics done
* and that's it folks
* last bit and golem fixup
* oof
* oops
* tweaks and fixes
* styling
Fixes more compile errors. Down to 65 now.
updates << into to_chat
Down to 60 errors, also starts to port the codex gigas and law 666 for cyborg devils.
Fixes more compile errors. Down to 41 now.
Replaces timers with spawns, and <<s with to_chats
40 compile errors.
Down to 34 compile errors.
whoops, actually down to 34 now.
Down to 25 compile errors.
Down to 15 compile errors, I'llprobably need some help at this point.
Woo! Down to 7 compile errors.
Ported over devil hud. Number of errors up to 19.
WOO! It compiles. It's completely untested, but it compiles.
Adds devils to traitor panel
Implements iron, silver and salt banes.
implements flashing lights bane
Selling your soul prevents cloning, and some other methods of revival.
Implements harvest bane
Merged and sorted icons/obj/bureaucracy.dmi
Adds toy codex gigas
Fixes compile errors, adds codex gigas sprite.
Lots of bug fixes. Contracts work, devil revival is more consistant, etc
Adds missing icons for flaming contracts, summon pitchfork, summon wealth, employment cabinet, and sintouch.
Converts DEEP LORE explanations from hell to inferno incorporated.
Banishes the compile errors.
Devils come from hell again.
replaces offer drink obligation with a much more lore appropriate devil's fiddle reference
Also fixes contract bashing brain damage chance.
Undoes some changes I accidentally did to example config files.
Fixes up a few remaining bugs.
Puts in the codex gigas and employment contract cabinets.
-- Lemon - I kinda skipped this one, I'll patch it back in later because
map conflicts are suffering incarnate
Solves the devil law problem in a REALLY hacky snowflake way.
Fixes a few methods in which a hellbound can be revived.
Devils respawn with a limited number of appropriate items, instead of COMPLETELY naked upon corpse destruction. Also adds lines to example config.
Updates devil laws to be less hacky.
Objective to sintouch x mortals now greentexts correctly.
Contracts no longer cause brain damage. I didn't realize it was lethal on this codebase. Oops.
Splits dust(visual_only) into dust() and dust_animation() procs
Fixes some defines.
Adds undef statements to improve compile times.
Fixes race changes from demonic form changes.
Fixes small runtime error. (Which somehow didn't break anything?)
Implements lots of small changes/corrections suggested by CrazyLemon64
I still need to test these changes, along with other potential issues he brought up.
Fixes harvest bane and power contracts. Also adds a few </span> tag enders.
Corrects some edge cases with revival contracts.
Fixes compile error.
Reverts unneccecary change to item/weapon/reagent_containers
Cleans up the code for readability.
Prevents cloning of hellbound individuals.
Latejoins now properly have employment contracts added to employment cabinets (provided they still exist)
Infernal contracts are no longer rendered unreadable by fire and alcohol.
All fireproof paper remains readable after being fireballed, not just infernal contracts. (Though infernal contracts are the only fireproof paper atm)
Fixes an edge case problem with cloning.
Adds is_revivable proc to mind.
Removes snowflake code involving preventing soulseller resurrection.
Indulges in the sin of sloth, and copies tg's lazy list macros
Proc calls that transform the user no longer go to a null target
Fixes devil UI, human regression will keep appearance, and adds danceoff
Devil's base forms no longer suffocate inside the devil
Fixes runtimes, gets stuff working
The arch devil can now blast down walls with their pitchfork
EXTERMINATE ALL SPIRITS
Activates devil clause in voice of god
Fawks Mcclood
Feature P A R I T Y
Fixes devil bugs from testing
- Does a death refactor to make sure that diabolical resurrection works
- Walls no longer leave girders when blasted by the devil
- Getting a new body gives you a rudimentary amount of equipment to work
with to get out of maintenance or whereever
Does all the icons in a single commit on their own because icon
conflicts suck
Starting point of extra devil rebalance/fixes
Ports devil friends
Also oops tramples all over Fethas' corpse PR that's still up I need
to take care of that one
Styling fixes
