* Makes the datum
* Initial Commit
* Gets TGUI menu not crashing
* Autodoc
* quirk menu bugged
* oh.
* Working menu + buttons
* trait defintes pt 1/?
* Moves traits around
* ACTUALLY START ON THE QUIRKS THEMSELVES
* TGUI Bundle Rebuild
* TGUI properly saves now
* Removes allergies for scope reasons, make foreigner work properly
* TGUI tweaks
* Reworks TGUI Menu
* quirks store the mob, not mind
* Adds asthma and mute
* minor tweaks
* Cloning re-adds quirks
* Adds functionality to frail
* Adds crafty
* TGUI fix
* Fixes a frail bug
* Makes sure the list is in the correct format
* TGUI size change
* Makes skittish work
* Adds glutton, removes unused traits
* Changes description and adds function to glutton
* Freerunner functioning
* Crafty buff
* Clear quirk list when changing species
* Forgot to remove light step
* Delete
* Refactor item-giving
* TGUI Bundle Rebuild
* whoops
* Apply quirks when changing species
* Removes some unneeded defines/paths
* Replaces improved charging cord with a bad charger
* coment
* Guard clause
* Changes how quirks add and remove organs
* unused var
* adding organs works, removing them doesn't yet
* oh that fixed it
* Hopefully finally once and for all fix the json issues
* Buffs asthma
* switches the processor to ssobj since it's slower
* actually spawns the items whoops
* maybe actually fixes json issues I really hope this doesn't come up again?
* moves sql to the right directory
* CULPRIT FOUND, JSON ISSUES ACTUALLY SOLVED
* adds admin tooling for quirks
* Ups the cost of lungs
* Adds removal for the drinking ones
* Fixes some duplicate code
* Removing foreigner works
* wops
* bumps sql version to 65
* prettier
* semicolon
* Foreigners can understand galcomm but not speak it, as per headmin request
* Different solution was agreed upon
* CC announcements now get auto-translated
* Apply suggestions from code review
Lewc quick suggestions
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
* Move alcohol tolerance basetype
* accomodates for reset_styles
* Swap to species flags, and being dead is a universal process stopper
* adds a foreigner trait
* Xenos and the like can't understand CC's translated announcements
* TGUI Bundle Rebuild
* Lewc quick fixes
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
* i forgor
* i forgor pt 2
* process properly returns true
* TGUI Bundle Rebuild
* sql update for fixing merge conflicts
* bundle changes
* actual sql fix
* Not test tiny in prod
* sql fix?
* tgui update, first pass
* Adds schema changes to main quirk branch
* persistent data works now
* TGUI Bundle Rebuild
* Fixes conflict with job assignment datumization
* TGUI Bundle Rebuild
* Adds pacifism by request, -3 points
* gives skittish a small cd
* Makes the lunch randomizer I was thinking about doing
* GC returns a qdel hint now
* Removes hard refs
* SQL save fix
* Fixes admin tools
* Fixes wizards getting quirked up
* ragin too
* Lightweight is more lightweight
* Adds admin logging for when someone makes a languagesless character
* TGUI Bundle Rebuild
* Adds colorblind, hungry, and buffs asthma
* fixed vv post-merge conflict
* behold, my monster
* rebuild and merge master
* Adds more positive quirks, and makes monochrome give more points
* adds nearsighted, and no whispering
* sorry linter
* Adds the cool quirk, thanks to pumpkin312
* Oh dear that signal gets sent to everyone every time someone spawns in
* i forgot that slimes dont have eyes
* tgui fix
* bundle rebuild probably
* prettier
* prettier
* Skittish package fix
* force add bundle
* Makes plasmemes be unable to take foreigner
* Makes advanced lungs respect the owner's species
* makes breaking open wrapped crates/lockers a do_after_once
* Makes plasmeme/vox advanced lungs actually help
* You get glasses anyway whoops
* bundle rebuild
---------
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* ddsadsa
ddsadsa
* moderate again
* revert
* medical first steps
* more work
* lots more work done
* more progress
* finished up
* attack chain linter
* attack chain update
* attack chain work
* fixes + chemist update
* gives comments
* Refactor/deduplicate camera eye code
Camera Eyes previously had duplicated logic across several files. This
change uncooks the spaghetti. Additionally, half-baked support for TG's
multicam feature has been removed, as it was not functional or in use.
* lets ff now
* Camera Eye refactor fixes and finishing touches
This change completes a refactor of AI eyes, which were previously used
by xenobio consoles, syndicate and abductor camera consoles, shuttle
docking computers, holograms, and, of course, the AI. Duplicated logic
has been extracted to an abstract base mob, /mob/camera/eye, from which
new types for each of the above now derive.
Functionality is largely the same, with only a few minor cosmetic
differences (i.e. camera eyes are now appropriately named given their
type and user), as well as a quality-of-life enhancement for holograms,
slowing their movement speed to base run speed to prevent users from
accidentally zooming out of calls.
* Camera eye refactor: Fix AI acceleration toggle
The acceleration toggle was broken in the camera eye refactor, as
previously the boolean was stored on the AI rather than its eye. This
change fixes that.
* Camera eye refactor: Fix syndicate cam visibility
With the camera eye refactor, the syndicate advanced camera consoles
lost the ability to view maintenance tunnels and other areas without
active cameras, seeing static in their place instead (as all other
cameras do). This change reinstates the original behavior.
* Camera eye refactor: Convert spaces to tabs
* Camera eye refactor: Fix CRLF
* Apply suggestions from code review
General minor code quality improvements suggested by GDNgit
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
* Apply suggestions from code review
Rename parameter names to avoid src accesses, remove an ambiguous and
unused mob_define and holopad range variable from a previous WIP, change
the for loop in /mob/camera/eye/relaymove to a for-to loop, and change
the chat message warning, sent when an AI Eye is created on an AI that
already has one, to a stack trace
* Adds toggle to AI commands for fast holograms
* Refactor ripped Hologram Eye relaymove
Previously, the relaymove proc for hologram eyes was redundant and
nearly impossible to read. It has been separated out into a few
different named procs, and has had its use of `spawn` removed.
* Remove unnecessary src access
* Fix bug involving shuttle placement outlines
The camera eye refactor that this commit is a part of introduced a bug
that prevented shuttle placement outlines from showing up on first use
of the shuttle console. This change fixes that bug.
* Unrevert some changes from #26306 lost in merge
* Remove erroneous free xray vision on advanced cams
* Autodoc camera acceleration vars
* Remove redundant null var initialization per code review
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
* Changed variables to camel_case, autodocs, cleanup
Changed a number of camera eye-related variables to camel_case style,
added appropriate autodoc comments, as per code review. Also removed an
unused cameranet function, modified the call signature of a cameranet
function to be more semantic, and changed a qdel-on-initialize in camera
eyes to return INITIALIZE_HINT_QDEL instead.
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Remove stray qdel(src) per code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
---------
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* refactor: Movement cross/uncross implementation.
* wrong var name
* fix unit tests dropping PDAs into nowhere
* Add documentation.
* remove unused constants
* say which procs are off limits
* fix simpleanimal z change runtime
* helps not to leave merge conflicts
* kill me
* fix typecast
* fix projectile/table collision
* treadmills don't cause MC to crash anymore
* connect_loc is appropriate here
* fix windoors and teleporters
* fix bonfires and clarify docs
* fix proximity sensors
Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers
* lint
* fix: polarized access helper false positives
* Revert "fix: polarized access helper false positives"
This reverts commit 9814f98cf6.
* hopefully the right change for mindflayer steam
* Changes following cameras
* fix glass table collision
* appears to fix doorspam
* fix ore bags not picking up ore
* fix signatures of /Exited
* remove debug log
* remove duplicate signal registrar
* fix emptying bags into locations
* I don't trust these nested Move calls
* use connect_loc for upgraded resonator fields
* use moveToNullspace
* fix spiderweb crossing
* fix pass checking for windows from a tile off
* fix bluespace closet/transparency issues
* fix mechs not interacting with doors and probably other things
* fix debug
* fix telepete
* add some docs
* stop trying to shoehorn prox monitor into cards
* I should make sure things build
* kill override signal warning
* undef signal
* not many prox monitors survive going off like this
* small fixes to storage
* make moving wormholes respect signals
* use correct signals for pulse demon
* fix pulse heart too
* fix smoke signals
* may have fucked singulo projectile swerve
* fix singulo projectile arcing
* remove duplicate define
* just look at it
* hopefully last cleanups of incorrect signal usage
* fix squeaking
* may god have mercy on my soul
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* lewc review
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* burza review
* fix bad args for grenade assemblies
* Update code/__DEFINES/is_helpers.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
---------
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* refactor: Rename all non-snake_case types (not procs or vars (yet)).
* completely dynamic update script
* might help to include the data
* update aa's scuffed python
* oh
* set script PR number
* run updatepaths again
* Add other table updates with JSON columns
* bump SQL version
* just fucking end my life
* move JSON data
* We can't have nice code
* Trailing newline
* Also fixes double closing sound
* Move invalid ID check all the way up
* Early return makes this if statement unnecessary.
---------
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
* The start
* Getting a bit further
* Slight ammo casing update
* Istype helper and foam blockage
* Adds status effect
* Foam blockage and status effect fixes
* Autolathe ammo + stun
* aaaaaaaa
* Adds uplink item
* Actual slowdown
* Makes attacking a bit faster again
* Ammo increase to 12
* Sirryan review
* Adds sprites - almost working
* Lots of fixes + mineral doors
* Mineral doors don't open with foam
* Let lockers prevent ants
* Refactor ants check; exclude closed lockers and cardboard boxes from turf structure check
* Make the structure check more lenient, convert to typecache
* gnarg
* gnarg 2: Electric Boogaloo
* Minor simplification/optimization
* added dragndrop click methods for atoms
* some updating, little changing MouseDrop logic
* added INVOKE_ASYNC to delayed procs
* cleanup
* cleanup
* cleanup
* no cheesing
* more comments, removed variable from atom
* whoopsie
* added inventory screen objects support, disabling tooltips now disables all tooltips, not only items
* fixing table hitting self issue
* slowdown on pulling
* slowdown only when pulling structure or machinery
* moving speed modifier to /mob/living/carbon instead of all atoms
* added pull_speed to /atom/movable, moved movement_delay proc to carbon/human
* no-slowdown-trash-bin
* Update code/game/atoms_movable.dm
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
* removed pull_speed on /obj/item/storage/bag/trash, no need to set this
* more 0 pull_speed objects
* added gravity check, moved pull_speed to /obj
---------
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
* Add initial support for telegraphing item pickups
* Add interaction to lockers
* Undo some extraneous changes
* Make pickpocket gloves not show any animation on pickup
