* refactor: Movement cross/uncross implementation.
* wrong var name
* fix unit tests dropping PDAs into nowhere
* Add documentation.
* remove unused constants
* say which procs are off limits
* fix simpleanimal z change runtime
* helps not to leave merge conflicts
* kill me
* fix typecast
* fix projectile/table collision
* treadmills don't cause MC to crash anymore
* connect_loc is appropriate here
* fix windoors and teleporters
* fix bonfires and clarify docs
* fix proximity sensors
Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers
* lint
* fix: polarized access helper false positives
* Revert "fix: polarized access helper false positives"
This reverts commit 9814f98cf6.
* hopefully the right change for mindflayer steam
* Changes following cameras
* fix glass table collision
* appears to fix doorspam
* fix ore bags not picking up ore
* fix signatures of /Exited
* remove debug log
* remove duplicate signal registrar
* fix emptying bags into locations
* I don't trust these nested Move calls
* use connect_loc for upgraded resonator fields
* use moveToNullspace
* fix spiderweb crossing
* fix pass checking for windows from a tile off
* fix bluespace closet/transparency issues
* fix mechs not interacting with doors and probably other things
* fix debug
* fix telepete
* add some docs
* stop trying to shoehorn prox monitor into cards
* I should make sure things build
* kill override signal warning
* undef signal
* not many prox monitors survive going off like this
* small fixes to storage
* make moving wormholes respect signals
* use correct signals for pulse demon
* fix pulse heart too
* fix smoke signals
* may have fucked singulo projectile swerve
* fix singulo projectile arcing
* remove duplicate define
* just look at it
* hopefully last cleanups of incorrect signal usage
* fix squeaking
* may god have mercy on my soul
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* lewc review
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* burza review
* fix bad args for grenade assemblies
* Update code/__DEFINES/is_helpers.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
---------
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* makes magma-ale and space beer bottles instead of cans
replaced all occurences of the cans to the new type
* forgot to rever test_tiny
* path script + repathing
* space bar sleepy beer repath
* Update tools/UpdatePaths/Scripts/27407_ale_beer_repath.txt
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>
* Update code/game/objects/structures/crates_lockers/closets/secure/bar.dm
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>
---------
Signed-off-by: Toastical <vnndvp@gmail.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* refactor: Rename all non-snake_case types (not procs or vars (yet)).
* completely dynamic update script
* might help to include the data
* update aa's scuffed python
* oh
* set script PR number
* run updatepaths again
* Add other table updates with JSON columns
* bump SQL version
* just fucking end my life
* move JSON data
* Basic card interactions
* initial interactions sorted
* nails down some interactions, radial menu
* Some more qol and keybind changes
* improves card interactions
* Unum decks can be flipped, showing the top card
* Decks can now be split and recombined
* minor tweaks to multi-deck stuff
* Clean up a bunch of interactions
* more cleanups
* more cleanups and documentation
* remote attacking looks pretty good
* minor cleanups
* ci
* parser errs
* Remove some debug things, re-add signal after merge
* Adds a whole bunch more qol.
* Improves examine messages
* ci
* concealed cards will now show properly in radial
* Fixes some weird proximity monitor and control issues
* Address reviews, clean up examine a bit more
* radial fixes
* remove todos
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* better documentation, adds label of who did what
* b etter grammar
* augh
* missing icon state
* Update code/game/gamemodes/wizard/magic_tarot.dm
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Add sleep on proximity monitor setup to hopefully avoid mapload issues
* been writing too much c lately
* Try late initialize
* late init
* 🧌
* map load
---------
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Adds the Service rover cyborg
Adds a "Rover" style cyborg for the Service module.
* Update sprite
Adds the finished service rover sprite.
* No Hat
Adds service rover to the unhattable list
* Adds the medical rover module
Adds the medical rover module to the same branch, since they both rely on the same service panel logic.
* Update medical rover panels
* Deconflict
* Resprites the nukie cyborg
* whatever fuck you rust g
* god I hate rust g
* suffering
* I forgot to save auugh
* fixed
* please stop silently modifying surgeon
* woe more sprites apon thee
* wip
* some formatting and copying over UI
* it compiles now
* oops
* Moves WATT_TICK_TO_JOULE to the power defines file. fixes UI
* spelling and announcement fixes
* Handle offsets for different directions
* laser comes from the correct tile now
* Added north and south sprites for the laser
* Adjust offsets for north and south sprites
* finished all north and south sprites
* tgui rebuild. Also sprites and code begoon
* put PTLs in maps
* Repositions PTL room door in cyberiad
* fix if spacing
* undef and unundeffed define
* Removed overlapping stuff in some maps
* Actually makes the changes to metastation
* Fixes more mapping stuff
* Fix more unit test failures
* unmirror multitile component grid
* Fixes multitile
* explosions no longer make a hole in the beam
* This should fix it
* Stray pipe begone!
* Ok I think I fiigured it out
* removes redundant removals of components parts and a redundant check. various style fixes
* Adds blocking to the beam and objects other than living beings take damage now.
* not using kwargs now. should work.
* Style changes and fixes some mobs getting hit by the laser that shouldn't be.
* Review changes and fixes trying to access wall turf's location.
* allow the new wall turf to form to we can properly access it.
* Moves the ptl beam effect to an atom proc that is overriden by the different types of things that can end up in the beam.
* Fixes some comments, adds clarifications, removes redundant usage of src
* moves the announcement threshold to a global var. Fixes ghost interaction.
* Revert "moves the announcement threshold to a global var. Fixes ghost interaction."
This reverts commit 7916ee76a1.
* Makes announcement threshold a static variable of the PTL
* power safty check on the mob ptl function
* well alright then
* Revert "well alright then"
This reverts commit a8c0b68205.
* Fixes ghost attack
* Sends credits to accounts 200 at a time to avoid spam.
* fix box station stuff
* fix the first announcement message
* fix the laser healing burn damage.
* Only round the earnings being sent so we don't delete credits.
* Give the high and medium cut ratios defines
* Fix and adjust some comments
* Uses the correct variable for the beam effects and fixes things being thrown while deleted
* Actually fixes qdeleted thing being thrown around error
* Fix the examine text
* Prevents grills from blocking the beam.
* Remove get_back_turf
* Make a blocker a UID instead of a ref
* limits capacity to 2000GJ
* replaces knobs with a number input
* Adds cameras to the rooms and a disposals bypass for faragus
* disallows pipes from being damaged by the beam
* Gives the PTL directional variants for mapping
* Allows deconstruction and reconstruction of the PTL as well as rotating it
* Removes a redundant newline
* Removes all damaging effects of the beam and it's blocking abilities
* Finishes the job
* Remove the disposals bypass on faragus since the beam is truly visual now
* implements orbital beaming of megafauna near the base. Still need to fix the overlay
* Dusts lavaland mobs when they are killed by the laser and disabled loot drops when damaged by it.
* Add some minor hazards to the PTL
* Fix the hazards
* Improves PTL rooms
* Fix some misplaced pipes and cables
* connect the disconnected pipes and cables in faragus
* minor map fixes
* more fixes and integrating faragus room a bit more
* correct the flash reduction to apply when not looking directly at the laser
* reduces the distance coefficient on the rads pulse
* Delta changes that apparently weren't committed earlier
* I think faragus is finally fixed.
* more mapping improvements
* fix wrong cable on faragus apc terminal
* moves the HV cable for the laser so it follows the station's outline more closely
* fixes cables converging
* Routes the cable along the existing catwalks instead of additional ones in farragus
* adds missing cable in faragus
* rebuild tgui
* Faragus mapping changes
* Delta Changes
* Diagoras changes
* Meta changes
* Cyberiad changes and placing a catwalk near the PTL for power measurements
* Faragus review changes
* Rebuild TGUI
* Rebuild TGUI
* tgui rebuild
* Rebuild TGUI
* Rebuild TGUI
* Rebuild TGUI
* Changes the announcement sound from the one used for command comms announcement to the one used by most other announcement.
* Rebuild TGUI
* rebuild TGUI
* Move button contents to child
* Using the correct acronym for the power transmission laser in the interface name.
* Rebuild TGUI
* change the folder name as well
* TGUI rebuild
* Remove a redundant space from the first announcement message
* Adds a door to the PTL room on Diagoras
* Lowers the amount of money generated to less absurd amounts.
* another adjustment
* Fixes some walls in maints being in the space area
* fixes divide by 0 runtime
* prevents trying to read the icon of a null target
* Makes power line on diagoras less jank and fixes flashes on lasers pointing west
* Fixes the PTL being charged over it's capacity
* Makes the flash modifier angle based.
* adds an explanation of flashmod
* Adjusting curve so less powerful engines are better rewarded
* Changes the grid saturation to be based on input rather than output.
* Removes the PTL announcements and adds total energy sold to the UI
* Adds the amount of energy exported(in GJ) to the end of round score card
* Credit cap nerf
* Review changes
* missing space
* Revert "Merge branch 'master' into powerLaserPort"
This reverts commit fe4a08f08c, reversing
changes made to bef963c89d.
* Reapply "Merge branch 'master' into powerLaserPort"
This reverts commit c990d93bc4.
* Fixes all the wrong path issues from the merge
* actually resolve the merge conflicts that somehow got automerged
* Should be all the duplicates
* Rest of the duplicates I missed
* remove lonely pipe and cable in faragus
* some more uncaught duplicates
---------
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* added Russian Nians
* adds a new space ruin Voidhopper of Nexus aka freighter
* forgot a quotation mark
* Convert maps to TGM
new : _maps/map_files/RandomRuins/SpaceRuins/freighter.dmm
new : code/modules/unit_tests/atmos/test_ventcrawl.dmm
Automatically commited by: tools\mapmerge2\fixup.py
* fixed file format of the ruin
* renamed Russian Nians to Soviet Nians
* see above
* down with russian nians, long live soviet nians
* added a ruin paper per Warriorstar's request
* the name russiannian just will not be fully replaced
* forgetting commas and adding a new subtype of paper for the shipping manifest
* I think using quotation marks is causing me issues
* further removal of the term "russian" in preperation of a PR removing lots of referrals to russia
* added some new Poly voice lines
* accidentally commited the wrong PR...
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
* made the shipping manifest ticked
* worked on the perspective of some stairs
* made changes requested by warriorstar
* changed formatting of the sovietnian's loot
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
* forgot to add a new line
* i think this is causing the tests to fail perchance
* purging the term russian to be in line with a recent PR doing the same
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
* fixed sovietnian to snake_case
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
* i may forget snake case exists
* second time's the charm like a snake's two fangs
* added warriorstar's suggestions
* reverted a file that was accidentally converted
* fixed merge issues
* added an extra line
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
* Update code/modules/awaymissions/mission_code/ruins/nian_freighter.dm
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
* Update code/modules/awaymissions/mission_code/ruins/nian_freighter.dm
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
---------
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* Janitor Rover
Adds the janitorial version of the Rover cyborg skin.
* Typo Fix
Jani rover formatting fix
* No-Hat
Currently the code doesn't support different hat offsets for directionals.
* Pink-to-Purple
Changed to a purpler color to better match other janitorial items.
* Deconflict
* Deconflict Again
* Rover Cyborg
Adding a new cyborg skin, 'rover'.
* No-Hat
The hat won't fit on its head without changes to how hat wearing works.
* Rename to Rover-Engi
To make way for other department module names.
