Commit Graph

11095 Commits

Author SHA1 Message Date
Contrabang
0fbfa2ca0d Adds "Highlights" to the Orbit menu (#19168)
* adds highlights

* comment update

* misc support

* weird spacing begone

* requested changes
2022-10-03 19:02:04 -05:00
FloFluoro
6a876e1994 Standardize cleaning object behavior into "cleaning_act" proc (#19001)
* Standardizes cleaning item functionality into "cleaning_act" proc

* Culling commented-out code

* Damp rag now checks for humans before cleaning

* Change proc scoping, moved mop reagent check out of cleaning.dm

* Adds can_clean and post_clean procs to handle mopping, removes ismop parameter

* Adds can_clean() to cleaning objects/mobs

* cleaning_act() now carries message strings as params

* Refactored cleaning_act() for earlier returns and less redundancy

* cleaning_act now runs on the target atom, instead of the cleaning object

* Changed turf checks to overrides, rescoped clean_turf, lots of tidying

* Removed cleaner param from post_clean, since it'll always be src

* Code review tidying

* Tidying..........

* Removed clean_turf and put its functionality in turf/simulated/cleaning_act(), added new param to keep track of original targeted object

* Moved cleaning.dm from datums to code/game/objects

* Added early return, defined cleanspeed in seconds
2022-10-03 20:25:00 +01:00
Charlie
8e39fbc57c moves all living var definitions to living_defines (#19203) 2022-10-03 11:19:37 +01:00
FloFluoro
094ca894ef Having a facehugger on your face muffles your speech (#19145)
* Having a facehugger on your face muffles your speech

* Scoped to living

* Yes.
2022-10-02 22:13:36 -05:00
S34N
a66c4ab225 this has to be the stupidest mistake we all missed ever (#19247) 2022-10-02 14:24:01 +01:00
S34N
2c6fc27434 Fixes speaking dead parrots (#19193)
* fixes speaking dead birds

* Update code/modules/mob/living/simple_animal/parrot.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* hal

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2022-10-01 17:10:18 +02:00
AzuleUtama
e1873e7718 Inhand small mobs now detail if they're dead/asleep when examined (#19124)
* Inhand small mobs now detail if they're dead/asleep when examined

Fixes #19097

* Checks on examine instead
2022-10-01 00:42:44 -05:00
Charlie
5785c3638f Removes Shadowstep. replace it with 2 powers for each vampire type. (#18951)
* WIP

* shadow boxing

* garg + hemomancer

* dantalion and stuff

* oops

* some tweaks

* sprites, tweaks and TGUI

* ready for review

* review

* forgot some sean comments

* oops

* prevents people walking over shockwaves

* shadow boxing DPS down to 20

* oops

* affected review
2022-09-30 12:32:53 -05:00
FloFluoro
32db03c463 Held items no longer prevent Xenomorph disarm knockdown + stamina damage (#19142)
* Held items no longer prevent xenomorph disarm knockdown + stamina damage

* Stam damage is now handled by a var, no longer fixed to 30
2022-09-27 16:23:47 +01:00
Charlie
1d132cf569 fix (#19127) 2022-09-25 21:01:18 +01:00
GDN
d86b6a4665 Reworks alien facehugger incubation (#19084)
* Well it works, but I need to check something first...

* Adds new maffs that we can use from Vi3trice

* minor var mistake

* Addresses steels + ryans review

* Oops
2022-09-25 13:12:11 -05:00
Henri215
98f4520a43 bald expansion and added shave bodyflag (#19117) 2022-09-25 17:44:27 +01:00
Luc
96aab66dc6 Add cooldown for unintentional emotes (#19078)
* Add cooldown for unintentional emotes

* Oops, let's try that again.
- Adds a separate cooldown system for unintentional emotes.
- Unintentional emotes will fire audio at most once every 2 seconds.
- Emotes like deathgasp can override this out of necessity.
- Scream's is longer because...come on.

* The part that makes the rest of it actualy work
2022-09-25 17:31:26 +01:00
Vi3trice
7a3f2ed506 Port TG pointing to inventory thought bubble, and expand valid pointing targets (#19072)
* Well that actually works

* Update atoms_movable.dm

* Now you can point at things inside of things.
2022-09-25 17:29:51 +01:00
Adri
b32f499e72 Removes xenomorphs from xenobiology gold slimes (#19002) 2022-09-25 17:21:17 +01:00
Qwertytoforty
ebd492f3bb Blood drunk will now transform its weapon during melee (#19139) 2022-09-25 17:07:46 +01:00
FloFluoro
5b60ae5c1e IDs now take priority over PDAs in get_idcard (#19051) 2022-09-25 17:03:21 +01:00
S34N
924e8cc949 Renames non-cybernetic implants to bio-chips (#18937)
* CHIPS

* microchip implanter

* more chips to purge

* bio-chip

* catches more things

* tgui

* final merge changes

* Update code/game/machinery/cloning.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* oops

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-09-24 14:24:25 +01:00
AffectedArc07
34927f05ab Wryn removal v2 (#19112)
* Removes Wryn

* and the sprites

* Fixes

Co-authored-by: Fox McCloud <Fox-McCloud@users.noreply.github.com>
2022-09-24 12:53:34 +01:00
Henri215
c2aba93317 removed var digestion_ratio (#19114) 2022-09-21 21:50:06 +01:00
Henri215
5e4d0db18a Fix #17543 Genetics UI Block 32 Doesn't Properly Change Gender (#19120)
* fixed gender being stuck in plural at genetics

* Update code/modules/mob/living/carbon/human/appearance.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-21 15:14:06 +01:00
GDN
9cda5ed786 Buffs Alien Queens (#19106)
* Buffs alien queens

* reviews and bigger queen

* Scoping to humanoid
2022-09-20 13:15:44 +01:00
AffectedArc07
3975e3531d Fix some busted logic (#19105) 2022-09-19 13:00:37 +01:00
AffectedArc07
1d008754da [READY] Bot Refactor (#18930)
* [WIP] Bot Refactor

* No more spawns, sleeps, and working EDs

* Mules

* GC fixing

* h
2022-09-17 12:46:25 +01:00
FloFluoro
15a0edc588 Fixes facehuggers facehugging forever (#19067)
* Fixes facehuggers facehugging forever

* Removed unnecessary "as mob", readded blindness because clothing-induced blindness doesn't fully mimic the status effect
2022-09-16 22:45:52 -05:00
Luc
346a1b8142 Yet Another Surgery Refactor (#18325)
* Initial commit

Fixes up surgery.dm
Adds some tool behavior

* More basic changes

* Checkpointing: this is a little gross right now

* Add signal COMPONENT_CANCEL_ATTACK_CHAIN

* Cleans up surgery initiator

* Mostly gets surgery (and canceling it) working

* Add abstract proxy surgery steps

Also adds them to organ manipulation

* Clean up most existing surgeries

* Rework organ openness, adds define for aborting a beginstep

* surgery works again, also implements retry defines

* fix surgery computer

* add limb repair to synth implant removal

* retry implant checks

* Clean up abductor surgeries as well as some other things

* A lot
- Reworks organ manipulation to use a series of surgery steps instead
- Fixes some runtimes with open hands
- Lets mito zero out the germ level while treating necrosis
- Adds a debug surgery tool

* add debug surgery tool, note some TODOs for later

* Add conditional check for surgeries repeating

* update surgery retry logic to make it more of a bonus

* Lets abductors automatically retry any failed surgery steps

* Rework robotic surgery to use abstract/proxy steps

* Bunch of bugfixes and more!
- Limb reattachment works properly now, you can just slap a limb onto a person
- If the limb isn't robotic, it'll be useless until the surgery is finished with a hemostat, though it might be enough to get the patient out of the OR.

* Remove more now-implicit checks

* Slight reorganization

* more fixes across the board

* Remove unused variable

* Trying not to lose my mind here
- Does away with can_run() entirely
- Cleans up visible messages in code
- begin steps should now all have ..() afterwards
- slime bone surgery should be fixed now
- more docs

* Robotic  surgery is stoppable with a crowbar, all surgery can_start now checks parent

* Fix some broken robotic typepaths

* Typepath fixes, do away with some last TODOs

* Forgor

* Last cleanups before we go gold

* jk lol

* Make early surgery termination clearer

* More "last" cleanups

* Fixes tool flags, surgery initiation

- Fixes surgery not being startable by sharp objects
- Moves surgical tool flags to item traits

* Clean up surgery cancellation, especially for borgos

* I think this should GC better

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Status is now step number

* Add a 20% chance to find nothing during organ manipulation

* Improve documentation, make forced_surgery a normal arg

* Charlie's reviews

* Why are abductors like this

* Little more verification, ensuring limb augmentation and organ manip healing work properly

* Fix torso organ manip being unfinishable

* Fix cavity implants, open-hand/any item steps

* Make sharp objects not try to start an operation with help intent

* Comments, quick target fix

* Re-order list so advanced bruise pack is pulled first

* Make surgical gripper function like an open hand

* Make mito only use one unit per organ for now

* Check if user is on operable surface before trying to operate

* Reduce admin logging

* Fix some bugs that appeared during the testmerge
- you can no longer start robotic surgeries with a scalpel (lol)
- you can now cancel surgeries on the first step after I fixed some bugs that I introduced (woo hoo)
- Synthetic limb attachment is now combined into a single startable surgery step, though still retains the fun flavor of both

* Swats some more bugs
- (hopefully) fixes a huge source of runtimes where we tried to check if we could run surgeries before checking if the surgery used an organ
- In doing so, moves the logic for determining if a surgery can start to the mob-level
- Fixes robotic reattachment surgery not working

* multi-bug drifting???

- Fixes a bug where a branching surgery with an any tool option could possibly override a step with a matching tool
- Fixes some intermediate surgeries failing due to not having specified possible_locs

* A few more fixes
- Fixes any surgery tool steps again
- Fixes cavity surgery again

* Hopefully fixes getting stuck in robotic organ manip

* Remove extra parent call

* Steel review

* Steel review

* Fix spacing for possible locs

* Roundstart traits

* Advanced surgical traits and other hal fixes

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-16 18:48:43 +01:00
Luc
686cd5fd79 Fixes emotes being displayed as the wrong type (#19026)
* Fixes some emote types, fixing the voice analyzer by proxy

* Remove unused utility function
2022-09-16 17:52:17 +01:00
Qwertytoforty
e275183ddd Xenomorphs can now stun borgs for practical ammounts of time. (#19050)
* god damn it.

* was cycles not seconds
2022-09-16 17:51:34 +01:00
FloFluoro
3974a98073 Facehuggers no longer instastun, removes some RNG (#19025)
* Facehuggers no longer instastun

* Changed egglaying time to actual seconds

* Code review

* Autodoc, typos, etc.
2022-09-13 23:22:39 +01:00
Qwertytoforty
ae0efa00b5 Ports the shuttle console hijack from TG. Tweaks malf AI hijack. (#19018)
* *puts on sunglasses* "I'm in."

* whoops

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Caching, danger, range, xenomorphs can no longer hijack

* Update code/modules/shuttle/emergency.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/shuttle/emergency.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-13 23:22:19 +01:00
FloFluoro
b8885719f4 Xenomorphs can now die (#19046) 2022-09-13 22:53:06 +01:00
FloFluoro
4c2da8fc28 Fixes Xenomorphs being able to build resin structures in space (#19028)
* Fixes Xenomorphs being able to build resin structures on turfless tiles

* powerc my beloathed

* When the return is indented!
2022-09-13 22:42:10 +01:00
Contrabang
e88b25bb24 wooohoo! I can see demons! (#19020) 2022-09-12 22:31:59 +01:00
AffectedArc07
279ee1dc12 Fixes a ton of security issues (#19005) 2022-09-10 14:12:16 +01:00
FloFluoro
1d6e105f8a check_id now checks for ID in the PDA slot (#18992) 2022-09-08 12:21:30 +01:00
Contrabang
fc4a0ea4d6 wow diagnostic hud (#18974) 2022-09-07 15:28:18 +01:00
GDN
c7bb5763d7 Removes weakens on tripping over simplebots (#18965)
title says all
2022-09-07 13:39:45 +01:00
Qwertytoforty
b1be1b5a36 Ports TG berserker armor from TG to replace champion hardsuit. (#18854)
* NT does not recommend punching fauna to death

* need x2, don't want reflection

* Armor -> brute burn resist, speed removed

* phys not species

* light em up

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* a hex on you

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* spacing, bolding, only stamina

* Apply suggestions from code review

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-06 00:05:36 +01:00
Edan
58f0419399 Legion Rework (#18819)
* initial changes

* crusher trophy + other changes

* oops

* status effect change

* charlie review 1

* spacing

* sentience type

* Update code/modules/mining/equipment/kinetic_crusher.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/hostile/megafauna/legion.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-05 01:11:49 +01:00
Octus
1c7882cb11 Ports the TG Dish Drive. A quality of life machine for service. (#18855)
* ILOVEBARTENDING

* improvements

* oopsie daisy

* Apply suggestions from code review

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: ElorgRHG <71735193+ElorgRHG@users.noreply.github.com>

* Update cable.dm

* fixes cable runtimes

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* applies for code critique

* steelslayerreview

* Update code/game/machinery/constructable_frame.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: ElorgRHG <71735193+ElorgRHG@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-04 10:36:11 +01:00
S34N
021fd9a416 adds implants and hair gradients to serialisation (#18934)
removes organ DNA from serialisation
2022-09-03 21:14:44 +01:00
S34N
08f36a9521 Admin QoL: Deletes stickybans, tidies mob VV menu (#18943)
* 1

* 2

* removes these too
2022-09-02 23:51:00 +01:00
alex-gh
7e3dda4556 Rework disease outbreak event (#18654)
* Rework disease outbreak

* Better dchat message

* Mary had a little lamb

* no symptoms for carriers

* Review Fixes part 1

* Review Fixes part 2

* Review Fixes part 3

* Lowers mundane disease probability

* Mundane disease can only happen once

* Improved naming/dchat message

* subtypes!

* space

* fix diseases overwriting each other

* SPAAAAAACE

* dchat message fix

* no initial
2022-09-01 12:49:27 +01:00
FloFluoro
92f6d88b35 Adds cooldown to Xenomorph neurotoxin, changes stun to knockdown (#18919)
* Adds cooldown to Xenomorph neurotoxin, changes stun to knockdown

* Neurotoxin now works when implanted in humans

* Tidying

* More tidying

* More tidying
2022-08-31 13:19:03 +01:00
AffectedArc07
629c099db7 Refactors status displays (#18811)
* Refactors status displays

* biggest commit
2022-08-29 16:45:29 +01:00
Kugamo
247c7239da InteliCard AI Core Display Sprites (#18821)
* hi

* bye

* hi again

* Sirryan2002 suggestion

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* adds unit test

idk what Im doing really here, so I hope this code works 😔 👍

* correction 1

* correction 2

kill me

* correction 3

im dead

* correction 4

big pepega moment

* correction 5

* correction 6

yep

* FINALE :D :D :D

* AffectedArc07 suggested change

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-08-28 14:37:08 +01:00
Qwertytoforty
5fd21ea339 fixes bubblegum / vetus hitting twice during charge (#18837) 2022-08-27 13:05:55 +01:00
SteelSlayer
f991ad2c07 fix failed give message appearing on success (#18894) 2022-08-26 19:29:49 +01:00
SteelSlayer
44af9906b9 fix give alert staying around (#18887) 2022-08-25 18:24:40 +01:00
Ordosian
9cf1e7e5a6 Large Plasma Tank (#18840)
* Large Plasma Tank

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/plasmaman.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Ordosian <Ordosian@gmail.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-08-25 17:42:17 +01:00