PR fixes#28143
Adds a `stat` check lost in an earlier migration from
`GLOB.alive_mob_list` to `GLOB.ai_list`, to ensure dead AIs aren't added
to the list of announcers.
* Mechas no longer get their attack cooldowns taken up by clicking the floor, and phazons finally deal burn on the burn mode
* lewc cooldown timer review
* Fixes#28022: mecha/AI/hologram bugs from #25078
PR #25078 introduced a few bugs related to AI eyes, mechs, and
holograms. This change fixes those bugs. Now, entering a mech with an
active hologram eye will first release that eye before granting control
of the mech. Double clicking on a turf as an AI while in a mech will no
longer unstick the camera from the mech. When exiting a mech, the AI
will now properly refocus on its core instead of on the spot that it
first entered the mech. AI holograms no longer receive normal audio
near their holopads, receiving only holopad-relayed speech now instead.
AIs will no longer be able to activate a holopad while occupying a mech.
* Update code/_onclick/ai_onclick.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
---------
Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* one at a time let's go
* air alarm
* so many
* meh
* hell
* hell
* hmm
* Attack chain migration: /obj/machinery
* what the fuck?
* hell
* review fixes
* whoops
* fix build
* nuke fixes, more tests
* gland dispsenser and start of autolathe test
* var renames
* small fixes
* i tire of life
* more tests
* more tests
* more tests
* shrink map
* customize autolathe design disk load delay
* cell charger
* fire alarm frame installation test
* funny and burz reviews
* nuke fixes
* Slices have a base class /food/slice
* Refactor
* Small fix
* Adds default reagent for empy slices
* Looks good
* adds_list_reagents
* "Reverted snake_case_remap files to state from original commit
* I don't know how to resolve merge conflicts :)
---------
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
* Port /tg/ move manager, drift and jetpack components.
* don't add go through newtonian movement if not moved to a turf
* various cleans for blood drifts and mob speed
* fix slow meteors
* why on fuck's earth aren't speedbikes vehicles
* style lint
* also wtf
* okay i'm an idiot
* fix meaty ore speed and blood decal double stepping
* fix not unbuckling pulled object occupants
* don't bother dealing with immovable rods just yet
* exclude bubblegum and vetus from move manager for now
* fix issues related to null weightless blood icons
* reset blood icon state properly
* fuck it, we'll deal with mobs when basic mobs happen
* break infinite loop in decal splat
* Refactor/deduplicate camera eye code
Camera Eyes previously had duplicated logic across several files. This
change uncooks the spaghetti. Additionally, half-baked support for TG's
multicam feature has been removed, as it was not functional or in use.
* lets ff now
* Camera Eye refactor fixes and finishing touches
This change completes a refactor of AI eyes, which were previously used
by xenobio consoles, syndicate and abductor camera consoles, shuttle
docking computers, holograms, and, of course, the AI. Duplicated logic
has been extracted to an abstract base mob, /mob/camera/eye, from which
new types for each of the above now derive.
Functionality is largely the same, with only a few minor cosmetic
differences (i.e. camera eyes are now appropriately named given their
type and user), as well as a quality-of-life enhancement for holograms,
slowing their movement speed to base run speed to prevent users from
accidentally zooming out of calls.
* Camera eye refactor: Fix AI acceleration toggle
The acceleration toggle was broken in the camera eye refactor, as
previously the boolean was stored on the AI rather than its eye. This
change fixes that.
* Camera eye refactor: Fix syndicate cam visibility
With the camera eye refactor, the syndicate advanced camera consoles
lost the ability to view maintenance tunnels and other areas without
active cameras, seeing static in their place instead (as all other
cameras do). This change reinstates the original behavior.
* Camera eye refactor: Convert spaces to tabs
* Camera eye refactor: Fix CRLF
* Apply suggestions from code review
General minor code quality improvements suggested by GDNgit
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
* Apply suggestions from code review
Rename parameter names to avoid src accesses, remove an ambiguous and
unused mob_define and holopad range variable from a previous WIP, change
the for loop in /mob/camera/eye/relaymove to a for-to loop, and change
the chat message warning, sent when an AI Eye is created on an AI that
already has one, to a stack trace
* Adds toggle to AI commands for fast holograms
* Refactor ripped Hologram Eye relaymove
Previously, the relaymove proc for hologram eyes was redundant and
nearly impossible to read. It has been separated out into a few
different named procs, and has had its use of `spawn` removed.
* Remove unnecessary src access
* Fix bug involving shuttle placement outlines
The camera eye refactor that this commit is a part of introduced a bug
that prevented shuttle placement outlines from showing up on first use
of the shuttle console. This change fixes that bug.
* Unrevert some changes from #26306 lost in merge
* Remove erroneous free xray vision on advanced cams
* Autodoc camera acceleration vars
* Remove redundant null var initialization per code review
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
* Changed variables to camel_case, autodocs, cleanup
Changed a number of camera eye-related variables to camel_case style,
added appropriate autodoc comments, as per code review. Also removed an
unused cameranet function, modified the call signature of a cameranet
function to be more semantic, and changed a qdel-on-initialize in camera
eyes to return INITIALIZE_HINT_QDEL instead.
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Remove stray qdel(src) per code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
---------
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Refactor /mob/unEquip.
* fix things found in testing
* more fixes from testing
* fix removal of hooded suits
* fix flayers inability to deploy swarmprod
* fix changeling blade activation
* unnecessary parens
* pass default unequip args to proc overrides
* fix belts being able to forceMove into full hands
