Commit Graph

3257 Commits

Author SHA1 Message Date
warriorstar-orion
2a81f86af7 Adds a basic AI controller info panel to VV. (#29898) 2025-07-29 23:17:12 +00:00
Burzah
18573ef254 Tgui v6 (#29342)
* [TGUI v6 Project] Remove `context` (#29086)

* [TGUI v6 Project] Remove `context`

* I forgot I had to do that.

* [TGUI v6 Project] Move to React (#29090)

* It compiles

* Last Inferno uses

* all works now

* Fixes

* [TGUI v6] Changes files extensions for interfaces from .js to .jsx, Deprecates Inferno State Hooks (#29094)

* Initial Commit

* Apply suggestions from code review

trust me bro

Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com>
Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>

---------

Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com>

* [TGUI v6] Replaces babel with swc, fixes realtive paths on a few files, new build (#29100)

* Initial commit

* Build

* webpack config and errors and rebuild

* export routingError, hopefully

* fix pda app routing

* pass current tab index to tab headers and content in nanobank

---------

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>

* fix dna modifier bluescreen and library computer tabs (#29108)

* TGUI parity with TG

Need to fix a bunch of things...

* Implement TGUI payload chunking backend

https://github.com/tgstation/tgstation/pull/90295

* Filx chan bottom scroll. Again

* Fix TGchat focus

* Fix rounding

* Fix inputs

* Upgrade deps

* More fixes

* Fix chat lineHeight

* Fix NanoMap

* Update `tgui-core`

* fix autolathe

* fix airlock electronics

* fix intercom

* fix compost bin height

* Fix chat preferences

* Move to TSX without types :clueless:

* test tiny meet your new brother test tgui

* Fix RCD

* fix stackcraft

* fix up beakercontents

* Fix MODsuits

* fix seed extractor

* Merge branch 'tgui-v6' of github.com:ParadiseSS13/Paradise into tgui-v6

* fix holodeck

* fix cookbook pda app

* fix remaining useState args

* Fix DNAModifier

* Fix Sleeper

* Fix SupermatterMonitor

* Remove `vitest`

* Update dev-server

* Fix `IconStack`

* Correct margin

* bundles, please don't break

* prettier

* Revert "Remove `vitest`"

This reverts commit 0609006abb.

* Re-add tests

* Prettier

* fix maplint for test_tgui

* TGchat shine effect

* TGUI Rebuildo

* Fix broken tabs, search boxes, sortable tables, and others (#29450)

* Replace KitchenSink theme state with a React context

* Remove last usage of useLocalState

* Rebind unbound useState calls

* Build and update /tg/ui

* Reformat /tg/ui

* [ci skip]

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>

* Ports #29217 to tgui v6. Added tgui-setup to CI builds (#29787)

* Add tgui-setup to build scripts

* Fix CORS issue

* Build and update /tg/ui

Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>

* Add one missing word to comment

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix law manager

* Removes dangling references to `context` (#29793)

* Removes dangling references to `context`

* Build and update /tg/ui (#25)

Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix messenger and atmos scanner

* swap out line break in examinate

* fix powermonitor

* Bump tgui-core from 3.1.5/3.1.4 to 4.3.4 (#29799)

* Bump tgui-core

* Build and update /tg/ui (#28)

Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixes additional examine text

* oopsie

* Small tgui v6 fixes (#29801)

* Remove flow

* Miscellaneous fixes

* Miscellaneous fixes

* Moved properties placed on the wrong element

* Migrate removed CSS attributes in JSX

* Build and update /tg/ui (#27)

Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix carbon examine

* fix robot examine

* fix lint

* improve SMES appearance

* fix camera console name order

* more newline fixes

* fix boolean modal cancel not working

* fix random disabled access in RCD

* point tgui to correct passthrough verb names

* Fix missing 0 option for ERTs. (#29819)

* fix newlines in damage flavor

* Revert all changes related to newlines in DM

* fix the actual thing that was wrong with newlines

* fix ERT manager deny input

* [tgui-v6] Makes Agent Card UI more aesthethic, fixes input fields, fixes minimum age slider (#29832)

* agent card fixes and tweaks

* tgui bundle

* Reformat /tg/ui (#33) (#29838)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* restore camera console list appearance

* fixed pai ui paths (#29867)

* /tg/ui fixes no. 3 (#29868)

* Remove IconStack styles that conflict with styles added in tgstation/tgui-core#203

* Fix minesweeper icon

* DNA Modifier fixes

* Fix alignment of icons in PDA games menu

* Expand chem dispenser

* Fix pAI interfaces

* Build and update /tg/ui

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Toastical <20125180+Toastical@users.noreply.github.com>

* teleporter fix, bundle changes, test

* /tg/ui fixes no.4 (#29877)

* Fix translucent buttons

* Remove stories already present in tgui-core

* Make voting choices not transparent

* Build and update /tg/ui

* Fix size of set ringtone in PDA messenger

* Fix crew monitor highlight colors

* Fix ReagentsEditor search. Small style fixes

* tgui-say radio prefix has special color again

* Expand chameleon mask a little

* Fix search in chameleon mask

* Make list input modal slightly taller

* [ci skip]

* Build /tg/ui

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Aylong <alexanderkitsa@gmail.com>
Co-authored-by: Arthri <41360489+Arthri@users.noreply.github.com>
Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: /tg/ui Builder <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Nolan <funnyman3595@gmail.com>
Co-authored-by: Toastical <20125180+Toastical@users.noreply.github.com>
2025-07-27 23:23:20 +00:00
Charlie Nolan
b475431187 Saner FLW links. (#29852) 2025-07-26 06:16:20 +00:00
Bm0n
dc529f084f Allows MP3 files to be uploaded to the TGchat player - renames play internet sound (#28575)
* first commit

* review

* review again

* renames adds alert

* updates alert

---------

Co-authored-by: Bmon <no@email.com>
2025-07-06 21:45:32 +00:00
PollardTheDragon
9947777511 Updates Lightning Bolt Smite (#29662)
* Updates Lightning Bolt Smite

* Adds lightning bolt effect
2025-06-25 13:23:55 +00:00
ike709
01572c939c Rename BYOND 516 var conflicts (#29658) 2025-06-23 10:51:06 +00:00
Toastical
bc3f1759d9 Make atom picker properly release keys (#29584) 2025-06-18 20:37:54 +00:00
warriorstar-orion
64bf2b0fda Add R_VIEWLOGS permission. (#29613) 2025-06-14 21:05:16 +00:00
Contrabang
a683db0128 bang (#29567) 2025-06-11 18:05:54 +00:00
Toastical
fe7d3ca3f3 update staffsay log title (#29585) 2025-06-11 15:18:45 +00:00
AffectedArc07
11d527c819 READY - Rust HTTP Stuff (#28997)
* WIP AND BROKEN - Rust HTTP Stuff

* this mostly works

* TM ready???

* Build Rust library

* handle failed requests properly

* Build Rust library

* Build Rust library

* Remove TM stuff

---------

Co-authored-by: Chuga <98280110+chuga-git@users.noreply.github.com>
Co-authored-by: paradisess13[bot] <165046124+paradisess13[bot]@users.noreply.github.com>
2025-06-06 16:51:05 +00:00
Bm0n
4c2928a2bb Makes ban notes public (#28946)
* first commit

* Update code/modules/admin/topic.dm

Co-authored-by: Paul <90473506+pwbokie@users.noreply.github.com>
Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>

---------

Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Bmon <no@email.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Paul <90473506+pwbokie@users.noreply.github.com>
2025-06-04 12:51:55 +00:00
Contrabang
d0170a11c6 Adds buttons for admins/mentors to see amount of open adminhelp/mentorhelp tickets. (#29498)
* wham

* fix
2025-06-03 21:30:00 +00:00
warriorstar-orion
72a4ec7dc9 support running saved sdql scripts (#29480)
* support running saved sdql scripts

* Update code/modules/admin/verbs/SDQL2/SDQL_2.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2025-06-03 21:23:38 +00:00
warriorstar-orion
81873336c8 fix timezones for round log filenames (#29446)
* fix timezones for round log filenames

* add debug log
2025-05-26 18:58:17 +00:00
kyunkyunkyun
72bd68fa2d pls don't scare me (#29314) 2025-05-15 17:23:45 +00:00
Contrabang
43439da811 Adds Staff-say (#28813)
* staff say

* finally, staffsays

* oops

* deconflict

* yea

* bonk

* build
2025-05-13 17:00:15 +00:00
warriorstar-orion
58967ee12e elementize pet collars (#29209) 2025-05-07 22:31:17 +00:00
warriorstar-orion
29935d7db9 Datumize job assignment. (#28521)
* Datumize job assignment.

* fix arg

* correct argument type passing

* lewc review 1

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* microptimizations for iterations

* shit, not this one

* make logging more consistent

* copy over head/antag roll logic

* okay we're done with dumb boutique logging sinks

* this is the same proc

* this is the same proc

* fix build

* more logging and check command position availability

* tighten up some logic

* mostly tiny tweaks

* tweak logs

* add step type for latejoin

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-05-04 18:23:46 +00:00
warriorstar-orion
b5fa9dda9f add admin verb for log access by round ID (#29174)
* add admin verb for log access by round ID

* Update code/modules/admin/verbs/getlogs.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* add check_rights

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-05-04 05:34:44 +00:00
kyunkyunkyun
6f0f2b8024 Syndicate mobs rework (#28706)
* initial

* i'll get fired

* update icons for mapping as well

* update maps

* tweak

* tweak and revert a bit

* tabs

* speak english, motherfucker

* oh

* updatepaths
2025-04-26 17:58:24 +00:00
Toastical
2cac9b7e64 check if the ticker is ticker is running (#29105) 2025-04-26 14:26:52 +00:00
Toastical
56f46c9304 [s] Adds message length limits. (#29107)
* message limits

* different limits
2025-04-24 16:00:08 +00:00
warriorstar-orion
fa1faf6054 add 'get machines by type' to SSmachines (#28979) 2025-04-16 17:17:54 +00:00
warriorstar-orion
07a22cdb64 Enable multi-sector lavaland. (#28358)
* Enable multi-sector lavaland.

* fix exclude ci paths

* remove old lavaland

* Lewc review and other cleanups, add GPS stuff

* rebuild tgui

* fix ash storm no eligible areas

* update test config, don't skip out on test level creation

* unfuck example config

* whoops

* add north entrances to legion arena for easier traversal

* TM config -- REVERT BEFORE MERGE

* Make SSweather work on traits directly

* flip order of procgen/ruin placement

* fix GPS

* fix budget in code

* clobber prod config for lavaland ruin budget for TM

* add relay to gulag

* some more guards for procgen

* separate relays

* make gulag and base one ruin

* bridge improvements

* actually remove gulag map

* make linter happy

* harden ruin placement against failing

Config changes made. Bypassing code ownership.
2025-04-08 06:18:46 -07:00
warriorstar-orion
c820499f90 Basic mobs core implementation and cow migration. (#28667)
* Basic mobs core implementation and cow migration.

* fix whitespace

* uncomfortable fix for null weirdness

* update updatepaths script number

* lewc review 1

* fix delta

* Update code/datums/ai/basic_mobs/basic_ai_behaviors/tipped_reaction.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-04-05 11:35:42 +00:00
Contrabang
808553727c Adds public notes (#28373)
* Adds public notes

* oops sorry CI

* AA review

* head of staff requests

* darkmode + disclaimer
2025-03-30 19:00:46 +00:00
Contrabang
fde22d1c43 Adds more reasons to explosion logging (#28812)
* explos

* yeah good enough

* shorten that

* use ckey

* forgot this cause

* unfuck it
2025-03-28 18:49:57 +00:00
Mikhail Dzianishchyts
93319097a1 Mass screenshot verb (#28537)
* Mass screenshot verb

* Well, this is actually useless

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Mikhail Dzianishchyts <mikhail.dzianishchyts@gmail.com>

---------

Signed-off-by: Mikhail Dzianishchyts <mikhail.dzianishchyts@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-03-25 20:07:47 +00:00
chuga-git
6605985ef8 Refactors reagent shock reduction (#28385)
* makes reagent shock reduction only apply to mobs that can process them

* Update code/modules/mob/living/carbon/human/human_life.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: chuga-git <98280110+chuga-git@users.noreply.github.com>

---------

Signed-off-by: chuga-git <98280110+chuga-git@users.noreply.github.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2025-03-02 23:39:25 +00:00
PopeDaveThe3th
bd132853f6 boolet (#28445) 2025-03-01 03:31:15 +00:00
Silverplate
eb1d866fa7 Refactors SSTicker checks (#28469)
* SSTicker check update

* Wilk first pass
2025-03-01 03:29:36 +00:00
Bm0n
8bec408c29 Adds Play Internet Sound (#28183)
* death to the OGG

* lint

* adresses issues

* nukes shells

* sounds should still stop even if you muted someone

* Update code/modules/admin/verbs/playsound.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>

* deconflict

* as mentioned

* minortypomoment

* i prefer this wording

* updates catches and moves admin logging.fixes span

* fixes another weird edge case with muting admins

* 516 support

* linters?

* further idiot proofing

* typescript player update

* more typescript player updates

---------

Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com>
Co-authored-by: Bmon <no@email.com>
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2025-02-27 21:57:30 +00:00
chuga-git
55605ad8ae stops antag menu from runtiming when high value items are nullspaced (#28407) 2025-02-20 15:07:44 +00:00
BiancaWilkson
4fdc79ca90 Cyborg Inventory Refactor (#27788)
* Initial variable changes

* Add defines

* oh my god huds

* Removes update_items(), it seems useless but this might need reverting later

* the hud doesn't work but the inventory itself seems to

* Renames a var, gets inventory working properly

* Activation/Deactivation support, ore bag fixed

* Fixes CL and also this would have been a massive, hilarious bug

* Apply suggestions from code review

Dr and Lewc reviews

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>

* Update code/_onclick/hud/robot_hud.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>

* Fixes a comment

* Wait I forgot this worked like this for a reason

* Lewc Suggestions

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>

* Burza Suggestions

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>

---------

Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2025-02-12 21:55:11 +00:00
Bm0n
c11e1c969c Ports stop sounds verb from TG (#28072)
* sounds have been stopped

* update

* name and format update

---------

Co-authored-by: Bmon <no@email.com>
2025-02-12 21:38:48 +00:00
Contrabang
5d32c2f8d2 Improves runtime info during admin proc calls (#28279) 2025-02-08 18:44:17 +00:00
Contrabang
2d998b8317 Cult is now part of dynamic (#28236)
* Adds cult to dynamic

* declare result

* more dynamic stuff

* config

* comment

* tweaks

* numbers changes
2025-02-08 17:10:21 +00:00
Contrabang
f9f3b4aac6 Ports TG lazy-loading of map templates using turf reservations (#28101)
* kills off heaps

* turf reservations

* lazy loading map templates

* atmos + a comment

* port LISTASSERTLEN and rename a proc

* CI happy

* yes

* oops

* removes blocks air and adds comments
2025-02-07 10:15:08 +00:00
Contrabang
e3f73e178d Changes a lot of lighting colors, ranges, and powers (#28226)
* 8u hiubntgvby9 gb

* colors

* undo airlock

* bluer light

* spaghetti review
2025-02-04 19:30:09 +00:00
Charlie Nolan
fd04e5a332 No VV/proccall click runtime (#28243) 2025-02-04 17:02:58 +00:00
Charlie Nolan
529e55be05 Proc calls now use vv_get_value, which can get things you click on. (#28172) 2025-01-29 13:22:02 +00:00
Charlie Nolan
509e7955c1 Easier banning of DC'd players. (#28032)
* Easier banning of DC'd players.

* Make bans work on new players (still on start screen).

* More accurate messaging
2025-01-26 13:46:22 +00:00
Erikos
47cec936e9 Makes One-Click-Antag report who was made antag (#28058)
* create antag verbosity

* whoopsie
2025-01-25 19:38:59 +00:00
Charlie Nolan
02a591afa0 Add one-click for event roles. (#27855)
* Add one-click for event roles.

* Apply suggestions from code review

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>

* Review fix.

* Update code/modules/admin/verbs/one_click_antag.dm

Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>

* Update code/modules/admin/verbs/one_click_antag.dm

Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>

* Update code/modules/admin/verbs/one_click_antag.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>

---------

Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-01-21 15:33:07 +00:00
Contrabang
8954a8e401 "Dynamic" Gamemode using rulesets (#27600)
* yeah

* yeah

* lock tf in

* aaaa

* fix

* im going to have a fucking stroke i hate mindflayers

* dynamic is ready

* fucking hell

* yes

* warrior review

* blah blah

* updates based on #27811

* ok fix

* makes the menu usable during secret

* ok RANDOM BULLSHIT GO!

* Dynamic final changes

* fixes some missing budget
2025-01-19 19:39:55 +00:00
Drsmail
4d7e14fc1f [FIX] Fix for a runtime error in deathsquad.dm (#28012)
* Admins can change AI laws in Death Squad  spawn event

* Refactored some text

* Adds ERT coms to an ai and cyborgs

* Spelling

Thanks Christasmurf

Co-authored-by: Christasmurf <25437893+Christasmurf@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>

* high-importance style text on laws update

Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>

* Laws uppdate + sound

* Update sound to much much bette one, made by dj-34

* Removed old comment

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>

* Fix cyborg radio and refactor how ai gets his

* Fix cyborg radio and refactor how ai gets his

* Removed empty lines

* spelling

Co-authored-by: Mira <42539014+MiraHell@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>

---------

Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Christasmurf <25437893+Christasmurf@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Mira <42539014+MiraHell@users.noreply.github.com>
2025-01-18 17:54:59 +00:00
asciodev
93ed0f096d Refactors AI / camera eyes and slows holopad holograms to walk speed (#25078)
* Refactor/deduplicate camera eye code

Camera Eyes previously had duplicated logic across several files. This
change uncooks the spaghetti. Additionally, half-baked support for TG's
multicam feature has been removed, as it was not functional or in use.

* lets ff now

* Camera Eye refactor fixes and finishing touches

This change completes a refactor of AI eyes, which were previously used
by xenobio consoles, syndicate and abductor camera consoles, shuttle
docking computers, holograms, and, of course, the AI. Duplicated logic
has been extracted to an abstract base mob, /mob/camera/eye, from which
new types for each of the above now derive.

Functionality is largely the same, with only a few minor cosmetic
differences (i.e. camera eyes are now appropriately named given their
type and user), as well as a quality-of-life enhancement for holograms,
slowing their movement speed to base run speed to prevent users from
accidentally zooming out of calls.

* Camera eye refactor: Fix AI acceleration toggle

The acceleration toggle was broken in the camera eye refactor, as
previously the boolean was stored on the AI rather than its eye. This
change fixes that.

* Camera eye refactor: Fix syndicate cam visibility

With the camera eye refactor, the syndicate advanced camera consoles
lost the ability to view maintenance tunnels and other areas without
active cameras, seeing static in their place instead (as all other
cameras do). This change reinstates the original behavior.

* Camera eye refactor: Convert spaces to tabs

* Camera eye refactor: Fix CRLF

* Apply suggestions from code review

General minor code quality improvements suggested by GDNgit

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* Apply suggestions from code review

Rename parameter names to avoid src accesses, remove an ambiguous and
unused mob_define and holopad range variable from a previous WIP, change
the for loop in /mob/camera/eye/relaymove to a for-to loop, and change
the chat message warning, sent when an AI Eye is created on an AI that
already has one, to a stack trace

* Adds toggle to AI commands for fast holograms

* Refactor ripped Hologram Eye relaymove

Previously, the relaymove proc for hologram eyes was redundant and
nearly impossible to read. It has been separated out into a few
different named procs, and has had its use of `spawn` removed.

* Remove unnecessary src access

* Fix bug involving shuttle placement outlines

The camera eye refactor that this commit is a part of introduced a bug
that prevented shuttle placement outlines from showing up on first use
of the shuttle console. This change fixes that bug.

* Unrevert some changes from #26306 lost in merge

* Remove erroneous free xray vision on advanced cams

* Autodoc camera acceleration vars

* Remove redundant null var initialization per code review

Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>

* Changed variables to camel_case, autodocs, cleanup

Changed a number of camera eye-related variables to camel_case style,
added appropriate autodoc comments, as per code review. Also removed an
unused cameranet function, modified the call signature of a cameranet
function to be more semantic, and changed a qdel-on-initialize in camera
eyes to return INITIALIZE_HINT_QDEL instead.

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Remove stray qdel(src) per code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>

---------

Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2025-01-17 18:22:43 +00:00
Charlie Nolan
bb230c3624 Update SIT spawn prompt (#27968)
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
2025-01-13 22:41:39 +00:00
Contrabang
734ec10f98 Updates "Check New Players" verb (#27963)
* updates "Check New Players" verb

* bam
2025-01-13 21:15:53 +00:00