* port ADMIN_VERB and friends
* some renaming
* dumb
* one more rename
* never search and replace this codebase
* fix TM issues, more renaming
* add a static analysis to shore up user verbs
* fix double message on roundstart
* remove macro we're not using yet
* convert remaining playsounds verbs
* convert more verbs i missed somehow
* why is this a completely different signature than everything else
* fix ui_interact arg
* fix logging view and others
* buncha issues caught in TM
* fix mentor tickets ui
* fix bug report viewing
* moron
* Makes the datum
* Initial Commit
* Gets TGUI menu not crashing
* Autodoc
* quirk menu bugged
* oh.
* Working menu + buttons
* trait defintes pt 1/?
* Moves traits around
* ACTUALLY START ON THE QUIRKS THEMSELVES
* TGUI Bundle Rebuild
* TGUI properly saves now
* Removes allergies for scope reasons, make foreigner work properly
* TGUI tweaks
* Reworks TGUI Menu
* quirks store the mob, not mind
* Adds asthma and mute
* minor tweaks
* Cloning re-adds quirks
* Adds functionality to frail
* Adds crafty
* TGUI fix
* Fixes a frail bug
* Makes sure the list is in the correct format
* TGUI size change
* Makes skittish work
* Adds glutton, removes unused traits
* Changes description and adds function to glutton
* Freerunner functioning
* Crafty buff
* Clear quirk list when changing species
* Forgot to remove light step
* Delete
* Refactor item-giving
* TGUI Bundle Rebuild
* whoops
* Apply quirks when changing species
* Removes some unneeded defines/paths
* Replaces improved charging cord with a bad charger
* coment
* Guard clause
* Changes how quirks add and remove organs
* unused var
* adding organs works, removing them doesn't yet
* oh that fixed it
* Hopefully finally once and for all fix the json issues
* Buffs asthma
* switches the processor to ssobj since it's slower
* actually spawns the items whoops
* maybe actually fixes json issues I really hope this doesn't come up again?
* moves sql to the right directory
* CULPRIT FOUND, JSON ISSUES ACTUALLY SOLVED
* adds admin tooling for quirks
* Ups the cost of lungs
* Adds removal for the drinking ones
* Fixes some duplicate code
* Removing foreigner works
* wops
* bumps sql version to 65
* prettier
* semicolon
* Foreigners can understand galcomm but not speak it, as per headmin request
* Different solution was agreed upon
* CC announcements now get auto-translated
* Apply suggestions from code review
Lewc quick suggestions
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
* Move alcohol tolerance basetype
* accomodates for reset_styles
* Swap to species flags, and being dead is a universal process stopper
* adds a foreigner trait
* Xenos and the like can't understand CC's translated announcements
* TGUI Bundle Rebuild
* Lewc quick fixes
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
* i forgor
* i forgor pt 2
* process properly returns true
* TGUI Bundle Rebuild
* sql update for fixing merge conflicts
* bundle changes
* actual sql fix
* Not test tiny in prod
* sql fix?
* tgui update, first pass
* Adds schema changes to main quirk branch
* persistent data works now
* TGUI Bundle Rebuild
* Fixes conflict with job assignment datumization
* TGUI Bundle Rebuild
* Adds pacifism by request, -3 points
* gives skittish a small cd
* Makes the lunch randomizer I was thinking about doing
* GC returns a qdel hint now
* Removes hard refs
* SQL save fix
* Fixes admin tools
* Fixes wizards getting quirked up
* ragin too
* Lightweight is more lightweight
* Adds admin logging for when someone makes a languagesless character
* TGUI Bundle Rebuild
* Adds colorblind, hungry, and buffs asthma
* fixed vv post-merge conflict
* behold, my monster
* rebuild and merge master
* Adds more positive quirks, and makes monochrome give more points
* adds nearsighted, and no whispering
* sorry linter
* Adds the cool quirk, thanks to pumpkin312
* Oh dear that signal gets sent to everyone every time someone spawns in
* i forgot that slimes dont have eyes
* tgui fix
* bundle rebuild probably
* prettier
* prettier
* Skittish package fix
* force add bundle
* Makes plasmemes be unable to take foreigner
* Makes advanced lungs respect the owner's species
* makes breaking open wrapped crates/lockers a do_after_once
* Makes plasmeme/vox advanced lungs actually help
* You get glasses anyway whoops
* bundle rebuild
---------
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* Fixes-video-camera-exploit
* Fixes issue with basic mobs and xenos attacks
* Revert "Fixes issue with basic mobs and xenos attacks"
This reverts commit b84d3144ae.
* you will get a robotics bay and you will like it
* also nanopaste
* work
* and kill those whoops
* holy fuck how many times did I missclick
* stop fucking unticking shit please fuck
* colour coding
* fix floor
---------
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* Fix unmoving video cam feeds.
This change refactor the screen-setting logic in camera consoles to its
own method, and additionally calls that method whenever a video camera
is moved, if that video camera's feed is being watched by a camera
console.
* Reduce follow lag and add stabilization to vidcams
Extracts camera follow lag into a variable on video cameras called
`update_viewer_cooldown_rate` and reduces it from 3 to 2 seconds.
Additionally, adds another variable on video cameras called
`update_viewer_stabilization_rate`, which updates all tuned-in camera
consoles with the new position of the video camera a final time, so the
feed remains centered on the camera.
* Change video camera feed follow to use signals
* Fix unmoving camera console feeds
Makes camera consoles refresh their feeds every 2 seconds as long as
they have active watchers. This fixes camera bugs, ERT cameras, video
cameras (including the journalist's advanced video camera), and any
other mobile cameras on a console's camera network.
* Replace manual camera feed cooldown with process()
Co-authored-by: Charlie Nolan <funnyman3595@gmail.com>
* Update Camera Console autodoc to reflect process() implementation
---------
Co-authored-by: Charlie Nolan <funnyman3595@gmail.com>
* one at a time let's go
* air alarm
* so many
* meh
* hell
* hell
* hmm
* Attack chain migration: /obj/machinery
* what the fuck?
* hell
* review fixes
* whoops
* fix build
* nuke fixes, more tests
* gland dispsenser and start of autolathe test
* var renames
* small fixes
* i tire of life
* more tests
* more tests
* more tests
* shrink map
* customize autolathe design disk load delay
* cell charger
* fire alarm frame installation test
* funny and burz reviews
* nuke fixes
* Refactor/deduplicate camera eye code
Camera Eyes previously had duplicated logic across several files. This
change uncooks the spaghetti. Additionally, half-baked support for TG's
multicam feature has been removed, as it was not functional or in use.
* lets ff now
* Camera Eye refactor fixes and finishing touches
This change completes a refactor of AI eyes, which were previously used
by xenobio consoles, syndicate and abductor camera consoles, shuttle
docking computers, holograms, and, of course, the AI. Duplicated logic
has been extracted to an abstract base mob, /mob/camera/eye, from which
new types for each of the above now derive.
Functionality is largely the same, with only a few minor cosmetic
differences (i.e. camera eyes are now appropriately named given their
type and user), as well as a quality-of-life enhancement for holograms,
slowing their movement speed to base run speed to prevent users from
accidentally zooming out of calls.
* Camera eye refactor: Fix AI acceleration toggle
The acceleration toggle was broken in the camera eye refactor, as
previously the boolean was stored on the AI rather than its eye. This
change fixes that.
* Camera eye refactor: Fix syndicate cam visibility
With the camera eye refactor, the syndicate advanced camera consoles
lost the ability to view maintenance tunnels and other areas without
active cameras, seeing static in their place instead (as all other
cameras do). This change reinstates the original behavior.
* Camera eye refactor: Convert spaces to tabs
* Camera eye refactor: Fix CRLF
* Apply suggestions from code review
General minor code quality improvements suggested by GDNgit
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
* Apply suggestions from code review
Rename parameter names to avoid src accesses, remove an ambiguous and
unused mob_define and holopad range variable from a previous WIP, change
the for loop in /mob/camera/eye/relaymove to a for-to loop, and change
the chat message warning, sent when an AI Eye is created on an AI that
already has one, to a stack trace
* Adds toggle to AI commands for fast holograms
* Refactor ripped Hologram Eye relaymove
Previously, the relaymove proc for hologram eyes was redundant and
nearly impossible to read. It has been separated out into a few
different named procs, and has had its use of `spawn` removed.
* Remove unnecessary src access
* Fix bug involving shuttle placement outlines
The camera eye refactor that this commit is a part of introduced a bug
that prevented shuttle placement outlines from showing up on first use
of the shuttle console. This change fixes that bug.
* Unrevert some changes from #26306 lost in merge
* Remove erroneous free xray vision on advanced cams
* Autodoc camera acceleration vars
* Remove redundant null var initialization per code review
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
* Changed variables to camel_case, autodocs, cleanup
Changed a number of camera eye-related variables to camel_case style,
added appropriate autodoc comments, as per code review. Also removed an
unused cameranet function, modified the call signature of a cameranet
function to be more semantic, and changed a qdel-on-initialize in camera
eyes to return INITIALIZE_HINT_QDEL instead.
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Remove stray qdel(src) per code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
---------
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* idk what i am doing
* reverts config.toml
* restores test_tiny
* migrates the handlabeler to new attack_chain
* return signals + datum autodoc
* return defines to handlabeler.dm
* trailing newline
* handlabeler goes backpack if no label now
* moved the labeling stuff out of interact_with_atom
* guard clause
---------
Co-authored-by: Toastical <toastical@toaster.com>
Co-authored-by: Toastical <toast@toaster.com>
* Now light is shown on photography
* Also fixed grass disposition on photos
* Fixes icon ordering
* Simplified atom sorting pipeline for captured atoms
* Applied review suggestions
* Refactor /mob/unEquip.
* fix things found in testing
* more fixes from testing
* fix removal of hooded suits
* fix flayers inability to deploy swarmprod
* fix changeling blade activation
* unnecessary parens
* pass default unequip args to proc overrides
* fix belts being able to forceMove into full hands
* PT1 - Death to experimentor
* I cant fail CI this fast come on
* PT2 - DA -> SA
* CRLF to LF
* Strange icons in the SA now
* Lets give this a go
* AGH
* Dirt
* WORK
* Oops - cere was missing the RD locker
* Map fixes
* Adds delivery chute back
* Warrior review
* Also removes magnetics
---------
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* refactor: Rename all non-snake_case types (not procs or vars (yet)).
* completely dynamic update script
* might help to include the data
* update aa's scuffed python
* oh
* set script PR number
* run updatepaths again
* Add other table updates with JSON columns
* bump SQL version
* just fucking end my life
* move JSON data
* IT WORKS UP UNTIL THIS POINT
* Consolidates SLOT_FLAG and SLOT_HUD into one
* Remove cover_both_ears
* SLOT_HUD to ITEM_SLOT
* Remove clothing_trait changes for the time being
* Remove accidental copy-paste
* Re-add no-slip var
* More failure to copy-paste correctly
* Leftover flag
* Combine left and right slot flags where possible
* UNGOOF MY DEFINES, PHAND IS NOT A THING
* Minor spacing changes
* Some more fixes from merge
* Seperates ITEM SLOT AMOUNT into two defines
* ON SECOND THOUGHT LETS NOT DO THAT.
* Addresses Contra's review
* Thank you GREP
* Rename ITEM_SLOT_FEET to ITEM_SLOT_SHOES
* Added a comment to the bitmasks in clothing defines
* Rename ITEM_SLOT_TIE to ITEM_SLOT_ACCESSORY
* These are for a seperate PR.
* Magboot fixes
* Requested changes
* Re-add accidental removal
* Wrong flags
* Update code/__DEFINES/clothing_defines.dm
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Chap <erwin@lombok.demon.nl>
* Requested changes
* Merge fixes
* Fix double headset
* Fixes multiple accessories
---------
Signed-off-by: Chap <erwin@lombok.demon.nl>
Co-authored-by: Adrer <adrermail@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
