Commit Graph

11145 Commits

Author SHA1 Message Date
S34N
667dd5d4ac 515 Compatibility (#19636)
* 515 compat

* double spaces

* Callback documentation, aa review

* spacing

* NAMEOF_STATIC

* big beta
2022-11-08 23:08:40 +00:00
Farie82
118f5708da Ensures update_pipe_vision is called only when you switch pipenets. Fixes lag caused by ventcrawlers (#19620)
* Ensures update_pipe_vision is called only when you switch pipenets

* Comments baby
2022-11-06 12:25:55 +00:00
S34N
0f4157d31e Attempts to fix phantom bot path overlays (#19360)
* a

* more things

* two more cheeky spots
2022-11-06 10:26:29 +00:00
Vi3trice
2d4d65664a Split those out (#19280) 2022-11-05 13:46:44 +00:00
AffectedArc07
21109f3be2 Improved antag fishing busting (#19542) 2022-11-03 18:05:43 +00:00
PacifistDalek
250dc8a818 add description and new icons for components (#19535) 2022-11-03 18:02:35 +00:00
GDN
dfbe11e345 Alien BlackBox tracking (#19582)
* Alien BlackBox tracking

* AA's suggestion

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-11-03 17:57:24 +00:00
AzuleUtama
ac1517e8b3 Fixes human mobs still being able to vomit while dead (#19538)
* Jaunter no longer makes dead people vomit

* Vomit proc in carbon.dm now has a death check
2022-11-03 00:05:31 -05:00
Luc
c5bc28f41f Adds *crack, an audible emote that lets you crack your knuckles. (#19529)
* Adds knuckle cracking sfx

* Add cracks for IPCs too

* Matt code suggestions

* review 2

* Fix species limitations, add diona sfx
2022-11-02 23:00:46 -05:00
LynxSolstice
1f6f48e99a Removes gibbing animation (#19492)
* Removes gibbing animation

* small fix
2022-11-02 20:47:03 +01:00
warriorstar-orion
85f4503d33 Refactor announcements. (#19459)
* Refactor announcements.

* Actually make this a unit test

* Dumb

* Remove unnecessary 'as text'

* Reviews:

- Make CSS class a recognizable word
- Flip the defaults for logging

Also:

- Style fixes (default null in fields)
- Fix emergency/crew-transfer shuttle announcement titles
2022-11-02 20:31:37 +01:00
PacifistDalek
d5b261407e Adds Radial Menus to Cyborg Module and Sprite selection (#19234)
* 1

* expand radius

* added combat droid back, gotta test whether force_modules can let the ERT secborg in

* holy crap i think it might be ready

* Update code/modules/mob/living/silicon/robot/robot.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/silicon/robot/robot.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* change initialise to initialize, and update the sec/combat radial icon's name to be more self-explanatory

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-11-02 20:21:22 +01:00
Vi3trice
599221a602 doh (#19566) 2022-11-02 14:22:04 +00:00
Nathan Winters
25f7b57fc5 Small Medbot patient analysis and injection refactor (#19353)
* Gee medbot! How come your mom lets you have 26 extra parentheses?

* Check order consistency

* Avoid searching through viruses if already treated for them

* Simplify assessment logic for custom beakers

* Simplify assessment logic for viruses

* Fix medbots not considering all of patient's viruses

* Bool readability

* Fix medbots ignoring viruses if patient has no damage

* Fix medbots not considering loaded beaker when assessing treatment for viruses

* Fix inconsistent virus check between assessment and medication logic

* Check order consistency 2.0

* Fix medbots getting confused when patient has regular drug but no beaker drugs

* Refactor patient assessment

* Condense a loaded beaker volume check

* Extract virus assessment into separate proc
2022-10-31 18:08:11 -05:00
Vi3trice
05d93f665a [TM] Port TG Jump Point Search and SSpathfinder (#18984)
* move along move along

* Update bot.dm

* Diagonals are now more expensive

* Update path.dm

* Update parrot.dm

* Update path.dm

* Tweaks

* Fix cleanbot, add path safety

* Tweaked, added a safety, removed the previous one

* Update medbot.dm

* path.len isn't very safe as a whole, floorbots also had order of operations wrong

* Update medbot.dm

* clings not even once

* Back to the drawing board

* Update path.dm

* Make mules actually clear the drawn path.

* Make bots use step_towards unconditionally instead of flipping between step_to and Move

* Making extra sure the path is cleared. Somehow path was left over.

* Check for length as get_path_to is always true

* This and that
2022-10-30 15:54:51 +00:00
FloFluoro
9e78880036 Fixes punctuation on mob descriptions (#19533) 2022-10-30 15:52:00 +00:00
HMBGERDO
9f011740da Nerfs Cult Juggernaut. Removed reflection (#19461)
* Nerfs Cult Juggernaut. Removed reflection

* bringing back jugger armor without reflections

* comment and playstyle sting changed

* Update code/modules/mob/living/simple_animal/constructs.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2022-10-30 15:49:27 +00:00
ElorgRHG
4b0a2fc085 [GBP: No update] Golem hands fix, probably (#19490)
* Golem hands fix, probably

* I think this is how that works, maybe
2022-10-28 20:24:20 +02:00
Vi3trice
03ce2920e1 Defining Part 4 - Code cleanup toward defines (... and the rest) (#19388)
* I wasn't done

* nits
2022-10-28 19:28:23 +02:00
Henri215
47b3d08f04 Newscasters/camera monitors/displays tweaks (#19305)
* frames and autolathe

* final adjustment

* engine monitor

* circuit board selection and newscaster tweaks

* names adjustments

* entertainment frame icon adjustment

* moving to another PR

* forgot to move those

* added the other monitors circuit boards

* Update code/game/machinery/computer/camera.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* removed unnecessary flow

* display

* entertainment frame uses correct icon now

* merge conflcit part 2, do_build for newscasters

* moving var

* Sirryan suggestion and reverting piece of code removed by mistake

* Update code/game/machinery/computer/buildandrepair.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* added description

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* Sirryan suggestion and removed 1

* moved to on_deconstruction

* Removing unused arguments

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-10-28 19:00:03 +02:00
Qwertytoforty
2c5d9ffb43 Elite buffs / Highlander mode for arena (#19166)
* Elite buffs / Highlander mode for arena

* whoops forgot to push this

* Apply suggestions from code review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* removes unused list, proximity component

* range_edge_turfs

* comment

* Apply suggestions from code review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* ARENA_RADIUS

* Apply suggestions from code review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* last changes

* Update code/modules/mob/living/simple_animal/hostile/mining/elites/elite.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-10-24 21:47:43 +02:00
Charlie
16e845a81b Fixes parallax being visible in the "fog of war" (#19474)
* the most genius solution to a stupid problem

* help me

* perfect hatred
2022-10-23 15:48:09 +01:00
ElorgRHG
db0002fbc1 [GBP NO UPDATE] Hands don't overlay above jumpsuits on which the hands are covered (#19473)
* Hands layering tweaks

* I forgor about the ? 💀
2022-10-22 17:49:07 +01:00
matttheficus
373c9e3710 IPCs are Now Ignored by Slimes (#19400)
* zaaaaaaaaaaaaaaap

* oops, too much zap

* still too much zap

* damage boost

* faction change
2022-10-21 21:33:13 +02:00
Henri215
b56dc871a6 Fixes Tom description (#19409)
* Tom description fix

* Contrabang suggestion

* Apply suggestions from code review

Co-authored-by: Vi3trice <80771500+Vi3trice@users.noreply.github.com>

Co-authored-by: Vi3trice <80771500+Vi3trice@users.noreply.github.com>
2022-10-21 20:10:57 +02:00
warriorstar-orion
c254efbcdf Remove unused newscast ability from announcements. (#19442)
* Remove unused newscast ability from announcements.

* Switch from 0/1 to FALSE/TRUE in modified code.
2022-10-21 19:59:36 +02:00
ElorgRHG
12c4aa5590 Removes the need to make handholes for jumpsuit sprites (#19058)
* Handholes were kinda cringe

* A mildly overengineered solution

* Deconflict

* Lobby gloves fix
2022-10-21 12:35:04 +01:00
AffectedArc07
20faf722c3 Fix a cid warning (#19435) 2022-10-20 23:02:39 +01:00
GDN
72b64a72ce [GBP NO UPDATE][READY FOR TM] Simplemob GC improvement (#19225)
* Properly clears a simplemob references on GC

* We're going the whole mile here
2022-10-20 20:47:02 +01:00
Raven567
e26b0da026 Fix poly sprite (#19421)
Co-authored-by: Raven567 <johnnyberg11@gmail.com>
2022-10-20 20:34:37 +01:00
Vi3trice
7c1d8f9d1c Get it together (#19444) 2022-10-20 19:32:51 +01:00
Henri215
2681f84a69 Fixes #13967 AI crewmember hologram now works properly (#19389)
* AI hologram now gets id photo instead of null flaticon

* better this way

* *coughs

* updated comment
2022-10-17 22:50:07 +01:00
S34N
edeba92326 Smoke spells readability (#19387)
* read the smoke

* oops

* contra

* contra

* more tidying

* last one

* Update code/modules/projectiles/projectile/magic.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-10-15 18:05:55 +02:00
Farie82
a7179d97bf Makes wormhole projector portals spawn effects once every 0.5 seconds max (#19398)
* Refactor the parameters and starting the teleport

* Adds arguments and moves the default effect generation up to do_teleport

* Typo in arguments

* portals now only create sparks every 0.5 second when things pass through

* Comment fix
2022-10-15 11:40:32 +01:00
Contrabang
34309c24b8 Fixes mulebots not being screwable (#19348)
* fixxy fixxy

* farie review

* s34n review
2022-10-15 09:25:02 +02:00
SteelSlayer
79f9761a63 fix alerts not appearing (#19385) 2022-10-15 00:21:43 +01:00
PopeDaveThe3th
597a5a1801 Removes ability for facehuggers to target corgis (#19354) 2022-10-13 22:03:09 +02:00
Vi3trice
59dfdba201 Everything else through the door (#19358) 2022-10-13 21:56:58 +02:00
Charlie
bc79020037 fixes hallucination shocks (#19361) 2022-10-12 11:09:55 -05:00
DevanStrife
207562c1cb Legcuffs and beartraps show up on examine (#19298)
* Update README.md

* Workin now

* Github being a b again...

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-10-10 23:49:19 -05:00
DevanStrife
197db5df9f Fixes invisible in-hand pai sprite if the pai is resting (#19296)
* Update README.md

* Works as intended now

* did an oopsie somehow
2022-10-10 23:40:01 -05:00
warriorstar-orion
71cf58d8a5 Only give bots HUDs when player-controlled. (#19198)
* Only give bots HUDs when player-controlled.

* Clean up data_hud regardless of whether or not a player is present.

* No need to keep around this ref.
2022-10-10 15:20:55 -05:00
Vi3trice
20c437f7d2 linters do your magic (#19263) 2022-10-10 20:58:41 +02:00
ElorgRHG
e843567671 Clothing (jumpsuit) DMI split, unused jumpsuit sprite purge along the way (#19092)
* Medical and RnD DMI files split

* Cargo DMI split

* Security DMI split

* Engineering DMI split

* Captain DMI split

* Civilian/service DMI split

This one hurt

* Forgot about this one

* Color DMI split

* Purges everything that was delted up until this point

... with a blindfold and a shotgun

* Dress and suit DMI split

* Pants and shorts DMI split

and merges pants and shorts files... shorts are pants, right?

* Donator/fluff jumpsuit clothing organisational relocation

* e

oops

* So this is used, repath bad

* Random commit

* Costumes DMI split and jumpsuits purge

* Some fixes

* pennywise

* Centcom DMI split

* SolGov DMI split

* Retro DMI split

* Syndicate DMI split

* Misc DMI split

* centcom officer

* Kills off uniform.dmi completely

* last fixes

* lastest fixes

* vox navy gold conflict

* civilian barber

* Tourist observers work now

* Hopefully working non-human humanoid clothing

* This being in suit.dmi is one of the reasons I made this PR

* This shouldn't be here

* Late night coding

* Pun Pun regains his drip

* Last fixes

* security/OFFICER

* Most important - clown fix

* working subtypes good

* Fixes chameleon jumpsuit

* Proper QM pathes

* Fixes jumpsuit rolling with the power of poor quality code

* Cargo tech character setup fix

* else instead

why didn't I do this in the first place

* PURP

* Fixes broken character setup job clothing

* CC suit fix

* Psychedelic jumpsuit proper path

* You must wear the jumpsuit to adjust it
2022-10-09 14:24:10 +01:00
FloFluoro
c7db0bb208 Terror Prince attack now (also) does stamina damage (#19284) 2022-10-08 10:55:58 +01:00
Vi3trice
a9baf739f5 Diona nymphs eject from dionas if a species change occur (#19283)
* Give the little fellas a break

* Hopefully non-dionas do not get nymphs

* Update code/modules/mob/living/carbon/human/species/diona.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-10-06 22:23:56 -05:00
Contrabang
8418997ed8 Moves most screwdriver checks to screwdriver_act (#19024)
* screwdriver_act my beloved

* convert to returns instead of . / lewcc review

* it will be done

* i'm a little bit stupid, but now time to test

* sometimes I get excited and press the commit

* The great test has been completed

* oh wow oh wow, lewc review

* found one last one

* Steel review

* Lewc review

* quick sirryan review

* removes stupid comments (old coders I blame)

* sirryan review two

* whoops...

* hal review

* the fix to the fix to the fix

* Revert "the fix to the fix to the fix"

FUCK I pushed to the wrong branch
This reverts commit a96fe98781.
2022-10-06 09:30:33 +01:00
GDN
ec9142c238 Species now have their innate actions GC (#19212) 2022-10-05 22:29:31 -05:00
Qwertytoforty
02a66d2cd9 ancient goliaths now have their own trophy like other shiny lavaland mob. (#19222)
* ancient goliaths now have their own trophy like other shiny lavaland mobs

* Update code/modules/mining/equipment/kinetic_crusher.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-10-05 11:01:54 -05:00
Henri215
aba36033d8 AI cryo now respects too early to ghost (#19215) 2022-10-04 22:23:56 -05:00