Commit Graph

26858 Commits

Author SHA1 Message Date
Luc
9efffccd71 Adds CI checks forbidding certain kinds of world loops (#24454)
* Updates checkgrep to report unnecessary loops

* improved message

* global lists are better too

* much better

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* update to modern check_grep format

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-20 20:17:45 +00:00
Charlie Nolan
d1c77ea8fb Re-added the account info paper on creating a new account. (#24588)
* Re-added the account info paper on creating a new account.

* Review suggestions.
2024-03-20 20:16:52 +00:00
Contrabang
cb7b71a03d blamo (#24582) 2024-03-20 20:13:29 +00:00
CRUNCH
d4f7a2654a Proto Emitter Gun now has its own name and description (#24528)
* Update laser.dm

* Update code/modules/projectiles/guns/energy/laser.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/projectiles/guns/energy/laser.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-20 20:12:35 +00:00
Luc
2acd27f962 Optable fixes (#24101) 2024-03-20 20:11:10 +00:00
Qwertytoforty
0d27af414c Adds the Organ Extractor (#24100)
* Adds the Syndicate Organ Extractor

* ipc moment

* fix bug, prevents putting organs in dead bodies to extract

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* renames sprite

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* replace xx yy

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-20 20:10:53 +00:00
McRamon
d02d54bfd4 Security poncho (#24614)
* all at once

* no

* ah yes

* minor pixel adjustments

* moved

* Update code/modules/clothing/suits/armor_suits.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-20 19:55:59 +00:00
Qwertytoforty
588cec7193 fixes syndicate sensory being emp weak (#24625)
* fixes syndicate sensory being emp weak

* Update code/modules/surgery/organs/augments_internal.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* fixes it

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-20 19:55:49 +00:00
DGamerL
76142af004 [s] Fixes Mechs being able to walk through walls (#24695)
* Adds the ismecha check

* I am a dummy, thanks contra
2024-03-19 20:41:56 +00:00
Henri215
ec90b441ad Moves weapons sprites out of items.dmi (#24634)
* Moves weapons sprites out of items.dmi

* lets revert this

* oversight from energy melee PR
2024-03-19 17:08:35 +00:00
Pierre-Louis
979b3c52cf Collar on a chick stay when it grow into a chicken. (#24524)
* Collar on a chick stay when it grow into a chicken.

Collar on a chick stay when it grow into a chicken.
Fixes #24412

* Update code/modules/mob/living/simple_animal/friendly/farm_animals.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Pierre-Louis <hernandezpierrelouis@protonmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-19 17:08:09 +00:00
Charlie Nolan
d14970a350 More bitflag cleanup (#24531)
* Convert a few more bitflags that weren't bit-shifting.

* Update a few comments around bitflags.

* Add some parentheses around bitflag combination defines.

* Fix some whitespace consistency issues, mostly with bitflags.
2024-03-19 12:16:23 +00:00
Charlie Nolan
53e53b65d1 Admin controls now update the shuttle timer in units of minutes, not seconds. (#24356)
* Admins now update the shuttle timer in minutes, not seconds.

(As in the units, not how long it takes.)

* Apply suggestions from code review

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-19 10:58:56 +00:00
Charlie Nolan
7efa31aefd Refactored how monkeys name their brains. (#24678) 2024-03-19 10:49:47 +00:00
Mikhail Dzianishchyts
02ef03a24f Fix flying bayonet/seclight overlay (#24676)
* Fix flying bayonet overlay

* Make it simpler
2024-03-19 10:46:01 +00:00
Mikhail Dzianishchyts
2ed43610d4 Fix falling into chasm on map load (#24673) 2024-03-19 10:45:33 +00:00
Charlie Nolan
6c8b9b1dfb Parrots no longer hold items they don't have. (#24682)
* Parrots no longer hold items they don't have.

* Whoops.
2024-03-19 10:44:29 +00:00
Aylong
ffd3927ad0 It just work's. Probably. (#24515)
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-18 18:46:31 +00:00
Charlie Nolan
ba2720a231 Fixed clown and mime brain/head naming. (#24668) 2024-03-18 18:44:25 +00:00
Charlie Nolan
4dcc43fc88 Made eating Keeki a bit smarter. (#24373)
* Made eating Keeki a bit smarter.

* Prions -> Teslium, minor fixes.

* Better comment for total_final_bites.

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/friendly/cat.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-18 18:34:58 +00:00
Deniz
576cbdcf25 Cargo "View Contents" Fix (#24562)
* contains_special

* contains special list additions

* keep on testing

* moar

* test test

* get manifest

* make sure

* indentation mistake
2024-03-18 18:32:33 +00:00
Mikhail Dzianishchyts
435fbb6a58 Make gravity generator power-dependent again (#24601) 2024-03-18 18:31:31 +00:00
BiancaWilkson
c6c88118a7 adds extra check (#24648) 2024-03-18 18:30:39 +00:00
Charlie Nolan
a5aa7d923b Retaliate mobs no longer break stuff after revived with a laz injector. (#24665) 2024-03-18 18:25:35 +00:00
Charlie Nolan
13f0d607d6 Make pAIs show correctly in diagnostic HUDs (#24666) 2024-03-18 18:25:12 +00:00
Charlie Nolan
153284efae Fix mime/clown picked names not being on their bank account. (#24669) 2024-03-18 18:23:36 +00:00
Mikhail Dzianishchyts
e92e3a84cf Update gun icon on knife removing (#24674) 2024-03-18 18:22:56 +00:00
Qwertytoforty
c8dde43856 fixes admin shuttles breaking the escape shuttle / not working (#24677) 2024-03-18 18:13:44 +00:00
Contrabang
664b04a1cb goodbye exclaims (#24593) 2024-03-18 18:04:14 +00:00
Charlie Nolan
fa9246ec60 Capitalized Comfrey. (#24642) 2024-03-18 17:55:38 +00:00
Adrer
dabcd51fd2 Makes headslug mob_size MOB_SIZE_SMALL (#24623)
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
2024-03-18 17:54:50 +00:00
Marm
fdef20cc9e Adds Meson Sunglasses (#24619)
* meson sunglasses

* species sprites ew

* why

* Update code/modules/clothing/glasses/glasses.dm

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>

* eeh

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Self commit time (With approval)

---------

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-18 17:54:24 +00:00
LtDiggs
6f632040aa Adjusts Species Lung Temperature Tolerances (#24509)
* Adjusts Species Temperature Tolerances

* Update code/modules/surgery/organs/organ_datums/lung_datum.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Adjusts Unathi and Ashwalker to match #23325

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-18 17:53:04 +00:00
Contrabang
df29a55f54 niche case (#24595) 2024-03-18 17:52:22 +00:00
cybercapitalism
f31961a97d Modsuit activation/deactivation is no longer cancelled by user incapacitation (#24564)
* changes activation do_afters to not check for incapacitation

* fix spacing
2024-03-18 17:51:28 +00:00
CRUNCH
926dff2cf1 Cyborgs drop their upgrades on the floor when reset or deconstructed (#24467)
* Fixing some minor typos for cyborg upgrade flavour text

Throws in some missing apostrophes, capitalisation, and the letter "s."

* Briefcase Full of Cash buff

Increases the amount of cash in the Syndicate Briefcase Full of Cash from 600 Cr to 1000 Cr

* Reverts double-feature PR

* Reverts a broken revert

* Reverting again because Ebba told me to

* And reverting yet again

* yes

* Update robot_mob.dm

* Update robot_mob.dm

* Update code/modules/mob/living/silicon/robot/robot_mob.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-18 17:44:27 +00:00
cybercapitalism
cb7cf57c85 oops (#24658) 2024-03-17 19:24:07 +00:00
Contrabang
9b24572ed5 Updates OpenDream pragma file (#24516)
* hell yeah-coded

* welp im too tired to fix this one

* lets test this

* Revert "lets test this"

* okay, lets test!

* fixes

* okay we good?

* i might be stupid
2024-03-17 11:56:56 +00:00
Contrabang
2ec55dbfbb Datumizes Cult. (#24379)
* cult 1

* massive data refactor

* progress

* More crap

* IM SCARED IT COMPILES

* oops

* more fixes

* good comment

* hell yeah, team control

* lol

* blamo

* blam

* More stuff

* team refactor

* epic merge fail

* src not _src_

* more

* progress

* cult

* more stuff

* water

* goodbye __IMPLIED_TYPE__

* time to undraft

* FUCK FUCK FUCK

* okay this is better

* goodbye todos

* fix

* order of operations

* last fix? maybe

* yeah

* oops

* okay this should be ALL the fixes

* wow

* hell yeah

* wow

* fixes duplicate teams + adds more team safeties

* how the fuck did this happen

* admin objective improvements

* wah more bullshit

* guh

* fuuuuck

* fucking hell

* fixes
2024-03-16 20:36:55 +00:00
JimKil3
0c25bf4a21 Cloning Rework (#21683)
* guts the cloning pod

* guts cloning console (except the tgui)

* clonescanner, more gutting, linkage

* reagent stuff

* `cloning_data` datum

* scanner inserting/removing

* scanning logic

* auto-linkage

* `get_cloning_cost()` in its entirety

* logic for which limbs to grow

* RefreshParts() and insert_organ()

* removes misinformation

* robot parts

* more organ insertion logic

* more organ code :D

* create_clone

* beginnings of clone logic

* cloning addl. stuff

* cloning finalization

* fixes CI?

* whitespace fixes (regex edition)

* ejection logic

* Update code/game/machinery/clonepod.dm

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>

* stuff

* stuff 2

* update_icon_state stuff

* clonepod TGUI

* organ fix yipee

* cloning console UI beginnings

* cloning console main menu

* reagents stuff

* beginning of damage tab

* damages menu skeleton

* aiuhgugh

* splits up code

* ejecting patient updates ui

* contra reviews

* temp fix for CI

* tgui finished? (clueless)

* Cloning :D
it's done

* manual & tweaks

* more feedback!

* cooldown
because you can spam the fuck out if it otherwise and it's really loud for the ghost

* oops

* tweaks

* edits EVERY MAP OH GOD

* no link stuff

* oops

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Apply suggestions from code review (pt. 2)

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/cloning.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* dgamer review

* Update code/game/machinery/clonepod.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* henri stuff

* makes it compile

* builds tgui (oops)

* rebuilt bundle i guess?

* not stale i swear

* fixes

* whoops

* countdown stuff

* sirryan review pt. 1

* sirryan review pt 2

* every day i'm shuffling (or something idk)

* wasdfhdfg

* sean clonepod.dm changes

* update_icon(UPDATE_ICON_STATE)

* Update code/game/machinery/clonescanner.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* icon stuff

* map weirdness

* henri disks

* unfucks maps?

* cc maps

* eject button

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/game/machinery/clonepod.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* dgamer review 2

* ourgh

* dgamer review 3

* waaaah

* fixes access locks

* fixes
Fixes the numbers issues (and no feet hopefully?)

* re-adds feet

* more fixes yipee

* un-biomass

* fixes ghost stuff

* exploit fix

---------

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-16 16:51:13 +00:00
warriorstar-orion
08f9a8129b use directional helpers for ATMs (#24426)
* use directional helpers for ATMs

* updatepaths script PR number

---------

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-16 16:25:30 +00:00
DGamerL
1799458add Overrides the proc (#24635) 2024-03-16 16:15:43 +00:00
Adrer
426ee61c60 Plasma cutter no longer requires a permit (#24622)
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
2024-03-16 16:15:03 +00:00
Luc
a65809e32f Adds an action button for succumbing, broadcasts last words (#24501)
* succumb

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* capitalize

* clear the alert, and no more last words when you're already dead!

* Update code/modules/mob/living/death.dm

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-16 16:13:30 +00:00
Aylong
dcb0167ce8 BSA UI size fix & TGUI input list (#24500)
* BSA UI fix & TGUI input list

* Rebuild
2024-03-16 16:12:45 +00:00
GDN
4cf311cbf2 Reworks last resort. Reverts #23992 (#24389)
* Reworks last resort. Reverts #23992

* forgot to push these

* projectiles no longer pass over headslugs
2024-03-16 16:12:09 +00:00
CRUNCH
9c338a3dc3 Edits the descriptions of the MMI and SMMI, adds extended description to both (#24343)
* DEEP LORE!

Edits the descriptions of the MMI and SMMI and gives them extended descriptions.

* Spiderbots exist

I forgot about them but they do be real

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>

* Update code/modules/mob/living/brain/MMI.dm

---------

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
2024-03-16 16:10:51 +00:00
Charlie Nolan
521abceae8 Made effect teleporting into a trait. (#24640) 2024-03-16 04:40:27 +00:00
JimKil3
aa740508e2 Fixes assistants spawning with fake wizard gear (#24631)
* yea

* spacing
2024-03-15 20:18:04 +00:00
Charlie Nolan
11b808cc0d Removed an unused bit of UI data from the supply console. (#24630) 2024-03-15 19:42:24 +00:00