Commit Graph

11113 Commits

Author SHA1 Message Date
S34N
edeba92326 Smoke spells readability (#19387)
* read the smoke

* oops

* contra

* contra

* more tidying

* last one

* Update code/modules/projectiles/projectile/magic.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-10-15 18:05:55 +02:00
Farie82
a7179d97bf Makes wormhole projector portals spawn effects once every 0.5 seconds max (#19398)
* Refactor the parameters and starting the teleport

* Adds arguments and moves the default effect generation up to do_teleport

* Typo in arguments

* portals now only create sparks every 0.5 second when things pass through

* Comment fix
2022-10-15 11:40:32 +01:00
Contrabang
34309c24b8 Fixes mulebots not being screwable (#19348)
* fixxy fixxy

* farie review

* s34n review
2022-10-15 09:25:02 +02:00
SteelSlayer
79f9761a63 fix alerts not appearing (#19385) 2022-10-15 00:21:43 +01:00
PopeDaveThe3th
597a5a1801 Removes ability for facehuggers to target corgis (#19354) 2022-10-13 22:03:09 +02:00
Vi3trice
59dfdba201 Everything else through the door (#19358) 2022-10-13 21:56:58 +02:00
Charlie
bc79020037 fixes hallucination shocks (#19361) 2022-10-12 11:09:55 -05:00
DevanStrife
207562c1cb Legcuffs and beartraps show up on examine (#19298)
* Update README.md

* Workin now

* Github being a b again...

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-10-10 23:49:19 -05:00
DevanStrife
197db5df9f Fixes invisible in-hand pai sprite if the pai is resting (#19296)
* Update README.md

* Works as intended now

* did an oopsie somehow
2022-10-10 23:40:01 -05:00
warriorstar-orion
71cf58d8a5 Only give bots HUDs when player-controlled. (#19198)
* Only give bots HUDs when player-controlled.

* Clean up data_hud regardless of whether or not a player is present.

* No need to keep around this ref.
2022-10-10 15:20:55 -05:00
Vi3trice
20c437f7d2 linters do your magic (#19263) 2022-10-10 20:58:41 +02:00
ElorgRHG
e843567671 Clothing (jumpsuit) DMI split, unused jumpsuit sprite purge along the way (#19092)
* Medical and RnD DMI files split

* Cargo DMI split

* Security DMI split

* Engineering DMI split

* Captain DMI split

* Civilian/service DMI split

This one hurt

* Forgot about this one

* Color DMI split

* Purges everything that was delted up until this point

... with a blindfold and a shotgun

* Dress and suit DMI split

* Pants and shorts DMI split

and merges pants and shorts files... shorts are pants, right?

* Donator/fluff jumpsuit clothing organisational relocation

* e

oops

* So this is used, repath bad

* Random commit

* Costumes DMI split and jumpsuits purge

* Some fixes

* pennywise

* Centcom DMI split

* SolGov DMI split

* Retro DMI split

* Syndicate DMI split

* Misc DMI split

* centcom officer

* Kills off uniform.dmi completely

* last fixes

* lastest fixes

* vox navy gold conflict

* civilian barber

* Tourist observers work now

* Hopefully working non-human humanoid clothing

* This being in suit.dmi is one of the reasons I made this PR

* This shouldn't be here

* Late night coding

* Pun Pun regains his drip

* Last fixes

* security/OFFICER

* Most important - clown fix

* working subtypes good

* Fixes chameleon jumpsuit

* Proper QM pathes

* Fixes jumpsuit rolling with the power of poor quality code

* Cargo tech character setup fix

* else instead

why didn't I do this in the first place

* PURP

* Fixes broken character setup job clothing

* CC suit fix

* Psychedelic jumpsuit proper path

* You must wear the jumpsuit to adjust it
2022-10-09 14:24:10 +01:00
FloFluoro
c7db0bb208 Terror Prince attack now (also) does stamina damage (#19284) 2022-10-08 10:55:58 +01:00
Vi3trice
a9baf739f5 Diona nymphs eject from dionas if a species change occur (#19283)
* Give the little fellas a break

* Hopefully non-dionas do not get nymphs

* Update code/modules/mob/living/carbon/human/species/diona.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-10-06 22:23:56 -05:00
Contrabang
8418997ed8 Moves most screwdriver checks to screwdriver_act (#19024)
* screwdriver_act my beloved

* convert to returns instead of . / lewcc review

* it will be done

* i'm a little bit stupid, but now time to test

* sometimes I get excited and press the commit

* The great test has been completed

* oh wow oh wow, lewc review

* found one last one

* Steel review

* Lewc review

* quick sirryan review

* removes stupid comments (old coders I blame)

* sirryan review two

* whoops...

* hal review

* the fix to the fix to the fix

* Revert "the fix to the fix to the fix"

FUCK I pushed to the wrong branch
This reverts commit a96fe98781.
2022-10-06 09:30:33 +01:00
GDN
ec9142c238 Species now have their innate actions GC (#19212) 2022-10-05 22:29:31 -05:00
Qwertytoforty
02a66d2cd9 ancient goliaths now have their own trophy like other shiny lavaland mob. (#19222)
* ancient goliaths now have their own trophy like other shiny lavaland mobs

* Update code/modules/mining/equipment/kinetic_crusher.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-10-05 11:01:54 -05:00
Henri215
aba36033d8 AI cryo now respects too early to ghost (#19215) 2022-10-04 22:23:56 -05:00
Contrabang
0fbfa2ca0d Adds "Highlights" to the Orbit menu (#19168)
* adds highlights

* comment update

* misc support

* weird spacing begone

* requested changes
2022-10-03 19:02:04 -05:00
FloFluoro
6a876e1994 Standardize cleaning object behavior into "cleaning_act" proc (#19001)
* Standardizes cleaning item functionality into "cleaning_act" proc

* Culling commented-out code

* Damp rag now checks for humans before cleaning

* Change proc scoping, moved mop reagent check out of cleaning.dm

* Adds can_clean and post_clean procs to handle mopping, removes ismop parameter

* Adds can_clean() to cleaning objects/mobs

* cleaning_act() now carries message strings as params

* Refactored cleaning_act() for earlier returns and less redundancy

* cleaning_act now runs on the target atom, instead of the cleaning object

* Changed turf checks to overrides, rescoped clean_turf, lots of tidying

* Removed cleaner param from post_clean, since it'll always be src

* Code review tidying

* Tidying..........

* Removed clean_turf and put its functionality in turf/simulated/cleaning_act(), added new param to keep track of original targeted object

* Moved cleaning.dm from datums to code/game/objects

* Added early return, defined cleanspeed in seconds
2022-10-03 20:25:00 +01:00
Charlie
8e39fbc57c moves all living var definitions to living_defines (#19203) 2022-10-03 11:19:37 +01:00
FloFluoro
094ca894ef Having a facehugger on your face muffles your speech (#19145)
* Having a facehugger on your face muffles your speech

* Scoped to living

* Yes.
2022-10-02 22:13:36 -05:00
S34N
a66c4ab225 this has to be the stupidest mistake we all missed ever (#19247) 2022-10-02 14:24:01 +01:00
S34N
2c6fc27434 Fixes speaking dead parrots (#19193)
* fixes speaking dead birds

* Update code/modules/mob/living/simple_animal/parrot.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* hal

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2022-10-01 17:10:18 +02:00
AzuleUtama
e1873e7718 Inhand small mobs now detail if they're dead/asleep when examined (#19124)
* Inhand small mobs now detail if they're dead/asleep when examined

Fixes #19097

* Checks on examine instead
2022-10-01 00:42:44 -05:00
Charlie
5785c3638f Removes Shadowstep. replace it with 2 powers for each vampire type. (#18951)
* WIP

* shadow boxing

* garg + hemomancer

* dantalion and stuff

* oops

* some tweaks

* sprites, tweaks and TGUI

* ready for review

* review

* forgot some sean comments

* oops

* prevents people walking over shockwaves

* shadow boxing DPS down to 20

* oops

* affected review
2022-09-30 12:32:53 -05:00
FloFluoro
32db03c463 Held items no longer prevent Xenomorph disarm knockdown + stamina damage (#19142)
* Held items no longer prevent xenomorph disarm knockdown + stamina damage

* Stam damage is now handled by a var, no longer fixed to 30
2022-09-27 16:23:47 +01:00
Charlie
1d132cf569 fix (#19127) 2022-09-25 21:01:18 +01:00
GDN
d86b6a4665 Reworks alien facehugger incubation (#19084)
* Well it works, but I need to check something first...

* Adds new maffs that we can use from Vi3trice

* minor var mistake

* Addresses steels + ryans review

* Oops
2022-09-25 13:12:11 -05:00
Henri215
98f4520a43 bald expansion and added shave bodyflag (#19117) 2022-09-25 17:44:27 +01:00
Luc
96aab66dc6 Add cooldown for unintentional emotes (#19078)
* Add cooldown for unintentional emotes

* Oops, let's try that again.
- Adds a separate cooldown system for unintentional emotes.
- Unintentional emotes will fire audio at most once every 2 seconds.
- Emotes like deathgasp can override this out of necessity.
- Scream's is longer because...come on.

* The part that makes the rest of it actualy work
2022-09-25 17:31:26 +01:00
Vi3trice
7a3f2ed506 Port TG pointing to inventory thought bubble, and expand valid pointing targets (#19072)
* Well that actually works

* Update atoms_movable.dm

* Now you can point at things inside of things.
2022-09-25 17:29:51 +01:00
Adri
b32f499e72 Removes xenomorphs from xenobiology gold slimes (#19002) 2022-09-25 17:21:17 +01:00
Qwertytoforty
ebd492f3bb Blood drunk will now transform its weapon during melee (#19139) 2022-09-25 17:07:46 +01:00
FloFluoro
5b60ae5c1e IDs now take priority over PDAs in get_idcard (#19051) 2022-09-25 17:03:21 +01:00
S34N
924e8cc949 Renames non-cybernetic implants to bio-chips (#18937)
* CHIPS

* microchip implanter

* more chips to purge

* bio-chip

* catches more things

* tgui

* final merge changes

* Update code/game/machinery/cloning.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* oops

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-09-24 14:24:25 +01:00
AffectedArc07
34927f05ab Wryn removal v2 (#19112)
* Removes Wryn

* and the sprites

* Fixes

Co-authored-by: Fox McCloud <Fox-McCloud@users.noreply.github.com>
2022-09-24 12:53:34 +01:00
Henri215
c2aba93317 removed var digestion_ratio (#19114) 2022-09-21 21:50:06 +01:00
Henri215
5e4d0db18a Fix #17543 Genetics UI Block 32 Doesn't Properly Change Gender (#19120)
* fixed gender being stuck in plural at genetics

* Update code/modules/mob/living/carbon/human/appearance.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-21 15:14:06 +01:00
GDN
9cda5ed786 Buffs Alien Queens (#19106)
* Buffs alien queens

* reviews and bigger queen

* Scoping to humanoid
2022-09-20 13:15:44 +01:00
AffectedArc07
3975e3531d Fix some busted logic (#19105) 2022-09-19 13:00:37 +01:00
AffectedArc07
1d008754da [READY] Bot Refactor (#18930)
* [WIP] Bot Refactor

* No more spawns, sleeps, and working EDs

* Mules

* GC fixing

* h
2022-09-17 12:46:25 +01:00
FloFluoro
15a0edc588 Fixes facehuggers facehugging forever (#19067)
* Fixes facehuggers facehugging forever

* Removed unnecessary "as mob", readded blindness because clothing-induced blindness doesn't fully mimic the status effect
2022-09-16 22:45:52 -05:00
Luc
346a1b8142 Yet Another Surgery Refactor (#18325)
* Initial commit

Fixes up surgery.dm
Adds some tool behavior

* More basic changes

* Checkpointing: this is a little gross right now

* Add signal COMPONENT_CANCEL_ATTACK_CHAIN

* Cleans up surgery initiator

* Mostly gets surgery (and canceling it) working

* Add abstract proxy surgery steps

Also adds them to organ manipulation

* Clean up most existing surgeries

* Rework organ openness, adds define for aborting a beginstep

* surgery works again, also implements retry defines

* fix surgery computer

* add limb repair to synth implant removal

* retry implant checks

* Clean up abductor surgeries as well as some other things

* A lot
- Reworks organ manipulation to use a series of surgery steps instead
- Fixes some runtimes with open hands
- Lets mito zero out the germ level while treating necrosis
- Adds a debug surgery tool

* add debug surgery tool, note some TODOs for later

* Add conditional check for surgeries repeating

* update surgery retry logic to make it more of a bonus

* Lets abductors automatically retry any failed surgery steps

* Rework robotic surgery to use abstract/proxy steps

* Bunch of bugfixes and more!
- Limb reattachment works properly now, you can just slap a limb onto a person
- If the limb isn't robotic, it'll be useless until the surgery is finished with a hemostat, though it might be enough to get the patient out of the OR.

* Remove more now-implicit checks

* Slight reorganization

* more fixes across the board

* Remove unused variable

* Trying not to lose my mind here
- Does away with can_run() entirely
- Cleans up visible messages in code
- begin steps should now all have ..() afterwards
- slime bone surgery should be fixed now
- more docs

* Robotic  surgery is stoppable with a crowbar, all surgery can_start now checks parent

* Fix some broken robotic typepaths

* Typepath fixes, do away with some last TODOs

* Forgor

* Last cleanups before we go gold

* jk lol

* Make early surgery termination clearer

* More "last" cleanups

* Fixes tool flags, surgery initiation

- Fixes surgery not being startable by sharp objects
- Moves surgical tool flags to item traits

* Clean up surgery cancellation, especially for borgos

* I think this should GC better

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Status is now step number

* Add a 20% chance to find nothing during organ manipulation

* Improve documentation, make forced_surgery a normal arg

* Charlie's reviews

* Why are abductors like this

* Little more verification, ensuring limb augmentation and organ manip healing work properly

* Fix torso organ manip being unfinishable

* Fix cavity implants, open-hand/any item steps

* Make sharp objects not try to start an operation with help intent

* Comments, quick target fix

* Re-order list so advanced bruise pack is pulled first

* Make surgical gripper function like an open hand

* Make mito only use one unit per organ for now

* Check if user is on operable surface before trying to operate

* Reduce admin logging

* Fix some bugs that appeared during the testmerge
- you can no longer start robotic surgeries with a scalpel (lol)
- you can now cancel surgeries on the first step after I fixed some bugs that I introduced (woo hoo)
- Synthetic limb attachment is now combined into a single startable surgery step, though still retains the fun flavor of both

* Swats some more bugs
- (hopefully) fixes a huge source of runtimes where we tried to check if we could run surgeries before checking if the surgery used an organ
- In doing so, moves the logic for determining if a surgery can start to the mob-level
- Fixes robotic reattachment surgery not working

* multi-bug drifting???

- Fixes a bug where a branching surgery with an any tool option could possibly override a step with a matching tool
- Fixes some intermediate surgeries failing due to not having specified possible_locs

* A few more fixes
- Fixes any surgery tool steps again
- Fixes cavity surgery again

* Hopefully fixes getting stuck in robotic organ manip

* Remove extra parent call

* Steel review

* Steel review

* Fix spacing for possible locs

* Roundstart traits

* Advanced surgical traits and other hal fixes

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-09-16 18:48:43 +01:00
Luc
686cd5fd79 Fixes emotes being displayed as the wrong type (#19026)
* Fixes some emote types, fixing the voice analyzer by proxy

* Remove unused utility function
2022-09-16 17:52:17 +01:00
Qwertytoforty
e275183ddd Xenomorphs can now stun borgs for practical ammounts of time. (#19050)
* god damn it.

* was cycles not seconds
2022-09-16 17:51:34 +01:00
FloFluoro
3974a98073 Facehuggers no longer instastun, removes some RNG (#19025)
* Facehuggers no longer instastun

* Changed egglaying time to actual seconds

* Code review

* Autodoc, typos, etc.
2022-09-13 23:22:39 +01:00
Qwertytoforty
ae0efa00b5 Ports the shuttle console hijack from TG. Tweaks malf AI hijack. (#19018)
* *puts on sunglasses* "I'm in."

* whoops

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Caching, danger, range, xenomorphs can no longer hijack

* Update code/modules/shuttle/emergency.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/shuttle/emergency.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-09-13 23:22:19 +01:00
FloFluoro
b8885719f4 Xenomorphs can now die (#19046) 2022-09-13 22:53:06 +01:00
FloFluoro
4c2da8fc28 Fixes Xenomorphs being able to build resin structures in space (#19028)
* Fixes Xenomorphs being able to build resin structures on turfless tiles

* powerc my beloathed

* When the return is indented!
2022-09-13 22:42:10 +01:00