Commit Graph

24428 Commits

Author SHA1 Message Date
moxian
da2120f60d Fix runtime with borgs deathgasping (#18109)
* Fix runtime with borgs deathgasping

* farie's wonderful suggestion

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-06-27 14:25:50 +02:00
KalevTait
faf173b35c Glass container reagents saftey check (#18096)
* changed fake disintegrate to not need a permit (as far as sec bots are concerned)

* prefer boolean defines to magic numbers

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

* added check

* Update code/modules/reagents/reagent_containers/glass_containers.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-06-27 13:25:34 +01:00
Deniz
3c0603f7ea Alien Queen is now, indeed, dead (#18113) 2022-06-27 13:24:14 +01:00
Sirryan2002
92e9a86dfb adds qdel (#18101) 2022-06-26 21:44:06 +01:00
AffectedArc07
d538100ceb Shift+F3 debug menu (#18065)
* F3 debug menu

* Some tweaks

* So that escalated

* Update code/controllers/subsystem.dm

* Update code/controllers/subsystem/debugview.dm

* Charlie tweaks
2022-06-26 20:10:09 +01:00
Bm0n
d43eb77b25 Replaces Free Guns From Sci With Parts Kits (#17918)
* rip sci powergamers

* grammar

* apparently i don't know how to spell

* code review

* +to

* oook

* a over the
2022-06-26 18:53:03 +01:00
KalevTait
a0a1f2bbf4 Fix cutting meat to be consistent with itself and cutting other food items (#18092)
* make scalple work to cut cutlets into bacon

* Fix displayed messages to work with scalpel, and brought formating in line with everywhere else in the game.

* brings messaging for cutting meat in line with messages for other actions in the game.

* removed the extra 'the's from the the messages

* Add space between arguments in function call

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-06-26 17:43:49 +01:00
DamianX
645759d9df Admin spawn verb QoL (#18063) 2022-06-26 15:35:15 +01:00
Luc
1aaf3d6315 Make monkey death/gasps not travel through walls (#18080)
* Make monkey death/gasps not travel throguh walls

* based off of mind instead of monke
2022-06-26 15:33:10 +01:00
moxian
1f39be6cfb [GBP no update] Fix the display of the zone being operated on during the surgery (#18087)
* Fix the display of the zone during the surgery

* wrecks => rips. Better english
2022-06-26 11:32:41 +01:00
moxian
59b91e7c37 Fix runtime in mass-hallucination event (#18093) 2022-06-26 11:24:55 +01:00
S34N
705578b23b Energy detective revolver (#17771)
* Initial defines

* more work

* icon

* more stuff

* UID not hard ref

* tidying

* overload go brrt

* le sound and dead cell

* delet gap

* initial chargepack stuff

* simplify

* oops

* yeet this

* placeholder sprites

* oops magic number

* the gun speaks!

* consolidation

* tweaking and tidying

* so long old gun

* icon purge

* reapplies placeholder

* 1 minute tracker, not two

* makes it use a pinpointer

* revert tiny map changes

* cease your tracking, fool

* oops

* soft refs

* charlie review

* projectile ref to firing obj, removes testing overrides
& cleans up signals

* some more UID null checks

* ICONS

* ICONS CONFLICT

* MORE ICONS

* makes it freaking work

* first pass fixes

* charlie review

* charlie review 2, variable boogaloo

* fixes holsters

* colours the overcharged shot

* and recolours tracker to be yellow to match charge

* yellow laser icon

* widen overcharge misfire %

* fixes unlinkable pinpointers

* fixes gun not speaking when tcomms setup is changed

* steel request

* no chargey

* loudening 2022

* steel part 1

* Apply suggestions from code review

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* restores missing sprites

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-06-25 20:15:09 +01:00
DamianX
3582787514 Added set_stat setter for mob/var/stat (#18079) 2022-06-24 21:39:43 -05:00
moxian
f4bd86cc5e Surgery on napping people wakes them up. (#17661)
* Surgery on napping people wakes them up.

* Fix a potential afreeze issue

* Code review

* has_status_effect now returns `null` if no status effect

* move `voluntary` to be an arg to New

* Update code/modules/surgery/helpers.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* And this other IsSleeping call

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-06-25 00:20:24 +01:00
S34N
5f58a80d8a Let admins allow ERT borgs to choose sec modules (#17874)
* Let admins allow secborgs in ERT

* dont force them to be secborgs

* fixes up some logic

* remove this

* Update code/modules/tgui/modules/ert_manager.dm

* le indent

* deconflict

* tgui deconflict

* Update code/modules/tgui/modules/ert_manager.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
2022-06-25 00:07:18 +01:00
Kugamo
d97c8cb6eb Gloves now dyeable again (#18077)
* wow, this is just like one of those japanese animes...

* ok

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-06-24 17:46:16 +01:00
DamianX
06768b96a3 Added time dilation tracking (#18061)
* Added time dilation tracking

* Update code/controllers/subsystem/time_track.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-06-24 17:34:23 +01:00
Contrabang
ed203d9f69 Space ruins no longer have lava underneath them (#18047)
* begone space lava, remaps most of space ruins

* removes druglab having DJ station area

* renames "gasthelizards.dmm"

* revert "renames "gasthelizards.dmm""

* goodbye syringe gun, hello turf/template_noop
2022-06-24 10:50:21 +01:00
Mitchs98
dfca7bf993 Antag-Banned Players No Longer Selected In 'Everyone Is a traitor' (#18048)
* antagdenied

* faeriechanges
2022-06-23 20:24:34 +02:00
Charlie
023d179c9c fuckup of the yar (#18060) 2022-06-23 14:08:58 +01:00
Qwertytoforty
d9b2a0c4ae fixes being able to break plasma pistols (#18043) 2022-06-22 17:53:58 +01:00
S34N
ff912fe937 Reworks flap+windoor delivery areas, tidies delivery beacon directions (#18004)
* flaps 2.0, cleans up beacon dirs

* removes weird cyberiad double-windoor engi delivery

* charlie review

* WIP

* mules sliding into your d(epart)m(ent)'s
2022-06-22 12:27:48 +01:00
Kugamo
8d7631dd49 Fire alarm sounds (#17992)
* STOP DROP AND ROLL BABY!

* bruh

* roasty toasty

* Choose Your Voluuume!!!!

* :U 👌 🆘

* SteelSlayer Suggestion

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-06-22 09:51:32 +01:00
moxian
8b049ff877 Fix stack overflow in mutual grabs (#18032)
If you grab someone who grabs you, and either of you try to move
you'd get stack overflow.
No more.
2022-06-22 08:18:35 +01:00
Kugamo
1c2cec06d1 Fixes space movement pushing jank (#18024)
* 👾

* comment

* Sirryan2002 Suggestion

* Forgot facing dir lock

* SteelSlayer Suggestion

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-06-22 00:45:17 -05:00
Luc
727b299d33 Rapid Syringe Gun rework (#17816)
* First commit reworking most of RSG

* Fixes, add alternate versions

* Update in uplink, remove from R&D

* Add custom pre-loaded version to uplink

* Fixes message, linter error

* Change initialization of half rapidsyringe

* Some review updates

* Add some sound effects

* Use internal reagents instead of a literal bluespace beaker

* Update rapid syringe description

* Drop RSG to 8 TC

* Update code/modules/projectiles/guns/syringe_gun.dm

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>

* More review changes, improve messaging

* Update code/modules/projectiles/guns/syringe_gun.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* Address reviews

* Remove extraneous check

* Message and documentation reviews

* Syringening

* More review

* attempt to bump CI

* spacing

* last review concerns

Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-06-21 21:26:27 +01:00
AffectedArc07
c445b4d396 Grants VIEW variables to +VIEWRUNTIMES (#17996) 2022-06-21 18:51:04 +01:00
Kugamo
ae1e03f5d9 Beepski attack animation 2022-06-21 12:19:19 +01:00
Kugamo
630a88ab96 new variable (#18025) 2022-06-21 12:01:58 +01:00
Kugamo
1176812962 3863168 (#18026) 2022-06-21 12:01:51 +01:00
Kugamo
afab3764e9 👓 (#18022) 2022-06-21 11:56:02 +01:00
moxian
7505f5c886 Fix unstable mutagen not working (#18020) 2022-06-21 11:54:02 +01:00
Marm
af0b69c727 Makes Collosus death bolt dust dead people (#18011) 2022-06-20 21:02:35 +01:00
Qwertytoforty
a01d7ae390 Adds cargo blackbox tracking (#18008)
* Adds cargo blackbox tracking

* _ added
2022-06-20 21:02:11 +01:00
S34N
66901439b6 signaller bombs work on implant again (#18016) 2022-06-20 20:59:31 +01:00
Sirryan2002
6f5584edce checks + returns for extinguished lights (#18010) 2022-06-20 14:27:27 +01:00
SteelSlayer
c3fcf3e256 Datumizes changelings and refactors related code (#17774)
* it's finally here

unfucks tgui

* oops, I don't want to change the mode

* charlie and moxian review

* charlie review II + some GC fixes

* rebase to fix conflicts + tgui bundle deconflict

* charlie review III + affected review

* final? tweaks
2022-06-18 20:55:49 +01:00
LightFire53
52a2a90966 Fixes Area Shenanigans on Labour Camp, Derelict 5, and CharlieStation (#17987)
* Area tweaks

* Update oldstation.dm

* When you are Near Space

* 2 missed lattices...

I love catching things I missed in a screenshot...

I need a finer comb.
2022-06-17 12:19:23 +01:00
Finalgamer10
1105760a00 Fixes Hardsuits, so that they once again (#17971)
* Fixes Hardsuits, so that they once again
 have an ion trail behind them.

* Update code/modules/clothing/spacesuits/hardsuit.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-06-16 17:51:49 +01:00
SteelSlayer
ae6b1776c6 A few antag datum related fixes (#17974)
* thrall cyro fix for # 17958

* other fixes
2022-06-16 13:57:16 +01:00
Luc
747d8111ca Datumized Emotes (#17544)
* Add raw tg emote datums

* Some more initial implementation

* First (big) commit

* More reworks, most emotes seem to work but cooldowns are weird

* Add the remaining emote species

* Add simple mobs

* Update defines, add more comments

* Remove unnecessary intentional calls

* Fix some bugs, add more functionality
- Silicon mobs/bots can't use all the living emotes
- Sound volume can now be specified for emotes
- Added a define for emotes to not go thru runechat
- Reorganized some emotes
- Some human emotes that need breath will gasp
- IPCs can beep boop
- Restore power warn for robits
- Sneezing and coughing have sound effects

* Fixes emote species separation not working in *help

* Reorganize emotes based on what's available on paradise

* mouthful mode

* Update implants to use emote signals

* Update species whitelist to use a typecache

* Cleanups

* More small changes
- Remove old extraneous typecache
- Reconfigure drask emotes
- Make all mime emotes visible (since they're silent)

* Remove old emote functions

* Update emote sounds, volume

* Rework more emotes into EMOTE_VISIBLE

* *rumble*

* More slight testing and cleanup
- Drop audio emote cooldown from 10 to 5 seconds
- Change clapping behaivor slightly, putting it into run_emote
- Update some emote flags here and there
- Fix up johnny, though remind me why this one exists?

* Fix indentation, missing typecast

* fix some returns

* More review

* Rename emote files

* Add'l review

* Even more emote fixes!

- Move defines out into an emote define file
- Integrate audio and general emote cooldowns
- change some 1 and 2 into visible/audible
- Try to fix monkey screech

* Add ability for admins to mute users' emotes.

* Rename cooldowns, add general mob emote cooldown.

* Fix flip not always geting the right message

* Add some emote target handling, docs

* Fix admin rights, indentation

* Update emote.dm

set default mode to ANY

* General implant fixes

- The way implant triggers are handled is now improved, with separate checks for death and emotes instead of just checking deathgasp.
- Implants can choose to be triggered for the first death or for every death.
- Voice of God play dead now activates sad trombone

read: voice of god can now no longer lowtiergod nukies

* Bunch of other changes and bugfixes

- Adds number flag for behavior
- Reworks how muzzling/vocalizing emotes works
- Breaks out sound effects
- Drops cooldown to 1.5s

* Fix people being able to snore/nightmare while awake.

* Bump paralysis on living emotes

* First review pass

* Clean up implants (while we're here) and fix compile errors

* in living error

* More outstanding review fixes

* use more isx() checks

* Add pre-emote signal, try_run_emote()

* Prevent silicons from playing their deathgasp multiple times

* Add emote postfix behavior for adding parameters to non-message params.

Also adds a signal to intercept emote actions.

* Fix linter complaints

* Remove new player checks on GLOB.dead_mob_list

* Fix species emotes not being distinguished, remove weird legacy code

* monkey ball

* better docs == better code

* Fix audio cooldown, silicon emotes

* Fix ghost emotes (don't worry they're staying)

* Restore spin to 2 seconds

* oh johnny boy

* Make fainting last two seconds instead of .2 seconds

* Remove extra highfive message

* Tick friendly emotes

* Fix up friendly emotes, ghost emotes

* Add some emote message safeguards, prevent flip from showing twice

* Fix ghost vision message format

* Fix hands_use_check on non-carbon mobs

* Bring emotes in line with say re. oxyloss

* Add option for death implants to not trigger on gib

* Try adding some unit testing

* Include emote unit tests

* More attempts at unit testing

* More attempts at unit testing?

* forget it this is fine

* Housekeeping

* Little bit more

* Remove extra bolding from ghostsight emotes

* More sanity checks, fix snore

* Remove stack trace when unintentional emote fails

* Update code/modules/mob/living/silicon/silicon_emote.dm

oops

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

* More implant cleanups

* Oh I missed this

* Silence wagging, more review fixes

* Oops 2

* ensure everything can swear

* High-five fixes and status effect stuff
- Adds new on_timeout() function that gets triggered when a status effect expires
- Fixes up passing arguments to status effects
- Ensures high-five explosions don't kill the wizards

* More review stuff
- Add a stat to text to make things easier
- Make it harder to delete emotes
- BIG DANGER
- pose can no longer be set while unconscious

* Remove extra high five logic, godmode changes

* forgor

* Fix gasp not working

* Update docs for good measure

* Some review and custom emote fixes

* Fixes death alarms being broken

* Better handle stat_allowed, more review comments.

* ..() conventions

* This is why unit tests are nice

* Remove drone snowflake emote stuff

* Linting

* No more flipping on the ground

* Snap doesn't require hands free

* Does it make complete sense? no, but it's Fun

* Apply suggestions from code review

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

* Fix revenant messages, power warning

* epic webedit fail, laugh at this user

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-06-14 23:06:24 +01:00
Qwertytoforty
9dc65f5cf0 Meteor shield sats can now shoot meaty ores (#17957)
* Meteor shield sats can now shoot meaty ores

* Update code/modules/station_goals/shield.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-06-14 14:56:28 +01:00
Mitchs98
2c5f20f318 Malpractice-B-Gone (#17960) 2022-06-14 13:36:07 +01:00
13spacemen
6daf7b8515 Vamps With 0 Blood Sucked Don't React To Holy Water (#17959)
* vampires with 0 total blood sucked no longer react to holy water by bursting into flames etc.

* minor adjustment
2022-06-14 13:35:30 +01:00
Qwertytoforty
da7dd5b000 Nerfs xenobio xeno mobs HP (#17956) 2022-06-14 13:34:27 +01:00
Kugamo
d4d4615fe2 Inhand sprites for metal sheets and ores (#17952)
* amogus

* Revert "amogus"

This reverts commit ebaa99c77b.

* okay

* fix merge conflict
2022-06-14 13:34:08 +01:00
Bm0n
86b711d153 Restores Music Note Toggle On Headphones (#17949)
* i still dont like the floaty notes

* better wording

* review suggestions
2022-06-14 13:32:33 +01:00
Kugamo
944e6d1231 YES (#17946) 2022-06-14 13:32:13 +01:00
Kugamo
7acca3d599 Examine Energy Weapon Charge (#17945)
* BIG DATA

BIG DATA

* SMALL DATA

SMALL DATA
2022-06-14 13:31:40 +01:00
alex-gh
01a5869cce Added checks to prevent amount of gases from going negative (#17930) 2022-06-14 13:30:17 +01:00