mirror of
https://github.com/ParadiseSS13/Paradise.git
synced 2026-01-06 23:51:43 +00:00
5774092784
* Rework of chav disability text replacement <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## What Does This PR Do Replaces individual replacetext() calls with one regex function and a list. Adds more chav terms, updates disused terms. Stops replacetext() changing terms in the middle of other words, now only changes whole words. <!-- Include a small to medium description of what your PR changes. Document every changes or this may delay review or even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Little things like this add immersion and variety, so having a few extra changes at minimal performance cost helps. Matches found in the middle of words no longer get replaced, so you don't end up looking like a tool by saying "com**mate**d" instead of "com**man**d" Tidying up old code to include regex also makes the code easier to maintain. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog 🆑 add: Added more chav words, innit. del: Removed some old words. tweak: Replaced many replacetext() calls with a single regex function, only changes whole words. /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Update goon_disabilities.dm * Stopped chavlinks being global Moved the chavlinks list into the chav disability datum * ACTUALLY stopped chavlinks being global * Tidying Im a moron and forgot to move my comment with the lst * Incorporated farie82's suggestion changed rep_test to replace_speech * Tweaks to replacement list Removed dupes, added more -ed words, redone "you" and "your"