mirror of
https://github.com/ParadiseSS13/Paradise.git
synced 2025-12-26 18:21:56 +00:00
129a57bd9b
Ports Goon Lighting from /vg/station. Summary - This adds smooth edges to all lighting in order to increase the aesthetic appeal of the lighting system. It works by using a matrix to change the appearance of the lighting overlay sprite, which has been changed to be a base for the matrix to modify. Ported from /vg/station with the help of @PJB3005. This lighting system is a hybrid between Mloc's lighting rewrite and Tobba's Goonlights. Notable changes: - Darksight now matters on mobs. The lighting overlays are not alpha=255 when they are completely dark, meaning you can still see the floor- assuming you can view the turf at all, because it retains the luminousity setting. - This means Tajaran have 100% night vision again as they are intended to. Humans can see in a 3x3 square centered around themselves. - No, I'm not changing this, if it's even possible. This is how BYOND's lighting is meant to work. If you have any complaints about game balance, please feel free to make a pull request to change see_in_dark values, which will be seperately evaluated. - The lighting controller now runs at world.tick_lag, to emulate the realtime function of StonedMC. So far with my testing, this hasn't caused any noticable performance decreases- the lighting system is obviously more expensive than our previous iteration, however, it's not the next ZAS ;) Technical Details: - /atom/movable/lighting_overlay/proc/get_clamped_lum has been removed, succeeded by /turf/proc/get_lumcount. They behave identically. - Turf lighting is actually controlled by four "corner" datums, which feed information into the overlay. - The way opacity is factored into the system has changed. Anything that doesn't use set_opacity is not going to work to block light. - /area/lighting_use_dynamic has been renamed to /area/dynamic_lighting, for consistency with /turf/dynamic_lighting. - Lighting is no longer seperately initialized for away missions. It is handled in ChangeTurf() as it should be. Known & Unfixable issues: - There is a 5-10 second delay from starting the round to the lights turning on. Attribute it to "the powernet being spun up" if you would like to- but it's actually just how long it takes the lighting system to update every single turf on the map. - When you walk with a light on you, the light will actually jump ahead of you before you visually get to the tile. This is because of the movement gliding on mobs, realtime lighting actually goes faster than the glide takes to complete, so it appears that your lights are moving faster than you. Thank you krausy~ Animated Goonlights This adds an animate() call to the update_overlays() proc. This makes it so that any light changes will smoothly transition between the changes instead of instantly changing their appearance. Also fixes a few issues pointed out on Github. Change lighting animation (turns out the old one totally breaks if you toggle a light quickly, whoopsies) Kill LIGHTING_INSTANT_UPDATES isturf
92 lines
3.1 KiB
Plaintext
92 lines
3.1 KiB
Plaintext
// Solves problems with lighting updates lagging shit
|
|
// Max constraints on number of updates per doWork():
|
|
#define MAX_LIGHT_UPDATES_PER_WORK 100
|
|
#define MAX_CORNER_UPDATES_PER_WORK 1000
|
|
#define MAX_OVERLAY_UPDATES_PER_WORK 2000
|
|
|
|
/var/lighting_overlays_initialised = FALSE
|
|
|
|
/var/list/lighting_update_lights = list() // List of lighting sources queued for update.
|
|
/var/list/lighting_update_corners = list() // List of lighting corners queued for update.
|
|
/var/list/lighting_update_overlays = list() // List of lighting overlays queued for update.
|
|
|
|
/var/list/lighting_update_lights_old = list() // List of lighting sources currently being updated.
|
|
/var/list/lighting_update_corners_old = list() // List of lighting corners currently being updated.
|
|
/var/list/lighting_update_overlays_old = list() // List of lighting overlays currently being updated.
|
|
|
|
|
|
/datum/controller/process/lighting
|
|
/datum/controller/process/lighting/setup()
|
|
name = "lighting"
|
|
|
|
schedule_interval = world.tick_lag // run as fast as you possibly can
|
|
create_all_lighting_overlays()
|
|
lighting_overlays_initialised = TRUE
|
|
|
|
// Pre-process lighting once before the round starts. Wait 30 seconds so the away mission has time to load.
|
|
spawn(300)
|
|
doWork(1)
|
|
|
|
/datum/controller/process/lighting/doWork(roundstart)
|
|
// Counters
|
|
var/light_updates = 0
|
|
var/corner_updates = 0
|
|
var/overlay_updates = 0
|
|
|
|
lighting_update_lights_old = lighting_update_lights //We use a different list so any additions to the update lists during a delay from scheck() don't cause things to be cut from the list without being updated.
|
|
lighting_update_lights = list()
|
|
for(var/datum/light_source/L in lighting_update_lights_old)
|
|
if(light_updates >= MAX_LIGHT_UPDATES_PER_WORK && !roundstart)
|
|
lighting_update_lights += L
|
|
continue // DON'T break, we're adding stuff back into the update queue.
|
|
|
|
if(L.check() || L.destroyed || L.force_update)
|
|
L.remove_lum()
|
|
if(!L.destroyed)
|
|
L.apply_lum()
|
|
|
|
else if(L.vis_update) //We smartly update only tiles that became (in) visible to use.
|
|
L.smart_vis_update()
|
|
|
|
L.vis_update = FALSE
|
|
L.force_update = FALSE
|
|
L.needs_update = FALSE
|
|
|
|
light_updates++
|
|
|
|
SCHECK
|
|
|
|
lighting_update_corners_old = lighting_update_corners //Same as above.
|
|
lighting_update_corners = list()
|
|
for(var/A in lighting_update_corners_old)
|
|
if(corner_updates >= MAX_CORNER_UPDATES_PER_WORK && !roundstart)
|
|
lighting_update_corners += A
|
|
continue // DON'T break, we're adding stuff back into the update queue.
|
|
|
|
var/datum/lighting_corner/C = A
|
|
|
|
C.update_overlays()
|
|
|
|
C.needs_update = FALSE
|
|
|
|
corner_updates++
|
|
|
|
SCHECK
|
|
|
|
lighting_update_overlays_old = lighting_update_overlays //Same as above.
|
|
lighting_update_overlays = list()
|
|
|
|
for(var/atom/movable/lighting_overlay/O in lighting_update_overlays_old)
|
|
if(overlay_updates >= MAX_OVERLAY_UPDATES_PER_WORK && !roundstart)
|
|
lighting_update_overlays += O
|
|
continue // DON'T break, we're adding stuff back into the update queue.
|
|
|
|
O.update_overlay()
|
|
O.needs_update = 0
|
|
overlay_updates++
|
|
SCHECK
|
|
|
|
#undef MAX_LIGHT_UPDATES_PER_WORK
|
|
#undef MAX_CORNER_UPDATES_PER_WORK
|
|
#undef MAX_OVERLAY_UPDATES_PER_WORK
|