Merge pull request #8531 from Spookerton/spkrtn/sys/global-agenda

updates all bare globals to use /global/ semantics, and all shared members to /static/

code/modules/admin/NewBan.dm

@@ -1,5 +1,5 @@
-var/CMinutes = null
-var/savefile/Banlist
+var/global/CMinutes = null
+var/global/savefile/Banlist
 
 
 /proc/CheckBan(var/ckey, var/id, var/address)

code/modules/admin/admin_ranks.dm

@@ -1,4 +1,4 @@
-var/list/admin_ranks = list()								//list of all ranks with associated rights
+var/global/list/admin_ranks = list()								//list of all ranks with associated rights
 
 //load our rank - > rights associations
 /proc/load_admin_ranks()

code/modules/admin/admin_report.dm

@@ -24,7 +24,7 @@
 		else if(href_list["action"] == "edit")
 			C.edit_report(text2num(href_list["ID"]))
 
-var/datum/report_topic_handler/report_topic_handler
+var/global/datum/report_topic_handler/report_topic_handler
 
 world/New()
 	..()

code/modules/admin/admin_secrets.dm

@@ -1,4 +1,4 @@
-var/datum/admin_secrets/admin_secrets = new()
+var/global/datum/admin_secrets/admin_secrets = new()
 
 /datum/admin_secrets
 	var/list/datum/admin_secret_category/categories

code/modules/admin/admin_verb_lists.dm

@@ -1,5 +1,5 @@
 //admin verb groups - They can overlap if you so wish. Only one of each verb will exist in the verbs list regardless
-var/list/admin_verbs_default = list(
+var/global/list/admin_verbs_default = list(
 	/datum/admins/proc/show_player_panel,	//shows an interface for individual players, with various links (links require additional flags,
 	/client/proc/player_panel_new, //shows an interface for all players, with links to various panels,
 	/client/proc/player_panel,
@@ -15,7 +15,7 @@ var/list/admin_verbs_default = list(
 //	/client/proc/toggle_ahelp_sound,
 	)
 
-var/list/admin_verbs_admin = list(
+var/global/list/admin_verbs_admin = list(
 	/datum/admins/proc/set_tcrystals,
 	/datum/admins/proc/add_tcrystals,
 	/client/proc/invisimin,				//allows our mob to go invisible/visible,
@@ -110,18 +110,18 @@ var/list/admin_verbs_admin = list(
 	/client/proc/debug_global_variables
 	)
 
-var/list/admin_verbs_ban = list(
+var/global/list/admin_verbs_ban = list(
 	/client/proc/unban_panel,
 	/client/proc/jobbans
 	)
 
-var/list/admin_verbs_sounds = list(
+var/global/list/admin_verbs_sounds = list(
 	/client/proc/play_local_sound,
 	/client/proc/play_sound,
 	/client/proc/play_server_sound
 	)
 
-var/list/admin_verbs_fun = list(
+var/global/list/admin_verbs_fun = list(
 	/client/proc/object_talk,
 	/datum/admins/proc/cmd_admin_dress,
 	/client/proc/cmd_admin_gib_self,
@@ -142,7 +142,7 @@ var/list/admin_verbs_fun = list(
 	/client/proc/admin_lightning_strike,
 	)
 
-var/list/admin_verbs_spawn = list(
+var/global/list/admin_verbs_spawn = list(
 	/datum/admins/proc/spawn_fruit,
 	/datum/admins/proc/spawn_custom_item,
 	/datum/admins/proc/check_custom_items,
@@ -156,7 +156,7 @@ var/list/admin_verbs_spawn = list(
 	/client/proc/map_template_load_on_new_z
 	)
 
-var/list/admin_verbs_server = list(
+var/global/list/admin_verbs_server = list(
 	/datum/admins/proc/capture_map,
 	/client/proc/Set_Holiday,
 	/client/proc/ToRban,
@@ -189,7 +189,7 @@ var/list/admin_verbs_server = list(
 	/client/proc/dbcon_fix
 	)
 
-var/list/admin_verbs_debug = list(
+var/global/list/admin_verbs_debug = list(
 	/client/proc/getruntimelog,                     //allows us to access runtime logs to somebody,
 	/client/proc/cmd_admin_list_open_jobs,
 	/client/proc/Debug2,
@@ -239,25 +239,25 @@ var/list/admin_verbs_debug = list(
 	/client/proc/reload_webhooks
 	)
 
-var/list/admin_verbs_paranoid_debug = list(
+var/global/list/admin_verbs_paranoid_debug = list(
 	/client/proc/callproc,
 	/client/proc/callproc_datum,
 	/client/proc/debug_controller
 	)
 
-var/list/admin_verbs_possess = list(
+var/global/list/admin_verbs_possess = list(
 	/proc/possess,
 	/proc/release
 	)
-var/list/admin_verbs_permissions = list(
+var/global/list/admin_verbs_permissions = list(
 	/client/proc/edit_admin_permissions
 	)
-var/list/admin_verbs_rejuv = list(
+var/global/list/admin_verbs_rejuv = list(
 	/client/proc/respawn_character
 	)
 
 //verbs which can be hidden - needs work
-var/list/admin_verbs_hideable = list(
+var/global/list/admin_verbs_hideable = list(
 	/client/proc/deadmin_self,
 //	/client/proc/deadchat,
 	/datum/admins/proc/show_traitor_panel,
@@ -333,7 +333,7 @@ var/list/admin_verbs_hideable = list(
 	/datum/admins/proc/set_tcrystals,
 	/client/proc/debug_global_variables
 	)
-var/list/admin_verbs_mod = list(
+var/global/list/admin_verbs_mod = list(
 	/client/proc/cmd_admin_pm_context,	//right-click adminPM interface,
 	/client/proc/cmd_admin_pm_panel,	//admin-pm list,
 	/client/proc/debug_variables,		//allows us to -see- the variables of any instance in the game.,
@@ -363,7 +363,7 @@ var/list/admin_verbs_mod = list(
 	/datum/admins/proc/view_atk_log		//shows the server combat-log, doesn't do anything presently,
 )
 
-var/list/admin_verbs_event_manager = list(
+var/global/list/admin_verbs_event_manager = list(
 	/client/proc/cmd_event_say,
 	/client/proc/cmd_admin_pm_context,
 	/client/proc/cmd_admin_pm_panel,

code/modules/admin/banjob.dm

@@ -1,7 +1,7 @@
 //This file was auto-corrected by findeclaration.exe on 25.5.2012 20:42:32
 
-var/jobban_runonce			// Updates legacy bans with new info
-var/jobban_keylist[0]		//to store the keys & ranks
+var/global/jobban_runonce			// Updates legacy bans with new info
+var/global/jobban_keylist[0]		//to store the keys & ranks
 
 /proc/jobban_fullban(mob/M, rank, reason)
 	if (!M || !M.key) return

code/modules/admin/create_mob.dm

@@ -1,4 +1,4 @@
-/var/create_mob_html = null
+var/global/create_mob_html = null
 /datum/admins/proc/create_mob(var/mob/user)
 	if (!create_mob_html)
 		var/mobjs = null

code/modules/admin/create_object.dm

@@ -1,4 +1,4 @@
-/var/create_object_html = null
+var/global/create_object_html = null
 
 /datum/admins/proc/create_object(var/mob/user)
 	if (!create_object_html)

code/modules/admin/create_turf.dm

@@ -1,4 +1,4 @@
-/var/create_turf_html = null
+var/global/create_turf_html = null
 /datum/admins/proc/create_turf(var/mob/user)
 	if (!create_turf_html)
 		var/turfjs = null

code/modules/admin/holder2.dm

@@ -1,4 +1,4 @@
-var/list/admin_datums = list()
+var/global/list/admin_datums = list()
 
 /datum/admins
 	var/rank			= "Temporary Admin"

code/modules/admin/newbanjob.dm

@@ -1,4 +1,4 @@
-var/savefile/Banlistjob
+var/global/savefile/Banlistjob
 
 
 /proc/_jobban_isbanned(var/client/clientvar, var/rank)

code/modules/admin/verbs/check_customitem_activity.dm

@@ -1,5 +1,5 @@
-var/checked_for_inactives = 0
-var/inactive_keys = "None<br>"
+var/global/checked_for_inactives = 0
+var/global/inactive_keys = "None<br>"
 
 /client/proc/check_customitem_activity()
 	set category = "Admin"

code/modules/admin/verbs/mapping.dm

@@ -19,8 +19,8 @@
 //- Identify how hard it is to break into the area and where the weak points are
 //- Check if the area has too much empty space. If so, make it smaller and replace the rest with maintenance tunnels.
 
-var/camera_range_display_status = 0
-var/intercom_range_display_status = 0
+var/global/camera_range_display_status = 0
+var/global/intercom_range_display_status = 0
 
 GLOBAL_LIST_BOILERPLATE(all_debugging_effects, /obj/effect/debugging)
 
@@ -125,7 +125,7 @@ GLOBAL_LIST_BOILERPLATE(all_debugging_effects, /obj/effect/debugging)
 					qdel(F)
 	feedback_add_details("admin_verb","mIRD") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
 
-var/list/debug_verbs = list (
+var/global/list/debug_verbs = list (
         /client/proc/do_not_use_these
         ,/client/proc/camera_view
         ,/client/proc/sec_camera_report

code/modules/admin/verbs/playsound.dm

@@ -1,4 +1,4 @@
-var/list/sounds_cache = list()
+var/global/list/sounds_cache = list()
 
 /client/proc/play_sound(S as sound)
 	set category = "Fun"

code/modules/admin/verbs/striketeam.dm

@@ -1,5 +1,5 @@
 //STRIKE TEAMS
-var/const/commandos_possible = 6 //if more Commandos are needed in the future
+var/global/const/commandos_possible = 6 //if more Commandos are needed in the future
 
 /client/proc/strike_team()
 	set category = "Fun"