/atom New() => Initialize() [MDB IGNORE] (#8298)

* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
This commit is contained in:
MistakeNot4892
2021-11-14 19:09:14 +11:00
committed by GitHub
parent 0051b29ead
commit 2f0a618d45
589 changed files with 2903 additions and 3005 deletions

View File

@@ -10,7 +10,7 @@ somewhere on that shuttle. Subtypes of these can be then used to perform ship ov
var/list/whitelisted_types = list(/obj/effect/overmap/visitable/ship)
var/list/blacklisted_types = list()
/obj/machinery/computer/ship/New()
/obj/machinery/computer/ship/Initialize()
. = ..()
var/list/L = list()
for(var/type in whitelisted_types)

View File

@@ -191,11 +191,13 @@
light_color = "#ed9200"
anchored = 1
/obj/effect/engine_exhaust/New(var/turf/nloc, var/ndir, var/flame)
..(nloc)
/obj/effect/engine_exhaust/Initialize(var/ml, var/ndir, var/flame)
. = ..(ml)
if(flame)
icon_state = "exhaust"
nloc.hotspot_expose(1000,125)
if(isturf(loc))
var/turf/T = loc
T.hotspot_expose(1000,125)
set_light(0.5, 3)
set_dir(ndir)
QDEL_IN(src, 20)

View File

@@ -88,12 +88,10 @@
icon_state = "exhaust"
anchored = 1
New(var/turf/nloc, var/ndir, var/temp)
set_dir(ndir)
..(nloc)
if(nloc)
nloc.hotspot_expose(temp,125)
spawn(20)
loc = null
/obj/effect/engine_exhaust/Initialize(var/ml, var/ndir, var/temp)
set_dir(ndir)
. = ..()
if(isturf(loc))
var/turf/nloc = turf
nloc.hotspot_expose(temp,125)
QDEL_IN(2 SECONDS)

View File

@@ -5,13 +5,11 @@
known = 0
in_space = TRUE
/obj/effect/overmap/visitable/sector/temporary/Initialize(var/nx, var/ny)
/obj/effect/overmap/visitable/sector/temporary/Initialize()
. = ..()
loc = locate(nx, ny, global.using_map.overmap_z)
x = nx
y = ny
if(!map_z[1])
log_and_message_admins("Could not create empty sector at [nx], [ny]. No available z levels to allocate.")
log_and_message_admins("Could not create empty sector at [x], [y]. No available z levels to allocate.")
return INITIALIZE_HINT_QDEL
map_sectors["[map_z[1]]"] = src
@@ -48,10 +46,9 @@
var/obj/effect/overmap/visitable/sector/temporary/res = locate() in overmap_turf
if(istype(res))
return res
res = new /obj/effect/overmap/visitable/sector/temporary(x, y)
if(QDELETED(res))
res = null
return res
res = new /obj/effect/overmap/visitable/sector/temporary(overmap_turf)
if(!QDELETED(res))
return res
/atom/movable/proc/lost_in_space()
for(var/atom/movable/AM in contents)