/atom New() => Initialize() [MDB IGNORE] (#8298)

* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.

code/modules/pda/ai.dm

@@ -96,10 +96,10 @@
 		new/datum/data/pda/app/notekeeper,
 		new/datum/data/pda/app/messenger)
 
-/obj/item/device/pda/ai/pai/New(mob/living/silicon/pai/P)
-	if(istype(P))
-		our_owner = REF(P)
-	return ..()
+/obj/item/device/pda/ai/pai/Initialize()
+	if(istype(loc, /mob/living/silicon/pai))
+		our_owner = REF(loc)
+	. = ..()
 
 /obj/item/device/pda/ai/pai/tgui_status(mob/living/silicon/pai/user, datum/tgui_state/state)
 	if(!istype(user) || REF(user) != our_owner) // Only allow our pAI to interface with us

code/modules/pda/cart.dm

@@ -273,7 +273,8 @@ var/list/civilian_cartridges = list(
 	programs = list(new/datum/data/pda/utility/toggle_door)
 	messenger_plugins = list(new/datum/data/pda/messenger_plugin/virus/detonate)
 
-/obj/item/weapon/cartridge/syndicate/New()
+/obj/item/weapon/cartridge/syndicate/Initialize()
+	. = ..()
 	var/datum/data/pda/utility/toggle_door/D = programs[1]
 	if(istype(D))
 		D.remote_door_id = initial_remote_door_id

code/modules/pda/pda.dm

@@ -112,8 +112,8 @@ var/global/list/obj/item/device/pda/PDAs = list()
 		close(usr)
 	return 0
 
-/obj/item/device/pda/New(var/mob/living/carbon/human/H)
-	..()
+/obj/item/device/pda/Initialize()
+	. = ..()
 	PDAs += src
 	PDAs = sortAtom(PDAs)
 	update_programs()
@@ -121,7 +121,13 @@ var/global/list/obj/item/device/pda/PDAs = list()
 		cartridge = new default_cartridge(src)
 		cartridge.update_programs(src)
 	new /obj/item/weapon/pen(src)
-	pdachoice = isnull(H) ? 1 : (ishuman(H) ? H.pdachoice : 1)
+
+	if(ishuman(loc))
+		var/mob/living/carbon/human/H = loc
+		pdachoice = H.pdachoice
+	else
+		pdachoice = 1
+
 	switch(pdachoice)
 		if(1) icon = 'icons/obj/pda.dmi'
 		if(2) icon = 'icons/obj/pda_slim.dmi'
@@ -473,8 +479,8 @@ var/global/list/obj/item/device/pda/PDAs = list()
 	icon = 'icons/obj/pda.dmi'
 	icon_state = "pdabox"
 
-/obj/item/weapon/storage/box/PDAs/New()
-	..()
+/obj/item/weapon/storage/box/PDAs/Initialize()
+	. = ..()
 	new /obj/item/device/pda(src)
 	new /obj/item/device/pda(src)
 	new /obj/item/device/pda(src)

code/modules/pda/pda_subtypes.dm

@@ -43,7 +43,7 @@
 	default_cartridge = /obj/item/weapon/cartridge/mime
 	icon_state = "pda-mime"
 
-/obj/item/device/pda/mime/New()
+/obj/item/device/pda/mime/Initialize()
 	. = ..()
 	var/datum/data/pda/app/M = find_program(/datum/data/pda/app/messenger)
 	if(M)
@@ -128,7 +128,7 @@
 	desc = "A portable microcomputer by Thinktronic Systems, LTD. This is model is a WGW-11 series e-reader."
 	model_name = "Thinktronic 5290 WGW-11 Series E-reader and Personal Data Assistant"
 
-/obj/item/device/pda/librarian/New()
+/obj/item/device/pda/librarian/Initialize()
 	. = ..()
 	var/datum/data/pda/app/M = find_program(/datum/data/pda/app/messenger)
 	if(M)
@@ -171,44 +171,44 @@
 	)
 	var/list/cartridges_to_send_to = list()
 
-/obj/item/device/pda/multicaster/command/New()
-	..()
+/obj/item/device/pda/multicaster/command/Initialize()
+	. = ..()
 	owner = "Command Department"
 	name = "Command Department (Relay)"
 	cartridges_to_send_to = command_cartridges
 
-/obj/item/device/pda/multicaster/security/New()
-	..()
+/obj/item/device/pda/multicaster/security/Initialize()
+	. = ..()
 	owner = "Security Department"
 	name = "Security Department (Relay)"
 	cartridges_to_send_to = security_cartridges
 
-/obj/item/device/pda/multicaster/engineering/New()
-	..()
+/obj/item/device/pda/multicaster/engineering/Initialize()
+	. = ..()
 	owner = "Engineering Department"
 	name = "Engineering Department (Relay)"
 	cartridges_to_send_to = engineering_cartridges
 
-/obj/item/device/pda/multicaster/medical/New()
-	..()
+/obj/item/device/pda/multicaster/medical/Initialize()
+	. = ..()
 	owner = "Medical Department"
 	name = "Medical Department (Relay)"
 	cartridges_to_send_to = medical_cartridges
 
-/obj/item/device/pda/multicaster/research/New()
-	..()
+/obj/item/device/pda/multicaster/research/Initialize()
+	. = ..()
 	owner = "Research Department"
 	name = "Research Department (Relay)"
 	cartridges_to_send_to = research_cartridges
 
-/obj/item/device/pda/multicaster/cargo/New()
-	..()
+/obj/item/device/pda/multicaster/cargo/Initialize()
+	. = ..()
 	owner = "Cargo Department"
 	name = "Cargo Department (Relay)"
 	cartridges_to_send_to = cargo_cartridges
 
-/obj/item/device/pda/multicaster/civilian/New()
-	..()
+/obj/item/device/pda/multicaster/civilian/Initialize()
+	. = ..()
 	owner = "Civilian Services Department"
 	name = "Civilian Services Department (Relay)"
 	cartridges_to_send_to = civilian_cartridges
@@ -230,8 +230,8 @@
 	icon = 'icons/obj/pda.dmi'
 	icon_state = "pdabox"
 
-/obj/item/weapon/storage/box/PDAs/New()
-	..()
+/obj/item/weapon/storage/box/PDAs/Initialize()
+	. = ..()
 	new /obj/item/device/pda(src)
 	new /obj/item/device/pda(src)
 	new /obj/item/device/pda(src)

code/modules/pda/radio.dm

@@ -17,8 +17,8 @@
 	var/on = 0 //Are we currently active??
 	var/menu_message = ""
 
-/obj/item/radio/integrated/New()
-	..()
+/obj/item/radio/integrated/Initialize()
+	. = ..()
 	if(istype(loc.loc, /obj/item/device/pda))
 		hostpda = loc.loc
 	if(bot_filter)