/atom New() => Initialize() [MDB IGNORE] (#8298)

* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
This commit is contained in:
MistakeNot4892
2021-11-14 19:09:14 +11:00
committed by GitHub
parent 0051b29ead
commit 2f0a618d45
589 changed files with 2903 additions and 3005 deletions

View File

@@ -18,8 +18,8 @@
var/dpdir = 0 // directions as disposalpipe
var/base_state = "pipe-s"
/obj/structure/disposalconstruct/New(var/newturf, var/newtype, var/newdir, var/flipped, var/newsubtype)
..(newturf)
/obj/structure/disposalconstruct/Initialize(var/ml, var/newtype, var/newdir, var/flipped, var/newsubtype)
. = ..(ml)
ptype = newtype
dir = newdir
// Disposals handle "bent"/"corner" strangely, handle this specially.

View File

@@ -756,8 +756,8 @@
var/subtype = 0
// new pipe, set the icon_state as on map
/obj/structure/disposalpipe/New()
..()
/obj/structure/disposalpipe/Initialize()
. = ..()
base_icon_state = icon_state
return
@@ -1061,8 +1061,8 @@
/obj/structure/disposalpipe/segment
icon_state = "pipe-s"
/obj/structure/disposalpipe/segment/New()
..()
/obj/structure/disposalpipe/segment/Initialize()
. = ..()
if(icon_state == "pipe-s")
dpdir = dir | turn(dir, 180)
else
@@ -1075,8 +1075,8 @@
/obj/structure/disposalpipe/up
icon_state = "pipe-u"
/obj/structure/disposalpipe/up/New()
..()
/obj/structure/disposalpipe/up/Initialize()
. = ..()
dpdir = dir
update()
return
@@ -1125,8 +1125,8 @@
/obj/structure/disposalpipe/down
icon_state = "pipe-d"
/obj/structure/disposalpipe/down/New()
..()
/obj/structure/disposalpipe/down/Initialize()
. = ..()
dpdir = dir
update()
return
@@ -1180,8 +1180,8 @@
/obj/structure/disposalpipe/junction
icon_state = "pipe-j1"
/obj/structure/disposalpipe/junction/New()
..()
/obj/structure/disposalpipe/junction/Initialize()
. = ..()
if(icon_state == "pipe-j1")
dpdir = dir | turn(dir, -90) | turn(dir,180)
else if(icon_state == "pipe-j2")
@@ -1238,7 +1238,7 @@
else
name = initial(name)
/obj/structure/disposalpipe/tagger/New()
/obj/structure/disposalpipe/tagger/Initialize()
. = ..()
dpdir = dir | turn(dir, 180)
if(sort_tag) GLOB.tagger_locations |= sort_tag
@@ -1305,7 +1305,7 @@
dpdir = sortdir | posdir | negdir
/obj/structure/disposalpipe/sortjunction/New()
/obj/structure/disposalpipe/sortjunction/Initialize()
. = ..()
if(sortType) GLOB.tagger_locations |= sortType
@@ -1495,8 +1495,8 @@
// i.e. will be treated as an empty turf
desc = "A broken piece of disposal pipe."
/obj/structure/disposalpipe/broken/New()
..()
/obj/structure/disposalpipe/broken/Initialize()
. = ..()
update()
return