From 5dc47dd3ed3d86921844dde2baf1068e47be4c48 Mon Sep 17 00:00:00 2001
From: MarinaGryphon <ryfoxx93@gmail.com>
Date: Sun, 6 Jun 2021 04:36:52 -0500
Subject: [PATCH] Adds unit test for invalid recipes (#8119)

* Adds invalid recipe unit test

Checks for:
- Missing result type
- Result type is not /atom/movable (mob or obj)
- Result quantity unset
- Quantity less than or equal to zero
- Quantity is not an integer

* Update recipe_tests.dm

* adds tests to dme

* dont code at night (remix)

* Update recipe_tests.dm
---
 code/unit_tests/recipe_tests.dm | 29 +++++++++++++++++++++++++++++
 polaris.dme                     |  1 +
 2 files changed, 30 insertions(+)
 create mode 100644 code/unit_tests/recipe_tests.dm

diff --git a/code/unit_tests/recipe_tests.dm b/code/unit_tests/recipe_tests.dm
new file mode 100644
index 0000000000..a2d7594d0d
--- /dev/null
+++ b/code/unit_tests/recipe_tests.dm
@@ -0,0 +1,29 @@
+/datum/unit_test/recipe_test_shall_have_valid_result_and_quantity
+	name = "RECIPES: Recipes shall have valid result and result_quantity definitions"
+
+/datum/unit_test/recipe_test_shall_have_valid_result_and_quantity/start_test()
+	var/failed = FALSE
+	for(var/datum/recipe/R in subtypesof(/datum/recipe))
+		var/our_result = initial(R.result)
+		var/our_amount = initial(R.result_quantity)
+		if(!our_result)
+			log_unit_test("[R]: Recipes - Missing result.")
+			failed = TRUE
+		else if(!ispath(our_result, /atom/movable))
+			log_unit_test("[R]: Recipes - Improper result; [our_result] is not an obj or mob.")
+			failed = TRUE
+		if(isnull(our_amount))
+			log_unit_test("[R]: Recipes - result_quantity must be set.")
+			failed = TRUE
+		if(our_amount <= 0)
+			log_unit_test("[R]: Recipes - result_quantity must be greater than zero.")
+			failed = TRUE
+		else if(!ISINTEGER(our_amount))
+			log_unit_test("[R]: Recipes - result_quantity must be an integer.")
+			failed = TRUE
+
+	if(failed)
+		fail("One or more /datum/recipe subtypes had invalid results or result_quantity definitions.")
+	else
+		pass("All /datum/recipe subtypes had correct settings.")
+	return TRUE
diff --git a/polaris.dme b/polaris.dme
index fc622bfd31..af509d7e96 100644
--- a/polaris.dme
+++ b/polaris.dme
@@ -3229,6 +3229,7 @@
 #include "code\unit_tests\loadout_tests.dm"
 #include "code\unit_tests\map_tests.dm"
 #include "code\unit_tests\mob_tests.dm"
+#include "code\unit_tests\recipe_tests.dm"
 #include "code\unit_tests\research_tests.dm"
 #include "code\unit_tests\sqlite_tests.dm"
 #include "code\unit_tests\subsystem_tests.dm"