From 66a778b89a319fdd1d1d08ff6959466d7ed03a9b Mon Sep 17 00:00:00 2001
From: Mechoid <the60bucksisalie@gmail.com>
Date: Tue, 10 Mar 2020 23:00:08 -0700
Subject: [PATCH] Requests&Changeling

---
 .../spacesuits/rig/modules/specific/cloak.dm  |  3 +-
 .../rig/modules/specific/datajack.dm          | 16 +++-----
 .../spacesuits/rig/modules/specific/vision.dm |  4 +-
 html/changelogs/mechoid - RoboticsRigs.yml    | 38 +++++++++++++++++++
 4 files changed, 46 insertions(+), 15 deletions(-)
 create mode 100644 html/changelogs/mechoid - RoboticsRigs.yml

diff --git a/code/modules/clothing/spacesuits/rig/modules/specific/cloak.dm b/code/modules/clothing/spacesuits/rig/modules/specific/cloak.dm
index 797ce29efa..a1dfb05812 100644
--- a/code/modules/clothing/spacesuits/rig/modules/specific/cloak.dm
+++ b/code/modules/clothing/spacesuits/rig/modules/specific/cloak.dm
@@ -49,6 +49,5 @@
 	anim(get_turf(H), H, 'icons/effects/effects.dmi', "electricity",null,20,null)
 	H.alpha = initial(H.alpha)
 
-	for(var/mob/O in oviewers(H))
-		O.show_message("[H.name] appears from thin air!",1)
+	H.visible_message("[H.name] appears from thin air!")
 	playsound(get_turf(H), 'sound/effects/stealthoff.ogg', 75, 1)
\ No newline at end of file
diff --git a/code/modules/clothing/spacesuits/rig/modules/specific/datajack.dm b/code/modules/clothing/spacesuits/rig/modules/specific/datajack.dm
index 9848a5eea4..be34426447 100644
--- a/code/modules/clothing/spacesuits/rig/modules/specific/datajack.dm
+++ b/code/modules/clothing/spacesuits/rig/modules/specific/datajack.dm
@@ -44,18 +44,14 @@
 			to_chat(user, "<span class='warning'>The disk is blank. It is useless to you.</span>")
 		return 1
 
-	// I fucking hate R&D code. This typecheck spam would be totally unnecessary in a sane setup.
+	// I fucking hate R&D code. This typecheck spam would be totally unnecessary in a sane setup. Sanity? This is BYOND.
 	else if(istype(input_device,/obj/machinery))
 		var/datum/research/incoming_files
-		if(istype(input_device,/obj/machinery/computer/rdconsole))
-			var/obj/machinery/computer/rdconsole/input_machine = input_device
-			incoming_files = input_machine.files
-		else if(istype(input_device,/obj/machinery/r_n_d/server))
-			var/obj/machinery/r_n_d/server/input_machine = input_device
-			incoming_files = input_machine.files
-		else if(istype(input_device,/obj/machinery/mecha_part_fabricator))
-			var/obj/machinery/mecha_part_fabricator/input_machine = input_device
-			incoming_files = input_machine.files
+		if(istype(input_device,/obj/machinery/computer/rdconsole) ||\
+			istype(input_device,/obj/machinery/r_n_d/server) ||\
+			istype(input_device,/obj/machinery/mecha_part_fabricator))
+
+			incoming_files = input_device:files
 
 		if(!incoming_files || !incoming_files.known_tech || !incoming_files.known_tech.len)
 			to_chat(user, "<span class='warning'>Memory failure. There is nothing accessible stored on this terminal.</span>")
diff --git a/code/modules/clothing/spacesuits/rig/modules/specific/vision.dm b/code/modules/clothing/spacesuits/rig/modules/specific/vision.dm
index ec94ba3241..7e73f08880 100644
--- a/code/modules/clothing/spacesuits/rig/modules/specific/vision.dm
+++ b/code/modules/clothing/spacesuits/rig/modules/specific/vision.dm
@@ -193,13 +193,11 @@
 
 /obj/item/rig_module/vision/engage()
 
-	var/starting_up = !active
-
 	if(!..() || !vision_modes)
 		return 0
 
 	// Don't cycle if this engage() is being called by activate().
-	if(starting_up)
+	if(!active)
 		to_chat(holder.wearer, "<font color='blue'>You activate your visual sensors.</font>")
 		return 1
 
diff --git a/html/changelogs/mechoid - RoboticsRigs.yml b/html/changelogs/mechoid - RoboticsRigs.yml
new file mode 100644
index 0000000000..f7023732ea
--- /dev/null
+++ b/html/changelogs/mechoid - RoboticsRigs.yml	
@@ -0,0 +1,38 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes: 
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   maptweak
+#   spellcheck (typo fixes)
+#   experiment
+#################################
+
+# Your name.  
+author: Mechoid
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
+# Please surround your changes in  double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
+changes: 
+  - tweak: "Move Rig modules to more granular files"
+  - rscadd: "Add RIG components to robotics mechfab, plus incredibly basic belt-voidsuit RIG."
+  - rscadd: "Add Graphite, made by compressing coal, presently only used heavily in RIG components."