Updates Part Nine

code/modules/modular_computers/file_system/programs/_program.dm

@@ -7,7 +7,7 @@
 /obj/item/modular_computer/initial_data()
 	return get_header_data()
 
-/obj/item/modular_computer/update_layout()
+/obj/machinery/modular_computer/update_layout()
 	return TRUE
 
 /datum/nano_module/program

code/modules/modular_computers/file_system/programs/antagonist/dos.dm

@@ -24,14 +24,15 @@
 			dos_speed = NTNETSPEED_ETHERNET * NTNETSPEED_DOS_AMPLIFICATION
 	if(target && executed)
 		target.dos_overload += dos_speed
-		if(!target.is_operational())
+		if(!target.operable())
 			target.dos_sources.Remove(src)
 			target = null
 			error = "Connection to destination relay lost."
 
 /datum/computer_file/program/ntnet_dos/kill_program(var/forced)
-	target.dos_sources.Remove(src)
-	target = null
+	if(target)
+		target.dos_sources.Remove(src)
+		target = null
 	executed = 0
 
 	..(forced)

code/modules/modular_computers/file_system/programs/antagonist/hacked_camera.dm

@@ -24,6 +24,7 @@
 
 /datum/nano_module/camera_monitor/hacked
 	name = "Hacked Camera Monitoring Program"
+	//available_to_ai = FALSE
 
 /datum/nano_module/camera_monitor/hacked/can_access_network(var/mob/user, var/network_access)
 	return 1
@@ -33,4 +34,4 @@
 	networks.Add(list(list("tag" = NETWORK_MERCENARY, "has_access" = 1)))
 	networks.Add(list(list("tag" = NETWORK_ERT, "has_access" = 1)))
 	networks.Add(list(list("tag" = NETWORK_CRESCENT, "has_access" = 1)))
-	return networks 
+	return networks

code/modules/modular_computers/file_system/programs/camera.dm

@@ -36,7 +36,7 @@
 	var/obj/machinery/camera/current_camera = null
 	var/current_network = null
 
-/datum/nano_module/camera_monitor/ui_interact(mob/user, ui_key = "main", datum/nanoui/ui = null, force_open = 1)
+/datum/nano_module/camera_monitor/ui_interact(mob/user, ui_key = "main", datum/nanoui/ui = null, force_open = 1, state = default_state)
 	var/list/data = host.initial_data()
 
 	data["current_camera"] = current_camera ? current_camera.nano_structure() : null
@@ -92,14 +92,11 @@
 		return 1
 
 	else if(href_list["switch_network"])
-		if(!(href_list["switch_network"] in using_map.station_networks))
-			return
-
 		// Either security access, or access to the specific camera network's department is required in order to access the network.
 		if(can_access_network(usr, get_camera_access(href_list["switch_network"])))
 			current_network = href_list["switch_network"]
 		else
-			usr << "\The [nano_host()] shows an \"Network Access Denied\" error message."
+			to_chat(usr, "\The [nano_host()] shows an \"Network Access Denied\" error message.")
 		return 1
 
 	else if(href_list["reset"])
@@ -164,9 +161,10 @@
 
 /datum/nano_module/camera_monitor/ert
 	name = "Advanced Camera Monitoring Program"
+	//available_to_ai = FALSE
 
 // The ERT variant has access to ERT and crescent cams, but still checks for accesses. ERT members should be able to use it.
-/datum/nano_module/camera_monitor/hacked/modify_networks_list(var/list/networks)
+/datum/nano_module/camera_monitor/ert/modify_networks_list(var/list/networks)
 	..()
 	networks.Add(list(list("tag" = NETWORK_ERT, "has_access" = 1)))
 	networks.Add(list(list("tag" = NETWORK_CRESCENT, "has_access" = 1)))

code/modules/modular_computers/file_system/programs/card.dm

@@ -141,7 +141,7 @@
 								contents += "  [get_access_desc(A)]"
 
 						if(!computer.nano_printer.print_text(contents,"access report"))
-							usr << "<span class='notice'>Hardware error: Printer was unable to print the file. It may be out of paper.</span>"
+							to_chat(usr, "<span class='notice'>Hardware error: Printer was unable to print the file. It may be out of paper.</span>")
 							return
 						else
 							computer.visible_message("<span class='notice'>\The [computer] prints out paper.</span>")
@@ -151,7 +151,7 @@
 									[data_core ? data_core.get_manifest(0) : ""]
 									"}
 					if(!computer.nano_printer.print_text(contents,text("crew manifest ([])", stationtime2text())))
-						usr << "<span class='notice'>Hardware error: Printer was unable to print the file. It may be out of paper.</span>"
+						to_chat(usr, "<span class='notice'>Hardware error: Printer was unable to print the file. It may be out of paper.</span>")
 						return
 					else
 						computer.visible_message("<span class='notice'>\The [computer] prints out paper.</span>")
@@ -196,7 +196,7 @@
 								jobdatum = J
 								break
 						if(!jobdatum)
-							usr << "<span class='warning'>No log exists for this job: [t1]</span>"
+							to_chat(usr, "<span class='warning'>No log exists for this job: [t1]</span>")
 							return
 
 						access = jobdatum.get_access()

code/modules/modular_computers/file_system/programs/comm.dm

@@ -8,7 +8,7 @@
 	filedesc = "Command and communications program."
 	program_icon_state = "comm"
 	nanomodule_path = /datum/nano_module/program/comm
-	extended_desc = "Used to command and control the station. Can relay long-range communications."
+	extended_desc = "Used to command and control the station. Can relay long-range communications. This program can not be run on tablet computers."
 	required_access = access_heads
 	requires_ntnet = 1
 	size = 12
@@ -24,6 +24,7 @@
 
 /datum/nano_module/program/comm
 	name = "Command and communications program"
+	//available_to_ai = TRUE
 	var/current_status = STATE_DEFAULT
 	var/msg_line1 = ""
 	var/msg_line2 = ""
@@ -104,13 +105,15 @@
 	if(..())
 		return 1
 	var/mob/user = usr
-	var/ntn_comm = !!program.get_signal(NTNET_COMMUNICATION)
-	var/ntn_cont = !!program.get_signal(NTNET_SYSTEMCONTROL)
+	var/ntn_comm = program ? !!program.get_signal(NTNET_COMMUNICATION) : 1
+	var/ntn_cont = program ? !!program.get_signal(NTNET_SYSTEMCONTROL) : 1
 	var/datum/comm_message_listener/l = obtain_message_listener()
 	switch(href_list["action"])
 		if("sw_menu")
+			. = 1
 			current_status = text2num(href_list["target"])
 		if("announce")
+			. = 1
 			if(is_autenthicated(user) && !issilicon(usr) && ntn_comm)
 				if(user)
 					var/obj/item/weapon/card/id/id_card = user.GetIdCard()
@@ -118,31 +121,29 @@
 				else
 					crew_announcement.announcer = "Unknown"
 				if(announcment_cooldown)
-					usr << "Please allow at least one minute to pass between announcements"
-					SSnanoui.update_uis(src)
-					return
+					to_chat(usr, "Please allow at least one minute to pass between announcements")
+					return TRUE
 				var/input = input(usr, "Please write a message to announce to the station crew.", "Priority Announcement") as null|text
 				if(!input || !can_still_topic())
-					SSnanoui.update_uis(src)
-					return
+					return 1
 				crew_announcement.Announce(input)
 				announcment_cooldown = 1
 				spawn(600)//One minute cooldown
 					announcment_cooldown = 0
 		if("message")
+			. = 1
 			if(href_list["target"] == "emagged")
 				if(program)
 					if(is_autenthicated(user) && program.computer_emagged && !issilicon(usr) && ntn_comm)
 						if(centcomm_message_cooldown)
-							usr << "<span class='warning'>Arrays recycling. Please stand by.</span>"
+							to_chat(usr, "<span class='warning'>Arrays recycling. Please stand by.</span>")
 							SSnanoui.update_uis(src)
 							return
 						var/input = sanitize(input(usr, "Please choose a message to transmit to \[ABNORMAL ROUTING CORDINATES\] via quantum entanglement.  Please be aware that this process is very expensive, and abuse will lead to... termination. Transmission does not guarantee a response. There is a 30 second delay before you may send another message, be clear, full and concise.", "To abort, send an empty message.", "") as null|text)
 						if(!input || !can_still_topic())
-							SSnanoui.update_uis(src)
-							return
+							return 1
 						Syndicate_announce(input, usr)
-						usr << "<span class='notice'>Message transmitted.</span>"
+						to_chat(usr, "<span class='notice'>Message transmitted.</span>")
 						log_say("[key_name(usr)] has made an illegal announcement: [input]")
 						centcomm_message_cooldown = 1
 						spawn(300)//30 second cooldown
@@ -150,34 +151,35 @@
 			else if(href_list["target"] == "regular")
 				if(is_autenthicated(user) && !issilicon(usr) && ntn_comm)
 					if(centcomm_message_cooldown)
-						usr << "<span class='warning'>Arrays recycling. Please stand by.</span>"
+						to_chat(usr, "<span class='warning'>Arrays recycling. Please stand by.</span>")
 						SSnanoui.update_uis(src)
 						return
 					if(!is_relay_online())//Contact Centcom has a check, Syndie doesn't to allow for Traitor funs.
-						usr <<"<span class='warning'>No Emergency Bluespace Relay detected. Unable to transmit message.</span>"
-						SSnanoui.update_uis(src)
-						return
+						to_chat(usr, "<span class='warning'>No Emergency Bluespace Relay detected. Unable to transmit message.</span>")
+						return 1
 					var/input = sanitize(input("Please choose a message to transmit to Centcomm via quantum entanglement.  Please be aware that this process is very expensive, and abuse will lead to... termination.  Transmission does not guarantee a response. There is a 30 second delay before you may send another message, be clear, full and concise.", "To abort, send an empty message.", "") as null|text)
 					if(!input || !can_still_topic())
-						SSnanoui.update_uis(src)
-						return
+						return 1
 					CentCom_announce(input, usr)
-					usr << "<span class='notice'>Message transmitted.</span>"
+					to_chat(usr, "<span class='notice'>Message transmitted.</span>")
 					log_say("[key_name(usr)] has made an IA Centcomm announcement: [input]")
 					centcomm_message_cooldown = 1
 					spawn(300) //30 second cooldown
 						centcomm_message_cooldown = 0
 		if("shuttle")
+			. = 1
 			if(is_autenthicated(user) && ntn_cont)
 				if(href_list["target"] == "call")
 					var/confirm = alert("Are you sure you want to call the shuttle?", name, "No", "Yes")
 					if(confirm == "Yes" && can_still_topic())
 						call_shuttle_proc(usr)
+
 				if(href_list["target"] == "cancel" && !issilicon(usr))
 					var/confirm = alert("Are you sure you want to cancel the shuttle?", name, "No", "Yes")
 					if(confirm == "Yes" && can_still_topic())
 						cancel_call_proc(usr)
 		if("setstatus")
+			. = 1
 			if(is_autenthicated(user) && ntn_cont)
 				switch(href_list["target"])
 					if("line1")
@@ -194,8 +196,8 @@
 						post_status("alert", href_list["alert"])
 					else
 						post_status(href_list["target"])
-
 		if("setalert")
+			. = 1
 			if(is_autenthicated(user) && !issilicon(usr) && ntn_cont && ntn_comm)
 				var/current_level = text2num(href_list["target"])
 				var/confirm = alert("Are you sure you want to change alert level to [num2seclevel(current_level)]?", name, "No", "Yes")
@@ -214,9 +216,11 @@
 							if(SEC_LEVEL_BLUE)
 								feedback_inc("alert_comms_blue",1)
 			else
-				usr << "You press button, but red light flashes and nothing happens." //This should never happen
+				to_chat(usr, "You press button, but red light flashes and nothing happens.")//This should never happen
+
 			current_status = STATE_DEFAULT
 		if("viewmessage")
+			. = 1
 			if(is_autenthicated(user) && ntn_comm)
 				current_viewing_message_id = text2num(href_list["target"])
 				for(var/list/m in l.messages)
@@ -224,18 +228,19 @@
 						current_viewing_message = m
 				current_status = STATE_VIEWMESSAGE
 		if("delmessage")
+			. = 1
 			if(is_autenthicated(user) && ntn_comm && l != global_message_listener)
 				l.Remove(current_viewing_message)
 			current_status = STATE_MESSAGELIST
 		if("printmessage")
+			. = 1
 			if(is_autenthicated(user) && ntn_comm)
 				if(program && program.computer && program.computer.nano_printer)
 					if(!program.computer.nano_printer.print_text(current_viewing_message["contents"],current_viewing_message["title"]))
-						usr << "<span class='notice'>Hardware error: Printer was unable to print the file. It may be out of paper.</span>"
+						to_chat(usr, "<span class='notice'>Hardware error: Printer was unable to print the file. It may be out of paper.</span>")
 					else
 						program.computer.visible_message("<span class='notice'>\The [program.computer] prints out paper.</span>")
 
-	SSnanoui.update_uis(src)
 
 /datum/nano_module/program/comm/proc/post_status(var/command, var/data1, var/data2)
 

code/modules/modular_computers/file_system/programs/file_browser.dm

@@ -85,8 +85,16 @@
 		var/datum/computer_file/data/F = HDD.find_file_by_name(open_file)
 		if(!F || !istype(F))
 			return 1
-		// 16384 is the limit for file length in characters. Currently, papers have value of 2048 so this is 8 times as long, since we can't edit parts of the file independently.
-		var/newtext = sanitize(html_decode(input(usr, "Editing file [open_file]. You may use most tags used in paper formatting:", "Text Editor", F.stored_data) as message), 16384)
+		if(F.do_not_edit && (alert("WARNING: This file is not compatible with editor. Editing it may result in permanently corrupted formatting or damaged data consistency. Edit anyway?", "Incompatible File", "No", "Yes") == "No"))
+			return 1
+
+		var/oldtext = html_decode(F.stored_data)
+		oldtext = replacetext(oldtext, "\[editorbr\]", "\n")
+
+		var/newtext = sanitize(replacetext(input(usr, "Editing file [open_file]. You may use most tags used in paper formatting:", "Text Editor", oldtext) as message|null, "\n", "\[editorbr\]"), MAX_TEXTFILE_LENGTH)
+		if(!newtext)
+			return
+
 		if(F)
 			var/datum/computer_file/data/backup = F.clone()
 			HDD.remove_file(F)
@@ -235,5 +243,4 @@
 		ui.auto_update_layout = 1
 		ui.set_initial_data(data)
 		ui.open()
-
-
+#undef MAX_TEXTFILE_LENGTH

code/modules/modular_computers/file_system/programs/game.dm

@@ -69,7 +69,7 @@
 	data["gameover"] = gameover
 	data["information"] = information
 
-	ui = nanomanager.try_update_ui(user, src, ui_key, ui, data, force_open)
+	ui = SSnanoui.try_update_ui(user, src, ui_key, ui, data, force_open)
 	if (!ui)
 		ui = new(user, src, ui_key, "arcade_classic.tmpl", "Defeat [enemy_name]", 500, 350, state = state)
 		if(host.update_layout())
@@ -148,4 +148,4 @@
 		player_mana += regen
 		enemy_play()
 		check_gameover()
-		return 1 
+		return 1

code/modules/modular_computers/file_system/programs/news_browser.dm

@@ -0,0 +1,119 @@
+/datum/computer_file/program/newsbrowser
+	filename = "newsbrowser"
+	filedesc = "NTNet/ExoNet News Browser"
+	extended_desc = "This program may be used to view and download news articles from the network."
+	program_icon_state = "generic"
+	size = 8
+	requires_ntnet = 1
+	available_on_ntnet = 1
+
+	nanomodule_path = /datum/nano_module/program/computer_newsbrowser/
+	var/datum/computer_file/data/news_article/loaded_article
+	var/download_progress = 0
+	var/download_netspeed = 0
+	var/downloading = 0
+	var/message = ""
+
+/datum/computer_file/program/newsbrowser/process_tick()
+	if(!downloading)
+		return
+	download_netspeed = 0
+	// Speed defines are found in misc.dm
+	switch(ntnet_status)
+		if(1)
+			download_netspeed = NTNETSPEED_LOWSIGNAL
+		if(2)
+			download_netspeed = NTNETSPEED_HIGHSIGNAL
+		if(3)
+			download_netspeed = NTNETSPEED_ETHERNET
+	download_progress += download_netspeed
+	if(download_progress >= loaded_article.size)
+		downloading = 0
+		requires_ntnet = 0 // Turn off NTNet requirement as we already loaded the file into local memory.
+	SSnanoui.update_uis(NM)
+
+/datum/computer_file/program/newsbrowser/kill_program()
+	..()
+	requires_ntnet = 1
+	loaded_article = null
+	download_progress = 0
+	downloading = 0
+
+/datum/computer_file/program/newsbrowser/Topic(href, href_list)
+	if(..())
+		return 1
+	if(href_list["PRG_openarticle"])
+		. = 1
+		if(downloading || loaded_article)
+			return 1
+
+		for(var/datum/computer_file/data/news_article/N in ntnet_global.available_news)
+			if(N.uid == text2num(href_list["PRG_openarticle"]))
+				loaded_article = N.clone()
+				downloading = 1
+				break
+	if(href_list["PRG_reset"])
+		. = 1
+		downloading = 0
+		download_progress = 0
+		requires_ntnet = 1
+		loaded_article = null
+	if(href_list["PRG_clearmessage"])
+		. = 1
+		message = ""
+	if(href_list["PRG_savearticle"])
+		. = 1
+		if(downloading || !loaded_article)
+			return
+
+		var/savename = sanitize(input(usr, "Enter file name or leave blank to cancel:", "Save article", loaded_article.filename))
+		if(!savename)
+			return 1
+		var/obj/item/weapon/computer_hardware/hard_drive/HDD = computer.hard_drive
+		if(!HDD)
+			return 1
+		var/datum/computer_file/data/news_article/N = loaded_article.clone()
+		N.filename = savename
+		HDD.store_file(N)
+	if(.)
+		SSnanoui.update_uis(NM)
+
+
+/datum/nano_module/program/computer_newsbrowser
+	name = "NTNet/ExoNet News Browser"
+
+/datum/nano_module/program/computer_newsbrowser/ui_interact(mob/user, ui_key = "main", var/datum/nanoui/ui = null, var/force_open = 1, var/datum/topic_state/state = default_state)
+
+	var/datum/computer_file/program/newsbrowser/PRG
+	var/list/data = list()
+	if(program)
+		data = program.get_header_data()
+		PRG = program
+	else
+		return
+
+	data["message"] = PRG.message
+	if(PRG.loaded_article && !PRG.downloading) 	// Viewing an article.
+		data["title"] = PRG.loaded_article.filename
+		data["article"] = PRG.loaded_article.stored_data
+	else if(PRG.downloading)					// Downloading an article.
+		data["download_running"] = 1
+		data["download_progress"] = PRG.download_progress
+		data["download_maxprogress"] = PRG.loaded_article.size
+		data["download_rate"] = PRG.download_netspeed
+	else										// Viewing list of articles
+		var/list/all_articles[0]
+		for(var/datum/computer_file/data/news_article/F in ntnet_global.available_news)
+			all_articles.Add(list(list(
+				"name" = F.filename,
+				"size" = F.size,
+				"uid" = F.uid
+			)))
+		data["all_articles"] = all_articles
+
+	ui = SSnanoui.try_update_ui(user, src, ui_key, ui, data, force_open)
+	if (!ui)
+		ui = new(user, src, ui_key, "news_browser.tmpl", "NTNet/ExoNet News Browser", 575, 700, state = state)
+		ui.auto_update_layout = 1
+		ui.set_initial_data(data)
+		ui.open()

code/modules/modular_computers/file_system/programs/ntmonitor.dm

@@ -11,6 +11,7 @@
 
 /datum/nano_module/computer_ntnetmonitor
 	name = "NTNet Diagnostics and Monitoring"
+	//available_to_ai = TRUE
 
 /datum/nano_module/computer_ntnetmonitor/ui_interact(mob/user, ui_key = "main", var/datum/nanoui/ui = null, var/force_open = 1, var/datum/topic_state/state = default_state)
 	if(!ntnet_global)