Linter Introduction + Cleanup (#8085)

* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>

code/game/gamemodes/technomancer/core_obj.dm

@@ -30,7 +30,7 @@
 		"wizard's cloak"	= "wizard_cloak"
 		)
 
-	// Some spell-specific variables go here, since spells themselves are temporary.  Cores are more long term and more accessable than \
+	// Some spell-specific variables go here, since spells themselves are temporary.  Cores are more long term and more accessable than
 	// mind datums.  It may also allow creative players to try to pull off a 'soul jar' scenario.
 	var/list/summoned_mobs = list()	// Maintained horribly with maintain_summon_list().
 	var/list/wards_in_use = list()	// Wards don't count against the cap for other summons.

code/game/gamemodes/technomancer/equipment.dm

@@ -1,8 +1,5 @@
 /datum/technomancer/equipment/default_core
 	name = "Manipulation Core"
-//	desc = "The default core that you most likely already have.  This is here in-case you change your mind after buying \
-//	another core, don't forget to refund the old core.  This has a capacity of 10,000 units of energy, and recharges at a \
-//	rate of 50 units.  It also reduces incoming instability from functions by 20%."
 	desc = "The default core that you most likely already have.  This is here in-case you change your mind after buying \
 	another core, don't forget to refund the old core.<br>\
 	Capacity: 10k<br>\

code/game/gamemodes/technomancer/spell_objs_helpers.dm

@@ -53,7 +53,7 @@
 			continue
 		if(L.invisibility > owner.see_invisible) // Don't target ourselves or people we can't see.
 			continue
-		if(!L in viewers(owner)) // So we don't shoot at walls if someone is hiding behind one.
+		if(!(L in viewers(owner))) // So we don't shoot at walls if someone is hiding behind one.
 			continue
 		if(!L.stat) // Don't want to target dead people or SSDs.
 			chosen_target = L