Most items in the codebase have a slowdown multiplier of one, when slowdown is handled species-side in multiples of 0.5. This makes the effect of species slowdown almost non-existant when item slowdown is involved, and makes species that have item slowdown reduction (such as Unathi) unnaturally fast.
Do note that I also went through and removed odd slowdown numbers as well, as, due to the way slowdown is tied to tickrate, it should be done in intervals of 0.5.
I tried to view things on a case by case scenario but there will probably be changes that will need to be double checked.
Some items will be handled differently, I will list the exceptions below.
Boots of Speed: Kept at -1, it is boots of speed after all.
Chemistry Bag: Increased to 3. This should not really be toted around outside of chemistry.
Hybrid Tools: They already have a lot of other disadvantages, and are kind of hard to get, and 0.1 is a weird number for slowdown.
Site Manager's armor: Already 1.5
Unathi Breacher modules: These things are overpowered and Unathi already have a racial trait to virtually remove slowdown.
Voidsuits: Already done in intervals of 0.5, no change.
RHR Accellerator: This thing probably has appropriate slowdown values for what it is.
Utility suits: Already done in intervals of 0.5
Clothing/suits/armor: Already done in intervals of 0.5
This simplifies some very old and bad code, and unifies the admin/non-admin printing to avoid duplicate code.
Also fixes a number of bugs caused by ambiguous parens and various linter errors.
* Message piece combiner returns a list
* Emote formatter returns a list
* Port Runechat
* Various onamonapoea
* Suggested changes, small opts
* Fix chat message on different size mobs
* Couple more runefixes
* Enable encoding chat emphasis in runechat
* Remove extra asterisks from rune audible messages
* Fix runedefines
armour plate and armour plate inserts have the same sprite, name, and examine text in game. I can fix two of three things. You need to do stuff with amour plate inserts to make it fit in a plate carrier wile amour plate just will never fit
* Add icons for crablegs and crabmeat
* Build all vending machine inventories on startup (cursed)
* Fix cookie having no icon (convert everything to cookiesnack)
* Remove kabob with no actual definition
* Fix spicy burrito having no icon
* Adds linter defines to repo.
* Uncomments linter defines already in the code.
* Resolves unreachable code linter errors.
* Nukes decade+ old syndie specops code except for computer since that's mapped in?????
* Resolves procs has no parent linter error.
* Proc signature fixes
* Bad comments
* "In" danger
* Type safety
* Implied nested list abuse
* Top level ..() usage
* Sleepy coder typos
* Invalid kwargs calls
* Pointless returns
* Linter hacks (see full message)
Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.
Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.
* WHATEVER THIS IS
* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars
* Fix list decoration syntax - Its a list, not list of lists
- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax. Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`
* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.
* Fixes unwrapped negated object in list linter error.
* Resolves colon-like list accessing linter error.
* Turns linter on in linter config.
* Fixes closet indentation properly and cleans up suit storage unit switch.
Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
This should fix a bug where using blueprints to set a livable area on turfs without dynamic lighting (such as space) prevents dynamic lighting from properly initializing on turfs in that area.
Neerti