Commit Graph

375 Commits

Author SHA1 Message Date
Spookerton 978f4511a5 examine signature changed to include distance
- distance is INFINITE, 0, or a positive integer based on get_dist() between
the examiner and examinee's turfs when they are on the same Z. When the
examiner is dead or a ghost, distance is always 0.
- also updates /examine( implementations to use it!
- adds w_class_to_name proc for reusing "It is a X item." examine behavior.
2024-01-31 13:49:52 +00:00
atermonera a8a9054d08 Revert "SSmachines instancing PR (#9080)"
This reverts commit 4889b33cea.
2023-07-23 17:45:10 -08:00
enbyfriend 4889b33cea SSmachines instancing PR (#9080)
* Consistency Pass #1
Power cells of all types are now considered stock parts
Went through materials.dm and did some copy+paste work make material definitions consistent across the codebase (eg "steel" = 50 -> MAT_STEEL = 50)

* Machines are now instances in SSMachines

* Performance improvements by way of instancing all of SSmachines

* Fixes the powersink

* Revert "Consistency Pass #1"

This reverts commit cbeef1b5db.

* Update machines.dm

Styling changes

* Update machines.dm

* Update machines.dm

forgot to update the doc
2023-07-18 22:45:49 -08:00
klorpa f445ffde0a Spelling Fixes (#8973)
* SpellingFixes

* OtherTypos

* OtherTypos
2023-04-08 21:39:28 -08:00
Cerebulon 475a57d8fb Sounds for fabricators, mining machines, levers 2023-02-25 22:54:42 +00:00
Atermonera 56bf74c21f Merge pull request #8762 from Spookerton/spkrtn/sys/flagging
violently rearranges some flags and instance vars
2022-10-20 20:57:52 -08:00
Verkister 539dc0e67b Fixes a bug with deleted disposal outlets
Fixes deleted disposal outlets not unlinking their trunks, causing anything that the bare trunk tries to eject to runtime and get qdel'd instead.
2022-10-19 23:51:28 +03:00
spookerton 3abdbbaa1c replaces atom.initialized with ATOM_INITIALIZED
refactors atom/var/flags to atom_flags and area_flags
moves NOBLOODY, NOBLUDGEON, and PHORONGUARD to item_flags instead of atom_flags
corrects various misapplied flags
2022-10-18 09:36:36 +01:00
Spookerton 9a1b8322bd trained drakes can collect/drop items and use buttons, fire alarms, and levers (#8734)
* drakes can collect/drop items and use buttons

* add a basic implementation of mob dexterity levels

* trained drake emotes are less visually intrusive

also fixes being able to take anchored items as a drake
also fixes some double messages on drake storage
also fixes animals being able to attack/scratch doors without a cooldown
also adds optional scratch_sound on simple_mob for when scratching a door

* fire alarm & conveyor switch drake interactions

also fix runes for actions
also fix not showing progress for dropping an item

* trained drake button/inventory review tweaks

* animal harness suggestions early return tweak
2022-10-13 17:59:35 -08:00
spookerton 1ccb2df2de trivial 1:1 overlays -> overlay proc changes
NB. In some cases we go from a more complex image() to a single icon_state string and I assume this works for every case but do not care to check because of the sheer scale of extra fiddly effort. Buyer beware, not my code.
2022-04-24 07:50:21 +01:00
atermonera 9d71839ac6 Removes devices 2022-04-17 19:14:43 -08:00
atermonera 7a9806d9b4 Removes weapons 2022-04-17 19:14:32 -08:00
atermonera 101740a7d3 Updates icon paths 2022-04-17 19:14:07 -08:00
atermonera c7f1880394 Revert "What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)"
This reverts commit 4d8c43f106.
2022-03-29 16:01:32 -08:00
Atermonera 4d8c43f106 What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)
* get_tool_quality has numerical meaning

* Basic tools set tool quality

* Toolspeed is replaced by tool quality checks

* Addresses assorted results from live test

* Extra cleanup
2022-01-16 15:52:55 -08:00
MistakeNot4892 2f0a618d45 /atom New() => Initialize() [MDB IGNORE] (#8298)
* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
2021-11-14 00:09:14 -08:00
Atermonera 959511918c Replaces DEFAULT_WALL_MATERIAL with MAT_STEEL, where applicable (#8156)
* Replaces DEFAULT_WALL_MATERIAL with MAT_STEEL, where applicable

* floorbot compiles
2021-06-29 20:28:16 -07:00
MarinaGryphon 593246b595 Linter diagnostics + bans non-var relative pathing (#8150)
* Linter diagnostics + bans non-var relative pathing

* Enable DreamChecker Annotations

* make it executable

* update hashFiles

* oops

* tries to fix it... again

* trying again

* path

* repath

* fix perms

* fixes weird capitalisation issue
2021-06-20 13:14:29 -09:00
Neerti fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
MistakeNot4892 b22a0568a3 Sideports a couple of init unit tests from Neb. (#7893)
* Sideports a couple of init unit tests from Neb.

* Trying to unfuck initialize logic.

* Removing del()s.

* Adjusting return values to Initialize().

* Moving some dangerous object logic from obj onto the two types that use it.

* Rolling back some init changes and commenting out initialized atom unit test.

* this comment formatting is a minor war crime

* Removed sleep() from signaler circuit Initialize().

* Additional Init fixes post-rebase.

* Uncomments subsystem test since that's passing.
2021-02-21 12:03:34 -09:00
Mechoid 119bd1f458 Wall Disposals (#7816)
* Makes wall disposals.

* Tweak map for the disposal gods.

* Sprite Tweak
2021-01-14 21:56:35 -09:00
ShadowLarkens 983e7b8fc9 Merge remote-tracking branch 'upstream/master' into tgui_engineering 2020-12-24 04:50:24 -08:00
Hatterhat 8c790d91b4 A Thing About Digging Sand and Mineral Processor Speed (#7778)
* sand digging/mineral processor speed squashed

* typo moment + stacker also goes fast

Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com>
2020-12-21 18:34:40 -09:00
Mechoid 2018d76cae Department and Round Goals (#7369)
* Baseline work for Department Goals. Implements round-end stats, based in 3 categories of roughly-more-interesting to less interesting.

* Active Goal Separation.

* Map.

* Actually does the second half of this in this PR instead of a different one.
2020-12-11 15:16:47 -09:00
ShadowLarkens dad9020f9a TGUI Engineering... and a bunch of other random things 2020-10-21 13:02:19 -07:00
Rykka 0c7a7fd2b8 Massive Ambience and Sound Overhaul + Addition, Squashed Commit Edition 2020-08-21 06:53:05 -04:00
ShadowLarkens 971a95bc0a TGUI 4.0 & Camera Console 2020-07-30 17:48:11 -07:00
ShadowLarkens 9879c6744a Minor fix for not repeating checks that default state already does 2020-07-09 22:06:24 -07:00
ShadowLarkens c06a2d2cef TGUI v3.0
This ports TGUI, and makes the old nano crew monitor and the disposal
bins use it as first examples.
2020-07-09 22:06:23 -07:00
Kenzie 78957fd3cb fixes small package examination 2020-06-01 20:56:24 -04:00
Aronai Sieyes ad75bb86bd Alter playsound paradigm 2020-05-19 11:06:28 -04:00
Aronai Sieyes b7aae34335 Merge branch 'master' into pol-defaultparts 2020-05-05 22:51:02 -04:00
Atermonera 19468eaddc Merge pull request #7041 from VOREStation/vplk-disposal-consts
Slightly clean disposal pipe construction code.
2020-04-29 13:51:20 -07:00
Aronai Sieyes 6c6644f86c Rewrite examine() to pass a list around (#7038) 2020-04-29 13:42:16 -07:00
Aronai Sieyes b3e9960029 Move machines to use default_apply_parts() 2020-04-27 11:57:43 -04:00
Leshana 720e820ba1 Slightly clean disposal pipe construction code.
Portetd from YW, this replaces many hard coded constant numbers with defines for readability.
Also refactors the disposals pipe dispenser to use pipe recipes in a similar way that the atmos pipe dispenser does.
Also adds icon states to the pipe_recipe type since it was easily available in the source port and can be useful.
2020-04-25 15:17:58 -04:00
Aronai Sieyes 1d6e2ede7a Update code/modules/recycling/disposal.dm
Co-Authored-By: Leshana <Leshana@users.noreply.github.com>
2020-03-25 22:23:38 -04:00
Aronai Sieyes ad5f0485f7 Clean up things 2020-03-25 22:10:56 -04:00
Leshana c2d16acdca Always call update_use_power() instead of directly setting the use_power var.
- This will let us react to the change appropriately.
- While we're here, lets define some constants so we can stop using bare numbers.
- Always use those constants when calling update_use_power()
2020-03-21 16:40:22 -04:00
Cerebulon 52e6669bf9 Big Bastard Incidental Sound Port 2020-03-08 23:25:45 +00:00
Shadow 6088899908 Round One 2020-01-11 02:25:38 -06:00
Mechoid 90f8ca9f0d Mining Expansion, the Diggening. 2019-07-06 21:18:31 -07:00
Heroman af20e0e349 Fixes newly constructed conveyors not working 2019-04-13 06:05:53 +10:00
Heroman 24a3e04e03 Fixes conveyors being unable to go backwards 2019-04-08 08:15:18 +10:00
Anewbe aade8c356f Items are now assumed to be conductive, rather than the opposite 2019-03-02 20:34:49 -06:00
Neerti 76b077af4a Finishes seperating ZAS logic from CanPass(). 2019-02-10 01:46:38 -05:00
kevinz000 3cc35a1027 CanPass errors 2019-01-07 00:23:10 -08:00
Neerti 8ec3691911 Merge pull request #5770 from Atermonera/standard_rotation
Standardizes rotation verbs
2018-12-28 04:36:52 -05:00
kevinz000 ab3f30b28f Merge remote-tracking branch 'polaris/master' into PS_PORT_SCHEDULER 2018-12-09 20:34:39 -08:00
atermonera b8c9bb6c31 Standardizes rotation verbs 2018-12-08 21:27:10 -08:00