1428 Commits

Author SHA1 Message Date
Spookerton ebbf0e33fb between() -> clamp() & swaps args 1 and 2 in uses 2024-02-05 15:47:07 +00:00
Spookerton 978f4511a5 examine signature changed to include distance
- distance is INFINITE, 0, or a positive integer based on get_dist() between
the examiner and examinee's turfs when they are on the same Z. When the
examiner is dead or a ghost, distance is always 0.
- also updates /examine( implementations to use it!
- adds w_class_to_name proc for reusing "It is a X item." examine behavior.
2024-01-31 13:49:52 +00:00
MistakeNot4892 16ef531c64 Species shock vulnerability is now handled with a getter. 2023-08-14 15:55:20 +01:00
atermonera a8a9054d08 Revert "SSmachines instancing PR (#9080)"
This reverts commit 4889b33cea.
2023-07-23 17:45:10 -08:00
enbyfriend 4889b33cea SSmachines instancing PR (#9080)
* Consistency Pass #1
Power cells of all types are now considered stock parts
Went through materials.dm and did some copy+paste work make material definitions consistent across the codebase (eg "steel" = 50 -> MAT_STEEL = 50)

* Machines are now instances in SSMachines

* Performance improvements by way of instancing all of SSmachines

* Fixes the powersink

* Revert "Consistency Pass #1"

This reverts commit cbeef1b5db.

* Update machines.dm

Styling changes

* Update machines.dm

* Update machines.dm

forgot to update the doc
2023-07-18 22:45:49 -08:00
klorpa f445ffde0a Spelling Fixes (#8973)
* SpellingFixes

* OtherTypos

* OtherTypos
2023-04-08 21:39:28 -08:00
Atermonera 1809d95686 Merge pull request #9030 from Ilysen/if-i-dont-do-a-small-thing-here-and-there-im-gonna-melt
Fixes a small hiccup in cable coil examine text
2023-03-13 23:45:38 -08:00
MistakeNot4892 642348983f Fixing positional custom emotes. (#9011)
* Fixing positional custom emotes.

* see_emote cleanup.

* Further refinement work on custom emotes.

* Cleaning up some custom_emote() calls.
2023-03-08 19:33:25 -08:00
Ava d6e00dd400 Fixes a hiccup in cable coil examining 2023-03-06 05:37:15 -05:00
spookerton ffba11e5ab rename a bunch of atom flags 2022-10-18 09:36:41 +01:00
spookerton 3abdbbaa1c replaces atom.initialized with ATOM_INITIALIZED
refactors atom/var/flags to atom_flags and area_flags
moves NOBLOODY, NOBLUDGEON, and PHORONGUARD to item_flags instead of atom_flags
corrects various misapplied flags
2022-10-18 09:36:36 +01:00
MistakeNot4892 50c0648584 Lateload breaker boxes. 2022-08-27 12:49:07 +10:00
spookerton c6dfdeaae2 remove unused sources in code/* 2022-04-26 21:17:59 +01:00
Atermonera 21bd8477c7 Merge pull request #8531 from Spookerton/spkrtn/sys/global-agenda
updates all bare globals to use /global/ semantics, and all shared members to /static/
2022-04-24 19:56:07 -08:00
Atermonera 2a494dcb66 Merge pull request #8530 from Spookerton/cerebulon/ssoverlay
alt of 8336
2022-04-24 18:57:19 -08:00
spookerton 556331a6a3 use /global/ sugar for bare globals, no leading / 2022-04-24 07:54:34 +01:00
spookerton ee67e174fb use static for shared member vars 2022-04-24 07:52:32 +01:00
spookerton 1f3ffc2433 non-flagged, non-complex overlay -> ssoverlays 2022-04-24 07:51:12 +01:00
spookerton 1ccb2df2de trivial 1:1 overlays -> overlay proc changes
NB. In some cases we go from a more complex image() to a single icon_state string and I assume this works for every case but do not care to check because of the sheer scale of extra fiddly effort. Buyer beware, not my code.
2022-04-24 07:50:21 +01:00
spookerton a495456e36 fire loop behavior of SSalarm, GLOB alarm handlers 2022-04-24 07:40:38 +01:00
atermonera 9d71839ac6 Removes devices 2022-04-17 19:14:43 -08:00
atermonera 7a9806d9b4 Removes weapons 2022-04-17 19:14:32 -08:00
Cerebulon aba6293f8f ahem 2022-04-14 22:14:39 +01:00
Cerebulon 190df5af95 New stock part sprites 2022-04-14 22:10:01 +01:00
Atermonera 92d21dcc8c Merge pull request #8513 from Rykka-Stormheart/shep-dev-TGMC-ammo-HUD
TGMC Ammo HUD Port
2022-04-10 14:09:38 -08:00
Spookerton eafc8fabb6 Merge pull request #8504 from Atermonera/c420
C4 still explodes if the turf its placed upon changes
2022-04-09 11:02:59 +01:00
Rykka 3fd5296682 TGMC Ammo HUD Port
Ports over TGMC's Ammo HUD and all relevant code, adapted to work for Polaris's guns. This took me several days, but hey, I learned a bunch. <:
Time to port Aim Mode + Mentorhelp. :3c 
- All guns now have an ammo HUD sprite. If one lacks one, it will be ??? or blank, at which point, make an issue report, as all guns should be working by now.
- Guns will display how many rounds they have left until ammunition runs dry.
- Ammo will only count the casings that CURRENTLY have a projectile in them. This is slightly unrealistic, yes, but it is better and more intuitive for the player. This also enables guns like the revolver to work, given they recycle casings.
- Up to 4 ammo HUDs can be displayed at once, but given we lack TGMC's attachments and guncode, you'll only ever usually see 2. TBD on porting over TGMC guncode. <:
- Ammunition for multiple guns has different colors in the HUD based on what you currently have loaded.
- If you're looking at this later on to add new things. DON'T USE _FLASH IN THE HUD_STATE_EMPTY. THE _FLASH IS ADDED ON BY CODE.
- Grenades have a hud_state, pending us ever porting over a grenade launcher. Rockets ALSO have a hud_state.


Example of Laser/Energy Weapons:
https://i.imgur.com/MGvqGxh.mp4
Captain's Gun:
https://i.imgur.com/Wd0SS3C.gif

Full Test of all weapons:
https://streamable.com/usp4dy

Upstream port of https://github.com/CHOMPStation2/CHOMPStation2/pull/4033
2022-04-07 01:00:23 -06:00
atermonera 4368e99055 fiddlybits 2022-04-04 23:02:21 -08:00
atermonera 56a8fd834e C4 still explodes if the turf its placed upon changes 2022-04-02 19:13:04 -08:00
Atermonera 83ac485925 Merge pull request #8496 from Spookerton/spkrtn/sys/out-with-the-old-2
remove some obsolete defines
2022-04-02 17:46:13 -08:00
atermonera 35dbabff5d Revert "Reagent Geysers, Pump Fixing, Puddles. (#8268)"
This reverts commit 6996e46ed4.
2022-04-02 15:01:17 -08:00
spookerton 602cc67d2b removed CLAMP define 2022-03-31 19:21:58 +01:00
atermonera c7f1880394 Revert "What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)"
This reverts commit 4d8c43f106.
2022-03-29 16:01:32 -08:00
listerla 2b1360db68 Ports new supermatter sprite from Baystation
From https://github.com/Baystation12/Baystation12/pull/30803
2022-03-18 10:40:53 -04:00
spookerton e5023f92aa resolved sdmm-suite switch warnings 2022-03-04 19:30:36 +00:00
Cerebulon d3c648a09e Less Dreary Nightshift 2022-02-16 07:08:20 +00:00
Mechoid 6996e46ed4 Reagent Geysers, Pump Fixing, Puddles. (#8268)
* Reagent Geysers, Pump Fixing, Puddles.

* blah blah blah, CI fixes, linting, requested changes
2022-02-13 20:45:30 -08:00
Atermonera 4d8c43f106 What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)
* get_tool_quality has numerical meaning

* Basic tools set tool quality

* Toolspeed is replaced by tool quality checks

* Addresses assorted results from live test

* Extra cleanup
2022-01-16 15:52:55 -08:00
Atermonera 0232be9531 Repaths obj/effect/effect, datum/effect/effect [MDB_IGNORE] (#8312)
* Repaths obj/effect/effect, datum/effect/effect

* linter fixes

* No new

Co-authored-by: Atermonera <forslandm@gmail.com>
2022-01-16 00:14:39 -08:00
MistakeNot4892 2f0a618d45 /atom New() => Initialize() [MDB IGNORE] (#8298)
* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
2021-11-14 00:09:14 -08:00
Atermonera 9c4eceae2b Removes suicide_act() 2021-09-19 11:43:34 -08:00
Cerebulon 813049a8f2 Misc. Skyrat Sprites Port 2021-08-08 20:29:11 +01:00
klaasjared 4d66a12492 Base Commit 2021-07-26 22:12:40 -04:00
Atermonera 959511918c Replaces DEFAULT_WALL_MATERIAL with MAT_STEEL, where applicable (#8156)
* Replaces DEFAULT_WALL_MATERIAL with MAT_STEEL, where applicable

* floorbot compiles
2021-06-29 20:28:16 -07:00
Atermonera f97d1b884b Merge pull request #8152 from Hatterhat/wasted-waste
waste doesnt exist
2021-06-21 18:16:17 -07:00
MarinaGryphon 593246b595 Linter diagnostics + bans non-var relative pathing (#8150)
* Linter diagnostics + bans non-var relative pathing

* Enable DreamChecker Annotations

* make it executable

* update hashFiles

* oops

* tries to fix it... again

* trying again

* path

* repath

* fix perms

* fixes weird capitalisation issue
2021-06-20 13:14:29 -09:00
Hatterhat 11b810c262 waste doesnt exist 2021-06-20 08:20:22 -05:00
Neerti fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
ShadowLarkens c688399f60 Fix welding tools and cable coils as tools 2021-05-02 18:31:47 -07:00
Atermonera 0c0dcb1738 Oops, I refactored Chemistry! (#8013)
Reorganizes Reagents dir structure
Refactors reactions to /decl
SSChemistry is no longer processing

Optimization isn't so optimized
Updates to distillery
New decl repository methods
Further tweaks
2021-04-20 18:31:49 -09:00