* Adds linter defines to repo.
* Uncomments linter defines already in the code.
* Resolves unreachable code linter errors.
* Nukes decade+ old syndie specops code except for computer since that's mapped in?????
* Resolves procs has no parent linter error.
* Proc signature fixes
* Bad comments
* "In" danger
* Type safety
* Implied nested list abuse
* Top level ..() usage
* Sleepy coder typos
* Invalid kwargs calls
* Pointless returns
* Linter hacks (see full message)
Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.
Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.
* WHATEVER THIS IS
* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars
* Fix list decoration syntax - Its a list, not list of lists
- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax. Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`
* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.
* Fixes unwrapped negated object in list linter error.
* Resolves colon-like list accessing linter error.
* Turns linter on in linter config.
* Fixes closet indentation properly and cleans up suit storage unit switch.
Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
This makes it identical to it's real-life counterpart, and brings some actual sprite improvements upstream from Virgo.
Earlyport of https://github.com/VOREStation/VOREStation/pull/8812 with an actual rename of the gas, ID, and sprite used.
I actually forgot to do this before the event system went permanently live so that's on me.
Anyways this turns off swarmer drones from being able to be picked by the GM system, since right now they're, to put it charitably, poorly balanced and implemented (being super-maint drones is very clunky to me but thats not the main thing).
When the GM system spawns one in, it tends to result in a ghost becoming the drone, then that player essentially never being able to lose due to infinite re-tries and the crew has to fight off drones for the rest of the round or until they or the drone gets bored.
There's been quite a few number of rounds that have devolved due to them so for now it's probably best to turn them off for the time being.
Fancy that a downstream noticed this and got me to check all the way up here. So fix here, too for all the rest down the line.
Changelog Notes:
- Fixes typo in Solar Storm announcement with refrain being spelled "refain" instead.
- Best practice to avoid holding onto references to the subsystem instances aside from the global variables. (In case of restart/recover etc).
- The reference to GM was entirely unused by any event or meta-event. /datum/game_master would work fine using the global refs.
* Somewhat cleans up a piece of job code, makes new ID computers not be awful.
* Changes ROLE_ defines to DEPARTMENT_ to be clearer. Backports the new ID computer's assignment section of its UI to the old ID computer.
* Swaps back to southern cross map.
* Removes a block of commented code.
* Fixes 6 pAI faces
PAIs are no longer coded to only recognize 9 emotions. This enables the use of the neutral, silly, nose, smirk, exclamation points, and question mark faces as a pAI. Before, those buttons did nothing.
* Fixes the PDA Halogen Scanner's tendency to be number one.
* Unfolded pAIs can be picked up
Because who doesn't want a robotic cat on their head? Adds in the missing code to allow pAIs to actually be picked up, and held sprites for the newer 4 chassis options.
* Adds the Gigaphone, a suped-up Megaphone.
* Constant Chip has a sprite
* Fireaxe cabinets find their fireaxes in initialize(), rather than new()
* Speeds up alcohol
* fixed mining cloak not being in loadouts
* Admin Supermatter Setup now closes the monitoring room shutters (#5442)
* Admin Supermatter Setup now closes the monitoring room shutters
* Fixes a copy-paste error
* Begins work on lightning.
* Fixes#5447 (Deadspy submap not overwriting mapgen) (#5448)
* Map fix
* fixed deadspy.dmm
* Added Squid plushies of varying colours
I added a few Squid plushies in different colours, changing the files code/game/objects/items/toys.dm
and obj/toy.dmi
* Added hat functionality to Squid plushies
I added the ability to wear my Squid plushies as hats. They're damn good hats.
* Replaces Skrell namegen (#5453)
Created a first name list for Skrell, to replace the syllable assembler.
Created a surname list for Skrell to replace the syllable assembler.
Replaced the Skrell namegen with pre-written namelists, instead of the old syllable assembler.
* Mechoid makes mistakes. Fix telepathic gigaphones.
* Lets people be colorblind
Adds four types of colorblindness to the traits in the setup menu - protanopia, deuteranopia, tritanopia, and monochromacy. Previously, there were ones defined in the code, but not actually usable to players.
* Whoops, worded that wrong
* Adds beams to the Type var list for View Variables.
* Unfuck my Master
* Adds beams to the Type var selection in View Variables.
* Finishes thunderstorms.
* Adds logging.
* APC Sprite Change
- Port from Virgo recolored slightly to match closer to the old sprite
- Addition of directional sprites for the APCs
* Refactors supply controller.
Supply consoles now run nanoUI
* Missing '
* [Excitedly updates changelog]
* btw i use arc
* Removes supermatters from cave PoIs.
* Holomap Port
- Port of Holomaps from Virgo
* Changing species (via ling or admin button) should no longer ruin your HUD
* Converts most istype(thing,tool) procs into an appropriate thing.is_tool() format
* Removes empty file, gives the QM a control console again (Was replaced with an ordering console)
* Hopefully fixes some tool-conversion things
* Makes the Northern Star still compile
* Keeps NS up to date
* Taj and Unathi should have explorer mask sprites now
* Corgi rune now summons the corgi in a flash of harmless lightning
* Forces mech construction to work with the is_tool() procs
* Various things and floors no longer associate with dirt
* MultiZ falling tweaks
* Fixes the clusterbang grenade
* Added new hairstyles
* Added new hairstyles
* Fixes spelling of Strike in Lightning Strike admin verb
* I don't know how we keep breaking falling
* Hallucinations now use the old system again, but with the more modern components.
* Ambience Refactor (#5476)
* Refactors how ambience is assigned, removes bad ambience, ports good ambience from tg
* Apparently that file is still used, not worth the salt to remove it.
* Changelog
* The speed-related chem effects are no longer a one-or-none affair, oxy causes slowdown
* Corrects noted issues
* Add some missing sprites for xenoarch excavation.
* Become thwarted, thot.
* Fixes the Ultra AC2's burstfire bug.
* The Major Bill's shuttle is actually contagious now.
* penguins are from earth
capitalize this, anewbe, i dare you
* Mechoid's a butt
* Adds new job/department specific teshari clothing to the loadout (#5481)
* adding the new department specific teshari outfits
* Slightly cleans up hooded suit code (#5471)
* FBPs can have brute damage repaired externally again
* Windoors fix
* Cleans up some largecrate code
* Weather refactor.
* NanoUI makes me sad.
* Drinking more booze gets you drunk faster
* Ports the supermatter grenade, supporting code
* May or may not make movement seem smoother
* Fixes the Sleepy Ring
* Partially ports the GLOB system
* Fixes the bug(s) that allow meat bodies to have metal brains
* ports VOREStation/VOREStation#4165 - i forgot to check if advanced who was a thing here
* Optimizes supply UI
* Transfer shuttle grammar fixes
* Fixes borked E and W fish sprites
* Fixes incorrect ETA in crew transfer announcement
* Mech Mini 'Revamp'. Will need playtesting. (#5480)
* Exosuits are now capable of holding more equipment, of specific types.
* Tweaks regarding feedback in staffside thread, other concerns.
* Tweak to be more consistent. Why did the Odysseus have two universals. Tweak to weapon restriction on Med - > Odyss
* Weapons only fit in universal combat slots.
* Adds smart magazine, magazine functionality
* Adds a new subset of grenades that shoot projectiles
* Low alpha now makes HUDs and tooltips not show up on you
* Fixes a UI bug with emptying currently-open bags into smartfridges...hopefully. (#5515)
* Update smartfridge.dm
* actually indicates which line solves the bug
* Adds a whole bunch of Exosuit weapons and other miscellaneous parts.
* Minifrags now use the small fragments mainly as they should.
* Iced beer no longer freezes you to 3 degrees C, which is enough to seriously burn a Skrell. Seriously, that's weird.
* Touch stuff in reference to responses.
* NanoUI now processes again
* Converts more simple_animal mobs to simple_mob
* Submap correction
Somewhere on the station, a gas canister is faulty and ruptures, releasing its contents (no explosion).
* Added as an event_manger event. This version is nice on low severity and picks a canister with nobody nearby.
* Also added as a gamemaster event.
* Added helper method to check area occupancy.
