Commit Graph

112 Commits

Author SHA1 Message Date
Neerti
9fcb71dde4 Fixes double chat bug. 2021-07-16 16:15:48 -04:00
MarinaGryphon
593246b595 Linter diagnostics + bans non-var relative pathing (#8150)
* Linter diagnostics + bans non-var relative pathing

* Enable DreamChecker Annotations

* make it executable

* update hashFiles

* oops

* tries to fix it... again

* trying again

* path

* repath

* fix perms

* fixes weird capitalisation issue
2021-06-20 13:14:29 -09:00
Aronai Sieyes
1fd1d84deb Runechat (#8121)
* Message piece combiner returns a list

* Emote formatter returns a list

* Port Runechat

* Various onamonapoea

* Suggested changes, small opts

* Fix chat message on different size mobs

* Couple more runefixes

* Enable encoding chat emphasis in runechat

* Remove extra asterisks from rune audible messages

* Fix runedefines
2021-06-13 22:18:43 -09:00
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
MistakeNot4892
2b48ef76c8 Ported the Nebula emote system. 2021-03-27 10:24:14 +11:00
Atermonera
dfd0844701 Merge pull request #7989 from Atermonera/roofing_fix
Fixes roofing tiles not working in multiz areas
2021-03-25 09:08:31 -09:00
MistakeNot4892
0b5bb3fbf0 Allows Teshari to glide in some multiz fall conditions. (#7990)
* Allows Teshari to glide in some multiz fall conditions.

* Carried mobs will now fall off you if you go prone.
2021-03-21 17:58:26 -09:00
atermonera
3d85bf7369 Fixes roofing tiles not working in multiz areas 2021-03-19 01:05:30 -09:00
atermonera
d844cd87d2 Downwards transition happens on stair uncrossed 2021-03-04 20:13:07 -09:00
atermonera
aab9d22f98 Ghosts don't use stairs 2021-03-03 22:28:23 -09:00
atermonera
b2ca155477 Fixes stairs being wonky for fast, buckled mobs
Fixes thrown objects being catapulted to the max range when thrown up/down stairs
2021-03-02 12:11:45 -09:00
MistakeNot4892
e67c35e751 Removes transform from speech bubbles when speaker is scaled at less than 2x. (#7927)
* Resets scaling and colour on the typing indicator.

* Refactoring speech bubble generation.
2021-02-28 14:08:36 -09:00
MistakeNot4892
b22a0568a3 Sideports a couple of init unit tests from Neb. (#7893)
* Sideports a couple of init unit tests from Neb.

* Trying to unfuck initialize logic.

* Removing del()s.

* Adjusting return values to Initialize().

* Moving some dangerous object logic from obj onto the two types that use it.

* Rolling back some init changes and commenting out initialized atom unit test.

* this comment formatting is a minor war crime

* Removed sleep() from signaler circuit Initialize().

* Additional Init fixes post-rebase.

* Uncomments subsystem test since that's passing.
2021-02-21 12:03:34 -09:00
Atermonera
0c22294a90 Removes testing logs that were left in on stairs (#7791)
* Rewrites stairs

* Stairs go up and down

* Adds animation

* Polishes movement interactions.

* Grabs are moved across stairs, adds changelog

* Removes debug logs
2020-12-21 00:33:20 -08:00
Atermonera
47f71b2adb Reworks stairs to be sensible (#7783)
* Rewrites stairs

* Stairs go up and down

* Adds animation

* Polishes movement interactions.

* Grabs are moved across stairs, adds changelog
2020-12-13 16:25:13 -08:00
Atermonera
8dc9ba1385 Ladders respect Move Up/Down paradigm (#7559) 2020-08-27 18:37:35 -07:00
Atermonera
5714d64b8d Actually adds (and TESTS) exclude_mobs parameter to visible_message (#7555) 2020-08-24 21:29:55 -07:00
Atermonera
f621edf039 Adds overmap sensors to the Southern Cross (#7436)
* Enables overmap on SC, adds wip Sif to SC skybox

* codersprites

* Adds overmap sensors to the Southern Cross
2020-08-12 18:31:19 -07:00
Leshana
07d483203d Fix sector initialization stack overflow crash.
- Replace changes from 8c7371c5d4
    - Removed debugging prints in skybox generation
    - Reverted change to GetConnnectedZLevels to avoid the chicken-or-egg initialization issue of find_z_levels() requiring knowledge of a sector's z-levels during the attempt to determine a sector's z-levels.
    - Make find_z_levels() always called again so that lazy open space initialization works on landable ships again.
- Instead, allow static configuration of sector map_z to override the default behavior of calling GetConnectedZLevels()
2020-06-25 10:40:22 -04:00
Atermonera
80c1557263 Enables overmap on SC, adds Sif to SC skybox (#6954)
* Enables overmap on SC, adds wip Sif to SC skybox

* codersprites
2020-06-17 16:12:20 -07:00
Atermonera
6ab622a2b5 Merge pull request #7205 from VOREStation/Arokha/playsound
Alter playsound paradigm
2020-05-28 16:05:59 -07:00
Atermonera
551fc88ce1 Merge pull request #7204 from VOREStation/Arokha/performance
Performance improvements
2020-05-28 12:47:08 -07:00
Aronai Sieyes
c0f1feb351 Move openspace object updating to event listeners 2020-05-19 16:29:43 -04:00
Aronai Sieyes
ad75bb86bd Alter playsound paradigm 2020-05-19 11:06:28 -04:00
Aronai Sieyes
c62de5048f Port Bay's Catwalks (#7083)
* Port Bay's Catwalks

Allows for various new funtimes.

* Always initialize plated catwalks for you

* Allow climbing up and falling through opened plated catwalks

* 2 catwalk fixes, climbing and decon

* Use turf test helpers

* Update structure loops
2020-05-17 20:56:30 -07:00
Aronai Sieyes
a8f3a0a7a0 Refactor move/click code 2020-05-15 10:49:27 -04:00
Aronai Sieyes
eff72a9850 Merge branch 'master' into pol-moved 2020-05-12 11:22:43 -04:00
Aronai Sieyes
6c6644f86c Rewrite examine() to pass a list around (#7038) 2020-04-29 13:42:16 -07:00
Aronai Sieyes
bc1fa7bd05 Refactor Move() code 2020-04-27 10:08:55 -04:00
Atermonera
ab179d74a2 Space spaced through open space looks like space (#7018)
* Space spaced through open space looks like space

* Unnecessary update_icon
2020-04-26 00:23:14 -07:00
ShadowLarkens
54a8a5823d Saycode Overhaul -- Multilingualism (#6956)
* Port ParadiseSS13/Paradise#2100 - Saycode refactor

* Removed unused old carbon slimes code

* Port ParadiseSS13/Paradise#5099 - Saycode part 2

* Ported ParadiseSS13/Paradise#7170's /datum/browser Check Known Languages

* Port ParadiseSS13/Paradise#9240 - Get rid of alt_name in favor of GetAltName()

* Port ParadiseSS13/Paradise#10330 - You can now use multiple languages in one message

* Addressed Atermonera's review.

Translators now print the full message if they find any languages within the
message that the user doesn't understand, minus languages it cannot translate.

Additionally, the combine_message proc has been significantly simplified
by eliminating an ugly tree structure with the help of a little helper
proc.

The removal of the extra span inside each piece doesn't seem to have
visually changed the messages in any other way than changing where the
wordwrap happens, strangely enough. Must be something in IE's code being
picky about invisible elements. On the bright side, it splits *later*
than it did before, thus reducing the lines a message will take up by a
tiny amount.

Also, a bunch of things now have the 'filter_say' class from
PolarisSS13/Polaris#6998. Since span classes with no definition are
totally valid and just don't do anything, this PR does **not** depend on
that PR being merged first.

* Always gotta be one
2020-04-20 01:11:53 -07:00
Leshana
f8755f2de5 Fix openspace redering of under-objects that have no main icon (only over/underlays)
In particular stops manifolds from getting the openspace "map" icon state as its main icon instead of null.
2020-04-14 09:40:19 -04:00
Leshana
5dbf08b462 Refactor the Open Space controller into MC Subsystem
- Basically just refactor doWork() into fire() with the capablity to return in the middle with MC_TICK_CHECK.
- Move some vars around to be more organized.
- Only functional change is that when a turf is queued twice in one cycle, the second queue moves it to the end of the list instead of it being in the queue twice
2020-04-14 09:38:23 -04:00
Leshana
2d37c09d12 Commit move of open_space_controller.dm to subsystems folder to track history through rename. 2020-04-14 09:37:58 -04:00
Aronai Sieyes
1abf90b306 Add 2 new pipe types 2020-04-05 22:50:11 -04:00
Aronai Sieyes
7a571f68b0 Small mech tweaks 2020-03-20 20:00:59 -04:00
Atermonera
55cd990598 Merge pull request #6826 from VOREStation/vplk-landmark-shuttles
Port Landmark Shuttles
2020-03-19 15:14:47 -07:00
Neerti
2b9924bea3 Makes walk intent protect you from lagging into lava. (#6841) 2020-03-16 02:50:53 -07:00
Aronai Sieyes
339625bd3a Missed a good place to check is_incorporeal (#6832) 2020-03-16 02:00:12 -07:00
Leshana
85d3cbfa12 Replaced "area" shuttles with "landmark" shuttles.
Largely ported from the work done at Baystation in Baystation12#17460 and later commits.

 - Shuttles no longer require a separate area for each location they jump to.
   Instead destinations are indicated by landmark objects, which are not necessarily exclusive to that shuttle.
   This means that more than one shuttle could use the same docking port (not at the same time of course).
 - Enhanced shuttle control computers to use nanoui if they didn't.
 - Organizes shuttle datum code a bit better so there is less re-inventing the wheel in subtypes.
 - Allows the possibility of shuttles (or destinations) that start on late-loaded maps.
 - Deprecate the "extra" shuttle areas that are no longer needed and update shuttle areas in unit tests

This all required a bit of infrastructure improvements.

 - ChangeArea proc, for changing the area of a turf.
 - Fixed lighting overlays actually being able to be destroyed.
 - Added a few utility macros and procs.
 - Added "turf translation" procs which are like move_contents_to but more flexible.

(cherry picked from commit c837078105)
2020-03-13 00:26:08 -04:00
Aronai Sieyes
d391d9ab12 Mobs can be incorporeal (#6791)
* Mobs can be incorporeal

Prevents step noises, getting shot, etc. Basically living ghosts. Feel free to add more places this should check, but I think this is a majority.

* Fix missing incorporeal floatyness
2020-03-10 22:33:38 -07:00
Tad Hardesty
f44d31451e Fix remaining diagnostics 2020-01-18 23:01:36 -08:00
Unknown
b309f25e2b Multi-Z connectivity no longer limited by bit field
Port of Baystation PR  (#19832)
2019-11-22 08:34:38 -05:00
Neerti
42bd6eb1c2 Merge pull request #6105 from Heroman3003/climbybois
Fixes borgs being unable to use ladders
2019-04-22 00:26:44 -04:00
Heroman
1ed8d06a92 Fixes copypaste mistake in robot climbing 2019-04-19 06:07:13 +10:00
Heroman3003
8a14c0eaf9 Fixes borgs being unable to use ladders 2019-04-17 13:04:36 +10:00
Heroman3003
a5968047f6 Fixes newly constructed vertical pipes being invisible 2019-04-16 11:58:49 +10:00
Neerti
524d20f997 Merge pull request #6043 from Heroman3003/zshadow-fixes
Fixes way elevator handles deleting z-shadows
2019-04-09 17:47:14 -04:00
Neerti
a992d27749 Merge pull request #6050 from Heroman3003/ladder-fixaroo
Fixes being unable to climb ladders you're already on
2019-04-08 15:18:53 -04:00
Neerti
53e9641cc6 Merge pull request #6045 from Heroman3003/stairs-layer
Fixes items rendering below stairs
2019-04-08 11:58:17 -04:00