Commit Graph

8 Commits

Author SHA1 Message Date
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Unknown
2fa409b3a9 Fixes Indentation 2019-05-27 00:52:32 -04:00
Unknown
2b0367c5c6 Tries another fix 2019-05-27 00:49:13 -04:00
Unknown
ccd4ac3ae9 Replaces Timer SS with Bay Port
I have no clue how to code or debug subsystems, this is just my desperate attempt to fix the constant timer subsystem crashes on Virgo.
2019-05-26 23:52:03 -04:00
kevinz000
a0c78d09d2 Stufffff 2018-10-15 16:07:29 -07:00
kevinz000
ab3ce0455e Based MSO <3 2018-10-15 08:44:46 -07:00
kevinz000
c972d57620 Stuff 2018-10-14 23:15:25 -07:00
kevinz000
84ea3c0931 JFC 2018-10-14 19:45:38 -07:00