Commit Graph

15532 Commits

Author SHA1 Message Date
Leshana
092f415375 Fix Sundry Runtime Errors XII (#7007)
* Fix Runtime in atoms_movable.dm,597: list index out of bounds

* Fix Runtime in floor_attackby.dm,118: Cannot execute 0.is crowbar().

* Fix null values being present in mob_list.

* Another fix for Runtime in update_icons.dm,254: Cannot execute null.GetUIState().

- This time lets just ensure dna is instantiated no matter who is calling dress_preview_mob().

* Fix Runtime in suit_storage_unit.dm,792: Cannot execute null.set machine().

- Also fixed other mixups of usr vs. user that I found in the same file.

* Fixes Runtime in find_spawning.dm,688: Cannot read null.origin_tech

- if this else if block is reached, new_item must not exist, so we obviously can't set origin_tech on it. Examination of the code seems to suggest the original author intended that for any "talking" items to have arcane and precursor tech; since src is now being made talking, src should get the tech.

* Fix talking artifacts downgrading arcane/precursor tech

- Bump up the values by one for talking artifact items instead of overwriting whatever the value was.
2020-04-22 12:44:35 -07:00
Atlantiscze
a9af839845 Fixes Phazon and Janus being unable to phase
- Fixes #6302
2020-04-22 15:52:00 +02:00
Leshana
21c8c94971 Fix remaining code that directly modified use_power to call update_use_power. 2020-04-21 13:15:32 -04:00
Leshana
66b40b2c71 Call update procs instead of directly setting idle_power_usage or active_power_usage.
- Adds the update_idle_power_usage() and update_active_power_usage() procs for the respective vars.
- Switches all places modifying those vars directly to call the procs instead.
- This will let us react to the change appropriately, paving the way towards static area power.
- Adds update_power_channel proc for the sake of completeness, but no machines actually modify it so far.
2020-04-21 12:53:05 -04:00
Atlantiscze
131270c6f8 Converts Shutoff valve monitoring into a MC program
- Existing consoles remain for now, only refactored to use a shared nano_module. Included by default on engineering consoles, downloadable by anyone with basic engineering access.
- Tidies up the UI a bit, prevents manual toggling of valves when they are in Auto mode (as it would immediately toggle back)
2020-04-21 15:15:57 +02:00
Aronai Sieyes
5a92fc4ec9 Let mechs connect to ports if they're larger mechs (#7001) 2020-04-21 00:30:49 -07:00
ShadowLarkens
54a8a5823d Saycode Overhaul -- Multilingualism (#6956)
* Port ParadiseSS13/Paradise#2100 - Saycode refactor

* Removed unused old carbon slimes code

* Port ParadiseSS13/Paradise#5099 - Saycode part 2

* Ported ParadiseSS13/Paradise#7170's /datum/browser Check Known Languages

* Port ParadiseSS13/Paradise#9240 - Get rid of alt_name in favor of GetAltName()

* Port ParadiseSS13/Paradise#10330 - You can now use multiple languages in one message

* Addressed Atermonera's review.

Translators now print the full message if they find any languages within the
message that the user doesn't understand, minus languages it cannot translate.

Additionally, the combine_message proc has been significantly simplified
by eliminating an ugly tree structure with the help of a little helper
proc.

The removal of the extra span inside each piece doesn't seem to have
visually changed the messages in any other way than changing where the
wordwrap happens, strangely enough. Must be something in IE's code being
picky about invisible elements. On the bright side, it splits *later*
than it did before, thus reducing the lines a message will take up by a
tiny amount.

Also, a bunch of things now have the 'filter_say' class from
PolarisSS13/Polaris#6998. Since span classes with no definition are
totally valid and just don't do anything, this PR does **not** depend on
that PR being merged first.

* Always gotta be one
2020-04-20 01:11:53 -07:00
Atermonera
6a15586a74 Replaces toy waterflower with spraybottle waterflower (#6997) 2020-04-20 00:24:53 -07:00
Atermonera
098f1b1b43 Merge pull request #6993 from VOREStation/vplk-glass-firedoors
[PORT] Make glass firedoors constructable/deconstructable.
2020-04-19 14:32:55 -07:00
Atermonera
a92650b07d Merge pull request #6991 from VOREStation/pol-jobsplit
Allow 'offmap spawn' jobs to be isolated from station employees
2020-04-19 14:23:49 -07:00
Shadow Quill
7b13b7959d Desc Error 2020-04-18 20:32:12 -05:00
Atlantiscze
78925e2993 Ports over power-related enhancements and tweaks i coded for Bay a while back
- Please fasten your seatbelts, this will be a long one as it joins few older Bay PRs into one.

1. Ports https://github.com/Baystation12/Baystation12/pull/12626
- SMES units may now be damaged and destroyed. Charged SMES units fail quite violently. Damage can be fixed by welding tool.
- PSUs completely refactored, ghetto variant no longer exists.
- Cell rack PSUs now can be considered a hybrid between large battery charger and a SMES. They actually use the cells to store power (so you can hot-swap the cells to get more juice simply via the UI without deconstructing the whole machine), but in comparison to SMES have poor throughput and capacity in general (cells are simply too small). They are also somewhat limited in configuration options (lacks the precision electronics of a SMES). Better matter bin lets you put in more cells, up to 9.
- Cell rack PSU also has a mode that allows charge-balancing all inserted batteries (moves energy around so each battery has the same charge %)

2. Ports https://github.com/Baystation12/Baystation12/pull/11977
- SMES units now have full load balancing capability, getting rid of that annoying "One SMES charges at full, other SMES gets nothing" problem. If insufficient power is available on input, all inputting SMESes will now charge at same percentage. If more SMESes power a single output, they will all output equal percentage of their setting.
- This appears to have a pleasant side effect of fixing the issue where SMESes could starve APCs of energy. SMESes are ALWAYS last to input power on a powernet.
- This also appears to have fixed weird values displayed in SMES output/input load readings in the UI. By weird values i mostly mean inputs/outputs actually higher than the SMES is set to have.

3. Ports https://github.com/Baystation12/Baystation12/pull/18137
- SMES units (and subtypes, therefore effectively also PSUs from previous entry) can now have more than one terminal. This effectively allows a setup where two (or more) sources feed a single SMES, which then feeds the output. SMESes can not exceed input setting even with multiple terminals.
- Typical example of use in practice would be SMES that runs something important (for example an AI, telecomms, pick whatever you want). It could have one input from the power grid, and second input from a PACMAN generator set up nearby as a backup. Before the generator would have to be wired into main grid, therefore main grid would siphon off power from it. Now the generator can be separate and dedicated for whatever use you want.
2020-04-17 08:26:29 +02:00
Atermonera
08d463a797 Merge pull request #6971 from KillianKirilenko/kk-cyclers
Suit Cyclers: Faster, Smarter, Better
2020-04-16 20:14:52 -07:00
Killian
f7cf3143da ssu: don't prefix 'refitted' to the desc 2020-04-17 02:37:02 +01:00
Killian
31bd5e46b3 ssu: extended list, now sorted by departments 2020-04-15 21:09:28 +01:00
Aronai Sieyes
34ffcd2284 Allow fighters to traverse overmap ships predictably 2020-04-15 13:41:22 -04:00
Killian
2a3ba36f5d fix Sec EVA to Security EVA, sneaky workaround to inhands 2020-04-13 13:35:36 +01:00
Atermonera
017ac22ce9 Merge pull request #6989 from VOREStation/pol-blast
Random blast door fix
2020-04-12 23:22:02 -07:00
Atermonera
974919151b Merge pull request #6967 from VOREStation/pol-pipes
Add 2 new pipe types
2020-04-12 23:00:41 -07:00
Atermonera
32a573f5cc Merge pull request #6878 from Mechoid/ATaleofBlobsandMen
A Tale of Blobs and Man
2020-04-12 22:34:33 -07:00
Leshana
e11baeb0bb Make glass firedoors constructable/deconstructable. 2020-04-12 21:08:21 -04:00
Atermonera
1cae548d08 Merge pull request #6966 from VOREStation/vplk-bye-area-new
Refactor away area/New()
2020-04-11 21:40:51 -07:00
Atermonera
98fe59024a Merge pull request #6937 from VOREStation/pol-dockhelpers
Adds airlock setup helpers
2020-04-11 20:48:43 -07:00
Aronai Sieyes
23782f9783 Give sensors a master_tag so they can function as buttons 2020-04-11 15:33:15 -04:00
Aronai Sieyes
cfd052a977 Allow 'offmap spawn' jobs to be isolated from station employees 2020-04-11 13:38:13 -04:00
Aronai Sieyes
965f7235b7 Random blast door fix 2020-04-11 12:51:29 -04:00
Atermonera
f65aa7eb13 Merge pull request #6981 from VOREStation/vplk-overal-missed-fixes
Port followup misc fixes
2020-04-10 23:50:48 -07:00
Atermonera
b6b7c2468c Merge pull request #6974 from Shadow-Quill/patch-1
Unfucks arrival shuttle latejoins when shuttle is docked
2020-04-10 23:50:08 -07:00
Atermonera
68927cbc0d Merge pull request #6970 from VOREStation/pol-couplefix
Fix 2 bugs
2020-04-10 23:49:46 -07:00
Leshana
ba03c3321e Port 7056: Make blood etc decals vanish when overmap ships fly away. 2020-04-10 19:54:01 -04:00
Mechoid
1520c2d190 S l e e p, and split to Ater's request. 2020-04-10 15:54:50 -07:00
Leshana
6f5fb88922 Removed area.uid var and /area/New()
- var/uid was used in only a handful of places.  Because areas are singletons
  it is safe to replace the uid with \ref, areas don't get deleted.
- And with that /area/New() is empty, we can remove it!
2020-04-10 14:58:59 -04:00
Leshana
2c13bee848 Replace global all_areas list with world.
It ends up having similar performance, so might as well not bother with all_areas.
2020-04-10 14:58:59 -04:00
Mechoid
001d5b091f Merge branch 'master' of https://github.com/PolarisSS13/Polaris into ATaleofBlobsandMen
# FixConflicts:
#	polaris.dme
2020-04-09 22:55:42 -07:00
Atermonera
c81f9de1ac Employment records use comments like medical records (#6976) 2020-04-09 22:24:37 -07:00
Atermonera
94178864cf Adds preference to output description_info with examine text (#6969)
* Adds preference to output description_info with examine text

* includes the defines file
2020-04-09 22:20:45 -07:00
Aronai Sieyes
91f457eed1 Merge branch 'master' into pol-assemblies 2020-04-09 23:29:31 -04:00
Atermonera
a720c51d0b Merge pull request #6959 from ShadowLarkens/uplink_redesign
Syndicate Uplink redesign (Inspired by ParadiseSS13/Paradise#1844)
2020-04-08 23:58:18 -07:00
Atermonera
e399e21434 Merge pull request #6950 from VOREStation/pol-maphelp
Improves space edge-of-map behavior and add mapping tools
2020-04-08 23:09:56 -07:00
Killian
ea89193e7d merged additional option from #6957 2020-04-09 01:54:14 +01:00
Aronai Sieyes
765e6cb1a0 Looking glass holodeck (#6958)
* Fix mines qdel

* Looking Glass Holodecks

* Fix console html tag

* DME update
2020-04-08 11:57:15 -07:00
Atermonera
58479507c3 Merge pull request #6916 from VOREStation/vplk-port-overmap-events
[PORT] Overmap Events (and updates)
2020-04-06 23:07:08 -07:00
Neerti
8a03168d95 Stasis QoL (#6923) 2020-04-06 21:38:22 -07:00
Novacat
a5e11749c8 Port: Merge pull request 7028 from VOREStation/aro-oops
Don't delete landmarks oops
2020-04-06 17:54:33 -04:00
Aronai Sieyes
feda30e7d4 Port: Merge pull request 7017 from VOREStation/aro-spaceblood
Remove space blood
2020-04-06 17:54:33 -04:00
Aronai Sieyes
255a2fdf03 Port: Merge pull request 7010 from VOREStation/aro-lessdoom
Fix the doom asteroid waves
2020-04-06 17:54:33 -04:00
Aronai Sieyes
b3be065ae4 Port: Merge pull request 6900 from VOREStation/vplk-overmap-events
Overmap Events
2020-04-06 17:54:26 -04:00
Shadow-Quill
d21e4bbcdc Unfucks arrival shuttle latejoins when shuttle is docked 2020-04-06 15:24:39 -05:00
Killian
b7e8363e2a smarter suit cyclers 2020-04-06 17:15:22 +01:00
Aronai Sieyes
bc3bce6732 Fix infinite server destroying loop in interval effects 2020-04-06 12:12:34 -04:00