Commit Graph

786 Commits

Author SHA1 Message Date
Atermonera
4d8c43f106 What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)
* get_tool_quality has numerical meaning

* Basic tools set tool quality

* Toolspeed is replaced by tool quality checks

* Addresses assorted results from live test

* Extra cleanup
2022-01-16 15:52:55 -08:00
Atermonera
0232be9531 Repaths obj/effect/effect, datum/effect/effect [MDB_IGNORE] (#8312)
* Repaths obj/effect/effect, datum/effect/effect

* linter fixes

* No new

Co-authored-by: Atermonera <forslandm@gmail.com>
2022-01-16 00:14:39 -08:00
MistakeNot4892
2f0a618d45 /atom New() => Initialize() [MDB IGNORE] (#8298)
* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
2021-11-14 00:09:14 -08:00
Cerebulon
1327fc1620 New Organ Sprites 2021-08-23 16:44:18 +01:00
MarinaGryphon
593246b595 Linter diagnostics + bans non-var relative pathing (#8150)
* Linter diagnostics + bans non-var relative pathing

* Enable DreamChecker Annotations

* make it executable

* update hashFiles

* oops

* tries to fix it... again

* trying again

* path

* repath

* fix perms

* fixes weird capitalisation issue
2021-06-20 13:14:29 -09:00
MistakeNot4892
3267ae47b7 Tweaks to emote system to avoid memory overhead and make runtime validation easier. 2021-05-30 23:08:24 +10:00
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Novacat
d0e8fba365 Refactors IsSynthetic (#8078)
* Refactors IsSynthetic

Port of https://github.com/VOREStation/VOREStation/pull/10298 by Aronai

* Fixes emote refactor bug
2021-05-12 21:58:45 -09:00
MistakeNot4892
b4632da349 Swaps emote(me) out for custom_emote(). 2021-04-30 16:21:27 +10:00
Atermonera
0c0dcb1738 Oops, I refactored Chemistry! (#8013)
Reorganizes Reagents dir structure
Refactors reactions to /decl
SSChemistry is no longer processing

Optimization isn't so optimized
Updates to distillery
New decl repository methods
Further tweaks
2021-04-20 18:31:49 -09:00
Atermonera
5670946acc Merge pull request #7991 from MistakeNot4892/bird2
Repathed/renamed seromi to teshari.
2021-03-26 10:35:40 -09:00
MistakeNot4892
04f65551cc Deletes unused var. 2021-03-23 11:10:11 +11:00
MistakeNot4892
a9537638bf Repathed/renamed seromi to teshari. 2021-03-23 09:14:55 +11:00
Novacat
e4962d9f9f Fixes Global and Fixes Eyes (#7976)
* Fixes Custom Species Global lists

Basically changing it to a GLOB just had it add all the species into one global variable instead of a proper list.

* Update global_lists.dm

* Fixes Eyes Stuff

* Removes extraneous Vorestation Edits

* Fixes compile issue
2021-03-17 23:50:37 -09:00
MistakeNot4892
826dfa3a6a Small cleanup from init PR. 2021-03-02 18:17:22 +11:00
Mechoid
8dc04048ed Adds the Restraining Bolt. (#7820)
* Adds the Restraining Bolt.

* Malfunction.
2021-02-28 14:02:12 -09:00
Atermonera
ee968a23e8 Merge pull request #7907 from Cerebulon/virgoprosfix
Fixes some fluff weirdness with Virgo-ported prosthetics
2021-02-23 14:17:28 -08:00
Atermonera
c31a3e762f Merge pull request #7905 from MistakeNot4892/beepboop
Added verbs/handling for removing and attaching your own robotic bodyparts.
2021-02-23 14:16:59 -08:00
MistakeNot4892
b22a0568a3 Sideports a couple of init unit tests from Neb. (#7893)
* Sideports a couple of init unit tests from Neb.

* Trying to unfuck initialize logic.

* Removing del()s.

* Adjusting return values to Initialize().

* Moving some dangerous object logic from obj onto the two types that use it.

* Rolling back some init changes and commenting out initialized atom unit test.

* this comment formatting is a minor war crime

* Removed sleep() from signaler circuit Initialize().

* Additional Init fixes post-rebase.

* Uncomments subsystem test since that's passing.
2021-02-21 12:03:34 -09:00
MistakeNot4892
95d09b4137 Added verbs/handling for removing and attaching your own robotic bodyparts.
Tiny spelling/grammar fix.
2021-02-20 09:33:23 +11:00
Cerebulon
a363b6dd55 Fixes some weirdness with Virgo-ported prosthetics 2021-02-18 20:45:34 +00:00
Verkister
ff847a08aa Makes simplemob braingibs not create brainmobs
Every single simplemob that was gibbed or butchered would spawn a new carbonmob inside their braingib.
2021-02-15 11:30:48 +02:00
Heroman
ab855ca531 Fixes defib timers being 10 times as long as intended. 2021-01-24 09:47:56 +10:00
atermonera
eaefe4155c Fixes facial hair coloring 2020-12-16 18:47:32 -09:00
Mechoid
2018d76cae Department and Round Goals (#7369)
* Baseline work for Department Goals. Implements round-end stats, based in 3 categories of roughly-more-interesting to less interesting.

* Active Goal Separation.

* Map.

* Actually does the second half of this in this PR instead of a different one.
2020-12-11 15:16:47 -09:00
Mechoid
576d0657ce Kaleidoscope 2: The Retabbening (#7697)
* Begins the Project

* Move things to where they belong, if viable.

* Merge and move those files.

* Finish filenames, fix Taj ears.

* Tweak to Ater's Requests

* The Great Mergening with 03_body.

* Per Requests

* Continue per request. Plot nefarious plans to make Saviks usable as battlemounts.

* Smarter Proc Use

* Tweaken
2020-11-19 10:04:09 -08:00
Mechoid
50251d36c6 Fix a Fuckup, simplemobs no longer actually CONTAIN the organs before butchering or gibbing. 2020-11-14 23:51:53 -08:00
Mechoid
68b370be8a Fresh Meat, Leatherworking (#7629)
* Make Butchering more modular. Don't tell the demon lords.

* No guts no glory. That was far more work than expected to get organs to just process and work for butchering holy shit.

* Chitin and hides oh my.

* squeak. ..Why did this not fire on local?

* Squelch.

* Seven cubed livers, for the doctors in their sterile halls.

* Changeling

* Prep for Datums

* Fix Broken Broken Guns

* Redundancy

* F l a g s
2020-11-07 12:06:35 -08:00
atermonera
eadb08bf9f Revert "Kaleidoscope, Toolbox (#7608)"
This reverts commit a68014a9ae.
2020-09-26 11:57:34 -07:00
Atermonera
74318869e3 Merge pull request #7668 from Mechoid/ReagentCyclingCycler
Actually commit the reagent cycler's entire gimmick.
2020-09-21 09:47:42 -07:00
Mechoid
a68014a9ae Kaleidoscope, Toolbox (#7608)
* Begins the Project

* Move things to where they belong, if viable.

* Merge and move those files.

* Finish filenames, fix Taj ears.

* Tweak to Ater's Requests
2020-09-21 09:10:09 -07:00
Cerebulon
0815a554c6 Tweaks to pickup/equip sounds. (#7651) 2020-09-20 03:56:41 -07:00
SubberTheFabulous
3b1fe3fabc Adds two new augments to Traitor uplink (#7642)
* Adds two new antag augments

* Adds two new antag augments

* Adds two new antag augments

* Adds two new antag augments

* Adds two new antag augments

* Adds two new antag augments

* Adds two new antag augments

* Adds two new antag augments

* Changelog

* Adds two new antag augments; Satisfies Travis

* Pleases Travis, except competently

* Adds two new antag augments; with less incompetence

* Adds two new antag augments; with less incompetence
2020-09-20 03:47:56 -07:00
Mechoid
0e494b404a Actually commit the reagent cycler's entire gimmick. 2020-09-16 15:57:58 -07:00
Rykka
0c7a7fd2b8 Massive Ambience and Sound Overhaul + Addition, Squashed Commit Edition 2020-08-21 06:53:05 -04:00
Mechoid
85d13382df FBP Internal Components (#7445)
* Starts work on FBP components

* Complete

* Map

* Tweakening.

* P r e c i s i o n

* P r e c i s i o n Engineering
2020-08-20 18:39:46 -07:00
SplinterGP
42e23055a8 Gives FBP's a proc to change their monitor display without using a mask item. (#7452)
* Synthetics display monitor

Does a change to the synthetics monitor heads and other heads that have displays, allowing them to have those displays without using a mask, using a proc that is given to them. works by basically replacing eye sprite.

* changelog.

* removes the monitor mask item.

* switches && for || in line 363

* moves line of code
2020-08-20 18:24:23 -07:00
SubberTheFabulous
c155736aba Adds New Prosthetics Set (#7467)
* Adds a new FBP CS set, removes old alt2

* Adds a new FBP CS set, removes old alt2

* Readds Cyber Solutions - Array

* Readds Cyber Solutions - Array

* Adds a new FBP CS set

Changelog
2020-08-17 15:03:40 -07:00
Rykka Stormheart
89bfe3be40 Mulebot and vehicle updates - they now run over mobs! (#7430)
* Mulebot and vehicle updates - they now run over mobs!

* Remove unneeded safety check, and lying check

* Fix Mulebots running over themselves, fix runtime with blood.dm
2020-08-06 21:21:18 -07:00
Cyantime
2d4a71d1da Fix promethean core revival flavor text (#7422)
* Fix promethean revival flavor text

* fix whoopsie
2020-08-06 21:14:57 -07:00
Killian
8d731a153b blood mechanics tweaks (#7377) 2020-07-31 01:53:41 -07:00
Neerti
94062a21bf Implements status effect icons for various statuses. Cleans up various variable accesses to use setters instead. 2020-07-18 12:53:32 -04:00
Atermonera
32f9e43f27 Merge pull request #7211 from VOREStation/Arokha/talks
Talking, and other bugs
2020-06-06 11:33:34 -07:00
Atermonera
0c78a71226 Fixes runtimes related to mmi_holder and defib_timer (#7237)
Fixes runtime in life.dm,1831: undefined proc or verb /obj/item/organ/internal/mmi_holder/robot/tick defib timer().
Fixes runtime in defib.dm,511: undefined variable /obj/item/organ/internal/mmi_holder/robot/var/defib_timer
2020-06-04 19:37:29 -07:00
Aronai Sieyes
dcf09397b4 Various talking fixes/improvements 2020-06-03 10:10:55 -04:00
Rykka Stormheart
9917f31031 Merge branch 'master' into shep-dev-upstream-screenport 2020-05-30 06:54:08 -04:00
Atermonera
6ab622a2b5 Merge pull request #7205 from VOREStation/Arokha/playsound
Alter playsound paradigm
2020-05-28 16:05:59 -07:00
Rykka
eec5d912f7 Fix leftover mymob calls and other things 2020-05-23 04:48:47 -04:00
Rykka
fc1d6e741c Ported /tg/ style screen alerts, replacing the hunger icon with them
This adds throw_alert() and /obj/screen/alert, a system that allows you to do custom hud alerts for any variety of things from "You're too cold!" to mecha status indicators for the pilot.

There's quite a few things that actually got replaced; the
fire/oxy/tox/co2 alerts are all now just alerts, as is nutrition. There's also a number of new alerts, such as blindness, highness, legcuffed, buckled, handcuffed, and probably some more I missed; read code/_onclick/hud/alert.dm and see for yourself!

Additionally, a number of tweaks have been done to resisting code, to make it so that there's an indicator when you're buckled or handcuffed, and can just click the alert to start resisting. This includes a refactor that combines the logic for lockers, holders all into one proc, called container_resist().

Also, the health and internals indicator got moved down one tile each. Needed room for the alerts. If we add the oxygen tank action buttons from /tg/ and remove the internals indicator, the health indicator can go back where it was originally.

Alerts, pictured in the top right.
![https://i.imgur.com/H7Bipci.png](https://i.imgur.com/H7Bipci.png)
2020-05-23 04:48:47 -04:00
Atermonera
46b6bd155e Edit Appearance and Change Appearance update icon sex (#7193) 2020-05-19 18:53:30 -07:00