Commit Graph

25484 Commits

Author SHA1 Message Date
Leshana
c91dc333cd Some more types which need Destroy to return qdel hints! 2017-06-14 01:13:54 -04:00
Neerti
997c033d7e Merge pull request #3527 from VOREStation/radiation-fixes
Fix runtimes in radiation controller
2017-06-12 21:06:04 -04:00
Leshana
c4c5dc098a Fix runtimes in radiation controller
* Fixes Baystation12/Baystation12/issues/17443 - Runtime in radiation.dm,30: illegal: sqrt(-2.857143)
  * Updating radiation power to below zero should simply delete the source.
* Fixes at least one cause of Runtime in radiation.dm,41: Cannot read null.z in an effort to fix Baystation12/Baystation12/issues/17411
2017-06-11 20:50:13 -04:00
Neerti
18012fa1d1 Port's Bay's Shuttle Cleanup
Shuttles now set themselves up upon being instantiated instead of relying on a monolithic proc in the shuttle controller.
Shuttles can now be defined more cleanly on a per-map basis, as well.
Accidentally fixes a broken admin shuttle.
2017-06-11 11:45:31 -04:00
Anewbe
5d81148ab8 Merge pull request #3511 from VOREStation/garbage-subsystem
tg Garbage Subsystem
2017-06-10 17:20:22 -05:00
Anewbe
1ace6311a8 Merge pull request #3520 from VOREStation/aro-pol-gmob
Greases up get_blahblah_fast
2017-06-10 15:56:28 -05:00
Anewbe
03dae14050 Merge pull request #3516 from VOREStation/vplk-lazy-lists
Adds macros to assist with lazily instantiating lists
2017-06-09 20:55:44 -05:00
Arokha Sieyes
6d58df9f60 Surgery and syringe fixes
Fixes a line printed about staying close to your patient printed in error, and makes syringes work on laying patients again.

The do_surgery overrides are from a bygone era.

Tested == yes
2017-06-09 02:11:23 -04:00
Arokha Sieyes
7de82a599d Greases up get_blahblah_fast
Untypes lists, obj is more likely so it goes first, uses get_turf now that get_turf uses the get_step witchcraft method.
2017-06-09 00:42:16 -04:00
Leshana
3e84cbbbfd Converts area.all_doors list to be lazily instantiated as a simple example of using the lazy list macros. 2017-06-08 17:21:36 -04:00
Leshana
96a9527d0b Adds macros to assist with lazily instantiating lists.
* For various reasons its best to not instantiate lists until they are actually going to be used, especially if there is a good chance that a given list variable might *never* be used during the lifetime of an object.
* These macros make it simple and concise to add remove and access entries in lazily created lists.
2017-06-08 17:20:44 -04:00
Leshana
60ffe4b00f Ports garbage collector improvements and bugfixes from tg
* Writes a log of qdel() problems in a condensed format at the end of each round - tgstation/tgstation/pull/26135
* Moves hard dels into their own proc so that it can be profiled more easily, and uses it for the various types.  Includes bugfixes too
  * https://github.com/tgstation/tgstation/pull/26210
  * https://github.com/tgstation/tgstation/pull/26570
* Fix a bug with qdeling non-datums - https://github.com/tgstation/tgstation/pull/27434
* Fix typo - https://github.com/tgstation/tgstation/pull/27730
2017-06-08 00:11:59 -04:00
Leshana
d6b68dabdb Standardize MC subsystem initialization boilerplate
* Based on https://github.com/tgstation/tgstation/pull/25386
* Create macro for defining new subsystem types.
* Create PreInit proc to handle setup that needs to be done before the map loads
* Rename garbage_controller subsystem to garbage so it matches its global SSgarbage variable name.
2017-06-07 23:23:46 -04:00
Neerti
cbd1d410c3 Merge pull request #3500 from Anewbe/cloning
Teshari can now be cloned properly
2017-06-07 17:28:08 -04:00
Neerti
8e91e5ce0a Merge pull request #3506 from Anewbe/more_runtimes
Fixes an examine runtime
2017-06-07 17:28:00 -04:00
Anewbe
78a807ce48 Merge pull request #3499 from Yoshax/iamsolazy
Lazyports artifact containers from Bay
2017-06-07 16:27:51 -05:00
Anewbe
7a4e1fe3dc Merge pull request #3508 from VOREStation/aro-pol-commqol
Communicator QOL Tweak
2017-06-07 16:24:42 -05:00
Anewbe
130dba3a24 Merge pull request #3509 from VOREStation/aro-pol-surg
Object Implant Surgery Fix
2017-06-07 16:24:19 -05:00
Arokha Sieyes
c829a195e1 Polaris-able surgery fix 2017-06-06 01:04:11 -04:00
Arokha Sieyes
ade7f6c1cd Communicator QOL Tweak
Call/Msg buttons on contacts list
2017-06-06 01:03:08 -04:00
Leshana
e48b548f2b More and more Destroy() cleanups all across the board - Return qdel hints. 2017-06-05 23:01:41 -04:00
Leshana
010cca1d44 Pipe network datum Destroy() cleanup
* Every pipe in a pipeline has a reference to the pipeline.  This needs to be cleared, both so the pipeline can be gc'd, and also so the pipes don't try and keep using the qdel'd pipeline.
* Same story for each pipeline in a pipe network, and each machine in a pipe network.
* Pipe networks are also in the pipe_networks global list.  While the controller would detect and remove it from the list on the next tick, cleaning up ourselves is the responsible thing to do.
2017-06-05 23:01:39 -04:00
Leshana
8752999a14 Atmospherics Destroy() cleanup - return qdel hints. 2017-06-05 23:01:39 -04:00
Leshana
733f69a474 Remove redundant cleanup of /atom/var/reagents
* /datum/reagents/Destroy() does everything /datum/reagents/delete() does and more, and delete() is called only from /obj/effect/Destroy() which is *itself* redundant with its parent /atom/movable/Destroy()
2017-06-05 22:10:07 -04:00
Leshana
d4ebcac3f6 Update radiation system for the new garbage collector. 2017-06-05 22:10:07 -04:00
PsiOmegaDelta
ebe5cc916d Port of @PsiOmegaDelta's Baystation12/Baystation12#16820
Ports tg's garbage collector subsystem and Destroy() returning qdel hints.
2017-06-05 22:10:06 -04:00
Woodratt
914a291c1b WR Lighting changes and other tweaks
- Adjusts the radius of lights
- Roofs to shuttles
- Allows placement of full windows in DM
2017-06-05 17:03:58 -07:00
Anewbe
ef7b19926a Fixes an examine runtime 2017-06-05 15:08:28 -05:00
Leshana
d438cba406 Fix do_after exploits in Water-Coolers
* Fixes https://github.com/VOREStation/VOREStation/issues/561
* Prevents multi-clicking from doing the construction steps multiple times (spawning multiple jugs, or emptying contents of jug multiplie times).
* Prevents after-attack from transferring reagent from jug to cooler twice when putting a jug on.
2017-06-05 15:04:29 -04:00
Leshana
746571f53f Adds bedsheets to the list of washable items.
Fixes https://github.com/VOREStation/VOREStation/issues/1456
2017-06-05 14:21:07 -04:00
Anewbe
35230b4e7c Merge pull request #3497 from Ardebitis/master
Adds "treadwell" engiborg sprite.
2017-06-04 16:34:32 -05:00
Anewbe
b9007d11a8 Merge pull request #3493 from VOREStation/just-stonedmc
Port of StonedMC master controller framework
2017-06-04 16:15:13 -05:00
Yoshax
5daea1a43d Lazyports artifact containers from Bay 2017-06-04 02:40:58 +01:00
Anewbe
e2860b30b3 Fixes a runtime 2017-06-03 19:42:17 -05:00
Anewbe
3a751fd403 Teshari can now be cloned properly 2017-06-03 18:30:16 -05:00
Anewbe
24b35ace2f Merge pull request #3488 from LorenLuke/Changeling-camo
Changeling Visible Camouflage Tweaks
2017-06-03 16:11:14 -05:00
Anewbe
650cf3f0e9 Merge pull request #3492 from VOREStation/fix-null-rank
Prevent returning null from get_authentification_rank()
2017-06-03 16:01:22 -05:00
Yoshax
5ce5f87d4e Fixes the printout too 2017-06-03 13:04:35 +01:00
BuildTools
4e6a5ab55b Adds "treadwell" engiborg sprite. 2017-06-03 01:15:27 -04:00
Yoshax
72c8b745dd Fixes an advanced medical scanner bug 2017-06-02 19:18:29 +01:00
Leshana
8315abb352 Fix issues with radiation controller on multi-z maps.
Radiation sources are by design z-level specific, the ray trace check needs to respect this.
2017-06-02 07:56:09 -04:00
Leshana
b17fb86721 Tweaks Statpanel and System Initialization 2017-06-01 21:42:08 -04:00
Leshana
8b3403d54f Prevent returning null from get_authentification_rank()
Make sure we return the no job value if they have an id without a rank that is in a PDA.
Should fix https://github.com/PolarisSS13/Polaris/issues/3486
2017-06-01 15:52:38 -04:00
Anewbe
9dfc65b628 Merge pull request #3491 from Neerti/6/1/2017_mech_stumping
Makes Mechs Fall
2017-06-01 14:44:36 -05:00
Anewbe
da437e50ee Merge pull request #3485 from Neerti/5/31/2017_make_surgery_slightly_better_again
Surgery Modifications
2017-06-01 14:42:38 -05:00
Neerti
b5802fb185 Makes Mechs Fall
Mechs now will fall when crossing an open tile.
Anything below that tile will have a bad day.
Also makes lighting overlays unable to fall just incase.
2017-06-01 15:05:51 -04:00
Neerti
962cabe72c Merge pull request #3487 from Anewbe/deathalarm
Fixes Death Alarms
2017-05-31 22:54:52 -04:00
LorenLuke
2bdfe8bfa3 Prevents people from seeing names/examining cloaked changelings at range 2017-05-31 18:44:43 -07:00
Anewbe
9d8f4cfa53 Fixes Death Alarms 2017-05-31 19:38:07 -05:00
Anewbe
0af77012c4 Merge pull request #3465 from Yoshax/radiation
Ports radiation rework and stuff from Bay
2017-05-31 18:37:58 -05:00