Commit Graph

4901 Commits

Author SHA1 Message Date
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Atermonera
7b67601705 Merge pull request #8075 from Atermonera/revert_copper_recipes
Reverts recipe changes from Industrial Expansion
2021-05-23 12:39:50 -07:00
Atermonera
080b856593 Merge pull request #8095 from KillianKirilenko/kk-ports
Wall-mounted Geiger Counters
2021-05-23 12:39:09 -07:00
klaasjared
1c7d9c4cba Food 4 thought (#8083)
* Adds Everything

* Small error fix

* Edit fix

* Update code/modules/food/food/snacks.dm

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>

* Update code/modules/food/food/snacks.dm

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>

* Edit Fix

* Vending Machine Fix

* More fixes

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>
2021-05-20 18:11:19 -09:00
Killian
3cef5f6607 wall-mounted counters 2021-05-18 23:56:56 +01:00
atermonera
1a236e79f0 Reverts recipe changes from Industrial Expansion 2021-05-10 22:39:28 -09:00
klaasjared
d0aaab703b Adds Code and Sprites
Codes in the PCU and adds the sprites as well
2021-05-09 00:49:45 -04:00
ShadowLarkens
c688399f60 Fix welding tools and cable coils as tools 2021-05-02 18:31:47 -07:00
ShadowLarkens
0198ff3fbf Personal Crafting & Dependencies 2021-05-02 18:05:54 -07:00
Atermonera
8728919a43 Merge pull request #8040 from Novacat/nova-runtimes
Changes blueprints to use ChangeArea
2021-04-22 16:07:23 -07:00
atermonera
9ab4668f98 Moves material stacks to modules/materials
Moves vending machines to modules/economy
Moves metal coins, mint to modules/economy
2021-04-22 14:26:04 -09:00
Unknown
603768f0e5 Changes blueprints to use ChangeArea
This should fix a bug where using blueprints to set a livable area on turfs without dynamic lighting (such as space) prevents dynamic lighting from properly initializing on turfs in that area.
2021-04-20 18:14:57 -04:00
Novacat
157fe17963 fixes typo in qerr quem ID (#8026)
* fixes typo in qerr quem ID

* Removes unnecessary comments
2021-04-09 22:47:50 -09:00
Atermonera
d40a022362 Merge pull request #7987 from MistakeNot4892/chirp
Ported the Bay/Nebula emote system.
2021-03-30 22:44:43 -09:00
Atermonera
003d47fbbc Tanning Tweaks (#7965)
* Tanning Tweaks

* tanning racks remove from SSobj on destroy
2021-03-29 20:48:11 -09:00
MistakeNot4892
2b48ef76c8 Ported the Nebula emote system. 2021-03-27 10:24:14 +11:00
Atermonera
5670946acc Merge pull request #7991 from MistakeNot4892/bird2
Repathed/renamed seromi to teshari.
2021-03-26 10:35:40 -09:00
atermonera
6d7e6cf318 Patches new ID card code 2021-03-24 01:03:09 -09:00
MistakeNot4892
a9537638bf Repathed/renamed seromi to teshari. 2021-03-23 09:14:55 +11:00
Killian
47d2c55157 New ID Card Design (#7815)
* citcard port

* card component redundancy reduction

* Update id_stacks.dm

* more variants? more variants

* new ver.

* cleanup, fixes, couple of new elements

* begone, PRS

* minor updates

reorganized dmi, made color naming consistent, added some missing stripes/pips

* updated headstrips, pips, and static cards for readability
2021-03-21 17:27:22 -09:00
Cerebulon
7d8fa646b2 News Update + Communicator Lag Fix (#7973)
* News Update + Communicator Lag Fix

* combined if. please merge this has been up way too long
2021-03-21 12:11:44 -09:00
MistakeNot4892
420a8005f7 Tachikoma tweaks. (#7988)
* Fixes erroneous copypaste in tachikoma join string.

* Nerfs tachikoma speed.

* Nerfs tachikoma armour.

* Added wirecutters and welder to recon platform kit.

* Swaps the explo platform chainsaw to emag item, gives them a machete instead.

* Prevents ghosts from mousedropping crates onto platforms.
2021-03-19 00:02:11 -09:00
BillyBangles
2a4228b5b2 Makes custom cigarettes even more custom-ier (#7925)
* can now add multiple items to rolling papers

* adds blunt wraps and blunts

* un-scuffs the scuffed code
more scuffed up than a wooden middle school gym floor after a dodgeball game

* further optimization
2021-03-18 22:20:41 -09:00
MistakeNot4892
373b71f98b GPS presentation/update tweaks/fixes. 2021-03-18 19:54:50 +11:00
MistakeNot4892
92c6bead11 Added recon and cargo platforms. 2021-03-13 13:24:28 +11:00
Atermonera
823d5567ba Merge pull request #7963 from MistakeNot4892/implants
Tweaked implant loadout, refactored implant detection.
2021-03-10 10:18:22 -09:00
Atermonera
1f64eeb579 Merge pull request #7949 from Meghan-Rossi/e-cig
E-cigarette improvements
2021-03-10 09:49:52 -09:00
MistakeNot4892
0dcfcd90b8 Tweaked implant loadout, refactored implant detection. 2021-03-09 11:55:17 +11:00
Atermonera
e9971715c0 Merge pull request #7953 from MistakeNot4892/fixes2
Fixed/generalized loadout implants.
2021-03-07 23:03:40 -08:00
FenodyreeAv
ca583e2cb2 Adds a modular armour version of the explorer suit and adds sprites to specialist armour (#7921)
* Adds a modular armour version of the explorer suit.

* Adds material armour building steps for plates, arm guards and leg guards

Adjusts chitin hardness and weight (weaker and lighter)

* Maps a drying rack and washing machine into the planetside outpost

* Fixes QDEL issue, adds sprites to the specialist armours, and adjusts the cargo crates to match.

* Changes map format to TGM

* Removes flashy pixel on south facing leg sprites

* Adds proper returns, removes copypasta, fixes labeller & pen interactions
2021-03-07 11:36:51 -09:00
MistakeNot4892
47dc760585 Fixed/generalized loadout implants. 2021-03-06 22:29:00 +11:00
MistakeNot4892
34a11eac03 Added a GPS compass. 2021-03-04 07:03:19 +11:00
Meghan-Rossi
f858111f77 ecig improvements
🆑
rscadd - You can now tell roughly how full an e-cigarette's cartridge is by examine the e-cigarette while nearby.
rscadd - A message will appear when an e-cigaratte you are smoking turns off. 
/🆑
2021-03-03 02:42:51 +00:00
Meghan-Rossi
2564298eca Fixes a runtime when e-cigs are examined
🆑
bugfix - Fixed a runtime when e-cigarettes are examined.
/🆑
2021-03-02 23:23:05 +00:00
Mechoid
8dc04048ed Adds the Restraining Bolt. (#7820)
* Adds the Restraining Bolt.

* Malfunction.
2021-02-28 14:02:12 -09:00
Schnayy
031f8a7392 Merge pull request #7919 from Atermonera/point_defense_targeting
Hybridizes Point Defense Turrets with Bay's System
2021-02-26 09:04:43 -06:00
Aronai Sieyes
8b63a5a116 Merge pull request #7083 from VOREStation/vplk-pointdefense
Port Point Defense Batteries
# Conflicts:
#	code/_global_vars/lists/misc.dm
2021-02-22 14:00:43 -09:00
MistakeNot4892
b22a0568a3 Sideports a couple of init unit tests from Neb. (#7893)
* Sideports a couple of init unit tests from Neb.

* Trying to unfuck initialize logic.

* Removing del()s.

* Adjusting return values to Initialize().

* Moving some dangerous object logic from obj onto the two types that use it.

* Rolling back some init changes and commenting out initialized atom unit test.

* this comment formatting is a minor war crime

* Removed sleep() from signaler circuit Initialize().

* Additional Init fixes post-rebase.

* Uncomments subsystem test since that's passing.
2021-02-21 12:03:34 -09:00
Schnayy
462f96163e Merge pull request #7869 from Atermonera/mind_telecrystals
Telecrystals are only stored on the mind
2021-02-13 13:49:44 -06:00
atermonera
143b1a6c82 Last mistakes 2021-02-13 11:40:06 -09:00
atermonera
086d767db3 cost() and can_buy() don't always get minds 2021-02-12 13:41:45 -09:00
atermonera
4011b74e98 Fixes uplink implants 2021-02-10 20:48:43 -09:00
atermonera
c6a34aa639 Telecrystals are only stored on the mind 2021-02-10 19:19:02 -09:00
Cerebulon
6d2b5e4764 Allows custom-selection of posters 2021-02-09 20:53:50 +00:00
Mechoid
1de8bc1c40 Industrial Expansion (#7811)
* Begins work on the Industrial expansion, ft hidden Lore

* Removed Painite, Quartz, and Void Opal from generation pending their eventual uses. Recipes modified to use them have been reverted of this use.

Fix Fix.

* Reset map to master.

* Add copper to Robotics, R&D, Engineering, and EVA.
2021-01-27 19:28:13 -09:00
Nadyr
8ce61742c0 Fixes sif forest grass, adds overgrowth tiles (#7841) 2021-01-27 11:19:18 -08:00
Cerebulon
c729c0e23b Fixed global_announce autospeaker (#7839)
* Filth + Graffiti Fixes

* Excised Bad Lore

* Fixed Global Announcer

* fuckinn
2021-01-25 17:24:39 -08:00
Atermonera
1cb1a80ec4 Merge pull request #7838 from Heroman3003/defibtimefix
Fixes defib timers being 10 times as long compared to intended.
2021-01-24 16:32:45 -08:00
Mechoid
95ea4f6f2d Mech Appearance Update (#7818)
* Mechs are now properly scaled. Also fixes the FUCKING taur sprites.

* What
2021-01-24 10:18:05 -09:00
Heroman
ab855ca531 Fixes defib timers being 10 times as long as intended. 2021-01-24 09:47:56 +10:00