Commit Graph

20141 Commits

Author SHA1 Message Date
Neerti fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Atermonera 9667dad5ba Merge pull request #8098 from Neerti/webhook_no_meta
Makes roundstart webhook not metagame.
2021-05-23 12:40:16 -07:00
Atermonera 7b67601705 Merge pull request #8075 from Atermonera/revert_copper_recipes
Reverts recipe changes from Industrial Expansion
2021-05-23 12:39:50 -07:00
Atermonera e7c00701b1 Merge pull request #8074 from Atermonera/unmap_tin
Removes tin for ore generation
2021-05-23 12:39:37 -07:00
Atermonera 080b856593 Merge pull request #8095 from KillianKirilenko/kk-ports
Wall-mounted Geiger Counters
2021-05-23 12:39:09 -07:00
Atermonera b36e45f328 Merge pull request #8094 from Hatterhat/pbore-buff
phoron bore stock parts now affect range, along with other bits
2021-05-23 12:38:30 -07:00
Atermonera 4ccc12224f Merge pull request #8089 from TheFurryFeline/TFF-Possibly_Fix_Cleanbots
[Bugfix] Maybe Fix Cleanbots
2021-05-20 20:51:22 -07:00
Aronai Sieyes 9cd4a89782 SSpersistence tweaks (#8087)
* Add some 'lossy' smartfridges and options

* Convert persistence to JSON

* Update map_datum to specify persistence levels
2021-05-20 18:50:36 -09:00
klaasjared 1c7d9c4cba Food 4 thought (#8083)
* Adds Everything

* Small error fix

* Edit fix

* Update code/modules/food/food/snacks.dm

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>

* Update code/modules/food/food/snacks.dm

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>

* Edit Fix

* Vending Machine Fix

* More fixes

Co-authored-by: Greenjoe12345 <33647525+Greenjoe12345@users.noreply.github.com>
2021-05-20 18:11:19 -09:00
Neerti 3d3ca3e399 Makes roundstart webhook not metagame. 2021-05-20 21:59:34 -04:00
Hatterhat 37bc8cd741 phoron bore buff but squashed 2021-05-19 00:41:50 -05:00
Killian 3cef5f6607 wall-mounted counters 2021-05-18 23:56:56 +01:00
Atermonera 7fb6a4f4ad Merge pull request #8084 from TheFurryFeline/patch-10
[Bugfix]  Stop SSD Snoring
2021-05-18 00:08:54 -07:00
Novacat 55533c05d9 Mecha Balance and Fighter Fixes (#8081)
* Mecha Balance and Fighter Fixes

- Shields are no longer buildable by Robotics
- Fighters are now equipped with components that enable them to go fast
- Fighter step cost is now zero

* Mecha are now repairable

* Code Correction

* Mrowl
2021-05-17 21:52:49 -09:00
Atermonera b4a2e215dc Merge pull request #8052 from Atermonera/simplemob_pathing_improvements
Simplemobs seek lost targets
2021-05-17 23:46:52 -07:00
TheFurryFeline c3882a0590 Maybe Fix Cleanbots
Removes blood stuff, since it's already a cleanable, which is what a cleanbot is to clean, anything cleanable. Also effectively removes anything in the target_types list, replace with the base cleanable obj path so it cleans any children of cleanable. Tested, spawned stuff, it cleaned pie splatter, cobwebs, etc.

The way this was before, if there was still a cleanable that wasn't listed in target_types, the bot would get stuck forever without the un-included cleanable showing up in their target.

🆑
bugfix - Cleanbots no longer get stuck trying to clean something not in its target list
/🆑
2021-05-15 10:58:28 -04:00
Novacat d0e8fba365 Refactors IsSynthetic (#8078)
* Refactors IsSynthetic

Port of https://github.com/VOREStation/VOREStation/pull/10298 by Aronai

* Fixes emote refactor bug
2021-05-12 21:58:45 -09:00
Novacat 70170f0dde Allow more than one ore processor (#8072)
* Allow more than one ore processor

Port of https://github.com/VOREStation/VOREStation/pull/10280

* Forgot these files
2021-05-12 21:25:31 -09:00
Neerti 4deffc7186 Ports Nebula's Discord Webhook Integration (#8071)
* Ports Nebula's Discord Webhook Integration

* Forgot the example .json file.
2021-05-12 21:22:25 -09:00
Atermonera b123a4750b Adds persistent smartfridges for garden products, material sheets (#8042)
* Addsd sheet storage smartfridge
Implements persistent item storage

* Adds persistent produce smartfridge
Repaths smartfridge base type to /produce subtype

* Raises produce cap to 50, per staff meeting
2021-05-12 21:05:04 -09:00
TheFurryFeline 361b8798ba Stop SSD Snoring
Up-port https://github.com/VOREStation/VOREStation/pull/10313. Reduces chat log spam potential.

🆑 
tweak - Stop Snore if SSD
/🆑
2021-05-12 19:59:42 -04:00
atermonera 1a236e79f0 Reverts recipe changes from Industrial Expansion 2021-05-10 22:39:28 -09:00
atermonera fe0df5c56d Removes tin for ore generation 2021-05-10 22:24:28 -09:00
Atermonera e317eab41a Merge pull request #8068 from Novacat/spriteadd
Fix view spinning reversing movement controls
2021-05-11 00:01:19 -07:00
Atermonera b49fc74423 Merge pull request #8067 from Novacat/nova-alerts
Simple player notes filter
2021-05-11 00:00:39 -07:00
atermonera 96cb824895 Adds verb to VV global variables 2021-05-09 16:27:03 -09:00
Atermonera a5beeb53b3 Merge pull request #8064 from MistakeNot4892/styles
Fixes Virgo #10254.
2021-05-07 00:14:38 -07:00
Unknown b26850e16c Fix view spinning reversing movement controls
Ports https://github.com/VOREStation/VOREStation/pull/8912
2021-05-06 12:39:34 -04:00
Unknown e771698073 Simple player notes filter
Port of https://github.com/VOREStation/VOREStation/pull/10258
2021-05-06 01:02:26 -04:00
Atermonera 26f17d2780 Merge pull request #8060 from ShadowLarkens/personal_crafting
Personal Crafting & Dependencies
2021-05-05 21:26:19 -07:00
MistakeNot4892 a647ca622a Fixes Virgo #10254. 2021-05-05 10:02:39 +10:00
Atermonera 0e55e04de8 Merge pull request #8058 from MistakeNot4892/emotes
Swaps emote(me) out for custom_emote().
2021-05-02 20:58:58 -07:00
Atermonera 4b4e9768b3 Merge pull request #8057 from MistakeNot4892/styles
Body style selection and sanitizing refactor.
2021-05-02 20:55:50 -07:00
Atermonera 8bbdd51252 Merge pull request #8056 from Greenjoe12345/weather-sounds
weather sounds adjustments
2021-05-02 20:53:09 -07:00
ShadowLarkens c688399f60 Fix welding tools and cable coils as tools 2021-05-02 18:31:47 -07:00
ShadowLarkens 0198ff3fbf Personal Crafting & Dependencies 2021-05-02 18:05:54 -07:00
MistakeNot4892 1265b8a5d6 Body style selection and sanitizing refactor. 2021-04-30 16:52:08 +10:00
MistakeNot4892 b4632da349 Swaps emote(me) out for custom_emote(). 2021-04-30 16:21:27 +10:00
Novacat 6608393d7c Fixes Stunrevolver PATH (#8053)
It seems like the description assumed the stunrevolver was a subtype of /gun/ when it is not!
2021-04-28 19:55:26 -07:00
Atermonera 7534219899 Makes mineral turf ore list static (#8044) 2021-04-27 14:22:29 -07:00
Atermonera a083c7a4b2 Sanitizes languages, ears/wings/tail prefs on login (#8030) 2021-04-27 13:46:02 -07:00
atermonera 94539328ec Adds config option to control loadout whitelist strictness 2021-04-26 16:37:48 -09:00
Greenjoe12345 99df0f9e5e weather sounds 2021-04-27 02:11:45 +01:00
Cerebulon 322e8a23d0 Brings back old tesh radsuit sprites, adds 'fitted' version. (#7995)
* Brings back old tesh radsuit sprites, adds 'fitted' version.

* removed superfluous fitted grondsprite

* Conflicts with teshari path changes resolved
2021-04-26 08:27:18 -09:00
atermonera 485e5f6549 Simplemobs seek lost targets 2021-04-26 01:50:03 -09:00
Atermonera 8f116f2611 Merge pull request #8047 from Verkister/patch-70
Makes xenowear species WL check for species instead of ckey
2021-04-25 11:23:31 -07:00
klaasjared 64c7c62014 Drink Overhaul V1.2 (#8041)
* Adds Sprites

Adds the new bottled sprites for soda as well as some other additional drink sprites

* Added code and organization

Adds the code that'll modify the bottles as well as organizes the code that already exists

* Whoops - minor sprite error

Fixed the Schnapps sprites - forgot to change the 'alpha' of some pixels
2021-04-23 20:38:05 -09:00
Verkister 76d2a40936 Makes xenowear species WL check species
Makes loadout xenowear species whitelists check the selected species of the character instead of whether or not the client key is whitelisted for the species.
2021-04-23 18:00:44 +03:00
Atermonera 482fca82c9 Merge pull request #8043 from MistakeNot4892/chirp
Corrected erroneous emote flag.
2021-04-22 16:10:28 -07:00
atermonera 9ab4668f98 Moves material stacks to modules/materials
Moves vending machines to modules/economy
Moves metal coins, mint to modules/economy
2021-04-22 14:26:04 -09:00