Commit Graph

2121 Commits

Author SHA1 Message Date
Neerti fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Neerti 4deffc7186 Ports Nebula's Discord Webhook Integration (#8071)
* Ports Nebula's Discord Webhook Integration

* Forgot the example .json file.
2021-05-12 21:22:25 -09:00
Atermonera b49fc74423 Merge pull request #8067 from Novacat/nova-alerts
Simple player notes filter
2021-05-11 00:00:39 -07:00
atermonera 96cb824895 Adds verb to VV global variables 2021-05-09 16:27:03 -09:00
Unknown e771698073 Simple player notes filter
Port of https://github.com/VOREStation/VOREStation/pull/10258
2021-05-06 01:02:26 -04:00
Unknown de5cb9e42f Updates respawn_character some more
- Fixes Spawned characters not having their job title set properly
- Fixes depreciated proc being called, replaces with closest equivalent: regenerate_icons()
2021-03-29 03:00:44 -04:00
Atermonera a6b031ded5 Merge pull request #7967 from Verkister/patch-66
Makes drag-drop bodyjacking not break aghost bonds
2021-03-17 23:15:01 -09:00
Verkister 0b9e22dd11 Makes drag-drop bodyjacking not break aghost bonds
Possessing mobs by drag-dropping your aghost into the mob now transfers your original body's spirit link into the possessed mob and thus prevents your original body from getting knocked out when your ghost disappears into the new body.
2021-03-09 21:44:29 +02:00
atermonera c9877d4001 Fixes context-menu examine expanding incorrect target 2021-03-07 21:46:19 -09:00
Cerebulon d0b71c8c52 Lobby Improvements (#7856)
* Lobby Improvements

* HTML Tags + more recent article while I'm in here bc this may take a day or two 2 merge

* Removed to_world + fixed header
2021-02-21 12:32:38 -09:00
Novacat e47f39ec24 Porting Fixes (#7891)
* Porting Fixes

- Ores now properly initialize
- Spawned in characters now have languages set

* Update ore.dm

* More Hard Delete Fixes

* Fixes compile issue
2021-02-19 22:07:27 -09:00
Cerebulon c729c0e23b Fixed global_announce autospeaker (#7839)
* Filth + Graffiti Fixes

* Excised Bad Lore

* Fixed Global Announcer

* fuckinn
2021-01-25 17:24:39 -08:00
Atermonera c58fb16bc1 Adds proc to properly update human icon gender (#7813) 2020-12-31 21:31:35 -08:00
ShadowLarkens dad9020f9a TGUI Engineering... and a bunch of other random things 2020-10-21 13:02:19 -07:00
Atermonera 6bd15bc200 Merge pull request #7625 from ShadowLarkens/tgui_med
TGUI Medical Conversion
2020-09-19 18:52:23 -07:00
ShadowLarkens 44f65e2602 TGUI Medical Conversion 2020-09-04 16:25:32 -07:00
Greenjoe12345 74538d383e adds the ability to give loadout items a custom name/description 2020-08-31 01:20:59 +01:00
listerla d56974cb92 Colony Director -> Site Manager 2020-08-25 20:12:29 -04:00
Atermonera 7428d47c83 Merge pull request #7508 from Rykka-Stormheart/shep-dev-persistence-patch
Persistence Patch
2020-08-20 19:31:12 -07:00
Rykka 2ad7b475ec Persistence Patch
- Fixes Paper and font tags stacking across rounds, as shown in: ![](https://cdn.discordapp.com/attachments/187013248309002240/741937939382141000/164fdd3a37fb22f18dfa9b5c431ffc04.png)

- Fixes Persistence being always-on because of if("persistence_enabled") config.persistence_enabled = 1. As explained: 
> it's on by default, which means config.txt will be read and if it's not there it stays at 1. If it is there,it gets set to 1. There is no way to disable it

- Adds config options to enable/disable **Persistence for Maploaded objects**, as well as a verb to toggle such.
- Adds Persistence to config.

Currently IGNORE_MAPLOAD for Persistance is **Disabled.**
Maploaded objects/dirt/etc will be saved by persistence, preserving current behavior.

You will need to update config.txt with the following lines:
\## Uncomment this to DISABLE persistence 
\#PERSISTENCE_DISABLED 
 
\## Uncomment this to DISABLE maploaded trash/paper/etc from being saved by the persistence system. 
\#PERSISTENCE_IGNORE_MAPLOAD
2020-08-16 09:58:57 -04:00
Shadow Quill e5ddb1afe5 Cancel! 2020-08-13 20:21:49 -05:00
Atermonera 1fc6477d5e Merge pull request #7393 from Rykka-Stormheart/shep-dev-tg-alerts-updoot
Port lots of things that had to wait on alerts (Replaces Arokha's PR)
2020-08-06 11:38:16 -07:00
Atermonera f1eb479af6 Merge pull request #7317 from ShadowLarkens/tgui
TGUI-V3
2020-07-30 14:11:32 -07:00
Rykka 28a7698b9e Port lots of things that had to wait on alerts
Adds a HUD for observers
Adds a HUD for rigs and mechs
Adds up/down buttons for AI hud
Add more tg style alerts
Fix some bugs with the tg alerts
Improve icon_states usage by caching it
Redo how respawning works, add a button to ghost hud for it
2020-07-30 16:23:32 -04:00
Atermonera 55b2c8d6ef Merge pull request #7354 from Neerti/status_indicators
Implements Status Indicators
2020-07-30 12:29:46 -07:00
Cerebulon 03b7a0ea0d Persistent Trash/Dirt/Graffiti/Notices (#7337)
* Port Trash/Writing Persistence from World

* stuff beyond straight portin

* Fixed admin menu

* Config, cigbutts, blood exceptions, offices....

* mapped butts
2020-07-24 02:23:34 -07:00
Neerti 94062a21bf Implements status effect icons for various statuses. Cleans up various variable accesses to use setters instead. 2020-07-18 12:53:32 -04:00
Kates 124ac24257 Make the quick create less less ugly & re-add proper mecha after their last item path change. (#7327) 2020-07-13 19:26:01 -07:00
ShadowLarkens c06a2d2cef TGUI v3.0
This ports TGUI, and makes the old nano crew monitor and the disposal
bins use it as first examples.
2020-07-09 22:06:23 -07:00
Verkister adb86c61ef Update create_turf.dm 2020-06-24 18:38:25 +03:00
Verkister 1743dab941 Update create_object.dm 2020-06-24 18:37:59 +03:00
Verkister 07bbde22b3 Update create_mob.dm 2020-06-24 18:37:04 +03:00
Atermonera 6ab622a2b5 Merge pull request #7205 from VOREStation/Arokha/playsound
Alter playsound paradigm
2020-05-28 16:05:59 -07:00
Atermonera 3f253263e2 Fixes runtime in item_attack.dm, line 81 (#7236)
Undefined variable /turf/simulated/floor/plating/var/lastattacker
2020-05-24 14:32:02 -07:00
Atermonera 46b6bd155e Edit Appearance and Change Appearance update icon sex (#7193) 2020-05-19 18:53:30 -07:00
Aronai Sieyes ad75bb86bd Alter playsound paradigm 2020-05-19 11:06:28 -04:00
Atermonera 2d6b2e4dfa Merge pull request #7122 from VOREStation/pol-buildai
Make buildmode AI control reset home turfs when move orders given
2020-05-15 17:57:11 -07:00
Atermonera ae176fcc3f Fixes #649 (#7114) 2020-05-15 13:32:13 -07:00
Aronai Sieyes a8f3a0a7a0 Refactor move/click code 2020-05-15 10:49:27 -04:00
Aronai Sieyes 180e975b1b Make buildmode AI control reset home turfs when move orders given 2020-05-08 18:49:56 -04:00
Aronai Sieyes 65cfc5bd39 Refactor telecomms to send messages to logically adjacent zlevels 2020-04-27 10:45:25 -04:00
Leshana ec86a98e16 [PORT] Refactor the gameticker controller into SSticker (#6994)
* Move gameticker to subsystem folder before editing to track history thru rename.

* Refactor the gameticker into SSticker

  - Instead of independently spawn'd while/sleep loops, it stores its state and lets the MC fire it.
  - Convert relative path indentation procs to absolute path as per modern style standards.
  - Break apart the inner loops into separate procs so you can see what is actually going on.
  - It now shows up in MC tab, along with stats about what phase it is in.

* Revamp Start Now admin verb to actually wait until init is done before starting.

* Update Lobby stat panel to show voting and server init status.

* Fix: Only call autogamemode vote once.

* Spawn statistic_cycle off to not sleep SSticker.

* Add SStickere changelog

* Change to use to_world and add wrapping spans.

* Added filtering spans by specific request of Polaris.
2020-04-25 12:26:54 -07:00
Atermonera 1ed5556b8f Adds empty filter classes to send messages to particular vchat filters. (#6998)
* Adds empty filter classes to send messages to particular vchat filters.
Adds combat log (playerside X hit Y) filter
Adds admin log, attack log, and debug log filters (Admin side)
Moves many unfiltered admin verb outputs to admin log filter

* unmatched tags
2020-04-20 00:28:16 -07:00
Atermonera 1cae548d08 Merge pull request #6966 from VOREStation/vplk-bye-area-new
Refactor away area/New()
2020-04-11 21:40:51 -07:00
Leshana 2c13bee848 Replace global all_areas list with world.
It ends up having similar performance, so might as well not bother with all_areas.
2020-04-10 14:58:59 -04:00
Leshana 5c12bd5dea Fix links and options on VV list page.
- Fixes the dropdown options of the /list VV page to actually do anything.
- Fixes the E,C,- links next to each list entry on the /list VV page to actually do anything.
- Fixes the Refresh link on the /list VV page to actually refresh.
2020-04-07 00:32:13 -04:00
Leshana 85ebeeef1f Fix VV editing numeric entries in lists
- Previously attempting to edit a list entry with a Number value would runtime.  Unless you were in a particular set of circumstances, which could lead to even weirder effects like unexpected associatead values being set.
- Also cleaned up the experience by removing options from popup prompts that would inevitably lead to runtime errors.
2020-04-07 00:31:05 -04:00
Atermonera 558ff4ade9 Merge pull request #6936 from VOREStation/vplk-sundry-bugfixes-xi
[PORT] Sundry Bugfixes XI
2020-04-04 23:36:44 -07:00
Atermonera eae8cade90 Merge pull request #6912 from VOREStation/aro-mapload
[PORT] Speed up map load significantly
2020-04-01 20:25:17 -07:00
Leshana d9103b6f38 Fixes Runtime in randomverbs.dm,134: list index out of bounds 2020-03-31 16:49:38 -04:00