Commit Graph

8907 Commits

Author SHA1 Message Date
Neerti
fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
Atermonera
4ccc12224f Merge pull request #8089 from TheFurryFeline/TFF-Possibly_Fix_Cleanbots
[Bugfix] Maybe Fix Cleanbots
2021-05-20 20:51:22 -07:00
Atermonera
7fb6a4f4ad Merge pull request #8084 from TheFurryFeline/patch-10
[Bugfix]  Stop SSD Snoring
2021-05-18 00:08:54 -07:00
TheFurryFeline
c3882a0590 Maybe Fix Cleanbots
Removes blood stuff, since it's already a cleanable, which is what a cleanbot is to clean, anything cleanable. Also effectively removes anything in the target_types list, replace with the base cleanable obj path so it cleans any children of cleanable. Tested, spawned stuff, it cleaned pie splatter, cobwebs, etc.

The way this was before, if there was still a cleanable that wasn't listed in target_types, the bot would get stuck forever without the un-included cleanable showing up in their target.

🆑
bugfix - Cleanbots no longer get stuck trying to clean something not in its target list
/🆑
2021-05-15 10:58:28 -04:00
Novacat
d0e8fba365 Refactors IsSynthetic (#8078)
* Refactors IsSynthetic

Port of https://github.com/VOREStation/VOREStation/pull/10298 by Aronai

* Fixes emote refactor bug
2021-05-12 21:58:45 -09:00
TheFurryFeline
361b8798ba Stop SSD Snoring
Up-port https://github.com/VOREStation/VOREStation/pull/10313. Reduces chat log spam potential.

🆑 
tweak - Stop Snore if SSD
/🆑
2021-05-12 19:59:42 -04:00
Unknown
b26850e16c Fix view spinning reversing movement controls
Ports https://github.com/VOREStation/VOREStation/pull/8912
2021-05-06 12:39:34 -04:00
Atermonera
26f17d2780 Merge pull request #8060 from ShadowLarkens/personal_crafting
Personal Crafting & Dependencies
2021-05-05 21:26:19 -07:00
Atermonera
0e55e04de8 Merge pull request #8058 from MistakeNot4892/emotes
Swaps emote(me) out for custom_emote().
2021-05-02 20:58:58 -07:00
ShadowLarkens
0198ff3fbf Personal Crafting & Dependencies 2021-05-02 18:05:54 -07:00
MistakeNot4892
1265b8a5d6 Body style selection and sanitizing refactor. 2021-04-30 16:52:08 +10:00
MistakeNot4892
b4632da349 Swaps emote(me) out for custom_emote(). 2021-04-30 16:21:27 +10:00
Atermonera
6fcca25408 Merge pull request #8038 from Novacat/nova-accessory
Lying on the ground can be left or right
2021-04-20 20:57:01 -07:00
Nyks
6526ca1b61 Updates all bots to use TGUI, and adds mute button for certain bots (#8035)
* tgui-bots

* Uhhh, guess it needs tgui bundle too?
2021-04-20 18:54:53 -09:00
Unknown
e40183e011 Lying on the ground can be left or right 2021-04-19 00:00:38 -04:00
Unknown
5f6080d743 Throwing Crit/Dead humanmobs now damages them
🆑
tweak - Throwing critically injured/dead humanmobs now damages them further.
/🆑
2021-04-11 13:50:37 -04:00
Novacat
157fe17963 fixes typo in qerr quem ID (#8026)
* fixes typo in qerr quem ID

* Removes unnecessary comments
2021-04-09 22:47:50 -09:00
Atermonera
45707a61a5 Merge pull request #8006 from MistakeNot4892/teshpets
Prevented Teshari from selecting positronic brains.
2021-04-01 22:52:21 -09:00
Atermonera
7d1536b9a2 Merge pull request #8017 from Novacat/nova-alerts
Updates respawn_character some more
2021-03-30 23:29:21 -09:00
Atermonera
93202af683 Merge pull request #8012 from MistakeNot4892/bird
Tesh gliding tweaks.
2021-03-30 23:22:20 -09:00
Atermonera
ddfb5f3352 Merge pull request #8000 from Atermonera/ai_eye_higgs_bugson
Fixes runtime in chunk.dm: line 91, I think?
2021-03-30 22:46:15 -09:00
Atermonera
d40a022362 Merge pull request #7987 from MistakeNot4892/chirp
Ported the Bay/Nebula emote system.
2021-03-30 22:44:43 -09:00
Unknown
b8111013ac Deletes old unused procs 2021-03-29 03:10:49 -04:00
Atermonera
37bdcc22a2 Merge pull request #8004 from Novacat/nova-alerts
Technomancer Bugfixes
2021-03-26 20:04:01 -09:00
Atermonera
311bcca911 Merge pull request #7997 from Verkister/patch-69
Fixes naked ghosts
2021-03-26 15:09:52 -09:00
MistakeNot4892
425060f1bd Tesh gliding tweaks, allows Tesh to jump off cliffs. 2021-03-27 10:25:31 +11:00
MistakeNot4892
dc7c2a9bd1 Prevented Teshari from selecting drone or positronic brains. 2021-03-27 10:25:07 +11:00
MistakeNot4892
2b48ef76c8 Ported the Nebula emote system. 2021-03-27 10:24:14 +11:00
Unknown
f0cd058d26 Fixes two more bugs. 2021-03-23 15:44:41 -04:00
atermonera
b0e3347818 Fixes runtime in chunk.dm: line 91 2021-03-22 20:43:43 -09:00
MistakeNot4892
a9537638bf Repathed/renamed seromi to teshari. 2021-03-23 09:14:55 +11:00
Verkister
e751ebd22b Fixes naked ghosts
Fixes ghosts going all naked as soon as they summon a typing bubble or anything.
2021-03-22 17:47:20 +02:00
Atermonera
3a82d38de4 Merge pull request #7993 from MistakeNot4892/tachikoma
Removed inactive platforms from the end of round laws output, gives them pilot access.
2021-03-21 18:04:06 -09:00
MistakeNot4892
0b5bb3fbf0 Allows Teshari to glide in some multiz fall conditions. (#7990)
* Allows Teshari to glide in some multiz fall conditions.

* Carried mobs will now fall off you if you go prone.
2021-03-21 17:58:26 -09:00
MistakeNot4892
9d78f057de Removed inactive platforms from the end of round laws output. 2021-03-21 11:48:51 +11:00
MistakeNot4892
420a8005f7 Tachikoma tweaks. (#7988)
* Fixes erroneous copypaste in tachikoma join string.

* Nerfs tachikoma speed.

* Nerfs tachikoma armour.

* Added wirecutters and welder to recon platform kit.

* Swaps the explo platform chainsaw to emag item, gives them a machete instead.

* Prevents ghosts from mousedropping crates onto platforms.
2021-03-19 00:02:11 -09:00
Atermonera
921ac67a8a Merge pull request #7980 from MistakeNot4892/gps
GPS presentation/update tweaks/fixes.
2021-03-18 00:03:25 -09:00
Atermonera
c4957e6a2e Merge pull request #7977 from Verkister/patch-67
Updates some ancient comments
2021-03-18 00:03:06 -09:00
MistakeNot4892
373b71f98b GPS presentation/update tweaks/fixes. 2021-03-18 19:54:50 +11:00
Atermonera
135ccb7d69 Merge pull request #7981 from MistakeNot4892/cleanup
Minor cleanup.
2021-03-17 23:54:29 -09:00
Atermonera
f3368de28a Merge pull request #7979 from MistakeNot4892/goasts
Ghosts now use their body appearance initially.
2021-03-17 23:52:02 -09:00
Atermonera
63580fc569 Merge pull request #7956 from MistakeNot4892/poppy
Ported Poppy the possum.
2021-03-17 23:10:12 -09:00
MistakeNot4892
b2dc698a66 Tweaked think tanks for speed/init errors. 2021-03-13 14:29:48 +11:00
MistakeNot4892
92c6bead11 Added recon and cargo platforms. 2021-03-13 13:24:28 +11:00
MistakeNot4892
783b4825b0 Ported Poppy the possum. 2021-03-13 13:19:01 +11:00
MistakeNot4892
0ad6e44b44 Removed unused mouse path. 2021-03-13 13:14:43 +11:00
MistakeNot4892
924991fef6 Ghosts now use their body appearance initially. 2021-03-13 13:12:46 +11:00
Verkister
71a77c6023 Updates some ancient comments
This part here was causing some issues with certain features.
2021-03-12 22:13:55 +02:00
Atermonera
45a7e57f27 Merge pull request #7958 from Atermonera/examine_autoexpansion
Fixes context-menu examine expanding incorrect target
2021-03-10 10:36:17 -09:00
cadyn
75dbadd12e Allergens v2 (#7950)
* Allergens v2

* The eggening

Add egg allergen, give it to skrell, apply egg allergen where it belongs.

* Update species_languages.dm
2021-03-10 09:53:07 -09:00