mirror of
https://github.com/PolarisSS13/Polaris.git
synced 2026-01-06 07:22:42 +00:00
fdabe51ee8
* Adds linter defines to repo. * Uncomments linter defines already in the code. * Resolves unreachable code linter errors. * Nukes decade+ old syndie specops code except for computer since that's mapped in????? * Resolves procs has no parent linter error. * Proc signature fixes * Bad comments * "In" danger * Type safety * Implied nested list abuse * Top level ..() usage * Sleepy coder typos * Invalid kwargs calls * Pointless returns * Linter hacks (see full message) Byond doesn't care and it has no effect but linter doesn't like var/proc for holding references to procs, despite that it's valid byond code. Also, the linter seems to have serious issues figuring out relative proc names. This commit is a sort of take-it-or-leave-it thing. It's not required, it just cuts down on warnings, but this code is valid DM code. * WHATEVER THIS IS * Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars * Fix list decoration syntax - Its a list, not list of lists - To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax. Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()` * Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors. * Fixes unwrapped negated object in list linter error. * Resolves colon-like list accessing linter error. * Turns linter on in linter config. * Fixes closet indentation properly and cleans up suit storage unit switch. Co-authored-by: Aronai Sieyes <arokha@arokha.com> Co-authored-by: Leshana <Leshana@users.noreply.github.com>
36 lines
1.5 KiB
Plaintext
36 lines
1.5 KiB
Plaintext
/obj/item/clothing/apply_accessories(var/image/standing)
|
|
if(LAZYLEN(accessories))
|
|
for(var/obj/item/clothing/accessory/A in accessories)
|
|
standing.add_overlay(A.get_mob_overlay())
|
|
|
|
/obj/item/clothing/apply_blood(var/image/standing)
|
|
if(blood_DNA && blood_sprite_state && ishuman(loc))
|
|
var/mob/living/carbon/human/H = loc
|
|
var/image/bloodsies = image(icon = H.species.get_blood_mask(H), icon_state = blood_sprite_state)
|
|
bloodsies.color = blood_color
|
|
standing.add_overlay(bloodsies)
|
|
|
|
//UNIFORM: Always appends "_s" to iconstate, stupidly.
|
|
/obj/item/clothing/under/get_worn_icon_state(var/slot_name)
|
|
var/state2use = ..()
|
|
state2use += "_s"
|
|
return state2use
|
|
|
|
//HELMET: May have a lighting overlay
|
|
/obj/item/clothing/head/make_worn_icon(var/body_type,var/slot_name,var/inhands,var/default_icon,var/default_layer = 0,var/icon/clip_mask = null)
|
|
var/image/standing = ..()
|
|
if(on && slot_name == slot_head_str)
|
|
var/cache_key = "[light_overlay][LAZYACCESS(sprite_sheets,body_type) ? "_[body_type]" : ""]"
|
|
if(standing && light_overlay_cache[cache_key])
|
|
standing.add_overlay(light_overlay_cache[cache_key])
|
|
return standing
|
|
|
|
//SUIT: Blood state is slightly different
|
|
/obj/item/clothing/suit/apply_blood(var/image/standing)
|
|
if(blood_DNA && blood_sprite_state && ishuman(loc))
|
|
var/mob/living/carbon/human/H = loc
|
|
blood_sprite_state = "[blood_overlay_type]blood"
|
|
var/image/bloodsies = image(icon = H.species.get_blood_mask(H), icon_state = blood_sprite_state)
|
|
bloodsies.color = blood_color
|
|
standing.add_overlay(bloodsies)
|