From 7cd8cde1324ffd403a76740e37b009d36024afbb Mon Sep 17 00:00:00 2001 From: CitadelStationBot Date: Sat, 26 Aug 2017 11:07:29 -0500 Subject: [PATCH] Add note about regex and schema version to contributing.md --- .github/CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 97e2a74364..3e2742de11 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -233,6 +233,8 @@ This prevents nesting levels from getting deeper then they need to be. * All changes to the database's layout(schema) must be specified in the database changelog in SQL, as well as reflected in the schema files +* Any time the schema is changed the `schema_revision` table and `DB_MAJOR_VERSION` or `DB_MINOR_VERSION` defines must be incremented. + * Queries must never specify the database, be it in code, or in text files in the repo. @@ -246,6 +248,8 @@ This prevents nesting levels from getting deeper then they need to be. * Do not divide when you can easily convert it to multiplication. (ie `4/2` should be done as `4*0.5`) +* If you used regex to replace code during development of your code, post the regex in your PR for the benefit of future developers and downstream users. + #### Enforced not enforced The following coding styles are not only not enforced at all, but are generally frowned upon to change for little to no reason: