cleanup

tgui/packages/tgui/interfaces/ClockworkSlab.js

@@ -92,8 +92,7 @@ export const ClockworkSlab = (props, context) => {
                 </Fragment>
               )}
             </Box>
-            {recollection_categories?.map(cat => {
-              return (
+            {recollection_categories?.map(cat => (
               <Fragment key={cat.name}>
                 <br />
                 <Button
@@ -104,8 +103,7 @@ export const ClockworkSlab = (props, context) => {
                     "category": cat.name,
                   })} />
               </Fragment>
-              );
-            })}
+            ))}
             <Divider />
             <Box>
               <Box
@@ -115,7 +113,7 @@ export const ClockworkSlab = (props, context) => {
                 {rec_section?.title ? (
                   rec_section.title
                 ) : (
-                  '500 Server Internal archives not found.'
+                  '500 Slab Internal archives not found.'
                 )}
               </Box>
               <br /><br />

tgui/packages/tgui/interfaces/TelecommsInteraction.js

@@ -114,7 +114,7 @@ export const TelecommsInteraction = (props, context) => {
                           'toggle': true,
                         })}
                       />
-                      {machine.chang_frequency ? (
+                      {!!machine.chang_frequency && (
                         <NumberInput
                           animate
                           unit="kHz"
@@ -127,8 +127,6 @@ export const TelecommsInteraction = (props, context) => {
                           onChange={(e, value) => act('frequency', {
                             'adjust': value,
                           })} />
-                      ) : (
-                        ''
                       )}
                     </LabeledList.Item>
                   )}
@@ -179,8 +177,7 @@ export const TelecommsInteraction = (props, context) => {
                   title="Linked Network Entities"
                   level={2}>
                   <LabeledList>
-                    {links.map(entity => {
-                      return (
+                    {links.map(entity => (
                       <LabeledList.Item
                         key={entity.name}
                         label={entity.ref}
@@ -194,8 +191,7 @@ export const TelecommsInteraction = (props, context) => {
                         )}>
                         {`${entity.name} (${entity.id})`}
                       </LabeledList.Item>
-                      );
-                    })}
+                    ))}
                   </LabeledList>
                 </Section>
                 <Section

tgui/packages/tgui/interfaces/TelecommsLogBrowser.js

@@ -122,8 +122,7 @@ export const TelecommsLogBrowser = (props, context) => {
           {(tab === "messages" && operational) ? (
             <Section title="Logs">
               {(operational && selected_logs) ? (
-                selected_logs.map(logs => {
-                  return (
+                selected_logs.map(logs => (
                   <Section
                     level={4}
                     key={logs.ref}>
@@ -158,8 +157,7 @@ export const TelecommsLogBrowser = (props, context) => {
                       </LabeledList.Item>
                     </LabeledList>
                   </Section>
-                  );
-                })
+                ))
               ) : (
                 "No server selected!"
               )}

tgui/packages/tgui/interfaces/TelecommsMonitor.js

@@ -133,11 +133,11 @@ export const TelecommsMonitor = (props, context) => {
                         selected.netspeed*0.30,
                       ],
                       average: [ // 30-70%
-                        selected.netspeed*0.30,
+                        selected.netspeed*0.31,
                         selected.traffic*0.70,
                       ],
-                      bad: [ // 30-100%
-                        selected.netspeed*0.70,
+                      bad: [ // 70-100%
+                        selected.netspeed*0.71,
                         Infinity,
                       ],
                     }}>
@@ -199,8 +199,7 @@ export const TelecommsMonitor = (props, context) => {
                 level={3}>
                 {(operational && selected_servers) ? (
                   <LabeledList>
-                    {selected_servers.map(server => {
-                      return (
+                    {selected_servers.map(server => (
                       <LabeledList.Item
                         key={server.name}
                         label={server.ref}
@@ -213,8 +212,7 @@ export const TelecommsMonitor = (props, context) => {
                         )}>
                         {`${server.name} (${server.id})`}
                       </LabeledList.Item>
-                      );
-                    })}
+                    ))}
                   </LabeledList>
                 ) : (
                   !operational ? (
@@ -229,8 +227,7 @@ export const TelecommsMonitor = (props, context) => {
             <Section title="Detected Network Entities">
               {(servers && servers.length) ? (
                 <LabeledList>
-                  {servers.map(server => {
-                    return (
+                  {servers.map(server => (
                     <LabeledList.Item
                       key={server.name}
                       label={server.ref}
@@ -245,8 +242,7 @@ export const TelecommsMonitor = (props, context) => {
                       )}>
                       {`${server.name} (${server.id})`}
                     </LabeledList.Item>
-                    );
-                  })}
+                  ))}
                 </LabeledList>
               ) : (
                 '404 Servers not found. Have you tried scanning the network?'

tgui/packages/tgui/interfaces/TelecommsPDALog.js

@@ -208,8 +208,7 @@ export const TelecommsPDALog = (props, context) => {
             <Section>
               {(servers && servers.length) ? (
                 <LabeledList>
-                  {servers.map(server => {
-                    return (
+                  {servers.map(server => (
                     <LabeledList.Item
                       key={server.name}
                       label={`${server.ref}`}
@@ -224,8 +223,7 @@ export const TelecommsPDALog = (props, context) => {
                       )}>
                       {`${server.name} (${server.id})`}
                     </LabeledList.Item>
-                    );
-                  })}
+                  ))}
                 </LabeledList>
               ) : (
                 '404 Servers not found. Have you tried scanning the network?'
@@ -233,13 +231,13 @@ export const TelecommsPDALog = (props, context) => {
             </Section>
           ) : (
             <Fragment>
-              {tab === "pdalog-message" && (
+              {(tab === "pdalog-message" && authenticated) && (
                 <TeleLogs />
               )}
-              {tab === "pdalog-reqmsg" && (
+              {(tab === "pdalog-reqmsg" && authenticated) && (
                 <TeleLogs msgs_log />
               )}
-              {tab === "pdalog-custommsg" && (
+              {(tab === "pdalog-custommsg" && authenticated) && (
                 <CustomMsg />
               )}
             </Fragment>
@@ -253,7 +251,7 @@ export const TelecommsPDALog = (props, context) => {
 // They're the same, so merged it into this. Idea stolen from cargonia
 export const TeleLogs = (props, context) => {
   const {
-    msgs_log = false, // <tlog msgs_log/>
+    msgs_log = false, // <TeleLogs msgs_log/>
   } = props;
   const { act, data } = useBackend(context);
   const {
@@ -284,8 +282,7 @@ export const TeleLogs = (props, context) => {
       <Section
         title="Messages"
         level={2}>
-        {log_to_use?.map(message => {
-          return (
+        {log_to_use?.map(message => (
           <Section key={message.ref}>
             <LabeledList>
               <LabeledList.Item
@@ -359,8 +356,7 @@ export const TeleLogs = (props, context) => {
               )}
             </LabeledList>
           </Section>
-          );
-        })}
+        ))}
       </Section>
     </Section>
   );